[Freeipa-devel] [PATCH] 101 Fix invalid issuer in unit tests

2011-07-27 Thread Martin Kosek
Fix several test failures when issuer does not match the one generated by make-testcert (CN=Certificate Authority,O=realm). https://fedorahosted.org/freeipa/ticket/1527 From 70152750668f1210ebfde655d2de0cec91f5d45f Mon Sep 17 00:00:00 2001 From: Martin Kosek mko...@redhat.com Date: Wed, 27 Jul

[Freeipa-devel] [PATCH] 102 Fix automountkey-add summary

2011-07-27 Thread Martin Kosek
The summary value was set to invalid primary key - automount map instead of automount key. https://fedorahosted.org/freeipa/ticket/1524 From 7384cb11979a33adb52874baee7dcf264b1d3570 Mon Sep 17 00:00:00 2001 From: Martin Kosek mko...@redhat.com Date: Wed, 27 Jul 2011 11:24:04 +0200 Subject:

Re: [Freeipa-devel] [PATCH] 002 Fixed adding host without DNS reverse zone

2011-07-27 Thread Petr Vobornik
On Tue, 2011-07-26 at 21:32 -0400, Adam Young wrote: On 07/26/2011 07:09 PM, Endi Sukma Dewata wrote: On 7/26/2011 6:27 AM, Petr Vobornik wrote: Fixed adding host without DNS reverse zone https://fedorahosted.org/freeipa/ticket/1481 Shows status dialog instead of error dialog (error

Re: [Freeipa-devel] [PATCH] 35 Fix external CA install

2011-07-27 Thread Jan Cholasta
On 26.7.2011 19:37, Rob Crittenden wrote: Jan Cholasta wrote: This patch contains several small fixes of external CA install. https://fedorahosted.org/freeipa/ticket/1523 This is a good start at simplifying things but needs a bit more work. One thing I was bending over backwards for was to

Re: [Freeipa-devel] [PATCH] 102 Fix automountkey-add summary

2011-07-27 Thread Martin Kosek
On Wed, 2011-07-27 at 11:28 +0200, Martin Kosek wrote: The summary value was set to invalid primary key - automount map instead of automount key. https://fedorahosted.org/freeipa/ticket/1524 The other commands' summary may be wrong in some cases as well. Updated patch fixes summary for all

[Freeipa-devel] [PATCH] 0007 Add command to test HBAC rules

2011-07-27 Thread Alexander Bokovoy
On 26.07.2011 22:55, Dmitri Pal wrote: The tests imply that there are deny rules. We removed them so very soon there would be no deny rules. Should the results of the test show something like: -- Access granted : True -- Granted by:

[Freeipa-devel] [PATCH] 103 Fix automountkey-mod

2011-07-27 Thread Martin Kosek
Fix automountkey-mod so that automountkey attribute is correctly updated. Add this test case to the unit tests. https://fedorahosted.org/freeipa/ticket/1528 From d1ba81e623f369777b297f8948dda30a24c63e63 Mon Sep 17 00:00:00 2001 From: Martin Kosek mko...@redhat.com Date: Wed, 27 Jul 2011 15:26:57

[Freeipa-devel] [PATCH] 840 don't set host passwords as expired

2011-07-27 Thread Rob Crittenden
When setting a host password once the host has already been enrolled will result in an expired password (like most passwords we set). We can just skip setting this at all on hosts. Test using this method: * ipa host-add --random * ipa-client-install --password '***' * ipa-client-install

Re: [Freeipa-devel] [PATCH] 101 Fix invalid issuer in unit tests

2011-07-27 Thread Rob Crittenden
Martin Kosek wrote: Fix several test failures when issuer does not match the one generated by make-testcert (CN=Certificate Authority,O=realm). https://fedorahosted.org/freeipa/ticket/1527 What kind of CA are you testing against? Right now the subject of the issue differs whether you are

Re: [Freeipa-devel] [PATCH] 101 Fix invalid issuer in unit tests

2011-07-27 Thread Martin Kosek
On Wed, 2011-07-27 at 10:10 -0400, Rob Crittenden wrote: Martin Kosek wrote: Fix several test failures when issuer does not match the one generated by make-testcert (CN=Certificate Authority,O=realm). https://fedorahosted.org/freeipa/ticket/1527 What kind of CA are you testing

Re: [Freeipa-devel] [PATCH] 839 check for duplicate keys when adding indirect maps

2011-07-27 Thread Rob Crittenden
Rob Crittenden wrote: Martin Kosek wrote: On Mon, 2011-07-25 at 10:08 -0400, Rob Crittenden wrote: When adding an indirect map verify that the key doesn't already exist. There is still the chance of collision but checking first should limit it in any case.

Re: [Freeipa-devel] [PATCH] 103 Fix automountkey-mod

2011-07-27 Thread Rob Crittenden
Martin Kosek wrote: Fix automountkey-mod so that automountkey attribute is correctly updated. Add this test case to the unit tests. https://fedorahosted.org/freeipa/ticket/1528 It fixes the problem but I've found another: --key isn't required so if you don't pass it in then a backtrace will

Re: [Freeipa-devel] [PATCH] 102 Fix automountkey-add summary

2011-07-27 Thread Martin Kosek
On Wed, 2011-07-27 at 10:35 -0400, Rob Crittenden wrote: Martin Kosek wrote: On Wed, 2011-07-27 at 11:28 +0200, Martin Kosek wrote: The summary value was set to invalid primary key - automount map instead of automount key. https://fedorahosted.org/freeipa/ticket/1524 The other

Re: [Freeipa-devel] [PATCH] 102 Fix automountkey-add summary

2011-07-27 Thread Rob Crittenden
Martin Kosek wrote: On Wed, 2011-07-27 at 10:35 -0400, Rob Crittenden wrote: Martin Kosek wrote: On Wed, 2011-07-27 at 11:28 +0200, Martin Kosek wrote: The summary value was set to invalid primary key - automount map instead of automount key. https://fedorahosted.org/freeipa/ticket/1524

Re: [Freeipa-devel] [PATCH] 102 Fix automountkey-add summary

2011-07-27 Thread Adam Young
On 07/27/2011 11:13 AM, Rob Crittenden wrote: Martin Kosek wrote: On Wed, 2011-07-27 at 10:35 -0400, Rob Crittenden wrote: Martin Kosek wrote: On Wed, 2011-07-27 at 11:28 +0200, Martin Kosek wrote: The summary value was set to invalid primary key - automount map instead of automount key.

Re: [Freeipa-devel] [PATCH] 0007 Add command to test HBAC rules

2011-07-27 Thread Jakub Hrozek
On 07/27/2011 03:12 PM, Alexander Bokovoy wrote: +for ipa_rule in rules: +try: +res = request.evaluate([ipa_rule]) +if res == pyhbac.HBAC_EVAL_ALLOW: +matched_rules.append(ipa_rule.name) +

Re: [Freeipa-devel] [PATCH] 102 Fix automountkey-add summary

2011-07-27 Thread Rob Crittenden
Adam Young wrote: On 07/27/2011 11:13 AM, Rob Crittenden wrote: Martin Kosek wrote: On Wed, 2011-07-27 at 10:35 -0400, Rob Crittenden wrote: Martin Kosek wrote: On Wed, 2011-07-27 at 11:28 +0200, Martin Kosek wrote: The summary value was set to invalid primary key - automount map instead of

Re: [Freeipa-devel] [PATCH] 103 Fix automountkey-mod

2011-07-27 Thread Martin Kosek
On Wed, 2011-07-27 at 10:41 -0400, Rob Crittenden wrote: Martin Kosek wrote: Fix automountkey-mod so that automountkey attribute is correctly updated. Add this test case to the unit tests. https://fedorahosted.org/freeipa/ticket/1528 It fixes the problem but I've found another: --key

Re: [Freeipa-devel] [PATCH] 103 Fix automountkey-mod

2011-07-27 Thread Dmitri Pal
On 07/27/2011 12:00 PM, Martin Kosek wrote: On Wed, 2011-07-27 at 10:41 -0400, Rob Crittenden wrote: Martin Kosek wrote: Fix automountkey-mod so that automountkey attribute is correctly updated. Add this test case to the unit tests. https://fedorahosted.org/freeipa/ticket/1528 It fixes the

Re: [Freeipa-devel] [PATCH] 103 Fix automountkey-mod

2011-07-27 Thread Martin Kosek
On Wed, 2011-07-27 at 12:11 -0400, Dmitri Pal wrote: On 07/27/2011 12:00 PM, Martin Kosek wrote: On Wed, 2011-07-27 at 10:41 -0400, Rob Crittenden wrote: Martin Kosek wrote: Fix automountkey-mod so that automountkey attribute is correctly updated. Add this test case to the unit

Re: [Freeipa-devel] [PATCH] 102 Fix automountkey-add summary

2011-07-27 Thread Martin Kosek
On Wed, 2011-07-27 at 11:13 -0400, Rob Crittenden wrote: Martin Kosek wrote: On Wed, 2011-07-27 at 10:35 -0400, Rob Crittenden wrote: Martin Kosek wrote: On Wed, 2011-07-27 at 11:28 +0200, Martin Kosek wrote: The summary value was set to invalid primary key - automount map instead of

Re: [Freeipa-devel] [PATCH] 103 Fix automountkey-mod

2011-07-27 Thread Adam Young
On 07/27/2011 12:15 PM, Martin Kosek wrote: On Wed, 2011-07-27 at 12:11 -0400, Dmitri Pal wrote: On 07/27/2011 12:00 PM, Martin Kosek wrote: On Wed, 2011-07-27 at 10:41 -0400, Rob Crittenden wrote: Martin Kosek wrote: Fix automountkey-mod so that automountkey attribute is correctly updated.

Re: [Freeipa-devel] [PATCH] 35 Fix external CA install

2011-07-27 Thread Rob Crittenden
Jan Cholasta wrote: On 26.7.2011 19:37, Rob Crittenden wrote: Jan Cholasta wrote: This patch contains several small fixes of external CA install. https://fedorahosted.org/freeipa/ticket/1523 This is a good start at simplifying things but needs a bit more work. One thing I was bending over

Re: [Freeipa-devel] [PATCH 32/32] Make AVA, RDN DN comparison case insensitive. No need for lowercase normalization.

2011-07-27 Thread Rob Crittenden
John Dennis wrote: Replace deepcopy with constructor (i.e. type call) Can now clone with configuration changes by passing object of the same type to it's constructor, e.g. dn1 = DN(('cn', 'foo') dn2 = DN(dn1) dn2 = DN(dn1, first_key_match=False) Remove pairwise grouping for RDN's. Had

Re: [Freeipa-devel] [PATCH] 103 Fix automountkey-mod

2011-07-27 Thread Rob Crittenden
Martin Kosek wrote: On Wed, 2011-07-27 at 12:11 -0400, Dmitri Pal wrote: On 07/27/2011 12:00 PM, Martin Kosek wrote: On Wed, 2011-07-27 at 10:41 -0400, Rob Crittenden wrote: Martin Kosek wrote: Fix automountkey-mod so that automountkey attribute is correctly updated. Add this test case to

Re: [Freeipa-devel] [PATCH] 839 check for duplicate keys when adding indirect maps

2011-07-27 Thread Rob Crittenden
Martin Kosek wrote: On Wed, 2011-07-27 at 10:26 -0400, Rob Crittenden wrote: Rob Crittenden wrote: Martin Kosek wrote: On Mon, 2011-07-25 at 10:08 -0400, Rob Crittenden wrote: When adding an indirect map verify that the key doesn't already exist. There is still the chance of collision but

Re: [Freeipa-devel] [PATCH] 224 Fixed problem setting host OTP.

2011-07-27 Thread Endi Sukma Dewata
On 7/26/2011 4:52 PM, Adam Young wrote: On 07/26/2011 11:17 AM, Endi Sukma Dewata wrote: The handler for host 'Set OTP' button has been modified to obtain the primary key from the entity and return false to stop the normal event processing. Ticket #1511 ACK Pushed to master. -- Endi S.

Re: [Freeipa-devel] [PATCH] 225 Fixed hard-coded labels in sudo rules.

2011-07-27 Thread Endi Sukma Dewata
On 7/26/2011 4:52 PM, Adam Young wrote: On 07/26/2011 01:19 PM, Endi Sukma Dewata wrote: The sudo rule interface has been modified to remove unused labels and use translated dialog box title. Ticket #1518 ACK Pushed to master. -- Endi S. Dewata

[Freeipa-devel] [PATCH] 226 Fixed hard-coded label in Find button.

2011-07-27 Thread Endi Sukma Dewata
The IPA.adder_dialog has been modified to use translated label for the Find button. Pushed to master under one-liner rule. -- Endi S. Dewata From 7d1c2a3f4563e97458f586b83a42ede2eeb4b1ff Mon Sep 17 00:00:00 2001 From: Endi S. Dewata edew...@redhat.com Date: Wed, 27 Jul 2011 16:35:16 -0500

Re: [Freeipa-devel] [PATCH] 0270-removing-setters-setup-and-init

2011-07-27 Thread Adam Young
On 07/27/2011 03:56 PM, Endi Sukma Dewata wrote: On 7/27/2011 11:33 AM, Adam Young wrote: This applies on top of my old patch 270 version 13. Changes are in a separate patch due to the size of the original. When submitted, I can squash the two patches into one. I have not rebased on top of the