Re: [Freeipa-devel] [PATCH] 1012 validate domain in installer

2012-05-15 Thread Martin Kosek
On Mon, 2012-05-14 at 17:29 -0400, Rob Crittenden wrote: Martin Kosek wrote: On Fri, 2012-05-11 at 16:03 -0400, Rob Crittenden wrote: Use our domain validator to validate the domain name we get in the installer. rob I found few issues with the patch: 1) The unexpected error is

Re: [Freeipa-devel] Adding indices and permissions to FreeIPA

2012-05-15 Thread Martin Kosek
On Tue, 2012-05-15 at 09:15 +0930, William Brown wrote: Hi, I am currently working on adding DHCP support, so that FreeIPA can control an ISC-DHCP server. As part of this, I need to add a number of indices to 389ds, as well as a number of permissions (ACIs) and groups to manage these.

Re: [Freeipa-devel] [PATCH] 1013 implement permission/aci find by subtree

2012-05-15 Thread Martin Kosek
On Mon, 2012-05-14 at 17:45 -0400, Rob Crittenden wrote: Martin Kosek wrote: On Fri, 2012-05-11 at 16:34 -0400, Rob Crittenden wrote: permission-find --subtree wasn't implemented so always returned all entries (the option was ignored). rob I found the following 2 issues: 1) The

Re: [Freeipa-devel] Adding indices and permissions to FreeIPA

2012-05-15 Thread William Brown
On 15/05/12 16:21, Martin Kosek wrote: I think the best approach would be to implement an install script ipa-dhcp-install (analogous to install/tools/ipa-dns-install) which could be used to optionally install this feature to running IPA server. This script would do all the needed set up and

Re: [Freeipa-devel] Adding indices and permissions to FreeIPA

2012-05-15 Thread Martin Kosek
On Tue, 2012-05-15 at 16:37 +0930, William Brown wrote: On 15/05/12 16:21, Martin Kosek wrote: I think the best approach would be to implement an install script ipa-dhcp-install (analogous to install/tools/ipa-dns-install) which could be used to optionally install this feature to running

Re: [Freeipa-devel] [PATCH] 0050 Fail on unknown Command options

2012-05-15 Thread Martin Kosek
On Mon, 2012-05-14 at 14:47 +0200, Petr Viktorin wrote: The final part of rejecting unknown Command arguments: enable the validation, add tests. Also fix up things that were changed since the previous patches. https://fedorahosted.org/freeipa/ticket/2509 The patch looks OK so far. I just

Re: [Freeipa-devel] [PATCH] 0051 Check for empty/single value parameters before calling callbacks

2012-05-15 Thread Martin Kosek
On Mon, 2012-05-14 at 15:22 +0200, Petr Viktorin wrote: Pre-callbacks were called before a few validation steps, leading to internal errors if the pre-callback relied on valid data. https://fedorahosted.org/freeipa/ticket/2701 Regression test included. ACK. Pushed to master. Martin

Re: [Freeipa-devel] [PATCH] 0048 Rework the CallbackInterface

2012-05-15 Thread Petr Viktorin
On 05/10/2012 02:20 PM, Petr Viktorin wrote: While investigating ticket 2674, I found several problems with our implementation of the CallbackInterface ­— it required complicated calling code, and would subtly break if command classes were instantiated in different ways than they are currently.

Re: [Freeipa-devel] [PATCH] 0049 Disallow '' and non-ASCII characters in the DM password

2012-05-15 Thread Martin Kosek
On Fri, 2012-05-11 at 16:55 +0200, Petr Viktorin wrote: https://fedorahosted.org/freeipa/ticket/2675 I've tested all ASCII non-alphanumeric characters that weren't blocked already. With all except for '' I've succeeded. Non-ASCII characters also don't work in passwords. (Not that it'd be a

Re: [Freeipa-devel] [PATCH] 137 Instructions to generate cert use certutil instead of openssl

2012-05-15 Thread Martin Kosek
On Fri, 2012-05-11 at 13:37 +0200, Petr Vobornik wrote: Instructions to generate certificate were changed. Now they use certutil instead of openssl. In the example is also used option for specifying key size. https://fedorahosted.org/freeipa/ticket/2725 ACK, the new procedure works fine.

Re: [Freeipa-devel] [PATCH] 257 Fix python Requires in Fedora 17 build

2012-05-15 Thread Martin Kosek
On Wed, 2012-05-09 at 14:42 +0200, Ondrej Hamada wrote: On 05/04/2012 05:45 PM, Martin Kosek wrote: This one actually took me some time to track it down (details are in a patch description). To check the result, simply build freeipa on Fedora 17 with make rpms, install rpms on the machine

Re: [Freeipa-devel] [PATCH] 135 Host page fixed to work with disabled DNS support

2012-05-15 Thread Petr Vobornik
On 05/11/2012 06:46 PM, JR Aquino wrote: On May 4, 2012, at 5:18 AM, Petr Vobornik wrote: When DNS support was disabled there were following errors in Web UI: 1) Host details page was not filled with data 2) Host adder dialog was broken - unusable 3) DNS tab was displayed in navigation

Re: [Freeipa-devel] [PATCH] 136 Correction of nested search facets tab labels

2012-05-15 Thread Petr Vobornik
On 05/14/2012 07:09 PM, Endi Sukma Dewata wrote: On 5/10/2012 5:29 AM, Petr Vobornik wrote: Nested search facets were using 'search' tab label instead of their nested entity name. This patch is fixing that regression. https://fedorahosted.org/freeipa/ticket/2744 ACK. Pushed to master. --

Re: [Freeipa-devel] [PATCHES] 124-132 Inconsistent ways to show/change entry status

2012-05-15 Thread Petr Vobornik
On 05/14/2012 07:08 PM, Endi Sukma Dewata wrote: On 5/10/2012 7:19 AM, Petr Vobornik wrote: Updated patch attached. See comments below. On 05/08/2012 04:23 AM, Endi Sukma Dewata wrote: Try adding a very long DNS zone, then open the zone. Compare the breadcrumbs in the DNS Resource Records