[Freeipa-devel] [PATCHES] 152-158 ipa-server-certinstall fixes

2013-07-15 Thread Jan Cholasta
On 11.7.2013 14:10, Jan Cholasta wrote: Hi, this is the first batch of patches for https://fedorahosted.org/freeipa/ticket/3641. It contains port of ipa-server-certinstall to the admintool framework and fixes some bugs. Note that there's still some work I have to do to make

Re: [Freeipa-devel] [PATCH] 3031 Allow TTL to be configured during ipa-client-install

2013-07-15 Thread James Hogarth
This patch allows the user during ipa-client-install to pick the TTL to be used on the creation of the client DNS records and configures the value in sssd.conf so that ongoing changes to IP use the TTL as desired. Apologies but I just realised I missed the link to the ticket this refers

Re: [Freeipa-devel] [PATCH] 1102 set correct content-type

2013-07-15 Thread Jan Cholasta
On 11.7.2013 22:50, Rob Crittenden wrote: Set the correct content-type on negotiated XML-RPC requests. It was being set as text/plain when it should be text/xml. rob ACK. Honza -- Jan Cholasta ___ Freeipa-devel mailing list

Re: [Freeipa-devel] [PATCHES] 149-151 Ask for PKCS#12 password interactively

2013-07-15 Thread Jan Cholasta
On 12.7.2013 10:19, Tomas Babej wrote: Just a nitpick: + # If any of the PKCS#12 options are selected, all are required. + pkcs12_req = (options.dirsrv_pkcs12, options.http_pkcs12) + pkcs12_opt = (options.pkinit_pkcs12,) + if any(pkcs12_req + pkcs12_opt) and not all(pkcs12_req):

Re: [Freeipa-devel] [PATCH] Remove unused variable

2013-07-15 Thread Tomas Babej
On Wednesday 10 of July 2013 22:27:16 Jakub Hrozek wrote: Hi, I was doing quite a few builds of freeipa for testing and patch reviews lately and found a couple of unused variables. The attached patch removed the variables. ACK Tomas___

Re: [Freeipa-devel] [PATCH] Use pkg-config to detect cmocka

2013-07-15 Thread Martin Kosek
On 07/04/2013 01:49 PM, Lukas Slebodnik wrote: On (04/07/13 13:10), Alexander Bokovoy wrote: On Thu, 04 Jul 2013, Lukas Slebodnik wrote: ehlo, libcmocka-0.3 was released and package is available in fedore = 18. libcmocka-devel contains pkg-config file, therefore it is better to use

[Freeipa-devel] [PATCH] 0044 Add 'ipa_server_mode' option to SSSD configuration

2013-07-15 Thread Ana Krivokapic
Hello, This patch addresses ticket https://fedorahosted.org/freeipa/ticket/3652. -- Regards, Ana Krivokapic Associate Software Engineer FreeIPA team Red Hat Inc. From 6c332b4a1149a35ebc76ee7756050edc0333ac21 Mon Sep 17 00:00:00 2001 From: Ana Krivokapic akriv...@redhat.com Date: Mon, 15 Jul

Re: [Freeipa-devel] [PATCH 0072] Provide ipa-client-advise tool

2013-07-15 Thread Martin Kosek
On 07/11/2013 08:59 AM, Tomas Babej wrote: On Wednesday 26 of June 2013 10:12:48 Petr Spacek wrote: [snip] Appropriate error handling = Return 'Permission denied' if particular operation requires higher privileges. IMHO 'cryptic' error message is bad in any case, so

[Freeipa-devel] [PATCH 0174] Fix crash during zone_refresh triggered by connection failure

2013-07-15 Thread Petr Spacek
Hello, Fix crash during zone_refresh triggered by connection failure. Variable 'iter' was initialized too late. Code in cleanup section of refresh_zones_from_ldap() dereferenced the uninitialized variable. -- Petr^2 Spacek From 3affa9c2431928a5b5708875ab937d598059561e Mon Sep 17 00:00:00 2001

Re: [Freeipa-devel] [PATCH 0072] Provide ipa-client-advise tool

2013-07-15 Thread Alexander Bokovoy
On Mon, 15 Jul 2013, Martin Kosek wrote: On 07/11/2013 08:59 AM, Tomas Babej wrote: On Wednesday 26 of June 2013 10:12:48 Petr Spacek wrote: [snip] Appropriate error handling = Return 'Permission denied' if particular operation requires higher privileges. IMHO 'cryptic'

Re: [Freeipa-devel] [PATCHES] 143-147 Improve performance with large groups

2013-07-15 Thread Martin Kosek
On 07/11/2013 12:15 PM, Alexander Bokovoy wrote: On Thu, 11 Jul 2013, Jan Cholasta wrote: On 11.7.2013 11:58, Alexander Bokovoy wrote: On Mon, 08 Jul 2013, Alexander Bokovoy wrote: On Thu, 27 Jun 2013, Jan Cholasta wrote: On 27.6.2013 17:34, Rich Megginson wrote: On 06/27/2013 09:31 AM, Jan

Re: [Freeipa-devel] [PATCHES] 0039-0040 systemd ipactl fixes

2013-07-15 Thread Martin Kosek
On 07/11/2013 05:03 PM, Alexander Bokovoy wrote: On Thu, 11 Jul 2013, Ana Krivokapic wrote: On 07/11/2013 11:38 AM, Alexander Bokovoy wrote: On Thu, 11 Jul 2013, Alexander Bokovoy wrote: On Wed, 10 Jul 2013, Ana Krivokapic wrote: On 07/08/2013 08:32 AM, Alexander Bokovoy wrote: On Thu, 20

Re: [Freeipa-devel] [PATCHES] 0039-0040 systemd ipactl fixes

2013-07-15 Thread Alexander Bokovoy
On Mon, 15 Jul 2013, Martin Kosek wrote: On 07/11/2013 05:03 PM, Alexander Bokovoy wrote: On Thu, 11 Jul 2013, Ana Krivokapic wrote: On 07/11/2013 11:38 AM, Alexander Bokovoy wrote: On Thu, 11 Jul 2013, Alexander Bokovoy wrote: On Wed, 10 Jul 2013, Ana Krivokapic wrote: On 07/08/2013 08:32

Re: [Freeipa-devel] [PATCH 0073] Remove support for IPA deployments with no persistent search

2013-07-15 Thread Martin Kosek
On 07/11/2013 05:10 PM, Tomas Babej wrote: On Thursday 11 of July 2013 16:10:33 Ana Krivokapic wrote: On 07/11/2013 11:20 AM, Tomas Babej wrote: boolean_var = {} - for var in ('persistent_search', 'serial_autoincrement'): + for var in ('serial_autoincrement'): This won't work -

Re: [Freeipa-devel] [PATCH] 1102 set correct content-type

2013-07-15 Thread Martin Kosek
On 07/15/2013 10:44 AM, Jan Cholasta wrote: On 11.7.2013 22:50, Rob Crittenden wrote: Set the correct content-type on negotiated XML-RPC requests. It was being set as text/plain when it should be text/xml. rob ACK. Honza Pushed to master, ipa-3-2. Martin

Re: [Freeipa-devel] [PATCH] Remove unused variable

2013-07-15 Thread Martin Kosek
On 07/15/2013 12:27 PM, Tomas Babej wrote: On Wednesday 10 of July 2013 22:27:16 Jakub Hrozek wrote: Hi, I was doing quite a few builds of freeipa for testing and patch reviews lately and found a couple of unused variables. The attached patch removed the variables. ACK

Re: [Freeipa-devel] [PATCHES] 143-147 Improve performance with large groups

2013-07-15 Thread Jan Cholasta
On 15.7.2013 15:16, Martin Kosek wrote: On 07/11/2013 12:15 PM, Alexander Bokovoy wrote: On Thu, 11 Jul 2013, Jan Cholasta wrote: We can add WebUI improvements later. I have some WIP, but I need to discuss it with Petr first (he's away this week). Ok. The patchset is in ipa-3-2 as well now.

Re: [Freeipa-devel] [PATCH 0073] Remove support for IPA deployments with no persistent search

2013-07-15 Thread Petr Spacek
On 15.7.2013 15:31, Martin Kosek wrote: On 07/11/2013 05:10 PM, Tomas Babej wrote: On Thursday 11 of July 2013 16:10:33 Ana Krivokapic wrote: On 07/11/2013 11:20 AM, Tomas Babej wrote: boolean_var = {} - for var in ('persistent_search', 'serial_autoincrement'): + for var in

Re: [Freeipa-devel] [PATCH 0073] Remove support for IPA deployments with no persistent search

2013-07-15 Thread Simo Sorce
On Mon, 2013-07-15 at 15:57 +0200, Martin Kosek wrote: On 07/15/2013 03:44 PM, Petr Spacek wrote: On 15.7.2013 15:31, Martin Kosek wrote: On 07/11/2013 05:10 PM, Tomas Babej wrote: On Thursday 11 of July 2013 16:10:33 Ana Krivokapic wrote: On 07/11/2013 11:20 AM, Tomas Babej wrote:

Re: [Freeipa-devel] [PATCH 0073] Remove support for IPA deployments with no persistent search

2013-07-15 Thread Petr Spacek
On 15.7.2013 16:15, Simo Sorce wrote: On Mon, 2013-07-15 at 15:57 +0200, Martin Kosek wrote: On 07/15/2013 03:44 PM, Petr Spacek wrote: On 15.7.2013 15:31, Martin Kosek wrote: On 07/11/2013 05:10 PM, Tomas Babej wrote: On Thursday 11 of July 2013 16:10:33 Ana Krivokapic wrote: On

Re: [Freeipa-devel] [PATCHES] 0230-0244 Integration testing framework

2013-07-15 Thread Petr Viktorin
On 07/11/2013 01:28 PM, Jan Cholasta wrote: On 10.7.2013 17:50, Petr Viktorin wrote: On 07/10/2013 02:03 PM, Jan Cholasta wrote: make test seems to run fine with patches 230-242 applied, however ipa-run-tests produces the following output: [...Skipping nose output...] I guess the location

Re: [Freeipa-devel] [PATCH] Use pkg-config to detect cmocka

2013-07-15 Thread Martin Kosek
On 07/15/2013 03:13 PM, Alexander Bokovoy wrote: On Mon, 15 Jul 2013, Martin Kosek wrote: On 07/04/2013 01:49 PM, Lukas Slebodnik wrote: On (04/07/13 13:10), Alexander Bokovoy wrote: On Thu, 04 Jul 2013, Lukas Slebodnik wrote: ehlo, libcmocka-0.3 was released and package is available in

Re: [Freeipa-devel] DNSSEC support design considerations: key material handling

2013-07-15 Thread Petr Spacek
Hello, first pair of this message quickly concludes discussion about database part of the DNSSEC support and then key material handling is discussed. I'm sorry for the wall of text. On 27.6.2013 18:43, Simo Sorce wrote: * How to get sorted list of entries from LDAP? Use

Re: [Freeipa-devel] [PATCH 0073] Remove support for IPA deployments with no persistent search

2013-07-15 Thread Martin Kosek
On 07/15/2013 04:41 PM, Petr Spacek wrote: On 15.7.2013 16:15, Simo Sorce wrote: On Mon, 2013-07-15 at 15:57 +0200, Martin Kosek wrote: On 07/15/2013 03:44 PM, Petr Spacek wrote: On 15.7.2013 15:31, Martin Kosek wrote: On 07/11/2013 05:10 PM, Tomas Babej wrote: On Thursday 11 of July 2013

Re: [Freeipa-devel] [PATCHES] 143-147 Improve performance with large groups

2013-07-15 Thread Martin Kosek
On 07/15/2013 03:43 PM, Jan Cholasta wrote: On 15.7.2013 15:16, Martin Kosek wrote: On 07/11/2013 12:15 PM, Alexander Bokovoy wrote: On Thu, 11 Jul 2013, Jan Cholasta wrote: We can add WebUI improvements later. I have some WIP, but I need to discuss it with Petr first (he's away this week).

Re: [Freeipa-devel] [PATCH 0073] Remove support for IPA deployments with no persistent search

2013-07-15 Thread Simo Sorce
On Mon, 2013-07-15 at 16:41 +0200, Petr Spacek wrote: On 15.7.2013 16:15, Simo Sorce wrote: On Mon, 2013-07-15 at 15:57 +0200, Martin Kosek wrote: On 07/15/2013 03:44 PM, Petr Spacek wrote: On 15.7.2013 15:31, Martin Kosek wrote: On 07/11/2013 05:10 PM, Tomas Babej wrote: On Thursday 11

[Freeipa-devel] [PATCH] 0108 Add support for compatibility tree for trusted domain users

2013-07-15 Thread Alexander Bokovoy
Hi! Attached patch allows to enable serving trusted domain users and groups through Schema Compatibilty plugin. The patch only does FreeIPA master configuration settings, the real work is done by the changes to slapi-nis plugin (in a separate email). Since ipa-adtrust-install can safely be run

Re: [Freeipa-devel] [PATCH 0073] Remove support for IPA deployments with no persistent search

2013-07-15 Thread Martin Kosek
On 07/15/2013 06:28 PM, Simo Sorce wrote: On Mon, 2013-07-15 at 16:41 +0200, Petr Spacek wrote: On 15.7.2013 16:15, Simo Sorce wrote: On Mon, 2013-07-15 at 15:57 +0200, Martin Kosek wrote: On 07/15/2013 03:44 PM, Petr Spacek wrote: On 15.7.2013 15:31, Martin Kosek wrote: On 07/11/2013 05:10

[Freeipa-devel] [PATCH] slapi-nis support for trusted domains

2013-07-15 Thread Alexander Bokovoy
Hi! Attached please find two patches against slapi-nis 0.47 to serve trusted domain users and groups to old clients. FreeIPA master needs to be enabled with this, see my patch 0108 (on freeipa-devel@). The patches add both lookup and PAM-based authentication bind for the users returned by SSSD