URL: https://github.com/freeipa/freeipa/pull/317
Title: #317: Unify password generation across FreeIPA
mbasti-rh commented:
"""
@tiran IMO you need check `length > uppercase + lowercase + num + special`,
otherwise infinity loop
but generally LGTM
"""
See the full comment at
https://github.co
On 08.12.2016 22:47, Simo Sorce wrote:
On Thu, 2016-12-08 at 21:46 +0100, simo5 wrote:
URL: https://github.com/freeipa/freeipa/pull/314
Author: simo5
Title: #314: RFC: privilege separation for ipa framework code
Action: edited
Changed field: body
Original value:
"""
As part of the Ext
URL: https://github.com/freeipa/freeipa/pull/62
Author: simo5
Title: #62: Configure Anonymous PKINIT on server install
Action: synchronized
To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/62/head:pr62
git checkout pr62
From ab5
On Thu, 2016-12-08 at 21:46 +0100, simo5 wrote:
>URL: https://github.com/freeipa/freeipa/pull/314
> Author: simo5
> Title: #314: RFC: privilege separation for ipa framework code
> Action: edited
>
> Changed field: body
> Original value:
> """
> As part of the External Authentication work thi
URL: https://github.com/freeipa/freeipa/pull/314
Author: simo5
Title: #314: RFC: privilege separation for ipa framework code
Action: edited
Changed field: body
Original value:
"""
As part of the External Authentication work this PR implements the privilege
separation portion of the design av
URL: https://github.com/freeipa/freeipa/pull/320
Title: #320: add missing attribute to ipaca replica during CA topology update
mbasti-rh commented:
"""
IMO #322 this might be related, @martbab can you please check it?
"""
See the full comment at
https://github.com/freeipa/freeipa/pull/320#issu
URL: https://github.com/freeipa/freeipa/pull/62
Author: simo5
Title: #62: Configure Anonymous PKINIT on server install
Action: synchronized
To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/62/head:pr62
git checkout pr62
From 13c
URL: https://github.com/freeipa/freeipa/pull/322
Author: tbordaz
Title: #322: masters DS<1.3.3 do not support bind group
Action: opened
PR body:
"""
Check the instance version before setting nsds5replicabbinddngroup and
nsds5replicabinddngroupcheckinterval
https://fedorahosted.org/freeipa/tic
URL: https://github.com/freeipa/freeipa/pull/317
Title: #317: Unify password generation across FreeIPA
tiran commented:
"""
```
#!/usr/bin/python3
import math
import random
import string
class TokenGenerator(object):
"""Simple, tunable token generator
TokenGenerator(uppercase=3, lower
URL: https://github.com/freeipa/freeipa/pull/62
Author: simo5
Title: #62: Configure Anonymous PKINIT on server install
Action: synchronized
To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/62/head:pr62
git checkout pr62
From 641
URL: https://github.com/freeipa/freeipa/pull/62
Title: #62: Configure Anonymous PKINIT on server install
simo5 commented:
"""
@abbra I have an idea of what it might be
"""
See the full comment at
https://github.com/freeipa/freeipa/pull/62#issuecomment-265795485
--
Manage your subscription for
URL: https://github.com/freeipa/freeipa/pull/62
Title: #62: Configure Anonymous PKINIT on server install
simo5 commented:
"""
@martbab sometimes you are blind to your own code ...
"""
See the full comment at
https://github.com/freeipa/freeipa/pull/62#issuecomment-265795306
--
Manage your subs
URL: https://github.com/freeipa/freeipa/pull/317
Title: #317: Unify password generation across FreeIPA
tiran commented:
"""
@mbasti-rh I probably misunderstood your intention. I read your comment as
"Replace it with something sane, the sane thing is sha1".
By the way I'm currently tangled up i
URL: https://github.com/freeipa/freeipa/pull/317
Title: #317: Unify password generation across FreeIPA
mbasti-rh commented:
"""
@tiran @simo5 If you read my comments properly I was happy with removing sha1()
and I pointed out that ipa_generate_password() must generate entropy 160bits as
was pr
URL: https://github.com/freeipa/freeipa/pull/270
Author: ofayans
Title: #270: Test: uniqueness of certificate renewal master
Action: closed
To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/270/head:pr270
git checkout pr270
--
M
URL: https://github.com/freeipa/freeipa/pull/270
Title: #270: Test: uniqueness of certificate renewal master
Label: +pushed
--
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Co
URL: https://github.com/freeipa/freeipa/pull/270
Title: #270: Test: uniqueness of certificate renewal master
martbab commented:
"""
Fixed upstream
master:
https://fedorahosted.org/freeipa/changeset/fad87a9962ee33cfebc4fa59aba589e98b076cea
"""
See the full comment at
https://github.com/freeipa/
URL: https://github.com/freeipa/freeipa/pull/270
Title: #270: Test: uniqueness of certificate renewal master
Label: +ack
--
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contr
URL: https://github.com/freeipa/freeipa/pull/62
Title: #62: Configure Anonymous PKINIT on server install
martbab commented:
"""
@simo5 I highlighted the code givin pylint issues, basically you forgot to
update ca_kdc_check signature.
"""
See the full comment at
https://github.com/freeipa/free
URL: https://github.com/freeipa/freeipa/pull/62
Title: #62: Configure Anonymous PKINIT on server install
abbra commented:
"""
@simo5 I tried to run the branch as an upgrade against Fedora 25 version
(4.4.2-1.fc25) and it failed at first because I was running in SELinux
enforcing:
Unexpect
URL: https://github.com/freeipa/freeipa/pull/317
Title: #317: Unify password generation across FreeIPA
tiran commented:
"""
@stlaz Your patch looks good. My comment regarding SHA1 was aimed at comment
https://github.com/freeipa/freeipa/pull/317#issuecomment-265440651 . The
suggestion of SHA1 i
URL: https://github.com/freeipa/freeipa/pull/317
Title: #317: Unify password generation across FreeIPA
simo5 commented:
"""
We may need a max length argument if we are dealing with some stuff that has
issues with more then max length caracters ... In that case we can warn (or
raise, we'll have
URL: https://github.com/freeipa/freeipa/pull/317
Title: #317: Unify password generation across FreeIPA
stlaz commented:
"""
@simo5 I was actually trying to get rid of SHA-1 and I am aware that entropy
will not be raised, that part of the code draw a smile on some of our faces
here, really :)
A
URL: https://github.com/freeipa/freeipa/pull/317
Title: #317: Unify password generation across FreeIPA
tiran commented:
"""
Please don't use a hack like sha1() to turn a random byte sequence into a hex
value. At best sha1 keeps the entropy of the input. I also don't like the fact
that the func
URL: https://github.com/freeipa/freeipa/pull/317
Title: #317: Unify password generation across FreeIPA
simo5 commented:
"""
@stlaz SHA-1 DOES NOT add entropy at all, you need the right number of bits in
INPUT for whatever trasformation you use.
@mbasti-rh in what way FIPS is incompatible with b
URL: https://github.com/freeipa/freeipa/pull/317
Title: #317: Unify password generation across FreeIPA
simo5 commented:
"""
@stiaz, SHA-1 DOES NOT add entropy at all, you need the right number of bits in
INPUT for whatever trasformation you use.
@mbasti-rh in what way FIPS is incompatible with
URL: https://github.com/freeipa/freeipa/pull/181
Author: gkaihorodova
Title: #181: Tests : User Tracker creation of user with minimal values
Action: synchronized
To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/181/head:pr181
gi
URL: https://github.com/freeipa/freeipa/pull/317
Title: #317: Unify password generation across FreeIPA
stlaz commented:
"""
Apparently, spaces are ok even in HTTP password.conf so I guess we can leave it
there.
"""
See the full comment at
https://github.com/freeipa/freeipa/pull/317#issuecomme
URL: https://github.com/freeipa/freeipa/pull/307
Author: pvomacka
Title: #307: Lowered the version of gettext
Action: synchronized
To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/307/head:pr307
git checkout pr307
From 1c49b0d07
URL: https://github.com/freeipa/freeipa/pull/314
Title: #314: RFC: privilege separation for ipa framework code
simo5 commented:
"""
@pspacek I added workflows to the Design page, please verify
"""
See the full comment at
https://github.com/freeipa/freeipa/pull/314#issuecomment-265734321
--
Ma
URL: https://github.com/freeipa/freeipa/pull/272
Title: #272: Build: makerpms.sh generates Python 2 & 3 packages at the same time
pspacek commented:
"""
I've synchronized `python-cryptography` and `python-gssapi` versions. Thank you
for noticing. Let's see if CI tests pass or not.
"""
See the
URL: https://github.com/freeipa/freeipa/pull/272
Author: pspacek
Title: #272: Build: makerpms.sh generates Python 2 & 3 packages at the same
time
Action: synchronized
To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/272/head:pr
URL: https://github.com/freeipa/freeipa/pull/101
Title: #101: Improved vault-show error message
Label: +rejected
--
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Co
URL: https://github.com/freeipa/freeipa/pull/101
Author: stlaz
Title: #101: Improved vault-show error message
Action: closed
To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/101/head:pr101
git checkout pr101
--
Manage your subs
URL: https://github.com/freeipa/freeipa/pull/272
Title: #272: Build: makerpms.sh generates Python 2 & 3 packages at the same time
tiran commented:
"""
* CI is failing: ```12-08 10:53 ipadocker.cli ERRORCommand echo Secret123 |
kinit admin && ipa ping failed (exit code 1)```. I have kicked T
URL: https://github.com/freeipa/freeipa/pull/317
Title: #317: Unify password generation across FreeIPA
stlaz commented:
"""
NSS does support spaces in its passwords it seems. My hopes are that HTTP will
be able to understand spaces in its password.conf file.
"""
See the full comment at
https:
URL: https://github.com/freeipa/freeipa/pull/321
Author: jcholast
Title: #321: certdb: fix PKCS#12 import with empty password
Action: opened
PR body:
"""
Since commit f919ab4ee0ec26d77ee6978e75de5daba4073402, a temporary file is
used to give passwords to pk12util. When a password is empty, the
URL: https://github.com/freeipa/freeipa/pull/318
Title: #318: server install: fix external CA install
Label: +pushed
--
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribut
URL: https://github.com/freeipa/freeipa/pull/318
Author: jcholast
Title: #318: server install: fix external CA install
Action: closed
To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/318/head:pr318
git checkout pr318
--
Manage
URL: https://github.com/freeipa/freeipa/pull/318
Title: #318: server install: fix external CA install
mbasti-rh commented:
"""
Fixed upstream
master:
https://fedorahosted.org/freeipa/changeset/4fff09978eab520d130d87c0112b5caac907e651
"""
See the full comment at
https://github.com/freeipa/freei
URL: https://github.com/freeipa/freeipa/pull/206
Author: simo5
Title: #206: Properly handle multiple cookies in rpcclient
Action: closed
To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/206/head:pr206
git checkout pr206
--
Mana
URL: https://github.com/freeipa/freeipa/pull/206
Title: #206: Properly handle multiple cookies in rpcclient
Label: +pushed
--
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Con
URL: https://github.com/freeipa/freeipa/pull/206
Title: #206: Properly handle multiple cookies in rpcclient
mbasti-rh commented:
"""
Fixed upstream
master:
https://fedorahosted.org/freeipa/changeset/560ab9e3176af8e59163155207cc2c1d631915dd
https://fedorahosted.org/freeipa/changeset/f1678693713dc
URL: https://github.com/freeipa/freeipa/pull/206
Title: #206: Properly handle multiple cookies in rpcclient
Label: +ack
--
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contri
URL: https://github.com/freeipa/freeipa/pull/317
Title: #317: Unify password generation across FreeIPA
mbasti-rh commented:
"""
> The passwords should have around the same entropy now. SHA-1 actually
> produces 160bit outputs (hence 40-characters long hexadecimal digests), so I
> recounted it
URL: https://github.com/freeipa/freeipa/pull/307
Title: #307: Lowered the version of gettext
pspacek commented:
"""
@pvomacka Pavel, you did not remove the `po/Rules-quot` file. Adding it to
`.gitignore` is not enough.
NACK (sorry for messing with the label, too fat fingers)
"""
See the full
URL: https://github.com/freeipa/freeipa/pull/307
Title: #307: Lowered the version of gettext
Label: -ack
--
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code
URL: https://github.com/freeipa/freeipa/pull/307
Title: #307: Lowered the version of gettext
Label: +ack
--
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code
URL: https://github.com/freeipa/freeipa/pull/272
Title: #272: Build: makerpms.sh generates Python 2 & 3 packages at the same time
pspacek commented:
"""
I've implemented tiran's proposal and rebased the patchset.
"""
See the full comment at
https://github.com/freeipa/freeipa/pull/272#issuecomm
URL: https://github.com/freeipa/freeipa/pull/272
Author: pspacek
Title: #272: Build: makerpms.sh generates Python 2 & 3 packages at the same
time
Action: synchronized
To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/272/head:pr
URL: https://github.com/freeipa/freeipa/pull/272
Title: #272: Build: makerpms.sh generates Python 2 & 3 packages at the same time
pspacek commented:
"""
I'm fine with `make pylint PYTHON=python3` as long as you can agree on it :-)
"""
See the full comment at
https://github.com/freeipa/freeipa/
URL: https://github.com/freeipa/freeipa/pull/206
Author: simo5
Title: #206: Properly handle multiple cookies in rpcclient
Action: synchronized
To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/206/head:pr206
git checkout pr206
Fr
URL: https://github.com/freeipa/freeipa/pull/318
Title: #318: server install: fix external CA install
Label: +ack
--
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/C
URL: https://github.com/freeipa/freeipa/pull/318
Title: #318: server install: fix external CA install
flo-renaud commented:
"""
Works as expected.
"""
See the full comment at
https://github.com/freeipa/freeipa/pull/318#issuecomment-265688266
--
Manage your subscription for the Freeipa-devel m
URL: https://github.com/freeipa/freeipa/pull/317
Title: #317: Unify password generation across FreeIPA
stlaz commented:
"""
The passwords should have around the same entropy now. SHA-1 actually produces
160bit outputs (hence 40-characters long hexadecimal digests), so I recounted
it for 20-by
URL: https://github.com/freeipa/freeipa/pull/317
Author: stlaz
Title: #317: Unify password generation across FreeIPA
Action: synchronized
To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/317/head:pr317
git checkout pr317
From bf
URL: https://github.com/freeipa/freeipa/pull/177
Author: frasertweedale
Title: #177: Add options to write lightweight CA cert or chain to file
Action: synchronized
To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/177/head:pr177
URL: https://github.com/freeipa/freeipa/pull/177
Title: #177: Add options to write lightweight CA cert or chain to file
frasertweedale commented:
"""
@jcholast updated PR to include `certificate` and `certificate_chain` in
`ca_find` output when `--all` is specified.
"""
See the full comment at
58 matches
Mail list logo