[Freeipa-devel] [freeipa PR#350][+pushed] spec file: revert to the previous Release tag

2017-01-02 Thread HonzaCholasta
URL: https://github.com/freeipa/freeipa/pull/350 Title: #350: spec file: revert to the previous Release tag Label: +pushed -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Con

[Freeipa-devel] [freeipa PR#350][comment] spec file: revert to the previous Release tag

2017-01-02 Thread HonzaCholasta
URL: https://github.com/freeipa/freeipa/pull/350 Title: #350: spec file: revert to the previous Release tag HonzaCholasta commented: """ Fixed upstream master: https://fedorahosted.org/freeipa/changeset/eb1f05d598d821f8e7eb5b8cfe606f570052f263 """ See the full

[Freeipa-devel] [freeipa PR#350][closed] spec file: revert to the previous Release tag

2017-01-02 Thread HonzaCholasta
URL: https://github.com/freeipa/freeipa/pull/350 Author: HonzaCholasta Title: #350: spec file: revert to the previous Release tag Action: closed To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/350/head:pr350 git checkout pr350

[Freeipa-devel] [freeipa PR#314][comment] RFC: privilege separation for ipa framework code

2017-01-02 Thread HonzaCholasta
URL: https://github.com/freeipa/freeipa/pull/314 Title: #314: RFC: privilege separation for ipa framework code HonzaCholasta commented: """ * Dogtag certificates and RA certificate renewal is broken: ``` ca-error: Server at "https://vm-226.abc.idm.lab.eng.brq.redh

[Freeipa-devel] [freeipa PR#209][comment] Enumerate available options in IPA installer

2017-01-02 Thread HonzaCholasta
URL: https://github.com/freeipa/freeipa/pull/209 Title: #209: Enumerate available options in IPA installer HonzaCholasta commented: """ Works for me, although you should probably keep the changes to `ipa-ca-install` from the original patch (using the `argparse` format, of course

[Freeipa-devel] [freeipa PR#363][comment] ipaclient: schema cache: Handle malformed server info data gracefully

2017-01-03 Thread HonzaCholasta
URL: https://github.com/freeipa/freeipa/pull/363 Title: #363: ipaclient: schema cache: Handle malformed server info data gracefully HonzaCholasta commented: """ Can the corruption also happen for schema files? """ See the full comment at https://githu

[Freeipa-devel] [freeipa PR#363][comment] ipaclient: schema cache: Handle malformed server info data gracefully

2017-01-03 Thread HonzaCholasta
URL: https://github.com/freeipa/freeipa/pull/363 Title: #363: ipaclient: schema cache: Handle malformed server info data gracefully HonzaCholasta commented: """ @dkupka, ok, see inline comment. """ See the full comment at https://github.com/freeipa/freeipa/p

[Freeipa-devel] [freeipa PR#209][+ack] Enumerate available options in IPA installer

2017-01-03 Thread HonzaCholasta
URL: https://github.com/freeipa/freeipa/pull/209 Title: #209: Enumerate available options in IPA installer Label: +ack -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contrib

[Freeipa-devel] [freeipa PR#209][+pushed] Enumerate available options in IPA installer

2017-01-03 Thread HonzaCholasta
URL: https://github.com/freeipa/freeipa/pull/209 Title: #209: Enumerate available options in IPA installer Label: +pushed -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Cont

[Freeipa-devel] [freeipa PR#209][comment] Enumerate available options in IPA installer

2017-01-03 Thread HonzaCholasta
URL: https://github.com/freeipa/freeipa/pull/209 Title: #209: Enumerate available options in IPA installer HonzaCholasta commented: """ Fixed upstream master: https://fedorahosted.org/freeipa/changeset/80c0e5cb8d689cf1ec6a883d2c7000f9dadbf7d8 """ See the full

[Freeipa-devel] [freeipa PR#209][closed] Enumerate available options in IPA installer

2017-01-03 Thread HonzaCholasta
URL: https://github.com/freeipa/freeipa/pull/209 Author: Akasurde Title: #209: Enumerate available options in IPA installer Action: closed To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/209/head:pr209 git checkout pr209 -- Ma

[Freeipa-devel] [freeipa PR#348][comment] ca: fix ca-find with --pkey-only

2017-01-05 Thread HonzaCholasta
URL: https://github.com/freeipa/freeipa/pull/348 Title: #348: ca: fix ca-find with --pkey-only HonzaCholasta commented: """ @frasertweedale, is that an ACK? :-) """ See the full comment at https://github.com/freeipa/freeipa/pull/348#issuecomment-270586148 -- Ma

[Freeipa-devel] [freeipa PR#314][comment] RFC: privilege separation for ipa framework code

2017-01-05 Thread HonzaCholasta
URL: https://github.com/freeipa/freeipa/pull/314 Title: #314: RFC: privilege separation for ipa framework code HonzaCholasta commented: """ @simo5, I might have fixed the certmonger issue, see HonzaCholasta@907ef3cff2045edd4625d4c422d1d0ae473fe51c, however I'm hitting the

[Freeipa-devel] [freeipa PR#376][opened] client install: correctly report all failures

2017-01-06 Thread HonzaCholasta
URL: https://github.com/freeipa/freeipa/pull/376 Author: HonzaCholasta Title: #376: client install: correctly report all failures Action: opened PR body: """ In commit 5249eb817efbb5708d097173a8d5f1e322fb201e, the client install code was converted to use exception handling in

[Freeipa-devel] [freeipa PR#377][opened] dogtaginstance: track server certificate with our renew agent

2017-01-08 Thread HonzaCholasta
URL: https://github.com/freeipa/freeipa/pull/377 Author: HonzaCholasta Title: #377: dogtaginstance: track server certificate with our renew agent Action: opened PR body: """ This patchset is intended to make @simo5's life easier when changing the RA agent certific

[Freeipa-devel] [freeipa PR#363][+ack] ipaclient: schema cache: Handle malformed server info data gracefully

2017-01-09 Thread HonzaCholasta
URL: https://github.com/freeipa/freeipa/pull/363 Title: #363: ipaclient: schema cache: Handle malformed server info data gracefully Label: +ack -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://ww

[Freeipa-devel] [freeipa PR#363][closed] ipaclient: schema cache: Handle malformed server info data gracefully

2017-01-09 Thread HonzaCholasta
URL: https://github.com/freeipa/freeipa/pull/363 Author: dkupka Title: #363: ipaclient: schema cache: Handle malformed server info data gracefully Action: closed To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/363/head:pr363 g

[Freeipa-devel] [freeipa PR#363][+pushed] ipaclient: schema cache: Handle malformed server info data gracefully

2017-01-09 Thread HonzaCholasta
URL: https://github.com/freeipa/freeipa/pull/363 Title: #363: ipaclient: schema cache: Handle malformed server info data gracefully Label: +pushed -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http:/

[Freeipa-devel] [freeipa PR#363][comment] ipaclient: schema cache: Handle malformed server info data gracefully

2017-01-09 Thread HonzaCholasta
URL: https://github.com/freeipa/freeipa/pull/363 Title: #363: ipaclient: schema cache: Handle malformed server info data gracefully HonzaCholasta commented: """ Fixed upstream master: https://fedorahosted.org/freeipa/changeset/d15ccde20fcc97a597180255ee9f5eb38caa206c "&quo

[Freeipa-devel] [freeipa PR#245][comment] Allow full customisability of IPA CA subject DN

2017-01-10 Thread HonzaCholasta
URL: https://github.com/freeipa/freeipa/pull/245 Title: #245: Allow full customisability of IPA CA subject DN HonzaCholasta commented: """ * `--subject-base` and `--ca-subject` are not validated in `ipa-ca-install`. * Please squash "{ds,ca}instance: rename 'subject'

[Freeipa-devel] [freeipa PR#245][comment] Allow full customisability of IPA CA subject DN

2017-01-11 Thread HonzaCholasta
URL: https://github.com/freeipa/freeipa/pull/245 Title: #245: Allow full customisability of IPA CA subject DN HonzaCholasta commented: """ @frasertweedale, the ticket *number* is correct, but the URL points to Dogtag Trac. """ See the full comment at https://g

[Freeipa-devel] [freeipa PR#245][+ack] Allow full customisability of IPA CA subject DN

2017-01-11 Thread HonzaCholasta
URL: https://github.com/freeipa/freeipa/pull/245 Title: #245: Allow full customisability of IPA CA subject DN Label: +ack -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Cont

[Freeipa-devel] [freeipa PR#245][closed] Allow full customisability of IPA CA subject DN

2017-01-11 Thread HonzaCholasta
URL: https://github.com/freeipa/freeipa/pull/245 Author: frasertweedale Title: #245: Allow full customisability of IPA CA subject DN Action: closed To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/245/head:pr245 git checkout pr2

[Freeipa-devel] [freeipa PR#245][comment] Allow full customisability of IPA CA subject DN

2017-01-11 Thread HonzaCholasta
URL: https://github.com/freeipa/freeipa/pull/245 Title: #245: Allow full customisability of IPA CA subject DN HonzaCholasta commented: """ Fixed upstream master: https://fedorahosted.org/freeipa/changeset/324183cd63aeadbaa9678d610ba59e1295a606fe https://fedorahosted.org/fr

[Freeipa-devel] [freeipa PR#245][+pushed] Allow full customisability of IPA CA subject DN

2017-01-11 Thread HonzaCholasta
URL: https://github.com/freeipa/freeipa/pull/245 Title: #245: Allow full customisability of IPA CA subject DN Label: +pushed -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/C

[Freeipa-devel] [freeipa PR#314][comment] RFC: privilege separation for ipa framework code

2017-01-12 Thread HonzaCholasta
URL: https://github.com/freeipa/freeipa/pull/314 Title: #314: RFC: privilege separation for ipa framework code HonzaCholasta commented: """ @simo5, I can't reproduce the bug anymore with the latest update. Pylint found one trivial issue: ``` ipaserver/install/server/u

[Freeipa-devel] [freeipa PR#314][comment] RFC: privilege separation for ipa framework code

2017-01-12 Thread HonzaCholasta
URL: https://github.com/freeipa/freeipa/pull/314 Title: #314: RFC: privilege separation for ipa framework code HonzaCholasta commented: """ Not sure if it's this PR or not, but `ipa-server-install` *sometimes* fails with: ``` [11/22]: setting up ssl [error] NetworkErro

[Freeipa-devel] [freeipa PR#384][comment] Add fix for user prompt in dnsrecord-add

2017-01-13 Thread HonzaCholasta
URL: https://github.com/freeipa/freeipa/pull/384 Title: #384: Add fix for user prompt in dnsrecord-add HonzaCholasta commented: """ I'm afraid this is not a proper fix, as it introduces a regression in CLI behavior. A proper fix would be to use correct argument names -

[Freeipa-devel] [freeipa PR#372][comment] Restore IPA 3.0 compatibility of copy-schema-to-ca.py

2017-01-16 Thread HonzaCholasta
URL: https://github.com/freeipa/freeipa/pull/372 Title: #372: Restore IPA 3.0 compatibility of copy-schema-to-ca.py HonzaCholasta commented: """ I agree with @mbasti-rh. IMO we should remove all 4.0+ specific code from the script, add a version check at the beginning and disa

[Freeipa-devel] [freeipa PR#266][synchronized] ipapython: simplify Env object initialization

2017-01-17 Thread HonzaCholasta
URL: https://github.com/freeipa/freeipa/pull/266 Author: HonzaCholasta Title: #266: ipapython: simplify Env object initialization Action: synchronized To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/266/head:pr266 git checkout

[Freeipa-devel] [freeipa PR#359][synchronized] dogtag: search past the first 100 certificates

2017-01-17 Thread HonzaCholasta
URL: https://github.com/freeipa/freeipa/pull/359 Author: HonzaCholasta Title: #359: dogtag: search past the first 100 certificates Action: synchronized To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/359/head:pr359 git

[Freeipa-devel] [freeipa PR#359][comment] dogtag: search past the first 100 certificates

2017-01-17 Thread HonzaCholasta
URL: https://github.com/freeipa/freeipa/pull/359 Title: #359: dogtag: search past the first 100 certificates HonzaCholasta commented: """ I have identified some issues in search limit handling in `cert-find` and fixed them in an additional commit. See commit message for detail

[Freeipa-devel] [freeipa PR#359][synchronized] dogtag: search past the first 100 certificates

2017-01-17 Thread HonzaCholasta
URL: https://github.com/freeipa/freeipa/pull/359 Author: HonzaCholasta Title: #359: dogtag: search past the first 100 certificates Action: synchronized To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/359/head:pr359 git

[Freeipa-devel] [freeipa PR#394][comment] Add fix for ipa plugins command

2017-01-17 Thread HonzaCholasta
URL: https://github.com/freeipa/freeipa/pull/394 Title: #394: Add fix for ipa plugins command HonzaCholasta commented: """ @mbasti-rh, no. Classes aren't named using unicode strings either. """ See the full comment at https://github.com/freeipa/free

[Freeipa-devel] [freeipa PR#336][comment] [py3] pki: add missing depedency pki-base[-python3]

2017-01-18 Thread HonzaCholasta
URL: https://github.com/freeipa/freeipa/pull/336 Title: #336: [py3] pki: add missing depedency pki-base[-python3] HonzaCholasta commented: """ @tiran, the dependency says `>= 10.2.1`, not `== 10.2.1`, so we are not depending on any non-existent packages. """

[Freeipa-devel] [freeipa PR#394][comment] Add fix for ipa plugins command

2017-01-18 Thread HonzaCholasta
URL: https://github.com/freeipa/freeipa/pull/394 Title: #394: Add fix for ipa plugins command HonzaCholasta commented: """ The namespace keys *are* text (`str`) in both Python 2 and 3. The issue here is that the RPC layer assumes that `str` is binary data, which the patch corr

[Freeipa-devel] [freeipa PR#394][comment] Add fix for ipa plugins command

2017-01-18 Thread HonzaCholasta
URL: https://github.com/freeipa/freeipa/pull/394 Title: #394: Add fix for ipa plugins command HonzaCholasta commented: """ @tiran, namespace keys are always ASCII. But feel free to open a ticket to convert all remaining uses of `str` as text to `unicode`, changing it for one

[Freeipa-devel] [freeipa PR#394][comment] Add fix for ipa plugins command

2017-01-18 Thread HonzaCholasta
URL: https://github.com/freeipa/freeipa/pull/394 Title: #394: Add fix for ipa plugins command HonzaCholasta commented: """ We are OK with the patch because fixing the root cause is out of the scope of this PR. """ See the full comment at https://githu

[Freeipa-devel] [freeipa PR#336][comment] [py3] pki: add missing depedency pki-base[-python3]

2017-01-18 Thread HonzaCholasta
URL: https://github.com/freeipa/freeipa/pull/336 Title: #336: [py3] pki: add missing depedency pki-base[-python3] HonzaCholasta commented: """ That is of no concern to us. `pki-base-python3 >= 10.2.1` will get us the correct package in all cases and under no circumstance

[Freeipa-devel] [freeipa PR#336][comment] [py3] pki: add missing depedency pki-base[-python3]

2017-01-18 Thread HonzaCholasta
URL: https://github.com/freeipa/freeipa/pull/336 Title: #336: [py3] pki: add missing depedency pki-base[-python3] HonzaCholasta commented: """ @tiran, I'm sorry to have to point this out, but the decision whether this PR is accepted or not is not yours to make, you are not

[Freeipa-devel] [freeipa PR#336][comment] [py3] pki: add missing depedency pki-base[-python3]

2017-01-18 Thread HonzaCholasta
URL: https://github.com/freeipa/freeipa/pull/336 Title: #336: [py3] pki: add missing depedency pki-base[-python3] HonzaCholasta commented: """ I see, didn't notice that. In this case, IMO either the current `pki-base >= 10.2.1` or an unversioned `pki-base-python2` is

[Freeipa-devel] [freeipa PR#113][comment] ipalib.constants: Remove default domain, realm, basedn, xmlrpc_uri, ldap_uri

2017-01-18 Thread HonzaCholasta
URL: https://github.com/freeipa/freeipa/pull/113 Title: #113: ipalib.constants: Remove default domain, realm, basedn, xmlrpc_uri, ldap_uri HonzaCholasta commented: """ @pvoborni, my plan is to amend / extend this patch. """ See the full comment at https://githu

[Freeipa-devel] [freeipa PR#314][comment] RFC: privilege separation for ipa framework code

2017-01-19 Thread HonzaCholasta
URL: https://github.com/freeipa/freeipa/pull/314 Title: #314: RFC: privilege separation for ipa framework code HonzaCholasta commented: """ @simo5, I can confirm that the ldapi error occurs every other install. I can also confirm that it does not occur during the initial serv

[Freeipa-devel] [freeipa PR#314][comment] RFC: privilege separation for ipa framework code

2017-01-19 Thread HonzaCholasta
URL: https://github.com/freeipa/freeipa/pull/314 Title: #314: RFC: privilege separation for ipa framework code HonzaCholasta commented: """ Here's what I did ``` # certutil -d /etc/httpd/alias -L | tail -n +5 | sed -r 's/ +[^ ]+ *$//' | xargs -I nickname -r sh -c

[Freeipa-devel] [freeipa PR#408][opened] ipaldap: properly escape raw binary values in LDAP filters

2017-01-23 Thread HonzaCholasta
URL: https://github.com/freeipa/freeipa/pull/408 Author: HonzaCholasta Title: #408: ipaldap: properly escape raw binary values in LDAP filters Action: opened PR body: """ Manually escape each byte in the value, do not use ldap.filter.escape_filter_chars() as it does not wor

[Freeipa-devel] [freeipa PR#408][synchronized] ipaldap: properly escape raw binary values in LDAP filters

2017-01-23 Thread HonzaCholasta
URL: https://github.com/freeipa/freeipa/pull/408 Author: HonzaCholasta Title: #408: ipaldap: properly escape raw binary values in LDAP filters Action: synchronized To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/408/head:pr408

[Freeipa-devel] [freeipa PR#337][comment] Client-side CSR autogeneration (take 2)

2017-01-23 Thread HonzaCholasta
URL: https://github.com/freeipa/freeipa/pull/337 Title: #337: Client-side CSR autogeneration (take 2) HonzaCholasta commented: """ @LiptonB, there's still one issue which I'd like to be resolved in this PR, and that's that currently CSR templates are tied to

[Freeipa-devel] [freeipa PR#408][synchronized] ipaldap: properly escape raw binary values in LDAP filters

2017-01-23 Thread HonzaCholasta
URL: https://github.com/freeipa/freeipa/pull/408 Author: HonzaCholasta Title: #408: ipaldap: properly escape raw binary values in LDAP filters Action: synchronized To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/408/head:pr408

[Freeipa-devel] [freeipa PR#337][comment] Client-side CSR autogeneration (take 2)

2017-01-24 Thread HonzaCholasta
URL: https://github.com/freeipa/freeipa/pull/337 Title: #337: Client-side CSR autogeneration (take 2) HonzaCholasta commented: """ @LiptonB, I think certificate profiles and CSR generation profiles / templates *should* be associated, but not by sharing the same logical `certp

[Freeipa-devel] [freeipa PR#314][comment] RFC: privilege separation for ipa framework code

2017-01-24 Thread HonzaCholasta
URL: https://github.com/freeipa/freeipa/pull/314 Title: #314: RFC: privilege separation for ipa framework code HonzaCholasta commented: """ @simo5, replica install still fails for me in the same way as before. """ See the full comment at https://githu

[Freeipa-devel] [freeipa PR#359][closed] dogtag: search past the first 100 certificates

2017-01-24 Thread HonzaCholasta
URL: https://github.com/freeipa/freeipa/pull/359 Author: HonzaCholasta Title: #359: dogtag: search past the first 100 certificates Action: closed To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/359/head:pr359 git checkout

[Freeipa-devel] [freeipa PR#359][+pushed] dogtag: search past the first 100 certificates

2017-01-24 Thread HonzaCholasta
URL: https://github.com/freeipa/freeipa/pull/359 Title: #359: dogtag: search past the first 100 certificates Label: +pushed -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Co

[Freeipa-devel] [freeipa PR#359][comment] dogtag: search past the first 100 certificates

2017-01-24 Thread HonzaCholasta
URL: https://github.com/freeipa/freeipa/pull/359 Title: #359: dogtag: search past the first 100 certificates HonzaCholasta commented: """ Fixed upstream master: https://fedorahosted.org/freeipa/changeset/d84edc43e55c2f7c30614a4a5268aeb58e33a087 https://fedorahosted.org/fr

[Freeipa-devel] [freeipa PR#314][comment] RFC: privilege separation for ipa framework code

2017-01-25 Thread HonzaCholasta
URL: https://github.com/freeipa/freeipa/pull/314 Title: #314: RFC: privilege separation for ipa framework code HonzaCholasta commented: """ @simo5, it turns out the request fails not on the replica, but on the initial master, so it's actually `ipa-server-install` whic

[Freeipa-devel] [freeipa PR#418][opened] replica install: do not log host OTP

2017-01-30 Thread HonzaCholasta
URL: https://github.com/freeipa/freeipa/pull/418 Author: HonzaCholasta Title: #418: replica install: do not log host OTP Action: opened PR body: """ Do not log the value of the --password option of ipa-client-install when it is run from ipa-replica-install before replica pr

[Freeipa-devel] [freeipa PR#314][comment] RFC: privilege separation for ipa framework code

2017-01-30 Thread HonzaCholasta
URL: https://github.com/freeipa/freeipa/pull/314 Title: #314: RFC: privilege separation for ipa framework code HonzaCholasta commented: """ Both replica install and CA-less install now work, but: * `ipa-replica-install` creates `/var/lib/ipa/radb` owned by `root` rather than `i

[Freeipa-devel] [freeipa PR#419][opened] ipa-ca-install: do not fail without --subject-base and --ca-subject

2017-01-30 Thread HonzaCholasta
URL: https://github.com/freeipa/freeipa/pull/419 Author: HonzaCholasta Title: #419: ipa-ca-install: do not fail without --subject-base and --ca-subject Action: opened PR body: """ When --subject-base and --ca-subject are not specified in ipa-ca-install, default values are u

[Freeipa-devel] [freeipa PR#337][comment] Client-side CSR autogeneration (take 2)

2017-01-30 Thread HonzaCholasta
URL: https://github.com/freeipa/freeipa/pull/337 Title: #337: Client-side CSR autogeneration (take 2) HonzaCholasta commented: """ @LiptonB, I meant it the other way around - `certprofile` should have an (optional) attribute which points to the associated CSR template. &q

[Freeipa-devel] [freeipa PR#337][+ack] Client-side CSR autogeneration (take 2)

2017-01-30 Thread HonzaCholasta
URL: https://github.com/freeipa/freeipa/pull/337 Title: #337: Client-side CSR autogeneration (take 2) Label: +ack -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/C

[Freeipa-devel] [freeipa PR#337][-ack] Client-side CSR autogeneration (take 2)

2017-01-30 Thread HonzaCholasta
URL: https://github.com/freeipa/freeipa/pull/337 Title: #337: Client-side CSR autogeneration (take 2) Label: -ack -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/C

[Freeipa-devel] [freeipa PR#337][comment] Client-side CSR autogeneration (take 2)

2017-01-30 Thread HonzaCholasta
URL: https://github.com/freeipa/freeipa/pull/337 Title: #337: Client-side CSR autogeneration (take 2) HonzaCholasta commented: """ Before I push this, could you please: * squash "Fix broken tests in CSR autogeneration" into "Add tests for CSR autogeneration&q

[Freeipa-devel] [freeipa PR#419][comment] ipa-ca-install: do not fail without --subject-base and --ca-subject

2017-01-30 Thread HonzaCholasta
URL: https://github.com/freeipa/freeipa/pull/419 Title: #419: ipa-ca-install: do not fail without --subject-base and --ca-subject HonzaCholasta commented: """ Fixed upstream master: https://fedorahosted.org/freeipa/changeset/87400cdec1054971f50f90a0c63f18ab045f3833 ""&

[Freeipa-devel] [freeipa PR#419][closed] ipa-ca-install: do not fail without --subject-base and --ca-subject

2017-01-30 Thread HonzaCholasta
URL: https://github.com/freeipa/freeipa/pull/419 Author: HonzaCholasta Title: #419: ipa-ca-install: do not fail without --subject-base and --ca-subject Action: closed To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/419

[Freeipa-devel] [freeipa PR#419][+pushed] ipa-ca-install: do not fail without --subject-base and --ca-subject

2017-01-30 Thread HonzaCholasta
URL: https://github.com/freeipa/freeipa/pull/419 Title: #419: ipa-ca-install: do not fail without --subject-base and --ca-subject Label: +pushed -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://ww

[Freeipa-devel] [freeipa PR#395][comment] Configure PKI ajp redirection to use "localhost" instead of "::1"

2017-01-30 Thread HonzaCholasta
URL: https://github.com/freeipa/freeipa/pull/395 Title: #395: Configure PKI ajp redirection to use "localhost" instead of "::1" HonzaCholasta commented: """ @pvoborni, there is no benefit in bumping `Requires` in a separate patch, as this patch is blocked b

[Freeipa-devel] [freeipa PR#416][comment] replica install: relax domain level check for promotion

2017-01-31 Thread HonzaCholasta
URL: https://github.com/freeipa/freeipa/pull/416 Title: #416: replica install: relax domain level check for promotion HonzaCholasta commented: """ Excuse me, but what is the point of checking for an exact domain level? Shouldn't `check_domain_level()` rather always check

[Freeipa-devel] [freeipa PR#337][comment] Client-side CSR autogeneration (take 2)

2017-01-31 Thread HonzaCholasta
URL: https://github.com/freeipa/freeipa/pull/337 Title: #337: Client-side CSR autogeneration (take 2) HonzaCholasta commented: """ @LiptonB, "CSR generation profile" works for me. Once the new design is implemented though, "CSR template" will be mor

[Freeipa-devel] [freeipa PR#337][+ack] Client-side CSR autogeneration (take 2)

2017-01-31 Thread HonzaCholasta
URL: https://github.com/freeipa/freeipa/pull/337 Title: #337: Client-side CSR autogeneration (take 2) Label: +ack -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/C

[Freeipa-devel] [freeipa PR#337][comment] Client-side CSR autogeneration (take 2)

2017-01-31 Thread HonzaCholasta
URL: https://github.com/freeipa/freeipa/pull/337 Title: #337: Client-side CSR autogeneration (take 2) HonzaCholasta commented: """ Fixed upstream master: https://fedorahosted.org/freeipa/changeset/10ef5947860f5098182b1f95c08c1158e2da15f9 https://fedorahosted.org/fr

[Freeipa-devel] [freeipa PR#337][closed] Client-side CSR autogeneration (take 2)

2017-01-31 Thread HonzaCholasta
URL: https://github.com/freeipa/freeipa/pull/337 Author: LiptonB Title: #337: Client-side CSR autogeneration (take 2) Action: closed To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/337/head:pr337 git checkout pr337 -- Manage y

[Freeipa-devel] [freeipa PR#337][+pushed] Client-side CSR autogeneration (take 2)

2017-01-31 Thread HonzaCholasta
URL: https://github.com/freeipa/freeipa/pull/337 Title: #337: Client-side CSR autogeneration (take 2) Label: +pushed -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribut

[Freeipa-devel] [freeipa PR#416][comment] replica install: relax domain level check for promotion

2017-01-31 Thread HonzaCholasta
URL: https://github.com/freeipa/freeipa/pull/416 Title: #416: replica install: relax domain level check for promotion HonzaCholasta commented: """ I see. The point is, `check_domain_level()` is supposed to check whether replica promotion is possible or not in the current domain

[Freeipa-devel] [freeipa PR#336][comment] [py3] pki: add missing depedency pki-base[-python3]

2017-02-01 Thread HonzaCholasta
URL: https://github.com/freeipa/freeipa/pull/336 Title: #336: [py3] pki: add missing depedency pki-base[-python3] HonzaCholasta commented: """ LGTM """ See the full comment at https://github.com/freeipa/freeipa/pull/336#issuecomment-276612233 -- Manage your subs

[Freeipa-devel] [freeipa PR#436][opened] x509: allow leading text in PEM files

2017-02-06 Thread HonzaCholasta
URL: https://github.com/freeipa/freeipa/pull/436 Author: HonzaCholasta Title: #436: x509: allow leading text in PEM files Action: opened PR body: """ This fixes a regression introduced in commit b8d6524d43dd0667184aebc79fb77a9b8a46939a. https://fedorahosted.org/freeipa/tick

[Freeipa-devel] [freeipa PR#436][comment] x509: allow leading text in PEM files

2017-02-06 Thread HonzaCholasta
URL: https://github.com/freeipa/freeipa/pull/436 Title: #436: x509: allow leading text in PEM files HonzaCholasta commented: """ Oops, didn't realize that `^` matches beginning of each line in multiline mode. I think we can keep the test, though. ""&qu

[Freeipa-devel] [freeipa PR#436][synchronized] x509: allow leading text in PEM files

2017-02-06 Thread HonzaCholasta
URL: https://github.com/freeipa/freeipa/pull/436 Author: HonzaCholasta Title: #436: x509: allow leading text in PEM files Action: synchronized To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/436/head:pr436 git checkout pr436

[Freeipa-devel] [freeipa PR#436][+pushed] x509: allow leading text in PEM files

2017-02-06 Thread HonzaCholasta
URL: https://github.com/freeipa/freeipa/pull/436 Title: #436: x509: allow leading text in PEM files Label: +pushed -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/

[Freeipa-devel] [freeipa PR#436][comment] x509: allow leading text in PEM files

2017-02-06 Thread HonzaCholasta
URL: https://github.com/freeipa/freeipa/pull/436 Title: #436: x509: allow leading text in PEM files HonzaCholasta commented: """ Fixed upstream master: https://fedorahosted.org/freeipa/changeset/89dfbab3ca076812590f371c21abcb51b350170b """ See the full comment

[Freeipa-devel] [freeipa PR#436][closed] x509: allow leading text in PEM files

2017-02-06 Thread HonzaCholasta
URL: https://github.com/freeipa/freeipa/pull/436 Author: HonzaCholasta Title: #436: x509: allow leading text in PEM files Action: closed To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/436/head:pr436 git checkout pr436

[Freeipa-devel] [freeipa PR#336][+ack] [py3] pki: add missing depedency pki-base[-python3]

2017-02-07 Thread HonzaCholasta
URL: https://github.com/freeipa/freeipa/pull/336 Title: #336: [py3] pki: add missing depedency pki-base[-python3] Label: +ack -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/

[Freeipa-devel] [freeipa PR#438][opened] ipaldap: preserve order of values in LDAPEntry._sync()

2017-02-07 Thread HonzaCholasta
URL: https://github.com/freeipa/freeipa/pull/438 Author: HonzaCholasta Title: #438: ipaldap: preserve order of values in LDAPEntry._sync() Action: opened PR body: """ In Python 2, the order was preserved by accident. This change makes sure the order is preserved in both

[Freeipa-devel] [freeipa PR#396][comment] Explicitly remove support of SSLv2

2017-02-07 Thread HonzaCholasta
URL: https://github.com/freeipa/freeipa/pull/396 Title: #396: Explicitly remove support of SSLv2 HonzaCholasta commented: """ @stlaz, you don't have to replace `root_logger` in old code, but don't use it in new code. """ See the full comment at htt

[Freeipa-devel] [freeipa PR#438][synchronized] ipaldap: preserve order of values in LDAPEntry._sync()

2017-02-07 Thread HonzaCholasta
URL: https://github.com/freeipa/freeipa/pull/438 Author: HonzaCholasta Title: #438: ipaldap: preserve order of values in LDAPEntry._sync() Action: synchronized To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/438/head:pr438 git

[Freeipa-devel] [freeipa PR#427][+ack] [Py3] WSGI part 2

2017-02-07 Thread HonzaCholasta
URL: https://github.com/freeipa/freeipa/pull/427 Title: #427: [Py3] WSGI part 2 Label: +ack -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

[Freeipa-devel] [freeipa PR#427][+pushed] [Py3] WSGI part 2

2017-02-07 Thread HonzaCholasta
URL: https://github.com/freeipa/freeipa/pull/427 Title: #427: [Py3] WSGI part 2 Label: +pushed -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

[Freeipa-devel] [freeipa PR#427][comment] [Py3] WSGI part 2

2017-02-07 Thread HonzaCholasta
URL: https://github.com/freeipa/freeipa/pull/427 Title: #427: [Py3] WSGI part 2 HonzaCholasta commented: """ Fixed upstream master: https://fedorahosted.org/freeipa/changeset/caa560ca79e4038b161b27d11e3f144606dbbcdb https://fedorahosted.org/fr

[Freeipa-devel] [freeipa PR#427][closed] [Py3] WSGI part 2

2017-02-07 Thread HonzaCholasta
URL: https://github.com/freeipa/freeipa/pull/427 Author: MartinBasti Title: #427: [Py3] WSGI part 2 Action: closed To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/427/head:pr427 git checkout pr427 -- Manage your subscription f

[Freeipa-devel] [freeipa PR#370][comment] ci: send build log to paste.fedoraproject.org

2017-02-08 Thread HonzaCholasta
URL: https://github.com/freeipa/freeipa/pull/370 Title: #370: ci: send build log to paste.fedoraproject.org HonzaCholasta commented: """ Right, I suggested https://transfer.sh, because uploading a file there is as easy as: ```bash curl --upload-file ./file https://transfer.sh

[Freeipa-devel] [freeipa PR#370][comment] ci: send build log to paste.fedoraproject.org

2017-02-08 Thread HonzaCholasta
URL: https://github.com/freeipa/freeipa/pull/370 Title: #370: ci: send build log to paste.fedoraproject.org HonzaCholasta commented: """ @martbab, I would rather not include irrelevant stuff, it's just noise. """ See the full comment at https://github.com/fr

[Freeipa-devel] [freeipa PR#443][comment] Stronger check for DM password during server install

2017-02-08 Thread HonzaCholasta
URL: https://github.com/freeipa/freeipa/pull/443 Title: #443: Stronger check for DM password during server install HonzaCholasta commented: """ IMHO you got it backwards - DM password may not comply to NSS requirements for passwords, therefore it must not be used as a passw

[Freeipa-devel] [freeipa PR#314][comment] RFC: privilege separation for ipa framework code

2017-02-09 Thread HonzaCholasta
URL: https://github.com/freeipa/freeipa/pull/314 Title: #314: RFC: privilege separation for ipa framework code HonzaCholasta commented: """ While investigating the CI test failures, I stumbled upon another issue - two simultaneous login requests will deadlock httpd until it is

[Freeipa-devel] [freeipa PR#449][+ack] Travis CI: Upload the logs from failed jobs to transfer.sh

2017-02-09 Thread HonzaCholasta
URL: https://github.com/freeipa/freeipa/pull/449 Title: #449: Travis CI: Upload the logs from failed jobs to transfer.sh Label: +ack -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.or

[Freeipa-devel] [freeipa PR#449][comment] Travis CI: Upload the logs from failed jobs to transfer.sh

2017-02-09 Thread HonzaCholasta
URL: https://github.com/freeipa/freeipa/pull/449 Title: #449: Travis CI: Upload the logs from failed jobs to transfer.sh HonzaCholasta commented: """ Fixed upstream master: https://fedorahosted.org/freeipa/changeset/91341f4035e0d78b0adbe9a09ba69e1fd35ec26d """

[Freeipa-devel] [freeipa PR#449][+pushed] Travis CI: Upload the logs from failed jobs to transfer.sh

2017-02-09 Thread HonzaCholasta
URL: https://github.com/freeipa/freeipa/pull/449 Title: #449: Travis CI: Upload the logs from failed jobs to transfer.sh Label: +pushed -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa

[Freeipa-devel] [freeipa PR#449][closed] Travis CI: Upload the logs from failed jobs to transfer.sh

2017-02-09 Thread HonzaCholasta
URL: https://github.com/freeipa/freeipa/pull/449 Author: martbab Title: #449: Travis CI: Upload the logs from failed jobs to transfer.sh Action: closed To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/449/head:pr449 git checkout

[Freeipa-devel] [freeipa PR#444][comment] Allow nsaccountlock to be searched in user-find commands

2017-02-10 Thread HonzaCholasta
URL: https://github.com/freeipa/freeipa/pull/444 Title: #444: Allow nsaccountlock to be searched in user-find commands HonzaCholasta commented: """ Replacing `flags=['no_option']` with `flags=['no_create', 'no_update']` is not backward compatible -

[Freeipa-devel] [freeipa PR#428][+ack] [Py3] ipa-server-install

2017-02-10 Thread HonzaCholasta
URL: https://github.com/freeipa/freeipa/pull/428 Title: #428: [Py3] ipa-server-install Label: +ack -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

[Freeipa-devel] [freeipa PR#428][+pushed] [Py3] ipa-server-install

2017-02-10 Thread HonzaCholasta
URL: https://github.com/freeipa/freeipa/pull/428 Title: #428: [Py3] ipa-server-install Label: +pushed -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

[Freeipa-devel] [freeipa PR#428][closed] [Py3] ipa-server-install

2017-02-10 Thread HonzaCholasta
URL: https://github.com/freeipa/freeipa/pull/428 Author: MartinBasti Title: #428: [Py3] ipa-server-install Action: closed To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/428/head:pr428 git checkout pr428 -- Manage your subscri

[Freeipa-devel] [freeipa PR#428][comment] [Py3] ipa-server-install

2017-02-10 Thread HonzaCholasta
URL: https://github.com/freeipa/freeipa/pull/428 Title: #428: [Py3] ipa-server-install HonzaCholasta commented: """ Fixed upstream master: https://fedorahosted.org/freeipa/changeset/88b192a37ead1538e6d840c2f686f8d21a948542 https://fedorahosted.org/fr

  1   2   3   4   5   6   >