Re: [Freeipa-devel] [PATCHES] 146-164 LDAP code refactoring (Part 4)

2013-01-30 Thread Petr Viktorin
On 01/29/2013 04:39 PM, Petr Viktorin wrote: On 01/28/2013 04:09 PM, Petr Viktorin wrote: On 01/28/2013 09:34 AM, Jan Cholasta wrote: On 25.1.2013 14:54, Petr Viktorin wrote: On 01/24/2013 03:06 PM, Petr Viktorin wrote: On 01/24/2013 10:43 AM, Petr Viktorin wrote: On 01/22/2013 04:04 PM, Pet

Re: [Freeipa-devel] [PATCHES] 0117-0118 Port ipa-replica-prepare to the admintool framework

2013-01-30 Thread Petr Viktorin
On 01/28/2013 04:36 PM, Petr Viktorin wrote: On 01/04/2013 02:43 PM, Petr Viktorin wrote: On 01/03/2013 02:56 PM, John Dennis wrote: On 01/03/2013 08:00 AM, Petr Viktorin wrote: Hello, The first patch implements logging-related changes to the admintool framework and ipa-ldap-updater (the only

[Freeipa-devel] Move ipaldap to ipalib?

2013-01-30 Thread Petr Viktorin
Hello, I've noticed that the client installer uses python-ldap directly, and duplicates some code we already have. Most recently, a convert_ldap_error function appeared in ipautil. Similar mechanisms are already in ipaldap, ipa-csreplica-manage, ipa-replica-manage, and my patches remove one i

[Freeipa-devel] [PATCH] 357 Use fully qualified CCACHE names

2013-01-30 Thread Martin Kosek
Some parts of install scripts used only ccache name as returned by krbV.CCache.name attribute. However, when this name is used again to initialize krbV.CCache object or when it is used in KRB5CCNAME environmental variable, it fails for new DIR type of CCACHE. We should always use both CCACHE type

Re: [Freeipa-devel] Move ipaldap to ipalib?

2013-01-30 Thread John Dennis
On 01/30/2013 07:04 AM, Petr Viktorin wrote: Hello, I've noticed that the client installer uses python-ldap directly, and duplicates some code we already have. Most recently, a convert_ldap_error function appeared in ipautil. Similar mechanisms are already in ipaldap, ipa-csreplica-manage, ipa-

Re: [Freeipa-devel] Move ipaldap to ipalib?

2013-01-30 Thread Rob Crittenden
Petr Viktorin wrote: Hello, I've noticed that the client installer uses python-ldap directly, and duplicates some code we already have. Most recently, a convert_ldap_error function appeared in ipautil. Similar mechanisms are already in ipaldap, ipa-csreplica-manage, ipa-replica-manage, and my p

Re: [Freeipa-devel] Move ipaldap to ipalib?

2013-01-30 Thread Petr Viktorin
On 01/30/2013 03:28 PM, Rob Crittenden wrote: Petr Viktorin wrote: Hello, I've noticed that the client installer uses python-ldap directly, and duplicates some code we already have. Most recently, a convert_ldap_error function appeared in ipautil. Similar mechanisms are already in ipaldap, ipa

Re: [Freeipa-devel] Move ipaldap to ipalib?

2013-01-30 Thread Dmitri Pal
On 01/30/2013 09:41 AM, Petr Viktorin wrote: > On 01/30/2013 03:28 PM, Rob Crittenden wrote: >> Petr Viktorin wrote: >>> Hello, >>> >>> I've noticed that the client installer uses python-ldap directly, and >>> duplicates some code we already have. >>> >>> Most recently, a convert_ldap_error functio

Re: [Freeipa-devel] Move ipaldap to ipalib?

2013-01-30 Thread Petr Viktorin
On 01/30/2013 03:56 PM, Dmitri Pal wrote: On 01/30/2013 09:41 AM, Petr Viktorin wrote: On 01/30/2013 03:28 PM, Rob Crittenden wrote: [...] ipaldap.py is going away eventually, right? No, the common code is in ipaldap.py. ldap2.py only has the ldap2 class, which is a CRUDBackend, manages the

Re: [Freeipa-devel] Move ipaldap to ipalib?

2013-01-30 Thread John Dennis
On 01/30/2013 09:41 AM, Petr Viktorin wrote: On 01/30/2013 03:28 PM, Rob Crittenden wrote: Petr Viktorin wrote: Hello, I've noticed that the client installer uses python-ldap directly, and duplicates some code we already have. Most recently, a convert_ldap_error function appeared in ipautil.

Re: [Freeipa-devel] Move ipaldap to ipalib?

2013-01-30 Thread Rob Crittenden
John Dennis wrote: On 01/30/2013 09:41 AM, Petr Viktorin wrote: On 01/30/2013 03:28 PM, Rob Crittenden wrote: Petr Viktorin wrote: Hello, I've noticed that the client installer uses python-ldap directly, and duplicates some code we already have. Most recently, a convert_ldap_error function a

Re: [Freeipa-devel] Move ipaldap to ipalib?

2013-01-30 Thread Petr Viktorin
On 01/30/2013 04:28 PM, Rob Crittenden wrote: John Dennis wrote: On 01/30/2013 09:41 AM, Petr Viktorin wrote: On 01/30/2013 03:28 PM, Rob Crittenden wrote: Petr Viktorin wrote: Hello, I've noticed that the client installer uses python-ldap directly, and duplicates some code we already have.

[Freeipa-devel] [PATCH 0027] Add checks for SELinux in install scripts

2013-01-30 Thread Tomas Babej
Hi, The checks make sure that SELinux is: - installed and enabled (on server install) - installed and enabled OR not installed (on client install) Please note that client installs with SELinux not installed are allowed since freeipa-client package has no dependency on SELinux. (any objection

Re: [Freeipa-devel] [PATCH 0027] Add checks for SELinux in install scripts

2013-01-30 Thread Tomas Babej
On 01/30/2013 05:12 PM, Tomas Babej wrote: Hi, The checks make sure that SELinux is: - installed and enabled (on server install) - installed and enabled OR not installed (on client install) Please note that client installs with SELinux not installed are allowed since freeipa-client package