[Freeipa-devel] [PATCH] 001 fixed empty dns record update

2011-07-25 Thread Petr Vobornik
https://fedorahosted.org/freeipa/ticket/1477 Redirection after updating empty DNS Record (which is deleted). Added hook to details facet for post update operation. Petr From aafbaf2464dcc16f552290f72424170c42055b45 Mon Sep 17 00:00:00 2001 From: Petr Vobornik pvobo...@redhat.com Date: Fri, 22

[Freeipa-devel] [PATCH] 002 Fixed adding host without DNS reverse zone

2011-07-26 Thread Petr Vobornik
. Is it ACKable, or is it better to do it as described? Petr From 3601c857fd4425c3df998e66a39235b67c441813 Mon Sep 17 00:00:00 2001 From: Petr Vobornik pvobo...@redhat.com Date: Tue, 26 Jul 2011 09:59:19 +0200 Subject: [PATCH] Fixed adding host without DNS reverse zone https://fedorahosted.org

Re: [Freeipa-devel] [PATCH] 002 Fixed adding host without DNS reverse zone

2011-07-27 Thread Petr Vobornik
On Tue, 2011-07-26 at 21:32 -0400, Adam Young wrote: On 07/26/2011 07:09 PM, Endi Sukma Dewata wrote: On 7/26/2011 6:27 AM, Petr Vobornik wrote: Fixed adding host without DNS reverse zone https://fedorahosted.org/freeipa/ticket/1481 Shows status dialog instead of error dialog (error

Re: [Freeipa-devel] [PATCH] 002 Fixed adding host without DNS reverse zone

2011-07-29 Thread Petr Vobornik
. Missed a few files in my commit. ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel From 75cc2819fafefc19d3feec7daf63b5bbe0aad4ca Mon Sep 17 00:00:00 2001 From: Petr Vobornik pvobo...@redhat.com

Re: [Freeipa-devel] [PATCH] 843 reduce dogtag install time

2011-08-03 Thread Petr Vobornik
On Mon, 2011-08-01 at 23:03 -0400, Adam Young wrote: On 08/01/2011 10:26 PM, Adam Young wrote: On 08/01/2011 03:19 PM, Rob Crittenden wrote: Ade Lee from the dogtag team looked at our installer and found that we restarted the pki-cad process too many times. Re-arranging some code

Re: [Freeipa-devel] [PATCH] 002 Fixed adding host without DNS reverse zone

2011-08-04 Thread Petr Vobornik
new version attached On Fri, 2011-07-29 at 12:11 -0500, Endi Sukma Dewata wrote: On 7/29/2011 11:12 AM, Petr Vobornik wrote: There was a small error in add.js:162. Fixed! Nice job on the dialog boxes. There's a problem though, the Retry doesn't quite work. This is because

Re: [Freeipa-devel] [PATCH] 002 Fixed adding host without DNS reverse zone

2011-08-05 Thread Petr Vobornik
On Thu, 2011-08-04 at 13:24 -0500, Endi Sukma Dewata wrote: On 8/4/2011 4:22 AM, Petr Vobornik wrote: new version attached Almost there, just a few more minor issues. Also these changes should be reverted back to maintain the Ajax context: - that.on_error.call(this, xhr, text_status

Re: [Freeipa-devel] [PATCH] 238 Fixed error after login on IE

2011-08-09 Thread Petr Vobornik
in error handling are OK. If it really works in IE I would consider it ACKed. -- Petr Vobornik ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel

Re: [Freeipa-devel] [PATCH] 239 Fixed host adder dialog.

2011-08-09 Thread Petr Vobornik
getting fqdn from field in host.js:280 fqdn: that.get_field('fqdn').save() isn't functional. -- Petr Vobornik ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel

Re: [Freeipa-devel] [PATCH] 239 Fixed host adder dialog.

2011-08-10 Thread Petr Vobornik
On 08/09/2011 08:04 PM, Endi Sukma Dewata wrote: On 8/9/2011 7:12 AM, Petr Vobornik wrote: NACK Add and edit without existing DNS reverse zone don't redirect to edit page. Field 'fqdn' doesn't exist any more so getting fqdn from field in host.js:280 fqdn: that.get_field('fqdn').save() isn't

Re: [Freeipa-devel] [PATCH] 240 Fixed DNS zone adder dialog.

2011-08-10 Thread Petr Vobornik
@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel ACK Same repetitive code as in host adder dialog (1457). But it should be covered by https://fedorahosted.org/freeipa/ticket/1394. -- Petr Vobornik ___ Freeipa-devel mailing list Freeipa

Re: [Freeipa-devel] [PATCH] 241 Fixed broken links in ipa_error.css and ipa_migration.css.

2011-08-11 Thread Petr Vobornik
@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel ACK I don't like that there is no pattern in image file naming. Sometimes it uses dashes, sometimes underscores. Some file names are capitalized. But this isn't the subject of this patch (ticket). -- Petr Vobornik

[Freeipa-devel] [PATCH] 004 error dialog for batch command

2011-08-11 Thread Petr Vobornik
but checking update dns' (1592) - added support(element's classes) for css styling of aggregated errors - except search dialog delete (1592) - no other batch command uses this feature (has to be explicitly turned on). -- Petr Vobornik From 52254b91e3c2546fea01c18f8bc879316ae7bb3d Mon Sep 17 00:00:00 2001

Re: [Freeipa-devel] [PATCH] 245 Fixed problem with buttons in enrollment dialog.

2011-08-15 Thread Petr Vobornik
://www.redhat.com/mailman/listinfo/freeipa-devel ACK -- Petr Vobornik ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel

Re: [Freeipa-devel] [PATCH] 004 error dialog for batch command

2011-08-15 Thread Petr Vobornik
future use in custom handlers 6. The list of errors should be displayed as a list (with bullets) like in the deleter dialog. done 7. Just for consistency, the Retry label declaration in ipa.js:737 could be moved into the if-statement like the other labels. done -- Petr Vobornik From

Re: [Freeipa-devel] [PATCH] 242 Removed custom layout for password reset.

2011-08-15 Thread Petr Vobornik
patch from code and working perspective is OK. Has this patch assigned some ticket? Don't know exactly what is IPA's policy for submitting patches without tickets in Trac (for future tracking). -- Petr Vobornik ___ Freeipa-devel mailing list Freeipa

Re: [Freeipa-devel] [PATCH] 247 Hide activation/deactivation link from regular users.

2011-08-17 Thread Petr Vobornik
@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel ACK -- Petr Vobornik ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel

Re: [Freeipa-devel] [PATCH] 246 Fixed browser configuration pages

2011-08-17 Thread Petr Vobornik
/freeipa-devel ACK -- Petr Vobornik ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel

[Freeipa-devel] [PATCH] 005 Show error in serial association

2011-08-17 Thread Petr Vobornik
in success handler should not be undefined. -- Petr Vobornik From 7670faa42492e8850cffd7c54d60f6f6eaa7c51b Mon Sep 17 00:00:00 2001 From: Petr Vobornik pvobo...@redhat.com Date: Wed, 17 Aug 2011 15:06:41 +0200 Subject: [PATCH] Show error in serial association https://fedorahosted.org/freeipa/ticket

Re: [Freeipa-devel] [PATCH] 005 Show error in serial association

2011-08-18 Thread Petr Vobornik
On 08/17/2011 05:38 PM, Petr Vobornik wrote: Ticket #1628 - https://fedorahosted.org/freeipa/ticket/1628 Unreported insufficient access error This patch is dependant on freeipa-pvoborni-0004-1-error-dialog-for-batch-command.patch. This may be only a checking if approach of this patch is good

[Freeipa-devel] [PATCH] 006 Uncheck checkboxes in association after deletion

2011-08-18 Thread Petr Vobornik
, it could be useful later. As I was implementing it, I noticed that after removing or adding sudo option it refreshes facet - all other associations. Don't know if it's a feature or a bug. (sudo.js: 679, 683, 723, 727). -- Petr Vobornik From b2113a79520dce7e95f5e70678187fcba814f839 Mon Sep 17 00:00:00

Re: [Freeipa-devel] [PATCH] 005 Show error in serial association

2011-08-18 Thread Petr Vobornik
On 08/18/2011 10:28 AM, Petr Vobornik wrote: On 08/17/2011 05:38 PM, Petr Vobornik wrote: Ticket #1628 - https://fedorahosted.org/freeipa/ticket/1628 Unreported insufficient access error This patch is dependant on freeipa-pvoborni-0004-1-error-dialog-for-batch-command.patch. This may be only

Re: [Freeipa-devel] [PATCH] 249 Removed 'Hide already enrolled' checkbox.

2011-08-19 Thread Petr Vobornik
mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel ACK if leaving string in internal.py is the right thing to do when deleting related label (the string isn't used anywhere else). -- Petr Vobornik ___ Freeipa

Re: [Freeipa-devel] [PATCH] 006 Uncheck checkboxes in association after deletion

2011-08-19 Thread Petr Vobornik
On 08/18/2011 10:30 PM, Endi Sukma Dewata wrote: On 8/18/2011 8:18 AM, Petr Vobornik wrote: https://fedorahosted.org/freeipa/ticket/1639 - added unchecking all checkboxes of table_widget and its derivates to on_load method. line '$('input[name=select]', that.tbody).attr('checked', false

Re: [Freeipa-devel] [PATCH] 005 Show error in serial association

2011-08-22 Thread Petr Vobornik
On 08/18/2011 06:25 PM, Endi Sukma Dewata wrote: On 8/17/2011 10:38 AM, Petr Vobornik wrote: Ticket #1628 - https://fedorahosted.org/freeipa/ticket/1628 Unreported insufficient access error This patch is dependant on freeipa-pvoborni-0004-1-error-dialog-for-batch-command.patch. This may

Re: [Freeipa-devel] [PATCH] 005 Show error in serial association

2011-08-23 Thread Petr Vobornik
On 08/22/2011 07:05 PM, Endi Sukma Dewata wrote: On 8/22/2011 10:06 AM, Petr Vobornik wrote: 'Failed' moved to command. On 'failed' success is transformed to error - can be change behaviour of serial associator in some commands (previously some commands were executed even after 'failed

Re: [Freeipa-devel] [PATCH] 251 Updated add and delete association dialog titles.

2011-08-23 Thread Petr Vobornik
___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel ACK -- Petr Vobornik ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com

Re: [Freeipa-devel] [PATCH] 252 Removed unnecessary HBAC/sudo rule category modification.

2011-08-23 Thread Petr Vobornik
, the IPA.rule_association_table_widget is no longer needed. Ticket #1692 ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel ACK -- Petr Vobornik ___ Freeipa

Re: [Freeipa-devel] [PATCH] 005 Show error in serial association

2011-08-24 Thread Petr Vobornik
On 08/23/2011 11:09 PM, Endi Sukma Dewata wrote: On 8/23/2011 6:34 AM, Petr Vobornik wrote: Please take a look at the attached patch. This should be applied on top of your patch. It does several things: 1. As mentioned over IRC, we should be treating these partial failure as a success

[Freeipa-devel] [PATCH] 007 Validation of details facet before update

2011-08-24 Thread Petr Vobornik
executed. Fixed integer minimum and maximum value checking. Read-only and non-writeable fields are no longer considered required. -- Petr Vobornik From 8ccfd1ac82eaa2cb322a23166be54836f907c644 Mon Sep 17 00:00:00 2001 From: Petr Vobornik pvobo...@redhat.com Date: Wed, 24 Aug 2011 15:36:48 +0200 Subject

Re: [Freeipa-devel] [PATCH] 254 Fixed default map type in automount map adder dialog.

2011-08-25 Thread Petr Vobornik
/freeipa-devel ACK -- Petr Vobornik ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel

Re: [Freeipa-devel] [PATCH] 256 Fixed host keytab status after setting OTP.

2011-08-26 Thread Petr Vobornik
@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel ACK -- Petr Vobornik ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel

Re: [Freeipa-devel] [PATCH] 009 Modifying sudo options refreshes the whole page

2011-08-29 Thread Petr Vobornik
On 08/26/2011 11:04 PM, Endi Sukma Dewata wrote: On 8/26/2011 11:41 AM, Petr Vobornik wrote: https://fedorahosted.org/freeipa/ticket/1689 Currently adding or deleting sudo options will refresh the entire page. It's not a problem but the code could be optimized to refresh only the sudo options

Re: [Freeipa-devel] [PATCH] 259 Fixed problem adding hostgroup into netgroup.

2011-08-31 Thread Petr Vobornik
name - something similar to what is used now in association_table) and do not blindly copy entity from facet as it is done now (association entity often isn't equal to facet entity (eg in memberof association)). This could be part of https://fedorahosted.org/freeipa/ticket/1690 . -- Petr

Re: [Freeipa-devel] [PATCH] 260 Fixed problem with combobox.

2011-08-31 Thread Petr Vobornik
/mailman/listinfo/freeipa-devel ACK -- Petr Vobornik ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel

[Freeipa-devel] [PATCH] 011 Attributes table not scrollable

2011-08-31 Thread Petr Vobornik
makes it more difficult to use. -- Petr Vobornik From d54e3d5758771fd010ce60ff0d77ee51964f7bc3 Mon Sep 17 00:00:00 2001 From: Petr Vobornik pvobo...@redhat.com Date: Wed, 31 Aug 2011 14:42:33 +0200 Subject: [PATCH] Attributes table not scrollable https://fedorahosted.org/freeipa/ticket/1739

[Freeipa-devel] [PATCH] 012 Fixed inconsistency in enabling delete buttons

2011-09-07 Thread Petr Vobornik
to be deleted or not, or even if there is no object to be selected to delete. One can click on this button...but then - there is no message indicating that something should be selected for deletion for this button to do anything. Milestone: 3.0 Core Effort Backlog -- Petr Vobornik From

[Freeipa-devel] [PATCH] 013 Fixed: JavaScript type error in entitlement page

2011-09-07 Thread Petr Vobornik
https://fedorahosted.org/freeipa/ticket/1767 Opening IPA Server/Entitlements causes: Uncaught TypeError: Cannot call method 'addClass' of undefined error - Details.js:489 -- Petr Vobornik From 17a3dbed887a75fa1ff0198edb5ae9873b1b35a3 Mon Sep 17 00:00:00 2001 From: Petr Vobornik pvobo

Re: [Freeipa-devel] [PATCH] 265 Fixed layout problem in permission adder dialog.

2011-09-08 Thread Petr Vobornik
by spec object usage. It doesn't add any functionality. 3) IPA.permission_details_facet can be deleted - it isn't used anywhere. Should we unite label align? In add dialog labels are aligned left, in details table right. Otherwise it looks OK. -- Petr Vobornik

Re: [Freeipa-devel] [PATCH] 265 Fixed layout problem in permission adder dialog.

2011-09-09 Thread Petr Vobornik
On 09/08/2011 06:51 PM, Endi Sukma Dewata wrote: On 9/8/2011 11:13 AM, Petr Vobornik wrote: In IPA.details_table_section: 1)not renamed list_section_create method Fixed. Code clean-up in aci.js: 2) IPA.rights_section can be deleted and replaced by spec object usage. It doesn't add any

Re: [Freeipa-devel] [PATCH] 266 Fixed sudo rule association dialogs.

2011-09-09 Thread Petr Vobornik
or indirectly via groups. This does not apply to the command and run-as tables because they do not support such option. Ticket #1768 Wrong email title. It should be patch #266. ACK -- Petr Vobornik ___ Freeipa-devel mailing list Freeipa-devel@redhat.com

Re: [Freeipa-devel] [PATCH] 012 Fixed inconsistency in enabling delete buttons

2011-09-09 Thread Petr Vobornik
On 09/07/2011 09:06 PM, Endi Sukma Dewata wrote: On 9/7/2011 7:16 AM, Petr Vobornik wrote: https://fedorahosted.org/freeipa/ticket/1640 .. One issue, in HBAC/sudo rules details page if the category is changed from 'all' to 'specific', the Delete button will be enabled although

Re: [Freeipa-devel] [PATCH] 267 Fixed missing optional field.

2011-09-12 Thread Petr Vobornik
in details facet. As you write, some clean-up should be addressed in #1394 or/and in #1696 (to be consistent with dialogs). -- Petr Vobornik ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel

Re: [Freeipa-devel] [PATCH] 268 Fixed labels for run-as users and groups.

2011-09-12 Thread Petr Vobornik
method in widget (IPA.get_entity_param) instead of metadata.objects.[other_entity].label. This isn't entirely wrong, but param labels aren't always consistent with entity.labels. Otherwise its OK. -- Petr Vobornik ___ Freeipa-devel mailing list Freeipa

[Freeipa-devel] [PATCH] 014 Code cleanup: widget creation

2011-09-13 Thread Petr Vobornik
https://fedorahosted.org/freeipa/ticket/1788 Removed code duplication of undo links. Simplified code of widget creation to be more readable. -- Petr Vobornik From c1e47469cd394c8934e0a6bf3cc84e88b5a6bb5a Mon Sep 17 00:00:00 2001 From: Petr Vobornik pvobo...@redhat.com Date: Tue, 13 Sep 2011 13

Re: [Freeipa-devel] [PATCH] 268 Fixed labels for run-as users and groups.

2011-09-13 Thread Petr Vobornik
On 09/13/2011 08:04 AM, Endi Sukma Dewata wrote: The labels from entity parameter are actually more appropriate. I've updated the patch to use them instead. I also fixed some of the labels (the run-as group label doc is incorrect). ACK -- Petr Vobornik

[Freeipa-devel] [PATCH] 015 Fixed: Missing read permission option in RBAC permission

2011-09-13 Thread Petr Vobornik
https://fedorahosted.org/freeipa/ticket/1787 In 'IPA Server/RBAC/Permission/Settings/Rights' is missing a option for setting 'read' permission which is supported in CLI. -- Petr Vobornik From 6110e275e36adf310fc56d3d72480b1512a76be2 Mon Sep 17 00:00:00 2001 From: Petr Vobornik pvobo

Re: [Freeipa-devel] [PATCH] 270 Fixed posix group checkbox.

2011-09-15 Thread Petr Vobornik
to be changes in save method). So if its OK, after a test correction I would consider it ACKed. -- Petr Vobornik ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel

Re: [Freeipa-devel] [PATCH] 273 Removed HBAC rule type.

2011-09-20 Thread Petr Vobornik
list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel ACK -- Petr Vobornik ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel

Re: [Freeipa-devel] [PATCH] 271 Modified dialog to use sections.

2011-09-22 Thread Petr Vobornik
On 09/21/2011 10:10 PM, Endi Sukma Dewata wrote: On 9/21/2011 6:50 AM, Petr Vobornik wrote: Fixed. The dialog fields don't need undo, so the text() needs to be overridden to disable undo. This can be improved again later. The override isn't necessary because it wasn't there before and all

Re: [Freeipa-devel] [PATCH] 279 Fixed problem enrolling member with the same name.

2011-09-22 Thread Petr Vobornik
___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel ACK -- Petr Vobornik ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com

Re: [Freeipa-devel] [PATCH] 280 Fixed problem displaying special characters.

2011-09-23 Thread Petr Vobornik
) { if(value) { return $('div/').html(value).text(); } else { return ''; } } -- Petr Vobornik ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel

Re: [Freeipa-devel] [PATCH] 281 Fixed problem on combobox with search limit.

2011-09-23 Thread Petr Vobornik
the filter automatically because that might not be the user's intention. Ticket #1819 ACK -- Petr Vobornik ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel

[Freeipa-devel] [PATCH] 017 Fixed: Column header for attributes table should be full, width

2011-09-23 Thread Petr Vobornik
element is added in order to set padding for cell text because parent th element has css-hacked width. Tbody's use of overflow is the cause of used hacks. -- Petr Vobornik From 6d5429191f5f530d5aae6b689a2326404ef4f126 Mon Sep 17 00:00:00 2001 From: Petr Vobornik pvobo...@redhat.com Date: Fri, 23

Re: [Freeipa-devel] [PATCH] 017 Fixed: Column header for attributes table should be full, width

2011-09-26 Thread Petr Vobornik
On 09/26/2011 08:15 AM, Endi Sukma Dewata wrote: On 9/23/2011 11:05 AM, Petr Vobornik wrote: https://fedorahosted.org/freeipa/ticket/1841 The column header for the attributes table (IPA.attributes_widget) does not cover the entire width of the table. This problem appears in the adder dialog

Re: [Freeipa-devel] [PATCH] 277 Updated DNS zone details page.

2011-09-26 Thread Petr Vobornik
, this attribute should be displayed as radio buttons and LABELED 'Enabled' Will this be part of other ticket (missing translation for 3.0 or such)? Otherwise its OK. -- Petr Vobornik ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https

Re: [Freeipa-devel] [PATCH] 278 Replaced description text fields with text areas.

2011-09-26 Thread Petr Vobornik
and SUDO add dialogs? Otherwise it's OK. -- Petr Vobornik ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel

[Freeipa-devel] [PATCH] 018 Fixed: Enrolment dialog offers to add entity to reflexive association.

2011-09-27 Thread Petr Vobornik
metadata/spec information). This all depends on how we want to make the framework flexible. -- Petr Vobornik From ac0fd222072d9360ac50dfd2ea7db9c8cdee6c6c Mon Sep 17 00:00:00 2001 From: Petr Vobornik pvobo...@redhat.com Date: Tue, 27 Sep 2011 10:00:27 +0200 Subject: [PATCH] Fixed: Enrolment dialog

Re: [Freeipa-devel] [PATCH] 016 Fixed: Some widgets do not have space for validation error message

2011-09-27 Thread Petr Vobornik
On 09/15/2011 01:51 AM, Endi Sukma Dewata wrote: On 9/14/2011 7:23 AM, Petr Vobornik wrote: Forgot to update tests - to address newly added validation row in table_widget. One issue, in all search and association facets we now have 2 rows of footer (there are 2 horizontal lines at the bottom

Re: [Freeipa-devel] [PATCH] 286 Fixed tab and dialog widths.

2011-09-29 Thread Petr Vobornik
On 09/28/2011 01:02 AM, Endi Sukma Dewata wrote: The width of the 1st level tab has been modified to expand according to the size of the tab label. The width of the adder dialogs have been increased to allow longer button labels. Ticket #1825 ACK -- Petr Vobornik

Re: [Freeipa-devel] [PATCH] 275 Use editable combobox for service type.

2011-09-29 Thread Petr Vobornik
On 09/28/2011 12:59 AM, Endi Sukma Dewata wrote: On 9/16/2011 12:16 PM, Endi Sukma Dewata wrote: The service type field in the service adder dialog has been modified to use an editable combobox. Ticket #1633. Rebased (removed undo parameter). ACK -- Petr Vobornik

Re: [Freeipa-devel] [PATCH] 288 Disable enroll button if nothing selected.

2011-09-29 Thread Petr Vobornik
probably can be combined with the IPA.action_button/IPA.button class so we can use icons or enable/disable buttons in a more consistent way. This is one step in that direction. I Agree. This would be nice especially in association table widget. ACK -- Petr Vobornik

Re: [Freeipa-devel] [PATCH] 016 Fixed: Some widgets do not have space for validation error message

2011-09-29 Thread Petr Vobornik
On 09/27/2011 10:54 PM, Endi Sukma Dewata wrote: On 9/27/2011 7:50 AM, Petr Vobornik wrote: I've added padding and unified font-weight in error-message style. The padding is added because text of the message was right on the border which wasn't much readable. Font-weight is added because

Re: [Freeipa-devel] [PATCH] 291 I18n clean-up.

2011-10-03 Thread Petr Vobornik
On 10/01/2011 12:09 AM, Endi Sukma Dewata wrote: The hard-coded 'undo' and 'undo all' labels have been moved into internal.py to allow translation. Ticket #1897 ACK -- Petr Vobornik ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https

Re: [Freeipa-devel] [PATCH] 292 Disable sudo options Delete button if nothing selected.

2011-10-03 Thread Petr Vobornik
On 10/01/2011 12:10 AM, Endi Sukma Dewata wrote: The Delete button for sudo options in sudo rule details page now will only work if there is at least one row selected. Ticket #1896 ACK -- Petr Vobornik ___ Freeipa-devel mailing list Freeipa-devel

[Freeipa-devel] [PATCH] 019 Disables gid field if not posix group in group adder dialog

2011-10-04 Thread Petr Vobornik
https://fedorahosted.org/freeipa/ticket/1922 gidNumber is not an allowed attribute for a non-posix group. When adding a non-posix group from the UI, unchecking the Is this a POSIX group?: box should disable the GID: field. -- Petr Vobornik From 3e329f7f6e26cf839681c95d163625223fb2c546 Mon

Re: [Freeipa-devel] [PATCH] 019 Disables gid field if not posix group in group adder dialog

2011-10-05 Thread Petr Vobornik
On 10/04/2011 11:59 PM, Adam Young wrote: On 10/04/2011 12:43 PM, Petr Vobornik wrote: https://fedorahosted.org/freeipa/ticket/1922 gidNumber is not an allowed attribute for a non-posix group. When adding a non-posix group from the UI, unchecking the Is this a POSIX group?: box should disable

[Freeipa-devel] [PATCH] 023 Circular entity dependency

2011-10-10 Thread Petr Vobornik
was second part of 021, but the file name was wrong(021-1) -- Petr Vobornik From 4785e6bbc9d4254025bb3e06e865f2eccac9f36f Mon Sep 17 00:00:00 2001 From: Petr Vobornik pvobo...@redhat.com Date: Mon, 10 Oct 2011 13:34:15 +0200 Subject: [PATCH] Circular entity dependency https://fedorahosted.org

[Freeipa-devel] [PATCH] 024 Added missing fields to password policy page

2011-10-11 Thread Petr Vobornik
https://fedorahosted.org/freeipa/ticket/1944 (2.1.3 Release) No editable fields exist for maxfail, failinterval lockouttime and priority in password policy page. -- Petr Vobornik From 9ae5eca65de34c02fe0c3baae6eb27e2fa8fe346 Mon Sep 17 00:00:00 2001 From: Petr Vobornik pvobo...@redhat.com

[Freeipa-devel] [PATCH] 026 Fixed: Unable to add external user for RunAs User for Sudo

2011-10-17 Thread Petr Vobornik
https://fedorahosted.org/freeipa/ticket/1987 -- Petr Vobornik From 931b27dbb54ace65e2213ffed718ee04ace5fc07 Mon Sep 17 00:00:00 2001 From: Petr Vobornik pvobo...@redhat.com Date: Mon, 17 Oct 2011 11:48:03 +0200 Subject: [PATCH] Fixed: Unable to add external user for RunAs User for Sudo rules

Re: [Freeipa-devel] [PATCH] 023 Circular entity dependency

2011-10-18 Thread Petr Vobornik
Comments in text. Also attached git diff for convenience. On 10/17/2011 10:39 PM, Endi Sukma Dewata wrote: On 10/10/2011 10:13 AM, Petr Vobornik wrote: https://fedorahosted.org/freeipa/ticket/1531 (3.0 Core Effort Iteration 01 September Y11 Release) Implemented solution: * all entities

Re: [Freeipa-devel] [PATCH] 023 Circular entity dependency

2011-10-20 Thread Petr Vobornik
Fix for regression in unit test, introduced by previous patch. -- Petr Vobornik From f1a1a99763f38a10304c374da88857c85c9e7748 Mon Sep 17 00:00:00 2001 From: Petr Vobornik pvobo...@redhat.com Date: Thu, 20 Oct 2011 16:37:48 +0200 Subject: [PATCH] Fixing infinite loop in UI navigation unit test

Re: [Freeipa-devel] [PATCH] 295 Fixed inconsistent required/optional attributes.

2011-10-21 Thread Petr Vobornik
unnecessary. But if the required indicator was like in 1) it will be useful. Summary: All 3 points are nice to have. If you think is not necessary then ACK. This patch is also fixing https://fedorahosted.org/freeipa/ticket/1973 . -- Petr Vobornik attachment: required

Re: [Freeipa-devel] [PATCH] 028 Code cleanup of HBAC, Sudo rules

2011-10-25 Thread Petr Vobornik
Comments in text. New patch not supplied yet - some topics may require further discussion. Most of the comments should be part of the 'Nesting widgets' thread. On 10/24/2011 06:29 PM, Endi Sukma Dewata wrote: On 10/24/2011 3:29 AM, Petr Vobornik wrote: https://fedorahosted.org/freeipa/ticket

Re: [Freeipa-devel] [PATCH] 295 Fixed inconsistent required/optional attributes.

2011-10-25 Thread Petr Vobornik
On 10/24/2011 10:43 PM, Endi Sukma Dewata wrote: On 10/21/2011 6:40 AM, Petr Vobornik wrote: 1) Wouldn't be better if the asterisk has different color than the label? Visually I don't like it that much and I think it can be overlook. Attaching a proposition. I used green IPAish color because

Re: [Freeipa-devel] [PATCH] 298 Fixed host Enrolled column.

2011-10-26 Thread Petr Vobornik
different language. It should be translated. We can fix it separately, it is also present in SUDO rules search facet. -- Petr Vobornik ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel

Re: [Freeipa-devel] [PATCH] 297 Fixed enroll labels.

2011-10-26 Thread Petr Vobornik
to entity_adder_dialog but its method add_dialog_create wasn't renamed -- Petr Vobornik ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel

Re: [Freeipa-devel] [PATCH] 297 Fixed enroll labels.

2011-10-27 Thread Petr Vobornik
On 10/26/2011 07:44 PM, Endi Sukma Dewata wrote: On 10/26/2011 7:09 AM, Petr Vobornik wrote: 1) add_dialog was renamed to entity_adder_dialog but its method add_dialog_create wasn't renamed Fixed. ACK -- Petr Vobornik ___ Freeipa-devel mailing

Re: [Freeipa-devel] [PATCH] 299 Merged widget's metadata and param_info.

2011-10-27 Thread Petr Vobornik
On 10/26/2011 07:59 PM, Endi Sukma Dewata wrote: The metadata and param_info attributes in widget have been merged because they are redundant. Ticket #1436 ACK -- Petr Vobornik ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https

Re: [Freeipa-devel] [PATCH] 300 Refactored validation code.

2011-10-27 Thread Petr Vobornik
On 10/26/2011 08:09 PM, Endi Sukma Dewata wrote: The validation code in details facet, dialog, and sections have been modified to work more consistently. This is required by patch #301. ACK -- Petr Vobornik ___ Freeipa-devel mailing list Freeipa

Re: [Freeipa-devel] [PATCH] 301 Added password field in user adder dialog.

2011-10-27 Thread Petr Vobornik
On 10/26/2011 08:11 PM, Endi Sukma Dewata wrote: The user adder dialog has been modified to provide optional fields to specify password during user creation. Ticket #1646 1) message in: 'field2.show_error('Passwords do not match');' should use translated string. -- Petr Vobornik

Re: [Freeipa-devel] [PATCH] 302 Fixed inconsistent image names.

2011-10-27 Thread Petr Vobornik
On 10/27/2011 12:31 AM, Endi Sukma Dewata wrote: The images have been renamed to be more consistent and moved into the images directory to mimic the original jQuery UI structure. Ticket #1613 ACK -- Petr Vobornik ___ Freeipa-devel mailing list

Re: [Freeipa-devel] [PATCH] 303 Fixed inconsistent details facet validation.

2011-10-27 Thread Petr Vobornik
move. I think, this way the handler is doing more things than it should do. However I'm fond of changing the update method to be more override friendly. -- Petr Vobornik ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com

[Freeipa-devel] [PATCH] 029 Page is cleared before it is visible

2011-10-27 Thread Petr Vobornik
https://fedorahosted.org/freeipa/ticket/1459 Changes: * added clear method to widgets, section, search, details, association facets * clear method in facet is called only if key/filter was changed -- Petr Vobornik From 22d6ba37f74ec40a8223082b8f6869ec9f1155a5 Mon Sep 17 00:00:00 2001 From

Re: [Freeipa-devel] [PATCH] 028 Code cleanup of HBAC, Sudo rules

2011-10-27 Thread Petr Vobornik
I'll rebase this patch on recent patches (which will be soon pushed). This effort is doing too many things, I'll split the patch into several. On 10/25/2011 07:57 PM, Endi Sukma Dewata wrote: On 10/25/2011 7:49 AM, Petr Vobornik wrote: 2. The set_facet() is added to widget. I don't think we

Re: [Freeipa-devel] [PATCH] 301 Added password field in user adder dialog.

2011-10-27 Thread Petr Vobornik
On 10/27/2011 04:59 PM, Endi Sukma Dewata wrote: On 10/27/2011 2:58 AM, Petr Vobornik wrote: 1) message in: 'field2.show_error('Passwords do not match');' should use translated string. Fixed. I'm considering to move the password fields into a reusable section, but that will be a separate

Re: [Freeipa-devel] [PATCH] 029 Page is cleared before it is visible

2011-11-01 Thread Petr Vobornik
On 10/31/2011 11:38 PM, Endi Sukma Dewata wrote: On 10/27/2011 4:57 AM, Petr Vobornik wrote: https://fedorahosted.org/freeipa/ticket/1459 Some issues: 1. The new clear() method is called during refresh(), so the facet with the old data is still shown for a brief moment before it's cleared

Re: [Freeipa-devel] [PATCH] 029 Page is cleared before it is visible

2011-11-02 Thread Petr Vobornik
On 11/01/2011 11:31 PM, Endi Sukma Dewata wrote: On 11/1/2011 7:37 AM, Petr Vobornik wrote: 1. The new clear() method is called during refresh(), so the facet with the old data is still shown for a brief moment before it's cleared. The clear() should be called before show(). However

Re: [Freeipa-devel] [PATCH] 029 Page is cleared before it is visible

2011-11-02 Thread Petr Vobornik
On 11/02/2011 04:41 PM, Endi Sukma Dewata wrote: On 11/2/2011 8:33 AM, Petr Vobornik wrote: Question about this one: 4) Changed direct/indirect radio names in association facets - radios form different facets were interfering. Did you notice any problem with the old radio name? The name

[Freeipa-devel] [PATCH] 030 Extending facet's mechanism of gathering changes

2011-11-03 Thread Petr Vobornik
https://fedorahosted.org/freeipa/ticket/2041 I'm not sure if update_info and other new classes should be in details.js. -- Petr Vobornik From 0506538ec9da347f2d2b7bac103b9c06fc405c2f Mon Sep 17 00:00:00 2001 From: Petr Vobornik pvobo...@redhat.com Date: Wed, 2 Nov 2011 16:43:00 +0100 Subject

[Freeipa-devel] [PATCH] 031 Field for DNS SOA class changed to combobox with options

2011-11-03 Thread Petr Vobornik
https://fedorahosted.org/freeipa/ticket/602 -- Petr Vobornik From 47022d96920b16a81ee54d53725de2e00d8c5c91 Mon Sep 17 00:00:00 2001 From: Petr Vobornik pvobo...@redhat.com Date: Thu, 3 Nov 2011 15:14:15 +0100 Subject: [PATCH] Field for DNS SOA class changed to combobox with options https

Re: [Freeipa-devel] [PATCH] 306 Moved facet code into facet.js.

2011-11-04 Thread Petr Vobornik
On 11/04/2011 04:35 AM, Endi Sukma Dewata wrote: Facet-related code has been moved from entity.js into a new facet.js because the file is getting too big. ACK and pushed to master -- Petr Vobornik ___ Freeipa-devel mailing list Freeipa-devel

Re: [Freeipa-devel] [PATCH] 029 Page is cleared before it is visible

2011-11-04 Thread Petr Vobornik
On 11/03/2011 10:22 PM, Endi Sukma Dewata wrote: On 11/2/2011 11:01 AM, Petr Vobornik wrote: Regardless, ACK and pushed to master. Found another problem, the krbtpolicy config need to be forced to update. See the attached patch. ACK and pushed to master. -- Petr Vobornik

Re: [Freeipa-devel] [PATCH] 307 Added extensible UI framework.

2011-11-04 Thread Petr Vobornik
and pushed to master -- Petr Vobornik ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel

Re: [Freeipa-devel] [PATCH] 308 Added current password field.

2011-11-07 Thread Petr Vobornik
On 11/04/2011 11:29 PM, Endi Sukma Dewata wrote: The reset password dialog for user has been modified to provide a field to specify the current password when changing the user's own password. Ticket #2065 ACK ipa-2-1, master -- Petr Vobornik

Re: [Freeipa-devel] [PATCH] 029 Page is cleared before it is visible

2011-11-07 Thread Petr Vobornik
On 11/05/2011 01:37 AM, Endi Sukma Dewata wrote: On 11/4/2011 11:02 AM, Petr Vobornik wrote: Found another problem, changing page in the association facet didn't work because pkey is still the same. See the attached patch. ACK and pushed to master -- Petr Vobornik

Re: [Freeipa-devel] [PATCH] 030 Extending facet's mechanism of gathering changes

2011-11-07 Thread Petr Vobornik
On 11/04/2011 06:22 PM, Endi Sukma Dewata wrote: Rebased, ACK, and pushed to master. Some comments below. On 11/4/2011 7:21 AM, Petr Vobornik wrote: Perhaps the save_as_update_info() later can be merged with get_update_info() too because both are essentially generating update_info for dirty

Re: [Freeipa-devel] [PATCH] 310 Updated sample data.

2011-11-11 Thread Petr Vobornik
On 11/09/2011 09:28 PM, Endi Sukma Dewata wrote: New sample data files have been added for search facet paging. Unused files have been removed. The names used in the files have been updated for consistency. Ticket #981 ACK -- Petr Vobornik

Re: [Freeipa-devel] [PATCH] 311 Added paging on search facet.

2011-11-11 Thread Petr Vobornik
pager (because page_length property is set). This can be misleading. Otherwise it is OK. -- Petr Vobornik ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel

Re: [Freeipa-devel] Ticket #1976 - Tab color groups

2011-11-11 Thread Petr Vobornik
] Name: example.com Status: Active Records [edit] host1 A 192.168.1.1 host2 A 192.168.1.2 May be useful for some users. -- Petr Vobornik ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel

  1   2   3   4   5   6   7   8   9   10   >