Re: [Freeipa-devel] [DESIGN-REVIEW] V4/Manage_replication_topology_4_4
On 05/19/2016 08:45 AM, Oleg Fayans wrote: > Hi Martin, > > I should probably rephrase my question: will the server_del API call be > added to 'ipa-server-install --uninstall' within 4.4 or is it a more > distant plan? It will be added in 4.4. Martin 3 is working on it. http://www.freeipa.org/page/V4/Manage_replication_topology_4_4#uninstallation https://fedorahosted.org/freeipa/ticket/5588 > > On 05/18/2016 05:18 PM, Martin Babinsky wrote: >> On 05/18/2016 05:01 PM, Oleg Fayans wrote: >>> Hi guys, >>> >>> Did I understand correctly that in 4.4 release the function of both >>> 'ipa-csreplica-manage del' and 'ipa-replica-manage del' will be >>> transfered to the API calls executed during replica uninstallation with >>> 'ipa-server-install --uninstall'? Which means that 'ipa-replica-manage >>> del' will be deprecated? >>> >>> >> >> `ipa-csreplica-manage del` is deprecated in domain level 1 topology and >> will raise an error, we even have a test case for this in replica >> promotion CI tests ;). So no `server_del` here. >> >> `ipa-replica-manage del` will not be explicitly deprecated, but it will >> call `server_del` behind the scenes. >> >>> On 05/16/2016 03:48 PM, Oleg Fayans wrote: Hi, The design is OK, the onlz thing that is missing is a HowToTest section in track tickets [1] and [2] about clean-dangling-ruvs and abort-clean-ruv respectively. It would really help if these tickets had detailed steps to test (in case of dangling RUV's - steps to generate them) >>> >> >> > -- Petr Vobornik -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code
Re: [Freeipa-devel] [DESIGN-REVIEW] V4/Manage_replication_topology_4_4
Hi Martin, I should probably rephrase my question: will the server_del API call be added to 'ipa-server-install --uninstall' within 4.4 or is it a more distant plan? On 05/18/2016 05:18 PM, Martin Babinsky wrote: > On 05/18/2016 05:01 PM, Oleg Fayans wrote: >> Hi guys, >> >> Did I understand correctly that in 4.4 release the function of both >> 'ipa-csreplica-manage del' and 'ipa-replica-manage del' will be >> transfered to the API calls executed during replica uninstallation with >> 'ipa-server-install --uninstall'? Which means that 'ipa-replica-manage >> del' will be deprecated? >> >> > > `ipa-csreplica-manage del` is deprecated in domain level 1 topology and > will raise an error, we even have a test case for this in replica > promotion CI tests ;). So no `server_del` here. > > `ipa-replica-manage del` will not be explicitly deprecated, but it will > call `server_del` behind the scenes. > >> On 05/16/2016 03:48 PM, Oleg Fayans wrote: >>> Hi, >>> >>> The design is OK, the onlz thing that is missing is a HowToTest section >>> in track tickets [1] and [2] about clean-dangling-ruvs and >>> abort-clean-ruv respectively. It would really help if these tickets had >>> detailed steps to test (in case of dangling RUV's - steps to generate >>> them) >>> >> > > -- Oleg Fayans Quality Engineer FreeIPA team RedHat. -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code
Re: [Freeipa-devel] [DESIGN-REVIEW] V4/Manage_replication_topology_4_4
On 05/18/2016 05:01 PM, Oleg Fayans wrote: Hi guys, Did I understand correctly that in 4.4 release the function of both 'ipa-csreplica-manage del' and 'ipa-replica-manage del' will be transfered to the API calls executed during replica uninstallation with 'ipa-server-install --uninstall'? Which means that 'ipa-replica-manage del' will be deprecated? `ipa-csreplica-manage del` is deprecated in domain level 1 topology and will raise an error, we even have a test case for this in replica promotion CI tests ;). So no `server_del` here. `ipa-replica-manage del` will not be explicitly deprecated, but it will call `server_del` behind the scenes. On 05/16/2016 03:48 PM, Oleg Fayans wrote: Hi, The design is OK, the onlz thing that is missing is a HowToTest section in track tickets [1] and [2] about clean-dangling-ruvs and abort-clean-ruv respectively. It would really help if these tickets had detailed steps to test (in case of dangling RUV's - steps to generate them) -- Martin^3 Babinsky -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code
Re: [Freeipa-devel] [DESIGN-REVIEW] V4/Manage_replication_topology_4_4
Hi guys, Did I understand correctly that in 4.4 release the function of both 'ipa-csreplica-manage del' and 'ipa-replica-manage del' will be transfered to the API calls executed during replica uninstallation with 'ipa-server-install --uninstall'? Which means that 'ipa-replica-manage del' will be deprecated? On 05/16/2016 03:48 PM, Oleg Fayans wrote: > Hi, > > The design is OK, the onlz thing that is missing is a HowToTest section > in track tickets [1] and [2] about clean-dangling-ruvs and > abort-clean-ruv respectively. It would really help if these tickets had > detailed steps to test (in case of dangling RUV's - steps to generate them) > -- Oleg Fayans Quality Engineer FreeIPA team RedHat. -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code
Re: [Freeipa-devel] [DESIGN-REVIEW] V4/Manage_replication_topology_4_4
Sorry, I forgot to list the tickets themselves On 05/16/2016 03:48 PM, Oleg Fayans wrote: > Hi, > > The design is OK, the onlz thing that is missing is a HowToTest section > in track tickets [1] and [2] about clean-dangling-ruvs and > abort-clean-ruv respectively. It would really help if these tickets had > detailed steps to test (in case of dangling RUV's - steps to generate them) > [1] https://fedorahosted.org/freeipa/ticket/5411 [2] https://fedorahosted.org/freeipa/ticket/5396 -- Oleg Fayans Quality Engineer FreeIPA team RedHat. -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code
[Freeipa-devel] [DESIGN-REVIEW] V4/Manage_replication_topology_4_4
Hi, The design is OK, the onlz thing that is missing is a HowToTest section in track tickets [1] and [2] about clean-dangling-ruvs and abort-clean-ruv respectively. It would really help if these tickets had detailed steps to test (in case of dangling RUV's - steps to generate them) -- Oleg Fayans Quality Engineer FreeIPA team RedHat. -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code
Re: [Freeipa-devel] [DESIGN REVIEW] V4/Manage_replication_topology_4_4
On 04/25/2016 01:27 PM, Martin Babinsky wrote: > Hi list, > > this is my review of the > http://www.freeipa.org/page/V4/Manage_replication_topology_4_4 design > page authored by Petr Vobornik. > > Overall the page needs some more polishing, there is a number of TODOs > and typos which need to be expanded/fixed. Todos were replaced. > > Here are some more specific points: > > 1.) there is a lengthy discussion about the interface and behavior of > server-del API command on this list.[1] The server_del description > should be updated to reflect the conclusion reached by this discussion. done > > 2.) we should also put more thought into actions which should be > performed by `server-del` regarding cleanup of leftover references to > replica's ldap/ and HTTP/ principals and DNS records. > > The thing is that the original code assumes that the cleanup is > performed under admin/Directory Manager credentials, while we should > assume that most of these tasks should be doable by host itself (see > server uninstall use-case). I shall make some more research into this. add a mention about ACIs and why it is need to contact different master from the installer. > > 3.) I would rewrite Topology graph section in Feature management because > the current text is not very readable. Also is there a plan to show > roles of an IPA master when clicking on it on the graph or is it a > stretch for 4.4? The unreadable part is reasoning. Proposal is in summary. Added a note that roles wont' be shown in topology graph in 4.4. > > [1] https://www.redhat.com/archives/freeipa-devel/2016-April/msg00101.html > -- Petr Vobornik -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code
[Freeipa-devel] [DESIGN REVIEW] V4/Manage_replication_topology_4_4
Hi list, this is my review of the http://www.freeipa.org/page/V4/Manage_replication_topology_4_4 design page authored by Petr Vobornik. Overall the page needs some more polishing, there is a number of TODOs and typos which need to be expanded/fixed. Here are some more specific points: 1.) there is a lengthy discussion about the interface and behavior of server-del API command on this list.[1] The server_del description should be updated to reflect the conclusion reached by this discussion. 2.) we should also put more thought into actions which should be performed by `server-del` regarding cleanup of leftover references to replica's ldap/ and HTTP/ principals and DNS records. The thing is that the original code assumes that the cleanup is performed under admin/Directory Manager credentials, while we should assume that most of these tasks should be doable by host itself (see server uninstall use-case). I shall make some more research into this. 3.) I would rewrite Topology graph section in Feature management because the current text is not very readable. Also is there a plan to show roles of an IPA master when clicking on it on the graph or is it a stretch for 4.4? [1] https://www.redhat.com/archives/freeipa-devel/2016-April/msg00101.html -- Martin^3 Babinsky -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code
