Re: [Freeipa-devel] [PATH 0053] Inconsistency between ipasearchrecordslimit and --sizelimit

2015-09-21 Thread Jan Cholasta 

On 21.9.2015 15:25, Gabe Alford wrote:

Sorry. I had fixed another mistake and had not read your comment
carefully. Updated patch attached.

Gabe

On Wed, Sep 16, 2015 at 12:23 AM, Jan Cholasta mailto:jchol...@redhat.com>> wrote:

On 15.9.2015 14:42, Gabe Alford wrote:

Yup. You are right. It was a mistake. Updated patch attached.

On Tue, Sep 15, 2015 at 12:46 AM, Jan Cholasta
mailto:jchol...@redhat.com>
>> wrote:

 On 14.9.2015 14:58, Gabe Alford wrote:

 Sounds good to me. Updated patch attached.

 On Mon, Sep 14, 2015 at 1:34 AM, Petr Spacek
mailto:pspa...@redhat.com>
 >
 
 IMO it does, because saying just "-1 is default"
is not
 entirely correct and
  > "0 is default" would be confusing, as you
pointed out.
 You might say "0 or -1
  > is unlimited" if you think it's clearer.

  my +1 to "0 or -1 is unlimited" variant

  Petr^2 Spacek


   > On 10.9.2015 18:39, Gabe Alford wrote:
   >> Oops.. replied without the list.
   >>
   >> Reason I said -1 is because users might be
confused if they
  enter `ipa
   >> config-mod --searchtimelimit=0`, and both `ipa
 user-show` and
  the webui
   >> show -1 instead of 0. I wonder if -1 makes
more sense
 in that
  regard?
   >> Thoughts? Does "<= 0 is unlimited" make more
sense?
   >>
   >> Thanks,
   >>
   >> Gabe


 The doc for ipasearchtimelimit and ipasearchrecordslimit
says "-1 is
 unlimited", but both 0 and -1 is unlimited for them, and
the doc for
 timelimit and sizelimit says "-1 or 0 is unlimited", but
only 0 is
 unlimited for them. Looks like a mistake.

 --
 Jan Cholasta



This hasn't changed since the previous patch and is still wrong, as
-1 is not supported here:

  Int('timelimit?',
  label=_('Time Limit'),
-doc=_('Time limit of search in seconds'),
+doc=_('Time limit of search in seconds (-1 or 0 is
unlimited)'),
  flags=['no_display'],
  minvalue=0,
  autofill=False,
  ),
  Int('sizelimit?',
  label=_('Size Limit'),
-doc=_('Maximum number of entries returned'),
+doc=_('Maximum number of entries returned (-1 or 0 is
unlimited)'),
  flags=['no_display'],
  minvalue=0,
  autofill=False,

--
Jan Cholasta


Thank you. ACK.

Pushed to:
master: 65e958fda4aee2e08cd1f7043369710b839476c3
ipa-4-2: 28d6ae0ac0e3d30f6672bd9a9a5f5827f2a768a3

--
Jan Cholasta

--
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

Re: [Freeipa-devel] [PATH 0053] Inconsistency between ipasearchrecordslimit and --sizelimit

2015-09-21 Thread Gabe Alford 
Sorry. I had fixed another mistake and had not read your comment carefully.
Updated patch attached.

Gabe

On Wed, Sep 16, 2015 at 12:23 AM, Jan Cholasta  wrote:

> On 15.9.2015 14:42, Gabe Alford wrote:
>
>> Yup. You are right. It was a mistake. Updated patch attached.
>>
>> On Tue, Sep 15, 2015 at 12:46 AM, Jan Cholasta > > wrote:
>>
>> On 14.9.2015 14:58, Gabe Alford wrote:
>>
>> Sounds good to me. Updated patch attached.
>>
>> On Mon, Sep 14, 2015 at 1:34 AM, Petr Spacek > 
>> >> wrote:
>>
>>  On 14.9.2015 07:23, Jan Cholasta wrote:
>>  > IMO it does, because saying just "-1 is default" is not
>> entirely correct and
>>  > "0 is default" would be confusing, as you pointed out.
>> You might say "0 or -1
>>  > is unlimited" if you think it's clearer.
>>
>>  my +1 to "0 or -1 is unlimited" variant
>>
>>  Petr^2 Spacek
>>
>>
>>   > On 10.9.2015 18:39, Gabe Alford wrote:
>>   >> Oops.. replied without the list.
>>   >>
>>   >> Reason I said -1 is because users might be confused if
>> they
>>  enter `ipa
>>   >> config-mod --searchtimelimit=0`, and both `ipa
>> user-show` and
>>  the webui
>>   >> show -1 instead of 0. I wonder if -1 makes more sense
>> in that
>>  regard?
>>   >> Thoughts? Does "<= 0 is unlimited" make more sense?
>>   >>
>>   >> Thanks,
>>   >>
>>   >> Gabe
>>
>>
>> The doc for ipasearchtimelimit and ipasearchrecordslimit says "-1 is
>> unlimited", but both 0 and -1 is unlimited for them, and the doc for
>> timelimit and sizelimit says "-1 or 0 is unlimited", but only 0 is
>> unlimited for them. Looks like a mistake.
>>
>> --
>> Jan Cholasta
>>
>>
>>
> This hasn't changed since the previous patch and is still wrong, as -1 is
> not supported here:
>
>  Int('timelimit?',
>  label=_('Time Limit'),
> -doc=_('Time limit of search in seconds'),
> +doc=_('Time limit of search in seconds (-1 or 0 is
> unlimited)'),
>  flags=['no_display'],
>  minvalue=0,
>  autofill=False,
>  ),
>  Int('sizelimit?',
>  label=_('Size Limit'),
> -doc=_('Maximum number of entries returned'),
> +doc=_('Maximum number of entries returned (-1 or 0 is
> unlimited)'),
>  flags=['no_display'],
>  minvalue=0,
>  autofill=False,
>
> --
> Jan Cholasta
>
From 1caa56120c9f3cc09b236bef2e0aad218b94365e Mon Sep 17 00:00:00 2001
From: Gabe 
Date: Mon, 21 Sep 2015 06:55:17 -0600
Subject: [PATCH] Standardize minvalue for ipasearchrecordlimit and
 ipasesarchsizelimit for unlimited minvalue

https://fedorahosted.org/freeipa/ticket/4023
---
 install/ui/test/data/ipa_init_commands.json |  6 +++---
 install/ui/test/data/ipa_init_objects.json  |  6 +++---
 install/ui/test/data/json_metadata.json |  4 ++--
 ipalib/plugins/baseldap.py  |  4 ++--
 ipalib/plugins/config.py| 21 +
 ipaserver/plugins/ldap2.py  |  4 ++--
 6 files changed, 25 insertions(+), 20 deletions(-)

diff --git a/install/ui/test/data/ipa_init_commands.json b/install/ui/test/data/ipa_init_commands.json
index 743f508e2a733b766008bdd21838454ef7df8c21..c7f717c357624489d0b7f43fdd01b5bb8b1bcd86 100644
--- a/install/ui/test/data/ipa_init_commands.json
+++ b/install/ui/test/data/ipa_init_commands.json
@@ -2446,7 +2446,7 @@
 "attribute": true,
 "class": "Int",
 "deprecated_cli_aliases": [],
-"doc": "Maximum amount of time (seconds) for a search (> 0, or -1 for unlimited)",
+"doc": "Maximum amount of time (seconds) for a search (-1 or 0 is unlimited)",
 "flags": [
 "nonempty"
 ],
@@ -2460,7 +2460,7 @@
 "attribute": true,
 "class": "Int",
 "deprecated_cli_aliases": [],
-"doc": "Maximum number of records to search (-1 is unlimited)",
+"doc": "Maximum number of records to search (-1 or 0 is unlimited)",
 "flags": [
 "nonempty"
 ],
@@ -24018,4 +24018,4 @@
 "methods": {},
 "objects": {}
 }
-}
\ No newline at end of file
+}
diff --git a/install/ui/test/data/ipa_init_objects.json b/install/ui/test/data/ipa_init_objects.json
index c8c836926d94dd4c1903aa9a62fa91c11a238e75..ca98a1a22855bfcc306e1a3ed98e398f1b4505b1 1006

Re: [Freeipa-devel] [PATH 0053] Inconsistency between ipasearchrecordslimit and --sizelimit

2015-09-15 Thread Jan Cholasta 

On 15.9.2015 14:42, Gabe Alford wrote:

Yup. You are right. It was a mistake. Updated patch attached.

On Tue, Sep 15, 2015 at 12:46 AM, Jan Cholasta mailto:jchol...@redhat.com>> wrote:

On 14.9.2015 14:58, Gabe Alford wrote:

Sounds good to me. Updated patch attached.

On Mon, Sep 14, 2015 at 1:34 AM, Petr Spacek mailto:pspa...@redhat.com>
>> wrote:

 On 14.9.2015 07:23, Jan Cholasta wrote:
 > IMO it does, because saying just "-1 is default" is not
entirely correct and
 > "0 is default" would be confusing, as you pointed out.
You might say "0 or -1
 > is unlimited" if you think it's clearer.

 my +1 to "0 or -1 is unlimited" variant

 Petr^2 Spacek


  > On 10.9.2015 18:39, Gabe Alford wrote:
  >> Oops.. replied without the list.
  >>
  >> Reason I said -1 is because users might be confused if they
 enter `ipa
  >> config-mod --searchtimelimit=0`, and both `ipa
user-show` and
 the webui
  >> show -1 instead of 0. I wonder if -1 makes more sense
in that
 regard?
  >> Thoughts? Does "<= 0 is unlimited" make more sense?
  >>
  >> Thanks,
  >>
  >> Gabe


The doc for ipasearchtimelimit and ipasearchrecordslimit says "-1 is
unlimited", but both 0 and -1 is unlimited for them, and the doc for
timelimit and sizelimit says "-1 or 0 is unlimited", but only 0 is
unlimited for them. Looks like a mistake.

--
Jan Cholasta




This hasn't changed since the previous patch and is still wrong, as -1 
is not supported here:


 Int('timelimit?',
 label=_('Time Limit'),
-doc=_('Time limit of search in seconds'),
+doc=_('Time limit of search in seconds (-1 or 0 is 
unlimited)'),

 flags=['no_display'],
 minvalue=0,
 autofill=False,
 ),
 Int('sizelimit?',
 label=_('Size Limit'),
-doc=_('Maximum number of entries returned'),
+doc=_('Maximum number of entries returned (-1 or 0 is 
unlimited)'),

 flags=['no_display'],
 minvalue=0,
 autofill=False,

--
Jan Cholasta

--
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

Re: [Freeipa-devel] [PATH 0053] Inconsistency between ipasearchrecordslimit and --sizelimit

2015-09-15 Thread Gabe Alford 
Yup. You are right. It was a mistake. Updated patch attached.

On Tue, Sep 15, 2015 at 12:46 AM, Jan Cholasta  wrote:

> On 14.9.2015 14:58, Gabe Alford wrote:
>
>> Sounds good to me. Updated patch attached.
>>
>> On Mon, Sep 14, 2015 at 1:34 AM, Petr Spacek > > wrote:
>>
>> On 14.9.2015 07:23, Jan Cholasta wrote:
>> > IMO it does, because saying just "-1 is default" is not entirely
>> correct and
>> > "0 is default" would be confusing, as you pointed out. You might
>> say "0 or -1
>> > is unlimited" if you think it's clearer.
>>
>> my +1 to "0 or -1 is unlimited" variant
>>
>> Petr^2 Spacek
>>
>>
>>  > On 10.9.2015 18:39, Gabe Alford wrote:
>>  >> Oops.. replied without the list.
>>  >>
>>  >> Reason I said -1 is because users might be confused if they
>> enter `ipa
>>  >> config-mod --searchtimelimit=0`, and both `ipa user-show` and
>> the webui
>>  >> show -1 instead of 0. I wonder if -1 makes more sense in that
>> regard?
>>  >> Thoughts? Does "<= 0 is unlimited" make more sense?
>>  >>
>>  >> Thanks,
>>  >>
>>  >> Gabe
>>
>>
> The doc for ipasearchtimelimit and ipasearchrecordslimit says "-1 is
> unlimited", but both 0 and -1 is unlimited for them, and the doc for
> timelimit and sizelimit says "-1 or 0 is unlimited", but only 0 is
> unlimited for them. Looks like a mistake.
>
> --
> Jan Cholasta
>
From 0cdf762bbb6cd3a6dcbc3885104e8b4efbd1bcd7 Mon Sep 17 00:00:00 2001
From: Gabe 
Date: Tue, 15 Sep 2015 06:38:13 -0600
Subject: [PATCH] Standardize minvalue for ipasearchrecordlimit and
 ipasesarchsizelimit for unlimited minvalue

https://fedorahosted.org/freeipa/ticket/4023
---
 install/ui/test/data/ipa_init_commands.json |  6 +++---
 install/ui/test/data/ipa_init_objects.json  |  6 +++---
 install/ui/test/data/json_metadata.json |  4 ++--
 ipalib/plugins/baseldap.py  |  4 ++--
 ipalib/plugins/config.py| 21 +
 ipaserver/plugins/ldap2.py  |  4 ++--
 6 files changed, 25 insertions(+), 20 deletions(-)

diff --git a/install/ui/test/data/ipa_init_commands.json b/install/ui/test/data/ipa_init_commands.json
index 743f508e2a733b766008bdd21838454ef7df8c21..c7f717c357624489d0b7f43fdd01b5bb8b1bcd86 100644
--- a/install/ui/test/data/ipa_init_commands.json
+++ b/install/ui/test/data/ipa_init_commands.json
@@ -2446,7 +2446,7 @@
 "attribute": true,
 "class": "Int",
 "deprecated_cli_aliases": [],
-"doc": "Maximum amount of time (seconds) for a search (> 0, or -1 for unlimited)",
+"doc": "Maximum amount of time (seconds) for a search (-1 or 0 is unlimited)",
 "flags": [
 "nonempty"
 ],
@@ -2460,7 +2460,7 @@
 "attribute": true,
 "class": "Int",
 "deprecated_cli_aliases": [],
-"doc": "Maximum number of records to search (-1 is unlimited)",
+"doc": "Maximum number of records to search (-1 or 0 is unlimited)",
 "flags": [
 "nonempty"
 ],
@@ -24018,4 +24018,4 @@
 "methods": {},
 "objects": {}
 }
-}
\ No newline at end of file
+}
diff --git a/install/ui/test/data/ipa_init_objects.json b/install/ui/test/data/ipa_init_objects.json
index c8c836926d94dd4c1903aa9a62fa91c11a238e75..ca98a1a22855bfcc306e1a3ed98e398f1b4505b1 100644
--- a/install/ui/test/data/ipa_init_objects.json
+++ b/install/ui/test/data/ipa_init_objects.json
@@ -498,7 +498,7 @@
 {
 "class": "Int",
 "deprecated_cli_aliases": [],
-"doc": "Maximum amount of time (seconds) for a search (> 0, or -1 for unlimited)",
+"doc": "Maximum amount of time (seconds) for a search (-1 or 0 is unlimited)",
 "flags": [],
 "label": "Search time limit",
 "maxvalue": 2147483647,
@@ -510,7 +510,7 @@
 {
 "class": "Int",
 "deprecated_cli_aliases": [],
-"doc": "Maximum number of records to search (-1 is unlimited)",
+"doc": "Maximum number of records to search (-1 or 0 is unlimited)",
 "flags": [],
 "label": "Search size limit",
 "maxvalue": 2147483647,
@@ -9158,4 +9158,4 @@
 }
 }
 }
-}
\ No newline at end of file
+}
diff --git a/install/ui/test/data/json_metadata.json b/install/ui/test/data/json_metadata.json
index a9e66230f94875f7da7efa73141e244b8201a5cc..5365336febeffc78e8878745a20e5e81f240b38a 100644
--- a/insta

Re: [Freeipa-devel] [PATH 0053] Inconsistency between ipasearchrecordslimit and --sizelimit

2015-09-14 Thread Jan Cholasta 

On 14.9.2015 14:58, Gabe Alford wrote:

Sounds good to me. Updated patch attached.

On Mon, Sep 14, 2015 at 1:34 AM, Petr Spacek mailto:pspa...@redhat.com>> wrote:

On 14.9.2015 07:23, Jan Cholasta wrote:
> IMO it does, because saying just "-1 is default" is not entirely correct 
and
> "0 is default" would be confusing, as you pointed out. You might say "0 
or -1
> is unlimited" if you think it's clearer.

my +1 to "0 or -1 is unlimited" variant

Petr^2 Spacek


 > On 10.9.2015 18:39, Gabe Alford wrote:
 >> Oops.. replied without the list.
 >>
 >> Reason I said -1 is because users might be confused if they
enter `ipa
 >> config-mod --searchtimelimit=0`, and both `ipa user-show` and
the webui
 >> show -1 instead of 0. I wonder if -1 makes more sense in that
regard?
 >> Thoughts? Does "<= 0 is unlimited" make more sense?
 >>
 >> Thanks,
 >>
 >> Gabe



The doc for ipasearchtimelimit and ipasearchrecordslimit says "-1 is 
unlimited", but both 0 and -1 is unlimited for them, and the doc for 
timelimit and sizelimit says "-1 or 0 is unlimited", but only 0 is 
unlimited for them. Looks like a mistake.


--
Jan Cholasta

--
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

Re: [Freeipa-devel] [PATH 0053] Inconsistency between ipasearchrecordslimit and --sizelimit

2015-09-14 Thread Gabe Alford 
Sounds good to me. Updated patch attached.

On Mon, Sep 14, 2015 at 1:34 AM, Petr Spacek  wrote:

> On 14.9.2015 07:23, Jan Cholasta wrote:
> > IMO it does, because saying just "-1 is default" is not entirely correct
> and
> > "0 is default" would be confusing, as you pointed out. You might say "0
> or -1
> > is unlimited" if you think it's clearer.
>
> my +1 to "0 or -1 is unlimited" variant
>
> Petr^2 Spacek
>
>
> > On 10.9.2015 18:39, Gabe Alford wrote:
> >> Oops.. replied without the list.
> >>
> >> Reason I said -1 is because users might be confused if they enter `ipa
> >> config-mod --searchtimelimit=0`, and both `ipa user-show` and the webui
> >> show -1 instead of 0. I wonder if -1 makes more sense in that regard?
> >> Thoughts? Does "<= 0 is unlimited" make more sense?
> >>
> >> Thanks,
> >>
> >> Gabe
>
> --
> Manage your subscription for the Freeipa-devel mailing list:
> https://www.redhat.com/mailman/listinfo/freeipa-devel
> Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code
>
From 99070f93a51c7e03fa9c98b3548420fc589eddc1 Mon Sep 17 00:00:00 2001
From: Gabe 
Date: Mon, 14 Sep 2015 06:56:00 -0600
Subject: [PATCH] Standardize minvalue for ipasearchrecordlimit and
 ipasesarchsizelimit for unlimited minvalue

https://fedorahosted.org/freeipa/ticket/4023
---
 install/ui/test/data/ipa_init_commands.json |  6 +++---
 install/ui/test/data/ipa_init_objects.json  |  6 +++---
 install/ui/test/data/json_metadata.json |  4 ++--
 ipalib/plugins/baseldap.py  |  4 ++--
 ipalib/plugins/config.py| 19 ---
 ipaserver/plugins/ldap2.py  |  4 ++--
 6 files changed, 24 insertions(+), 19 deletions(-)

diff --git a/install/ui/test/data/ipa_init_commands.json b/install/ui/test/data/ipa_init_commands.json
index 743f508e2a733b766008bdd21838454ef7df8c21..c7f717c357624489d0b7f43fdd01b5bb8b1bcd86 100644
--- a/install/ui/test/data/ipa_init_commands.json
+++ b/install/ui/test/data/ipa_init_commands.json
@@ -2446,7 +2446,7 @@
 "attribute": true,
 "class": "Int",
 "deprecated_cli_aliases": [],
-"doc": "Maximum amount of time (seconds) for a search (> 0, or -1 for unlimited)",
+"doc": "Maximum amount of time (seconds) for a search (-1 or 0 is unlimited)",
 "flags": [
 "nonempty"
 ],
@@ -2460,7 +2460,7 @@
 "attribute": true,
 "class": "Int",
 "deprecated_cli_aliases": [],
-"doc": "Maximum number of records to search (-1 is unlimited)",
+"doc": "Maximum number of records to search (-1 or 0 is unlimited)",
 "flags": [
 "nonempty"
 ],
@@ -24018,4 +24018,4 @@
 "methods": {},
 "objects": {}
 }
-}
\ No newline at end of file
+}
diff --git a/install/ui/test/data/ipa_init_objects.json b/install/ui/test/data/ipa_init_objects.json
index c8c836926d94dd4c1903aa9a62fa91c11a238e75..ca98a1a22855bfcc306e1a3ed98e398f1b4505b1 100644
--- a/install/ui/test/data/ipa_init_objects.json
+++ b/install/ui/test/data/ipa_init_objects.json
@@ -498,7 +498,7 @@
 {
 "class": "Int",
 "deprecated_cli_aliases": [],
-"doc": "Maximum amount of time (seconds) for a search (> 0, or -1 for unlimited)",
+"doc": "Maximum amount of time (seconds) for a search (-1 or 0 is unlimited)",
 "flags": [],
 "label": "Search time limit",
 "maxvalue": 2147483647,
@@ -510,7 +510,7 @@
 {
 "class": "Int",
 "deprecated_cli_aliases": [],
-"doc": "Maximum number of records to search (-1 is unlimited)",
+"doc": "Maximum number of records to search (-1 or 0 is unlimited)",
 "flags": [],
 "label": "Search size limit",
 "maxvalue": 2147483647,
@@ -9158,4 +9158,4 @@
 }
 }
 }
-}
\ No newline at end of file
+}
diff --git a/install/ui/test/data/json_metadata.json b/install/ui/test/data/json_metadata.json
index a9e66230f94875f7da7efa73141e244b8201a5cc..5365336febeffc78e8878745a20e5e81f240b38a 100644
--- a/install/ui/test/data/json_metadata.json
+++ b/install/ui/test/data/json_metadata.json
@@ -2596,7 +2596,7 @@
 "cli_name": "searchtimelimit",
 "cli_short_name": null,
 "default": null,
-"doc": "Max. amount of time (sec.) for a search (> 0, or -1 for unlimited)",
+"doc": "Max. amount of time (sec.) for

Re: [Freeipa-devel] [PATH 0053] Inconsistency between ipasearchrecordslimit and --sizelimit

2015-09-14 Thread Petr Spacek 
On 14.9.2015 07:23, Jan Cholasta wrote:
> IMO it does, because saying just "-1 is default" is not entirely correct and
> "0 is default" would be confusing, as you pointed out. You might say "0 or -1
> is unlimited" if you think it's clearer.

my +1 to "0 or -1 is unlimited" variant

Petr^2 Spacek


> On 10.9.2015 18:39, Gabe Alford wrote:
>> Oops.. replied without the list.
>>
>> Reason I said -1 is because users might be confused if they enter `ipa
>> config-mod --searchtimelimit=0`, and both `ipa user-show` and the webui
>> show -1 instead of 0. I wonder if -1 makes more sense in that regard?
>> Thoughts? Does "<= 0 is unlimited" make more sense?
>>
>> Thanks,
>>
>> Gabe

-- 
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

Re: [Freeipa-devel] [PATH 0053] Inconsistency between ipasearchrecordslimit and --sizelimit

2015-09-13 Thread Jan Cholasta 
IMO it does, because saying just "-1 is default" is not entirely correct 
and "0 is default" would be confusing, as you pointed out. You might say 
"0 or -1 is unlimited" if you think it's clearer.


On 10.9.2015 18:39, Gabe Alford wrote:

Oops.. replied without the list.

Reason I said -1 is because users might be confused if they enter `ipa
config-mod --searchtimelimit=0`, and both `ipa user-show` and the webui
show -1 instead of 0. I wonder if -1 makes more sense in that regard?
Thoughts? Does "<= 0 is unlimited" make more sense?

Thanks,

Gabe


On Thu, Sep 10, 2015 at 8:15 AM, Jan Cholasta mailto:jchol...@redhat.com>> wrote:

I'm not sure about that, I think it should still say 0, because
that's what we want to use as the unlimited value. If you insist on
including -1 in the docs, maybe we can say "<= 0 is unlimited"?

On 10.9.2015 16:08, Gabe Alford wrote:

Makes sense. I also changed the doc string to reflect -1 as well.
Updated patch attached.

Thanks,

Gabe

On Thu, Sep 10, 2015 at 1:41 AM, Jan Cholasta
mailto:jchol...@redhat.com>
>> wrote:

 On 4.9.2015 14:43, Gabe Alford wrote:

 Bump for review.

 On Wed, Aug 12, 2015 at 9:32 AM, Gabe Alford
 mailto:redhatri...@gmail.com>
>
  
>

Re: [Freeipa-devel] [PATH 0053] Inconsistency between ipasearchrecordslimit and --sizelimit

2015-09-10 Thread Gabe Alford 
Oops.. replied without the list.

Reason I said -1 is because users might be confused if they enter `ipa
config-mod --searchtimelimit=0`, and both `ipa user-show` and the webui
show -1 instead of 0. I wonder if -1 makes more sense in that regard?
Thoughts? Does "<= 0 is unlimited" make more sense?

Thanks,

Gabe


On Thu, Sep 10, 2015 at 8:15 AM, Jan Cholasta  wrote:

> I'm not sure about that, I think it should still say 0, because that's
> what we want to use as the unlimited value. If you insist on including -1
> in the docs, maybe we can say "<= 0 is unlimited"?
>
> On 10.9.2015 16:08, Gabe Alford wrote:
>
>> Makes sense. I also changed the doc string to reflect -1 as well.
>> Updated patch attached.
>>
>> Thanks,
>>
>> Gabe
>>
>> On Thu, Sep 10, 2015 at 1:41 AM, Jan Cholasta > > wrote:
>>
>> On 4.9.2015 14:43, Gabe Alford wrote:
>>
>> Bump for review.
>>
>> On Wed, Aug 12, 2015 at 9:32 AM, Gabe Alford
>> mailto:redhatri...@gmail.com>
>> >>
>> wrote:
>>
>>  On Tue, Aug 11, 2015 at 1:34 AM, Jan Cholasta
>> mailto:jchol...@redhat.com>
>>  >>
>>
>> wrote:
>>
>>  On 6.8.2015 21:43, Gabe Alford wrote:
>>
>>  Hello,
>>
>>  Updated patch attached.
>>
>>  - Time limit is -1 for unlimited. I found this
>>
>> https://www.redhat.com/archives/freeipa-devel/2011-January/msg00330.html
>>  in reference to keeping the time limit as -1 for
>> unlimited.
>>
>>
>>  This patch does two conflicting things: it coerces time
>> limit of
>>  0 to -1 and at the same time prohibits the user to use
>> 0 for
>>  time limit. We should do just one of these and IMHO it
>> should be
>>  the coercion of 0 to -1.
>>
>>  Sure enough, testing time limit at 0 did not work for
>>  unlimited as well
>>  as appeared to have negative effects on IPA.
>>
>>
>>  This is because the time limit read from ipa config is
>> not
>>  converted to int in ldap2.find_entries(), so the
>> coercion does
>>  not work. Fix this and 0 will work just fine.
>>
>>  Also, I believe that
>>
>> http://www.python-ldap.org/doc/html/ldap.html#ldap.LDAPObject.search_ext_s
>>  specifies unlimited for time limit as -1. (Please
>> correct me
>>  if I am wrong.)
>>
>>
>>  python-ldap is layers below our API and should not
>> determine
>>  what we use for unlimited time limit. I would prefer if
>> we were
>>  self-consistent and use 0 for both time limit and size
>> limit.
>>
>>
>>  A misunderstanding on my part as I thought it was higher up
>> in the
>>  API for some reason. Updated patch attached.
>>
>>
>> Thanks, this is better, but it turns out I was wrong about coercing
>> -1 to 0 in config-mod: in a topology with different versions of IPA
>> servers, setting the limits in LDAP to 0 on a newer server with your
>> patch will break older servers without your patch:
>>
>>  [user@old]$ ipa user-find
>>  --
>>  1 user matched
>>  --
>>User login: admin
>>Last name: Administrator
>>Home directory: /home/admin
>>Login shell: /bin/bash
>>UID: 136480
>>GID: 136480
>>Account disabled: False
>>Password: True
>>Kerberos keys available: True
>>  
>>  Number of entries returned 1
>>  
>>
>>  [user@new]$ ipa config-mod --searchtimelimit=0
>> --searchrecordslimit=0
>>  ...
>>
>>  [user@old]$ ipa user-find
>>  ---
>>  0 users matched
>>  ---
>>  
>>  Number of entries returned 0
>>  
>>
>> To fix this, we actually need to do the opposite and store -1 in
>> LDAP when 0 is specified in config-mod options.
>>
>> Honza
>>
>> --
>> Jan Cholasta
>>
>>
>>
>
> --
> Jan Cholasta
>
-- 
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

Re: [Freeipa-devel] [PATH 0053] Inconsistency between ipasearchrecordslimit and --sizelimit

2015-09-10 Thread Jan Cholasta 
I'm not sure about that, I think it should still say 0, because that's 
what we want to use as the unlimited value. If you insist on including 
-1 in the docs, maybe we can say "<= 0 is unlimited"?


On 10.9.2015 16:08, Gabe Alford wrote:

Makes sense. I also changed the doc string to reflect -1 as well.
Updated patch attached.

Thanks,

Gabe

On Thu, Sep 10, 2015 at 1:41 AM, Jan Cholasta mailto:jchol...@redhat.com>> wrote:

On 4.9.2015 14:43, Gabe Alford wrote:

Bump for review.

On Wed, Aug 12, 2015 at 9:32 AM, Gabe Alford
mailto:redhatri...@gmail.com>
>>
wrote:

 On Tue, Aug 11, 2015 at 1:34 AM, Jan Cholasta
mailto:jchol...@redhat.com>
 >>
wrote:

 On 6.8.2015 21:43, Gabe Alford wrote:

 Hello,

 Updated patch attached.

 - Time limit is -1 for unlimited. I found this
https://www.redhat.com/archives/freeipa-devel/2011-January/msg00330.html
 in reference to keeping the time limit as -1 for
unlimited.


 This patch does two conflicting things: it coerces time
limit of
 0 to -1 and at the same time prohibits the user to use
0 for
 time limit. We should do just one of these and IMHO it
should be
 the coercion of 0 to -1.

 Sure enough, testing time limit at 0 did not work for
 unlimited as well
 as appeared to have negative effects on IPA.


 This is because the time limit read from ipa config is not
 converted to int in ldap2.find_entries(), so the
coercion does
 not work. Fix this and 0 will work just fine.

 Also, I believe that

http://www.python-ldap.org/doc/html/ldap.html#ldap.LDAPObject.search_ext_s
 specifies unlimited for time limit as -1. (Please
correct me
 if I am wrong.)


 python-ldap is layers below our API and should not
determine
 what we use for unlimited time limit. I would prefer if
we were
 self-consistent and use 0 for both time limit and size
limit.


 A misunderstanding on my part as I thought it was higher up
in the
 API for some reason. Updated patch attached.


Thanks, this is better, but it turns out I was wrong about coercing
-1 to 0 in config-mod: in a topology with different versions of IPA
servers, setting the limits in LDAP to 0 on a newer server with your
patch will break older servers without your patch:

 [user@old]$ ipa user-find
 --
 1 user matched
 --
   User login: admin
   Last name: Administrator
   Home directory: /home/admin
   Login shell: /bin/bash
   UID: 136480
   GID: 136480
   Account disabled: False
   Password: True
   Kerberos keys available: True
 
 Number of entries returned 1
 

 [user@new]$ ipa config-mod --searchtimelimit=0
--searchrecordslimit=0
 ...

 [user@old]$ ipa user-find
 ---
 0 users matched
 ---
 
 Number of entries returned 0
 

To fix this, we actually need to do the opposite and store -1 in
LDAP when 0 is specified in config-mod options.

Honza

--
Jan Cholasta





--
Jan Cholasta

--
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

Re: [Freeipa-devel] [PATH 0053] Inconsistency between ipasearchrecordslimit and --sizelimit

2015-09-10 Thread Gabe Alford 
Makes sense. I also changed the doc string to reflect -1 as well. Updated
patch attached.

Thanks,

Gabe

On Thu, Sep 10, 2015 at 1:41 AM, Jan Cholasta  wrote:

> On 4.9.2015 14:43, Gabe Alford wrote:
>
>> Bump for review.
>>
>> On Wed, Aug 12, 2015 at 9:32 AM, Gabe Alford > > wrote:
>>
>> On Tue, Aug 11, 2015 at 1:34 AM, Jan Cholasta > > wrote:
>>
>> On 6.8.2015 21:43, Gabe Alford wrote:
>>
>> Hello,
>>
>> Updated patch attached.
>>
>> - Time limit is -1 for unlimited. I found this
>>
>> https://www.redhat.com/archives/freeipa-devel/2011-January/msg00330.html
>> in reference to keeping the time limit as -1 for unlimited.
>>
>>
>> This patch does two conflicting things: it coerces time limit of
>> 0 to -1 and at the same time prohibits the user to use 0 for
>> time limit. We should do just one of these and IMHO it should be
>> the coercion of 0 to -1.
>>
>> Sure enough, testing time limit at 0 did not work for
>> unlimited as well
>> as appeared to have negative effects on IPA.
>>
>>
>> This is because the time limit read from ipa config is not
>> converted to int in ldap2.find_entries(), so the coercion does
>> not work. Fix this and 0 will work just fine.
>>
>> Also, I believe that
>>
>> http://www.python-ldap.org/doc/html/ldap.html#ldap.LDAPObject.search_ext_s
>> specifies unlimited for time limit as -1. (Please correct me
>> if I am wrong.)
>>
>>
>> python-ldap is layers below our API and should not determine
>> what we use for unlimited time limit. I would prefer if we were
>> self-consistent and use 0 for both time limit and size limit.
>>
>>
>> A misunderstanding on my part as I thought it was higher up in the
>> API for some reason. Updated patch attached.
>>
>
> Thanks, this is better, but it turns out I was wrong about coercing -1 to
> 0 in config-mod: in a topology with different versions of IPA servers,
> setting the limits in LDAP to 0 on a newer server with your patch will
> break older servers without your patch:
>
> [user@old]$ ipa user-find
> --
> 1 user matched
> --
>   User login: admin
>   Last name: Administrator
>   Home directory: /home/admin
>   Login shell: /bin/bash
>   UID: 136480
>   GID: 136480
>   Account disabled: False
>   Password: True
>   Kerberos keys available: True
> 
> Number of entries returned 1
> 
>
> [user@new]$ ipa config-mod --searchtimelimit=0 --searchrecordslimit=0
> ...
>
> [user@old]$ ipa user-find
> ---
> 0 users matched
> ---
> 
> Number of entries returned 0
> 
>
> To fix this, we actually need to do the opposite and store -1 in LDAP when
> 0 is specified in config-mod options.
>
> Honza
>
> --
> Jan Cholasta
>
From 715dfae42bbe9e1ca93dee902b100672d6dafc39 Mon Sep 17 00:00:00 2001
From: Gabe 
Date: Thu, 10 Sep 2015 07:51:58 -0600
Subject: [PATCH] Standardize minvalue for ipasearchrecordlimit and
 ipasesarchsizelimit for unlimited minvalue

https://fedorahosted.org/freeipa/ticket/4023
---
 install/ui/test/data/ipa_init_commands.json |  4 ++--
 install/ui/test/data/ipa_init_objects.json  |  4 ++--
 install/ui/test/data/json_metadata.json |  2 +-
 ipalib/plugins/baseldap.py  |  4 ++--
 ipalib/plugins/config.py| 19 ---
 ipaserver/plugins/ldap2.py  |  4 ++--
 6 files changed, 21 insertions(+), 16 deletions(-)

diff --git a/install/ui/test/data/ipa_init_commands.json b/install/ui/test/data/ipa_init_commands.json
index 743f508e2a733b766008bdd21838454ef7df8c21..13e3cfe87549b0b58cb86db1e34a8f6e2cfbb7e8 100644
--- a/install/ui/test/data/ipa_init_commands.json
+++ b/install/ui/test/data/ipa_init_commands.json
@@ -2446,7 +2446,7 @@
 "attribute": true,
 "class": "Int",
 "deprecated_cli_aliases": [],
-"doc": "Maximum amount of time (seconds) for a search (> 0, or -1 for unlimited)",
+"doc": "Maximum amount of time (seconds) for a search (-1 is unlimited)",
 "flags": [
 "nonempty"
 ],
@@ -24018,4 +24018,4 @@
 "methods": {},
 "objects": {}
 }
-}
\ No newline at end of file
+}
diff --git a/install/ui/test/data/ipa_init_objects.json b/install/ui/test/data/ipa_init_objects.json
index c8c836926d94dd4c1903aa9a62fa91c11a238e75..e6b00f0335295d9c1ecfecf90bf470c63511 100644
--- a/install/ui/test/data/ipa_init_objects.json
+++ b/install/ui/test/data/ipa_i

Re: [Freeipa-devel] [PATH 0053] Inconsistency between ipasearchrecordslimit and --sizelimit

2015-09-10 Thread Jan Cholasta 

On 4.9.2015 14:43, Gabe Alford wrote:

Bump for review.

On Wed, Aug 12, 2015 at 9:32 AM, Gabe Alford mailto:redhatri...@gmail.com>> wrote:

On Tue, Aug 11, 2015 at 1:34 AM, Jan Cholasta mailto:jchol...@redhat.com>> wrote:

On 6.8.2015 21:43, Gabe Alford wrote:

Hello,

Updated patch attached.

- Time limit is -1 for unlimited. I found this

https://www.redhat.com/archives/freeipa-devel/2011-January/msg00330.html
in reference to keeping the time limit as -1 for unlimited.


This patch does two conflicting things: it coerces time limit of
0 to -1 and at the same time prohibits the user to use 0 for
time limit. We should do just one of these and IMHO it should be
the coercion of 0 to -1.

Sure enough, testing time limit at 0 did not work for
unlimited as well
as appeared to have negative effects on IPA.


This is because the time limit read from ipa config is not
converted to int in ldap2.find_entries(), so the coercion does
not work. Fix this and 0 will work just fine.

Also, I believe that

http://www.python-ldap.org/doc/html/ldap.html#ldap.LDAPObject.search_ext_s
specifies unlimited for time limit as -1. (Please correct me
if I am wrong.)


python-ldap is layers below our API and should not determine
what we use for unlimited time limit. I would prefer if we were
self-consistent and use 0 for both time limit and size limit.


A misunderstanding on my part as I thought it was higher up in the
API for some reason. Updated patch attached.


Thanks, this is better, but it turns out I was wrong about coercing -1 
to 0 in config-mod: in a topology with different versions of IPA 
servers, setting the limits in LDAP to 0 on a newer server with your 
patch will break older servers without your patch:


[user@old]$ ipa user-find
--
1 user matched
--
  User login: admin
  Last name: Administrator
  Home directory: /home/admin
  Login shell: /bin/bash
  UID: 136480
  GID: 136480
  Account disabled: False
  Password: True
  Kerberos keys available: True

Number of entries returned 1


[user@new]$ ipa config-mod --searchtimelimit=0 --searchrecordslimit=0
...

[user@old]$ ipa user-find
---
0 users matched
---

Number of entries returned 0


To fix this, we actually need to do the opposite and store -1 in LDAP 
when 0 is specified in config-mod options.


Honza

--
Jan Cholasta

--
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

Re: [Freeipa-devel] [PATH 0053] Inconsistency between ipasearchrecordslimit and --sizelimit

2015-09-04 Thread Gabe Alford 
Bump for review.

On Wed, Aug 12, 2015 at 9:32 AM, Gabe Alford  wrote:

> On Tue, Aug 11, 2015 at 1:34 AM, Jan Cholasta  wrote:
>
>> On 6.8.2015 21:43, Gabe Alford wrote:
>>
>>> Hello,
>>>
>>> Updated patch attached.
>>>
>>> - Time limit is -1 for unlimited. I found this
>>> https://www.redhat.com/archives/freeipa-devel/2011-January/msg00330.html
>>> in reference to keeping the time limit as -1 for unlimited.
>>>
>>
>> This patch does two conflicting things: it coerces time limit of 0 to -1
>> and at the same time prohibits the user to use 0 for time limit. We should
>> do just one of these and IMHO it should be the coercion of 0 to -1.
>>
>> Sure enough, testing time limit at 0 did not work for unlimited as well
>>> as appeared to have negative effects on IPA.
>>>
>>
>> This is because the time limit read from ipa config is not converted to
>> int in ldap2.find_entries(), so the coercion does not work. Fix this and 0
>> will work just fine.
>>
>> Also, I believe that
>>>
>>> http://www.python-ldap.org/doc/html/ldap.html#ldap.LDAPObject.search_ext_s
>>> specifies unlimited for time limit as -1. (Please correct me if I am
>>> wrong.)
>>>
>>
>> python-ldap is layers below our API and should not determine what we use
>> for unlimited time limit. I would prefer if we were self-consistent and use
>> 0 for both time limit and size limit.
>>
>
> A misunderstanding on my part as I thought it was higher up in the API for
> some reason. Updated patch attached.
>
> Thanks,
>
> Gabe
>
-- 
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

Re: [Freeipa-devel] [PATH 0053] Inconsistency between ipasearchrecordslimit and --sizelimit

2015-08-12 Thread Gabe Alford 
On Tue, Aug 11, 2015 at 1:34 AM, Jan Cholasta  wrote:

> On 6.8.2015 21:43, Gabe Alford wrote:
>
>> Hello,
>>
>> Updated patch attached.
>>
>> - Time limit is -1 for unlimited. I found this
>> https://www.redhat.com/archives/freeipa-devel/2011-January/msg00330.html
>> in reference to keeping the time limit as -1 for unlimited.
>>
>
> This patch does two conflicting things: it coerces time limit of 0 to -1
> and at the same time prohibits the user to use 0 for time limit. We should
> do just one of these and IMHO it should be the coercion of 0 to -1.
>
> Sure enough, testing time limit at 0 did not work for unlimited as well
>> as appeared to have negative effects on IPA.
>>
>
> This is because the time limit read from ipa config is not converted to
> int in ldap2.find_entries(), so the coercion does not work. Fix this and 0
> will work just fine.
>
> Also, I believe that
>> http://www.python-ldap.org/doc/html/ldap.html#ldap.LDAPObject.search_ext_s
>> specifies unlimited for time limit as -1. (Please correct me if I am
>> wrong.)
>>
>
> python-ldap is layers below our API and should not determine what we use
> for unlimited time limit. I would prefer if we were self-consistent and use
> 0 for both time limit and size limit.
>

A misunderstanding on my part as I thought it was higher up in the API for
some reason. Updated patch attached.

Thanks,

Gabe
From b1b173486e3ed4f6fd5bf05d93e52e2783ab1a1e Mon Sep 17 00:00:00 2001
From: Gabe 
Date: Wed, 12 Aug 2015 09:12:37 -0600
Subject: [PATCH] Standardize minvalue for ipasearchrecordlimit and
 ipasesarchsizelimit for unlimited minvalue

https://fedorahosted.org/freeipa/ticket/4023
---
 install/ui/test/data/ipa_init_commands.json |  6 +++---
 install/ui/test/data/ipa_init_objects.json  |  6 +++---
 install/ui/test/data/json_metadata.json |  4 ++--
 ipalib/plugins/baseldap.py  |  4 ++--
 ipalib/plugins/config.py| 21 +
 ipaserver/plugins/ldap2.py  |  4 ++--
 6 files changed, 25 insertions(+), 20 deletions(-)

diff --git a/install/ui/test/data/ipa_init_commands.json b/install/ui/test/data/ipa_init_commands.json
index 743f508e2a733b766008bdd21838454ef7df8c21..1e0a8088f2b769d382d9c8532d20ca2b356580de 100644
--- a/install/ui/test/data/ipa_init_commands.json
+++ b/install/ui/test/data/ipa_init_commands.json
@@ -2446,7 +2446,7 @@
 "attribute": true,
 "class": "Int",
 "deprecated_cli_aliases": [],
-"doc": "Maximum amount of time (seconds) for a search (> 0, or -1 for unlimited)",
+"doc": "Maximum amount of time (seconds) for a search (0 is unlimited)",
 "flags": [
 "nonempty"
 ],
@@ -2460,7 +2460,7 @@
 "attribute": true,
 "class": "Int",
 "deprecated_cli_aliases": [],
-"doc": "Maximum number of records to search (-1 is unlimited)",
+"doc": "Maximum number of records to search (0 is unlimited)",
 "flags": [
 "nonempty"
 ],
@@ -24018,4 +24018,4 @@
 "methods": {},
 "objects": {}
 }
-}
\ No newline at end of file
+}
diff --git a/install/ui/test/data/ipa_init_objects.json b/install/ui/test/data/ipa_init_objects.json
index c8c836926d94dd4c1903aa9a62fa91c11a238e75..9cbebaf099b4de937ae107e1be17c65bdeddedff 100644
--- a/install/ui/test/data/ipa_init_objects.json
+++ b/install/ui/test/data/ipa_init_objects.json
@@ -498,7 +498,7 @@
 {
 "class": "Int",
 "deprecated_cli_aliases": [],
-"doc": "Maximum amount of time (seconds) for a search (> 0, or -1 for unlimited)",
+"doc": "Maximum amount of time (seconds) for a search (0 is unlimited)",
 "flags": [],
 "label": "Search time limit",
 "maxvalue": 2147483647,
@@ -510,7 +510,7 @@
 {
 "class": "Int",
 "deprecated_cli_aliases": [],
-"doc": "Maximum number of records to search (-1 is unlimited)",
+"doc": "Maximum number of records to search (0 is unlimited)",
 "flags": [],
 "label": "Search size limit",
 "maxvalue": 2147483647,
@@ -9158,4 +9158,4 @@
 }
 }
 }
-}
\ No newline at end of file
+}
diff --git a/install/ui/test/data/json_metadata.json b/install/ui/test/data/json_metadata.json
index a9e66230f94875f7da7efa73141e244b8201a5cc..ff15fe793b48b76d9f8b3dfdb6df31f6f9226529 100644
--- a/install/ui/test/data/json_metadata.json
+++ b/install/ui/test/data/json_metadata.json
@@

Re: [Freeipa-devel] [PATH 0053] Inconsistency between ipasearchrecordslimit and --sizelimit

2015-08-11 Thread Jan Cholasta 

On 6.8.2015 21:43, Gabe Alford wrote:

Hello,

Updated patch attached.

- Time limit is -1 for unlimited. I found this
https://www.redhat.com/archives/freeipa-devel/2011-January/msg00330.html
in reference to keeping the time limit as -1 for unlimited.


This patch does two conflicting things: it coerces time limit of 0 to -1 
and at the same time prohibits the user to use 0 for time limit. We 
should do just one of these and IMHO it should be the coercion of 0 to -1.



Sure enough, testing time limit at 0 did not work for unlimited as well
as appeared to have negative effects on IPA.


This is because the time limit read from ipa config is not converted to 
int in ldap2.find_entries(), so the coercion does not work. Fix this and 
0 will work just fine.



Also, I believe that
http://www.python-ldap.org/doc/html/ldap.html#ldap.LDAPObject.search_ext_s
specifies unlimited for time limit as -1. (Please correct me if I am wrong.)


python-ldap is layers below our API and should not determine what we use 
for unlimited time limit. I would prefer if we were self-consistent and 
use 0 for both time limit and size limit.




- Size limit is 0 for unlimited per Jan's comment including a conversion
from -1 to 0 if -1 is entered for unlimited size limit.


   Actually, 0 means unlimited for size limit, see
   



Thanks,

Gabe

On Tue, Aug 4, 2015 at 3:28 AM, Jan Cholasta mailto:jchol...@redhat.com>> wrote:

Dne 31.7.2015 v 17:08 Gabe Alford napsal(a):

Updated patch attached.

Thanks,

Gabe

On Thu, Jul 30, 2015 at 7:15 AM, Gabe Alford
mailto:redhatri...@gmail.com>
>>
wrote:

 On Thu, Jul 30, 2015 at 1:32 AM, Jan Cholasta
mailto:jchol...@redhat.com>
 >>
wrote:

 Dne 30.7.2015 v 09:23 Jan Cholasta napsal(a):

 Hi,

 Dne 29.7.2015 v 17:23 Gabe Alford napsal(a):

 Hello,

 Fix for
https://fedorahosted.org/freeipa/ticket/4023


 Actually, 0 means unlimited for size limit, see


.


 After reading the ticket I think this should be fixed
the other
 way around: make 0 mean unlimited for both time and
size limit
 and fix the config plugin and LDAPClient to respect that.


 Thanks for the review. Updated patch attached.


We still need to accept -1 in config-mod for backward compatibility
- when received, it should be converted to 0.

--
Jan Cholasta





--
Jan Cholasta

--
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

Re: [Freeipa-devel] [PATH 0053] Inconsistency between ipasearchrecordslimit and --sizelimit

2015-08-06 Thread Gabe Alford 
Hello,

Updated patch attached.

- Time limit is -1 for unlimited. I found this
https://www.redhat.com/archives/freeipa-devel/2011-January/msg00330.html in
reference to keeping the time limit as -1 for unlimited.
Sure enough, testing time limit at 0 did not work for unlimited as well as
appeared to have negative effects on IPA. Also, I believe that
http://www.python-ldap.org/doc/html/ldap.html#ldap.LDAPObject.search_ext_s
specifies unlimited for time limit as -1. (Please correct me if I am wrong.)

- Size limit is 0 for unlimited per Jan's comment including a conversion
from -1 to 0 if -1 is entered for unlimited size limit.

>Actually, 0 means unlimited for size limit, see
><
http://www.python-ldap.org/doc/html/ldap.html#ldap.LDAPObject.search_ext_s>

Thanks,

Gabe

On Tue, Aug 4, 2015 at 3:28 AM, Jan Cholasta  wrote:

> Dne 31.7.2015 v 17:08 Gabe Alford napsal(a):
>
>> Updated patch attached.
>>
>> Thanks,
>>
>> Gabe
>>
>> On Thu, Jul 30, 2015 at 7:15 AM, Gabe Alford > > wrote:
>>
>> On Thu, Jul 30, 2015 at 1:32 AM, Jan Cholasta > > wrote:
>>
>> Dne 30.7.2015 v 09:23 Jan Cholasta napsal(a):
>>
>> Hi,
>>
>> Dne 29.7.2015 v 17:23 Gabe Alford napsal(a):
>>
>> Hello,
>>
>> Fix for https://fedorahosted.org/freeipa/ticket/4023
>>
>>
>> Actually, 0 means unlimited for size limit, see
>> <
>> http://www.python-ldap.org/doc/html/ldap.html#ldap.LDAPObject.search_ext_s
>> >.
>>
>>
>> After reading the ticket I think this should be fixed the other
>> way around: make 0 mean unlimited for both time and size limit
>> and fix the config plugin and LDAPClient to respect that.
>>
>>
>> Thanks for the review. Updated patch attached.
>>
>
> We still need to accept -1 in config-mod for backward compatibility - when
> received, it should be converted to 0.
>
> --
> Jan Cholasta
>
From 73a7fd9f2f3fbfa703da68f1a55bb16e4627ffba Mon Sep 17 00:00:00 2001
From: Gabe 
Date: Thu, 6 Aug 2015 13:18:06 -0600
Subject: [PATCH] Standardize minvalue for ipasearchrecordlimit and
 ipasesarchsizelimit for unlimited minvalue

https://fedorahosted.org/freeipa/ticket/4023
---
 API.txt | 82 ++---
 VERSION |  2 +-
 install/ui/test/data/ipa_init_commands.json |  4 +-
 install/ui/test/data/ipa_init_objects.json  |  4 +-
 install/ui/test/data/json_metadata.json |  2 +-
 ipalib/plugins/baseldap.py  |  6 +--
 ipalib/plugins/config.py|  7 ++-
 7 files changed, 56 insertions(+), 51 deletions(-)

diff --git a/API.txt b/API.txt
index 2e19d6b2f1e16cc1c89d71ed7d443145426a28e3..19c7857bee7cd7fb63c96a130b53946612f0c74e 100644
--- a/API.txt
+++ b/API.txt
@@ -273,7 +273,7 @@ option: IA5Str('automountinformation', attribute=True, autofill=False, cli_name=
 option: IA5Str('automountkey', attribute=True, autofill=False, cli_name='key', multivalue=False, query=True, required=False)
 option: Flag('raw', autofill=True, cli_name='raw', default=False, exclude='webui')
 option: Int('sizelimit?', autofill=False, minvalue=0)
-option: Int('timelimit?', autofill=False, minvalue=0)
+option: Int('timelimit?', autofill=False, minvalue=-1)
 option: Str('version?', exclude='webui')
 output: Output('count', , None)
 output: ListOfEntries('result', (, ), Gettext('A list of LDAP entries', domain='ipa', localedir=None))
@@ -337,7 +337,7 @@ option: Str('cn', attribute=True, autofill=False, cli_name='location', multivalu
 option: Flag('pkey_only?', autofill=True, default=False)
 option: Flag('raw', autofill=True, cli_name='raw', default=False, exclude='webui')
 option: Int('sizelimit?', autofill=False, minvalue=0)
-option: Int('timelimit?', autofill=False, minvalue=0)
+option: Int('timelimit?', autofill=False, minvalue=-1)
 option: Str('version?', exclude='webui')
 output: Output('count', , None)
 output: ListOfEntries('result', (, ), Gettext('A list of LDAP entries', domain='ipa', localedir=None))
@@ -412,7 +412,7 @@ option: Str('description', attribute=True, autofill=False, cli_name='desc', mult
 option: Flag('pkey_only?', autofill=True, default=False)
 option: Flag('raw', autofill=True, cli_name='raw', default=False, exclude='webui')
 option: Int('sizelimit?', autofill=False, minvalue=0)
-option: Int('timelimit?', autofill=False, minvalue=0)
+option: Int('timelimit?', autofill=False, minvalue=-1)
 option: Str('version?', exclude='webui')
 output: Output('count', , None)
 output: ListOfEntries('result', (, ), Gettext('A list of LDAP entries', domain='ipa', localedir=None))
@@ -556,7 +556,7 @@ option: Flag('pkey_only?', autofill=True, default=False)
 option: Flag('raw', autofill=True, cli_name='raw', default=False, exclude='webui')
 option: StrEnum('servicecategory', attribute=True, autofill=False, cli_name='servicecat', multivalue=False, query=True

Re: [Freeipa-devel] [PATH 0053] Inconsistency between ipasearchrecordslimit and --sizelimit

2015-08-04 Thread Jan Cholasta 

Dne 31.7.2015 v 17:08 Gabe Alford napsal(a):

Updated patch attached.

Thanks,

Gabe

On Thu, Jul 30, 2015 at 7:15 AM, Gabe Alford mailto:redhatri...@gmail.com>> wrote:

On Thu, Jul 30, 2015 at 1:32 AM, Jan Cholasta mailto:jchol...@redhat.com>> wrote:

Dne 30.7.2015 v 09:23 Jan Cholasta napsal(a):

Hi,

Dne 29.7.2015 v 17:23 Gabe Alford napsal(a):

Hello,

Fix for https://fedorahosted.org/freeipa/ticket/4023


Actually, 0 means unlimited for size limit, see

.


After reading the ticket I think this should be fixed the other
way around: make 0 mean unlimited for both time and size limit
and fix the config plugin and LDAPClient to respect that.


Thanks for the review. Updated patch attached.


We still need to accept -1 in config-mod for backward compatibility - 
when received, it should be converted to 0.


--
Jan Cholasta

--
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

Re: [Freeipa-devel] [PATH 0053] Inconsistency between ipasearchrecordslimit and --sizelimit

2015-07-31 Thread Gabe Alford 
Updated patch attached.

Thanks,

Gabe

On Thu, Jul 30, 2015 at 7:15 AM, Gabe Alford  wrote:

> On Thu, Jul 30, 2015 at 1:32 AM, Jan Cholasta  wrote:
>
>> Dne 30.7.2015 v 09:23 Jan Cholasta napsal(a):
>>
>>> Hi,
>>>
>>> Dne 29.7.2015 v 17:23 Gabe Alford napsal(a):
>>>
 Hello,

 Fix for https://fedorahosted.org/freeipa/ticket/4023

>>>
>>> Actually, 0 means unlimited for size limit, see
>>> <
>>> http://www.python-ldap.org/doc/html/ldap.html#ldap.LDAPObject.search_ext_s
>>> >.
>>>
>>
>> After reading the ticket I think this should be fixed the other way
>> around: make 0 mean unlimited for both time and size limit and fix the
>> config plugin and LDAPClient to respect that.
>>
>>
> Thanks for the review. Updated patch attached.
>
>
>> --
>> Jan Cholasta
>>
>
>
From 953f5bd85ee7d1ac6fee3034fda63b9a5783b418 Mon Sep 17 00:00:00 2001
From: Gabe 
Date: Fri, 31 Jul 2015 09:06:05 -0600
Subject: [PATCH] Standardize minvalue for ipasearchrecordlimit and
 ipasesarchsizelimit for unlimited minvalue

https://fedorahosted.org/freeipa/ticket/4023
---
 API.txt |  4 ++--
 VERSION |  4 ++--
 install/ui/test/data/ipa_init_commands.json | 10 +-
 install/ui/test/data/ipa_init_objects.json  | 10 +-
 install/ui/test/data/json_metadata.json |  8 
 ipalib/plugins/baseldap.py  |  4 ++--
 ipalib/plugins/config.py| 10 +-
 7 files changed, 25 insertions(+), 25 deletions(-)

diff --git a/API.txt b/API.txt
index 2e19d6b2f1e16cc1c89d71ed7d443145426a28e3..ef1aa080c9b4c0139dc4fe77c27f47c7b6d91226 100644
--- a/API.txt
+++ b/API.txt
@@ -778,8 +778,8 @@ option: StrEnum('ipakrbauthzdata', attribute=True, autofill=False, cli_name='pac
 option: Int('ipamaxusernamelength', attribute=True, autofill=False, cli_name='maxusername', minvalue=1, multivalue=False, required=False)
 option: Bool('ipamigrationenabled', attribute=True, autofill=False, cli_name='enable_migration', multivalue=False, required=False)
 option: Int('ipapwdexpadvnotify', attribute=True, autofill=False, cli_name='pwdexpnotify', minvalue=0, multivalue=False, required=False)
-option: Int('ipasearchrecordslimit', attribute=True, autofill=False, cli_name='searchrecordslimit', minvalue=-1, multivalue=False, required=False)
-option: Int('ipasearchtimelimit', attribute=True, autofill=False, cli_name='searchtimelimit', minvalue=-1, multivalue=False, required=False)
+option: Int('ipasearchrecordslimit', attribute=True, autofill=False, cli_name='searchrecordslimit', minvalue=0, multivalue=False, required=False)
+option: Int('ipasearchtimelimit', attribute=True, autofill=False, cli_name='searchtimelimit', minvalue=0, multivalue=False, required=False)
 option: Str('ipaselinuxusermapdefault', attribute=True, autofill=False, cli_name='ipaselinuxusermapdefault', multivalue=False, required=False)
 option: Str('ipaselinuxusermaporder', attribute=True, autofill=False, cli_name='ipaselinuxusermaporder', multivalue=False, required=False)
 option: StrEnum('ipauserauthtype', attribute=True, autofill=False, cli_name='user_auth_type', csv=True, multivalue=True, required=False, values=(u'password', u'radius', u'otp', u'disabled'))
diff --git a/VERSION b/VERSION
index ca43f3e0c06880d355c068514134187c5edda175..f31498b39c53bd41fff20fc7a3d9de9a6bdf4397 100644
--- a/VERSION
+++ b/VERSION
@@ -90,5 +90,5 @@ IPA_DATA_VERSION=2010061412
 #  #
 
 IPA_API_VERSION_MAJOR=2
-IPA_API_VERSION_MINOR=148
-# Last change: ftweedal - add --out option to user-show
+IPA_API_VERSION_MINOR=149
+# Last change: galford - Change ipasearchtimelime and ipasearchrecordslimit to 0 for unlimited
diff --git a/install/ui/test/data/ipa_init_commands.json b/install/ui/test/data/ipa_init_commands.json
index 743f508e2a733b766008bdd21838454ef7df8c21..477d7cf75aabd5c23dbf91a6305bfcbb9fbf5b1b 100644
--- a/install/ui/test/data/ipa_init_commands.json
+++ b/install/ui/test/data/ipa_init_commands.json
@@ -2446,13 +2446,13 @@
 "attribute": true,
 "class": "Int",
 "deprecated_cli_aliases": [],
-"doc": "Maximum amount of time (seconds) for a search (> 0, or -1 for unlimited)",
+"doc": "Maximum amount of time (seconds) for a search (> 0, or 0 for unlimited)",
 "flags": [
 "nonempty"
 ],
 "label": "Search time limit",
 "maxvalue": 2147483647,
-"minvalue": -1,
+"minvalue": 0,
 "name": "ipasearchtimelimit",
 "type": "int"
 },
@@ -2460,13 +2460,13 @@
 "attribute": true,
 "class": "Int",

Re: [Freeipa-devel] [PATH 0053] Inconsistency between ipasearchrecordslimit and --sizelimit

2015-07-30 Thread Gabe Alford 
On Thu, Jul 30, 2015 at 1:32 AM, Jan Cholasta  wrote:

> Dne 30.7.2015 v 09:23 Jan Cholasta napsal(a):
>
>> Hi,
>>
>> Dne 29.7.2015 v 17:23 Gabe Alford napsal(a):
>>
>>> Hello,
>>>
>>> Fix for https://fedorahosted.org/freeipa/ticket/4023
>>>
>>
>> Actually, 0 means unlimited for size limit, see
>> <
>> http://www.python-ldap.org/doc/html/ldap.html#ldap.LDAPObject.search_ext_s
>> >.
>>
>
> After reading the ticket I think this should be fixed the other way
> around: make 0 mean unlimited for both time and size limit and fix the
> config plugin and LDAPClient to respect that.
>
>
Thanks for the review. Updated patch attached.


> --
> Jan Cholasta
>
From 58e95a7eebe6e333786d9bd6b798490bdae25941 Mon Sep 17 00:00:00 2001
From: Gabe 
Date: Thu, 30 Jul 2015 07:04:06 -0600
Subject: [PATCH] Standardize minvalue for ipasearchrecordlimit and
 ipasesarchsizelimit for unlimited minvalue

https://fedorahosted.org/freeipa/ticket/4023
---
 API.txt |  4 ++--
 VERSION |  4 ++--
 install/ui/test/data/ipa_init_commands.json | 10 +-
 install/ui/test/data/ipa_init_objects.json  | 10 +-
 install/ui/test/data/json_metadata.json |  8 
 ipalib/plugins/baseldap.py  |  4 ++--
 ipalib/plugins/config.py| 10 +-
 7 files changed, 25 insertions(+), 25 deletions(-)

diff --git a/API.txt b/API.txt
index 6ab30ddab41715fdbccb4f37aa1852621bca62b4..90e52a686eb73af8af87b6065868d641e7e868ec 100644
--- a/API.txt
+++ b/API.txt
@@ -778,8 +778,8 @@ option: StrEnum('ipakrbauthzdata', attribute=True, autofill=False, cli_name='pac
 option: Int('ipamaxusernamelength', attribute=True, autofill=False, cli_name='maxusername', minvalue=1, multivalue=False, required=False)
 option: Bool('ipamigrationenabled', attribute=True, autofill=False, cli_name='enable_migration', multivalue=False, required=False)
 option: Int('ipapwdexpadvnotify', attribute=True, autofill=False, cli_name='pwdexpnotify', minvalue=0, multivalue=False, required=False)
-option: Int('ipasearchrecordslimit', attribute=True, autofill=False, cli_name='searchrecordslimit', minvalue=-1, multivalue=False, required=False)
-option: Int('ipasearchtimelimit', attribute=True, autofill=False, cli_name='searchtimelimit', minvalue=-1, multivalue=False, required=False)
+option: Int('ipasearchrecordslimit', attribute=True, autofill=False, cli_name='searchrecordslimit', minvalue=0, multivalue=False, required=False)
+option: Int('ipasearchtimelimit', attribute=True, autofill=False, cli_name='searchtimelimit', minvalue=0, multivalue=False, required=False)
 option: Str('ipaselinuxusermapdefault', attribute=True, autofill=False, cli_name='ipaselinuxusermapdefault', multivalue=False, required=False)
 option: Str('ipaselinuxusermaporder', attribute=True, autofill=False, cli_name='ipaselinuxusermaporder', multivalue=False, required=False)
 option: StrEnum('ipauserauthtype', attribute=True, autofill=False, cli_name='user_auth_type', csv=True, multivalue=True, required=False, values=(u'password', u'radius', u'otp', u'disabled'))
diff --git a/VERSION b/VERSION
index 678d1f8a7e588d480b16441e12e4d527d9c1cd98..837ee846f330779bbaa5fa43311a74c13b013690 100644
--- a/VERSION
+++ b/VERSION
@@ -90,5 +90,5 @@ IPA_DATA_VERSION=2010061412
 #  #
 
 IPA_API_VERSION_MAJOR=2
-IPA_API_VERSION_MINOR=147
-# Last change: mbasti - Consolidate DNS RR in API and schema
+IPA_API_VERSION_MINOR=148
+# Last change: galford - Change ipasearchtimelime and ipasearchrecordslimit to 0 for unlimited
diff --git a/install/ui/test/data/ipa_init_commands.json b/install/ui/test/data/ipa_init_commands.json
index 743f508e2a733b766008bdd21838454ef7df8c21..477d7cf75aabd5c23dbf91a6305bfcbb9fbf5b1b 100644
--- a/install/ui/test/data/ipa_init_commands.json
+++ b/install/ui/test/data/ipa_init_commands.json
@@ -2446,13 +2446,13 @@
 "attribute": true,
 "class": "Int",
 "deprecated_cli_aliases": [],
-"doc": "Maximum amount of time (seconds) for a search (> 0, or -1 for unlimited)",
+"doc": "Maximum amount of time (seconds) for a search (> 0, or 0 for unlimited)",
 "flags": [
 "nonempty"
 ],
 "label": "Search time limit",
 "maxvalue": 2147483647,
-"minvalue": -1,
+"minvalue": 0,
 "name": "ipasearchtimelimit",
 "type": "int"
 },
@@ -2460,13 +2460,13 @@
 "attribute": true,
 "class": "Int",
 "deprecated_cli_aliases": [],
-"doc": "Maximum number of records to search (-1 is

Re: [Freeipa-devel] [PATH 0053] Inconsistency between ipasearchrecordslimit and --sizelimit

2015-07-30 Thread Jan Cholasta 

Dne 30.7.2015 v 09:23 Jan Cholasta napsal(a):

Hi,

Dne 29.7.2015 v 17:23 Gabe Alford napsal(a):

Hello,

Fix for https://fedorahosted.org/freeipa/ticket/4023


Actually, 0 means unlimited for size limit, see
.


After reading the ticket I think this should be fixed the other way 
around: make 0 mean unlimited for both time and size limit and fix the 
config plugin and LDAPClient to respect that.


--
Jan Cholasta

--
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

Re: [Freeipa-devel] [PATH 0053] Inconsistency between ipasearchrecordslimit and --sizelimit

2015-07-30 Thread Jan Cholasta 

Hi,

Dne 29.7.2015 v 17:23 Gabe Alford napsal(a):

Hello,

Fix for https://fedorahosted.org/freeipa/ticket/4023


Actually, 0 means unlimited for size limit, see 
.


Honza

--
Jan Cholasta

--
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

[Freeipa-devel] [PATH 0053] Inconsistency between ipasearchrecordslimit and --sizelimit

2015-07-29 Thread Gabe Alford 
Hello,

Fix for https://fedorahosted.org/freeipa/ticket/4023

Thanks,

Gabe
From cba4b0d90f65be7734a977cb84f96f378e1c91d0 Mon Sep 17 00:00:00 2001
From: Gabe 
Date: Wed, 29 Jul 2015 09:04:32 -0600
Subject: [PATCH] Standardize minvalue for ipasearchrecordlimit and sizelimit
 for unlimited option

https://fedorahosted.org/freeipa/ticket/4023
---
 API.txt| 164 ++---
 VERSION|   4 +-
 ipalib/plugins/baseldap.py |   8 +--
 3 files changed, 88 insertions(+), 88 deletions(-)

diff --git a/API.txt b/API.txt
index 6ab30ddab41715fdbccb4f37aa1852621bca62b4..e588fe538251e84e26358abfb507dd7fce8c597f 100644
--- a/API.txt
+++ b/API.txt
@@ -272,8 +272,8 @@ option: Flag('all', autofill=True, cli_name='all', default=False, exclude='webui
 option: IA5Str('automountinformation', attribute=True, autofill=False, cli_name='info', multivalue=False, query=True, required=False)
 option: IA5Str('automountkey', attribute=True, autofill=False, cli_name='key', multivalue=False, query=True, required=False)
 option: Flag('raw', autofill=True, cli_name='raw', default=False, exclude='webui')
-option: Int('sizelimit?', autofill=False, minvalue=0)
-option: Int('timelimit?', autofill=False, minvalue=0)
+option: Int('sizelimit?', autofill=False, minvalue=-1)
+option: Int('timelimit?', autofill=False, minvalue=-1)
 option: Str('version?', exclude='webui')
 output: Output('count', , None)
 output: ListOfEntries('result', (, ), Gettext('A list of LDAP entries', domain='ipa', localedir=None))
@@ -336,8 +336,8 @@ option: Flag('all', autofill=True, cli_name='all', default=False, exclude='webui
 option: Str('cn', attribute=True, autofill=False, cli_name='location', multivalue=False, primary_key=True, query=True, required=False)
 option: Flag('pkey_only?', autofill=True, default=False)
 option: Flag('raw', autofill=True, cli_name='raw', default=False, exclude='webui')
-option: Int('sizelimit?', autofill=False, minvalue=0)
-option: Int('timelimit?', autofill=False, minvalue=0)
+option: Int('sizelimit?', autofill=False, minvalue=-1)
+option: Int('timelimit?', autofill=False, minvalue=-1)
 option: Str('version?', exclude='webui')
 output: Output('count', , None)
 output: ListOfEntries('result', (, ), Gettext('A list of LDAP entries', domain='ipa', localedir=None))
@@ -411,8 +411,8 @@ option: IA5Str('automountmapname', attribute=True, autofill=False, cli_name='map
 option: Str('description', attribute=True, autofill=False, cli_name='desc', multivalue=False, query=True, required=False)
 option: Flag('pkey_only?', autofill=True, default=False)
 option: Flag('raw', autofill=True, cli_name='raw', default=False, exclude='webui')
-option: Int('sizelimit?', autofill=False, minvalue=0)
-option: Int('timelimit?', autofill=False, minvalue=0)
+option: Int('sizelimit?', autofill=False, minvalue=-1)
+option: Int('timelimit?', autofill=False, minvalue=-1)
 option: Str('version?', exclude='webui')
 output: Output('count', , None)
 output: ListOfEntries('result', (, ), Gettext('A list of LDAP entries', domain='ipa', localedir=None))
@@ -555,8 +555,8 @@ option: Flag('no_members', autofill=True, default=False, exclude='webui')
 option: Flag('pkey_only?', autofill=True, default=False)
 option: Flag('raw', autofill=True, cli_name='raw', default=False, exclude='webui')
 option: StrEnum('servicecategory', attribute=True, autofill=False, cli_name='servicecat', multivalue=False, query=True, required=False, values=(u'all',))
-option: Int('sizelimit?', autofill=False, minvalue=0)
-option: Int('timelimit?', autofill=False, minvalue=0)
+option: Int('sizelimit?', autofill=False, minvalue=-1)
+option: Int('timelimit?', autofill=False, minvalue=-1)
 option: StrEnum('usercategory', attribute=True, autofill=False, cli_name='usercat', multivalue=False, query=True, required=False, values=(u'all',))
 option: Str('version?', exclude='webui')
 output: Output('count', , None)
@@ -711,8 +711,8 @@ option: Str('description', attribute=True, autofill=False, cli_name='desc', mult
 option: Bool('ipacertprofilestoreissued', attribute=True, autofill=False, cli_name='store', default=True, multivalue=False, query=True, required=False)
 option: Flag('pkey_only?', autofill=True, default=False)
 option: Flag('raw', autofill=True, cli_name='raw', default=False, exclude='webui')
-option: Int('sizelimit?', autofill=False, minvalue=0)
-option: Int('timelimit?', autofill=False, minvalue=0)
+option: Int('sizelimit?', autofill=False, minvalue=-1)
+option: Int('timelimit?', autofill=False, minvalue=-1)
 option: Str('version?', exclude='webui')
 output: Output('count', , None)
 output: ListOfEntries('result', (, ), Gettext('A list of LDAP entries', domain='ipa', localedir=None))
@@ -831,8 +831,8 @@ option: Int('cospriority', attribute=True, autofill=False, cli_name='cospriority
 option: DNParam('krbpwdpolicyreference', attribute=True, autofill=False, cli_name='krbpwdpolicyreference', multivalue=False, query=True, required=False)
 option