rcritten commented on a pull request
"""
For the record this test used to pass. Don't blame the test when the code it is
testing was changed.
"""
See the full comment at
https://github.com/freeipa/freeipa/pull/84#issuecomment-247329152
--
Manage your subscription for the Freeipa-devel mailing
stlaz commented on a pull request
"""
Well, I did fix the test, then. I can imagine the function being pretty handy
as a library function although it'd better be used in the future.
What infuriates me is the fact that the test might have never worked (well, at
least year and a half, but my guess
abbra commented on a pull request
"""
Update plugins are higher level of abstraction. They use
ipaserver.install.ldapupdate.LDAPUpdate which provides both .update() and
.update_from_dict() methods. Update plugins can produce dictionaries. With the
change in this pull request they will have to a
mbasti-rh commented on a pull request
"""
Shouldn't external plugins use update files or update plugins as IPA does?
We don't have any guaranteed internal API for anything, we don't have any
document about external plugins, we don't have prepared any API for 3rd party
plugins. We just have your
abbra commented on a pull request
"""
NACK. Please instead fix update_from_dict() to follow _run_updates()
expectations.
update_from_dict() is a handy function for externally provided FreeIPA modules.
They will need to implement the same functionality if they would want to do
dynamic updates t