abbra commented on a pull request """ NACK. Please instead fix update_from_dict() to follow _run_updates() expectations.
update_from_dict() is a handy function for externally provided FreeIPA modules. They will need to implement the same functionality if they would want to do dynamic updates themselves. Thus, the function is better to stay to avoid duplication and instead be fixed to properly call _run_updates(). """ See the full comment at https://github.com/freeipa/freeipa/pull/84#issuecomment-247279263
-- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code
