abbra commented on a pull request

NACK. Please instead fix update_from_dict() to follow _run_updates() 

update_from_dict() is a handy function for externally provided FreeIPA modules. 
They will need to implement the same functionality if they would want to do 
dynamic updates themselves. Thus, the function is better to stay to avoid 
duplication and instead be fixed to properly call _run_updates().

See the full comment at
Manage your subscription for the Freeipa-devel mailing list:
Contribute to FreeIPA:

Reply via email to