Re: [Freeipa-devel] [PATCH 50/50] Ticket 1718 - Fix Spanish po translation file
John Dennis wrote: On 10/12/2011 12:11 PM, John Dennis wrote: I thought what I had done was replace the> with> but I obviously didn't read the diff as closely as you did, good catch Rob , let me go back and check to make sure I didn't another similar mistake. Also I forgot to update the metadata in the header of the po. Attached is a revised patch with the mistake you found fixed. While reviewing the patch I discovered one of my tools had truncated long messages while it was fixing whitespace, I fixed that too. I also updated the metadata to show the po file had been edited by me. There are a few other minor formatting fixes thrown in for good measure :-) Use this patch instead. John ACK, pushed to master and ipa-2-1 Very strangely I had to drop the first changeset in the patch. It was a change that apparently wasn't actually changing anything and making git very unhappy. Anyway, nice work. I'm sure it wasn't a lot of fun. rob ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel
Re: [Freeipa-devel] [PATCH 50/50] Ticket 1718 - Fix Spanish po translation file
On 10/12/2011 11:57 AM, Rob Crittenden wrote: #: ipalib/plugins/config.py:76 msgid "searchtimelimit must be -1 or> 1." -msgstr "searchtimelimit debe ser -1 o> 1." +msgstr "" Why? This isn't where things are formatted for HTML. This string might be output on the command line. None of the other translations (nor the default English) does HTML escapes in the translation. The HTML escaping should occur after fetching the translation if and only if it's being inserted into HTML. Ok, but we don't have to drop the whole thing, just replace> with>? I thought what I had done was replace the > with > but I obviously didn't read the diff as closely as you did, good catch Rob , let me go back and check to make sure I didn't another similar mistake. Also I forgot to update the metadata in the header of the po. -- John Dennis Looking to carve out IT costs? www.redhat.com/carveoutcosts/ ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel
Re: [Freeipa-devel] [PATCH 50/50] Ticket 1718 - Fix Spanish po translation file
John Dennis wrote: On 10/11/2011 06:06 PM, Rob Crittenden wrote: John Dennis wrote: There were quite errors in es.po, it was difficult or impossible to track down where they came from, Transifex does not have good revision history. I fixed about 20% of the msgstr's in the file that had obvious problems which could be spotted by a non-Spanish speaking person. I think this should be left as it was: #: ipalib/plugins/config.py:76 msgid "searchtimelimit must be -1 or> 1." -msgstr "searchtimelimit debe ser -1 o> 1." +msgstr "" Why? This isn't where things are formatted for HTML. This string might be output on the command line. None of the other translations (nor the default English) does HTML escapes in the translation. The HTML escaping should occur after fetching the translation if and only if it's being inserted into HTML. Ok, but we don't have to drop the whole thing, just replace > with >? There are some cases where leading white space is remove and a bunch where it is added. Are these ok? @@ -3184,7 +3117,7 @@ msgid "" " " msgstr "" "\n" -"Búsqueda de cuentas de derechod." +" Búsqueda de cuentas de derechod." The translator modified the leading whitespace. I ran a script which forced the leading whitespace in the original string (msgid) to be the same in the translation (msgstr). Thus it set the leading whitespace back to what it should have been. In many instances it's a non-issue because we strip leading and trailing whitespace prior to display. Ok. rob ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel
Re: [Freeipa-devel] [PATCH 50/50] Ticket 1718 - Fix Spanish po translation file
On 10/11/2011 06:06 PM, Rob Crittenden wrote: John Dennis wrote: There were quite errors in es.po, it was difficult or impossible to track down where they came from, Transifex does not have good revision history. I fixed about 20% of the msgstr's in the file that had obvious problems which could be spotted by a non-Spanish speaking person. I think this should be left as it was: #: ipalib/plugins/config.py:76 msgid "searchtimelimit must be -1 or> 1." -msgstr "searchtimelimit debe ser -1 o> 1." +msgstr "" Why? This isn't where things are formatted for HTML. This string might be output on the command line. None of the other translations (nor the default English) does HTML escapes in the translation. The HTML escaping should occur after fetching the translation if and only if it's being inserted into HTML. There are some cases where leading white space is remove and a bunch where it is added. Are these ok? @@ -3184,7 +3117,7 @@ msgid "" "" msgstr "" "\n" -"Búsqueda de cuentas de derechod." +"Búsqueda de cuentas de derechod." The translator modified the leading whitespace. I ran a script which forced the leading whitespace in the original string (msgid) to be the same in the translation (msgstr). Thus it set the leading whitespace back to what it should have been. In many instances it's a non-issue because we strip leading and trailing whitespace prior to display. Otherwise looks lots better rob -- John Dennis Looking to carve out IT costs? www.redhat.com/carveoutcosts/ ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel
Re: [Freeipa-devel] [PATCH 50/50] Ticket 1718 - Fix Spanish po translation file
John Dennis wrote: There were quite errors in es.po, it was difficult or impossible to track down where they came from, Transifex does not have good revision history. I fixed about 20% of the msgstr's in the file that had obvious problems which could be spotted by a non-Spanish speaking person. I think this should be left as it was: #: ipalib/plugins/config.py:76 msgid "searchtimelimit must be -1 or > 1." -msgstr "searchtimelimit debe ser -1 o> 1." +msgstr "" There are some cases where leading white space is remove and a bunch where it is added. Are these ok? @@ -3184,7 +3117,7 @@ msgid "" "" msgstr "" "\n" -"Búsqueda de cuentas de derechod." +"Búsqueda de cuentas de derechod." Otherwise looks lots better rob ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel
