Re: [Freeipa-devel] Web UI refactoring effort ready for review

2013-05-10 Thread Endi Sukma Dewata
On 5/6/2013 11:20 AM, Petr Vobornik wrote: In the simpleuser.js the new 'user' entity is registered first then the old 'user' entity is removed, which could be confusing because they are both identified using 'user'. Should register() automatically remove the old object? I've mixed feelings abo

Re: [Freeipa-devel] Web UI refactoring effort ready for review

2013-05-06 Thread Petr Vobornik
On 05/03/2013 07:35 PM, Endi Sukma Dewata wrote: Hi, Sorry for the delay, I have some questions & comments. Registry: In the simpleuser.js the new 'user' entity is registered first then the old 'user' entity is removed, which could be confusing because they are both identified using 'user'. Sh

Re: [Freeipa-devel] Web UI refactoring effort ready for review

2013-05-06 Thread Petr Vobornik
On 05/06/2013 09:16 AM, Martin Kosek wrote: On 05/03/2013 07:35 PM, Endi Sukma Dewata wrote: In general there is no major issue that would warrant a NACK. As long as the API is well documented for plugin writers it should be sufficient. Thanks for review Endi! Since we do not have a NACK, le

Re: [Freeipa-devel] Web UI refactoring effort ready for review

2013-05-06 Thread Martin Kosek
On 05/03/2013 07:35 PM, Endi Sukma Dewata wrote: > Hi, > > Sorry for the delay, I have some questions & comments. > > Registry: > > In the simpleuser.js the new 'user' entity is registered first then the old > 'user' entity is removed, which could be confusing because they are both > identified

Re: [Freeipa-devel] Web UI refactoring effort ready for review

2013-05-03 Thread Endi Sukma Dewata
Hi, Sorry for the delay, I have some questions & comments. Registry: In the simpleuser.js the new 'user' entity is registered first then the old 'user' entity is removed, which could be confusing because they are both identified using 'user'. Should register() automatically remove the old ob

Re: [Freeipa-devel] Web UI refactoring effort ready for review

2013-05-03 Thread Petr Vobornik
Update: * added ticket number to every commit, some commit messages improved * ~4 commits squashed * rebased on current master On 04/30/2013 07:19 PM, Petr Vobornik wrote: Update: * rebased on current master an force-pushed to private repo * fixed crash when IPA installed without CA * fixed bugs

Re: [Freeipa-devel] Web UI refactoring effort ready for review

2013-05-03 Thread Petr Vobornik
On 05/03/2013 12:44 PM, Ana Krivokapic wrote: On 04/26/2013 12:51 PM, Petr Vobornik wrote: On 04/25/2013 06:37 PM, Ana Krivokapic wrote: 1) When in self service mode, you are now allowed to go to pages of related objects. If you go to e.g. User Groups for your user, there are Add/Delete butto

Re: [Freeipa-devel] Web UI refactoring effort ready for review

2013-05-03 Thread Ana Krivokapic
On 04/26/2013 12:51 PM, Petr Vobornik wrote: > On 04/25/2013 06:37 PM, Ana Krivokapic wrote: > >> >> 1) When in self service mode, you are now allowed to go to pages of >> related objects. If you go to e.g. User Groups for your user, there are >> Add/Delete buttons and they are enabled, but if you

Re: [Freeipa-devel] Web UI refactoring effort ready for review

2013-04-30 Thread Petr Vobornik
Update: * rebased on current master an force-pushed to private repo * fixed crash when IPA installed without CA * fixed bugs found by automated tests ** crash on ssh key add ** crash on host deletion * added design page for #3236: http://www.freeipa.org/page/V3/WebUI_extensible_navigation * enab

Re: [Freeipa-devel] Web UI refactoring effort ready for review

2013-04-26 Thread Petr Vobornik
Another problem found: trustconfig had invalid spec which made the trust section quite unusable. Fixed and pushed to the private repo. I also took an opportunity and added missing parts of trust metadata for static testing. On 04/26/2013 04:32 PM, Petr Vobornik wrote: Hi, 1, 2 and 3a are f

Re: [Freeipa-devel] Web UI refactoring effort ready for review

2013-04-26 Thread Petr Vobornik
Hi, 1, 2 and 3a are fixed and pushed to the private repo. Rest won't be fixed during the refactoring. I changed SingletonRegistry behavior that it returns null when builder/construction spec is missing. It's more consistent with build of unsupported entities (also returns null). On 04/26/2

Re: [Freeipa-devel] Web UI refactoring effort ready for review

2013-04-26 Thread Petr Vobornik
On 04/25/2013 06:37 PM, Ana Krivokapic wrote: Hi, While reviewing and testing the new UI changes, I have encountered the following issues. (Some of them may be unrelated to the webUI refactoring effort, but I will list them here just so we are aware of them.) Thanks for review, I will fix reg

Re: [Freeipa-devel] Web UI refactoring effort ready for review

2013-04-25 Thread Ana Krivokapic
On 04/24/2013 04:55 PM, Petr Vobornik wrote: > I've implemented the remaining work. Pushed to the private repo. > >> Know problems & remaining work >> -- >> 1. Change generation of plugin index to dynamical instead of rpm-post > > The plugin index (plugins.js) is generat

Re: [Freeipa-devel] Web UI refactoring effort ready for review

2013-04-24 Thread Alexander Bokovoy
On Wed, 24 Apr 2013, Petr Vobornik wrote: On 04/24/2013 06:03 PM, Alexander Bokovoy wrote: On Wed, 24 Apr 2013, Petr Vobornik wrote: I've implemented the remaining work. Pushed to the private repo. Know problems & remaining work -- 1. Change generation of plugin in

Re: [Freeipa-devel] Web UI refactoring effort ready for review

2013-04-24 Thread Petr Vobornik
On 04/24/2013 06:03 PM, Alexander Bokovoy wrote: On Wed, 24 Apr 2013, Petr Vobornik wrote: I've implemented the remaining work. Pushed to the private repo. Know problems & remaining work -- 1. Change generation of plugin index to dynamical instead of rpm-post The

Re: [Freeipa-devel] Web UI refactoring effort ready for review

2013-04-24 Thread Alexander Bokovoy
On Wed, 24 Apr 2013, Petr Vobornik wrote: I've implemented the remaining work. Pushed to the private repo. Know problems & remaining work -- 1. Change generation of plugin index to dynamical instead of rpm-post The plugin index (plugins.js) is generated by wsgi scr

Re: [Freeipa-devel] Web UI refactoring effort ready for review

2013-04-24 Thread Petr Vobornik
I've implemented the remaining work. Pushed to the private repo. Know problems & remaining work -- 1. Change generation of plugin index to dynamical instead of rpm-post The plugin index (plugins.js) is generated by wsgi script. New dir was created: /usr/share/ipa/w