Re: [Freeipmi-devel] bmc-config: PEF config checkout

2006-09-10 Thread Ingo van Lil
Anand Babu <[EMAIL PROTECTED]> schrieb: | ARGH! This code worked on another machine. I suppose the | randomness of the compile/memory usage would allow the value read | from the invalid pointer to still be correct for other machines. Memory de-allocation routines usually don't take extra effo

Re: [Freeipmi-devel] bmc-config: PEF config checkout

2006-09-09 Thread Anand Babu
On Tue, Sep 05, 2006 at 08:59:57AM -0700, Al Chu wrote: , | > - Several *_commit functions in bmc-sol-conf-section.c used to | >free the kv->value before actually parsing it, resulting in | >the actual parameter being set to 0. | | ARGH! This code worked on another machine. I suppose

Re: [Freeipmi-devel] bmc-config: PEF config checkout

2006-09-09 Thread Anand Babu
,[ On Mon, Sep 04, 2006, Ingo van Lil wrote: ] | a couple of weeks ago Albert Chu complained about not being able to | check out the PEF configuration on any of the machines he | tested. The explanation for this appears to be fairly simple: Unless | I'm badly mistaken most IPMI calls in | ipmi-

Re: [Freeipmi-devel] bmc-config: PEF config checkout

2006-09-05 Thread Al Chu
Hi Ingo, Great. Thanks for the patch. > - Several *_commit functions in bmc-sol-conf-section.c used to >free the kv->value before actually parsing it, resulting in >the actual parameter being set to 0. ARGH! This code worked on another machine. I suppose the randomness of the compile/

Re: [Freeipmi-devel] bmc-config: PEF config checkout

2006-09-05 Thread Ingo van Lil
Albert Chu <[EMAIL PROTECTED]> schrieb: Thanks Ingo. Great catches. I've checked all your changes in. Found a few more bugs today: - Several *_commit functions in bmc-sol-conf-section.c used to free the kv->value before actually parsing it, resulting in the actual parameter being set to

Re: [Freeipmi-devel] bmc-config: PEF config checkout

2006-09-04 Thread Albert Chu
Hi Ingo, Thanks Ingo. Great catches. I've checked all your changes in. Al > Ingo van Lil <[EMAIL PROTECTED]> schrieb: > >> A patch for libfreeipmi is attached. Admittedly, checking out the PEF >> section isn't any more successful with the patch than it used to be, >> but at least the error mes

Re: [Freeipmi-devel] bmc-config: PEF config checkout

2006-09-04 Thread Ingo van Lil
Ingo van Lil <[EMAIL PROTECTED]> schrieb: A patch for libfreeipmi is attached. Admittedly, checking out the PEF section isn't any more successful with the patch than it used to be, but at least the error message changed from "unsupported command" to "expression failed". OK, got it: The "para

[Freeipmi-devel] bmc-config: PEF config checkout

2006-09-04 Thread Ingo van Lil
Hi there, a couple of weeks ago Albert Chu complained about not being able to check out the PEF configuration on any of the machines he tested. The explanation for this appears to be fairly simple: Unless I'm badly mistaken most IPMI calls in ipmi-pef-and-alerting-cmds-udm.c use the wrong Net