Re: [Freeipmi-devel] ipmiconsole_engine_teardown does not seem to block as advertised

2007-07-11 Thread Al Chu
On Wed, 2007-07-11 at 12:21 -0600, Levi Pearson wrote: > On Thu, 2007-06-28 at 16:47 -0600, Levi Pearson wrote: > > On Thu, 2007-06-28 at 15:33 -0700, Al Chu wrote: > > > Hey Levi, > > > > > > One other additional note. I added several debug flags into the > > > library. It may be worth adding i

Re: [Freeipmi-devel] ipmiconsole_engine_teardown does not seem to block as advertised

2007-07-11 Thread Levi Pearson
On Thu, 2007-06-28 at 16:47 -0600, Levi Pearson wrote: > On Thu, 2007-06-28 at 15:33 -0700, Al Chu wrote: > > Hey Levi, > > > > One other additional note. I added several debug flags into the > > library. It may be worth adding it into your code to help us figure out > > the problem. Passing >

Re: [Freeipmi-devel] ipmiconsole_engine_teardown does not seem to block as advertised

2007-06-28 Thread Levi Pearson
On Thu, 2007-06-28 at 15:33 -0700, Al Chu wrote: > Hey Levi, > > One other additional note. I added several debug flags into the > library. It may be worth adding it into your code to help us figure out > the problem. Passing > > IPMICONSOLE_DEBUG_FILE > > to engine_init() will output debug

Re: [Freeipmi-devel] ipmiconsole_engine_teardown does not seem to block as advertised

2007-06-28 Thread Al Chu
Hey Levi, One other additional note. I added several debug flags into the library. It may be worth adding it into your code to help us figure out the problem. Passing IPMICONSOLE_DEBUG_FILE to engine_init() will output debug info into files in /tmp. Al On Thu, 2007-06-28 at 13:58 -0700, Al

Re: [Freeipmi-devel] ipmiconsole_engine_teardown does not seem to block as advertised

2007-06-28 Thread Al Chu
Hey Levi, > engine_teardown(); <- doesn't block right now > foreach context > while ipmi_destroy_ctx(ctx) < 0 <- need to spin in case > sleep(1) connections aren't dead yet > > And it sits forever (or at least 10 minutes or so) in the loop; > apparently the call

Re: [Freeipmi-devel] ipmiconsole_engine_teardown does not seem to block as advertised

2007-06-28 Thread Levi Pearson
On Thu, 2007-06-28 at 09:39 -0700, Al Chu wrote: > > So is it not closing the sessions? > Apparently not. > > It would be handy to have a call that > > does trigger the closing of all sessions such that ipmi_ctx_destroy() > > will work on them afterward, though. > > The library should work suc

Re: [Freeipmi-devel] ipmiconsole_engine_teardown does not seem to block as advertised

2007-06-28 Thread Al Chu
On Thu, 2007-06-28 at 10:31 -0600, Levi Pearson wrote: > On Thu, 2007-06-28 at 09:19 -0700, Al Chu wrote: > > > I really view the engine and the contexts as two separate "objects" the > > user is responsible for. The user "creates" each context and thus is > > responsible for "destroying" each on

Re: [Freeipmi-devel] ipmiconsole_engine_teardown does not seem to block as advertised

2007-06-28 Thread Al Chu
On Thu, 2007-06-28 at 10:06 -0600, Levi Pearson wrote: > On Thu, 2007-06-28 at 08:42 -0700, Al Chu wrote: > > Hey Levi, > > > > Thanks for noticing this. I'm guessing that the implementation changed > > awhile back and I forgot to change the comments. > > > > I need to look at the code again the

Re: [Freeipmi-devel] ipmiconsole_engine_teardown does not seem to block as advertised

2007-06-28 Thread Levi Pearson
On Thu, 2007-06-28 at 09:19 -0700, Al Chu wrote: > I really view the engine and the contexts as two separate "objects" the > user is responsible for. The user "creates" each context and thus is > responsible for "destroying" each one. The user "inits" the engine and > responsible for "destroying

Re: [Freeipmi-devel] ipmiconsole_engine_teardown does not seem to block as advertised

2007-06-28 Thread Al Chu
On Thu, 2007-06-28 at 10:23 -0600, Levi Pearson wrote: > On Thu, 2007-06-28 at 08:42 -0700, Al Chu wrote: > > Hey Levi, > > > > Thanks for noticing this. I'm guessing that the implementation changed > > awhile back and I forgot to change the comments. > > > > I need to look at the code again the

Re: [Freeipmi-devel] ipmiconsole_engine_teardown does not seem to block as advertised

2007-06-28 Thread Levi Pearson
On Thu, 2007-06-28 at 08:42 -0700, Al Chu wrote: > Hey Levi, > > Thanks for noticing this. I'm guessing that the implementation changed > awhile back and I forgot to change the comments. > > I need to look at the code again the refresh my memory on how best to > implement this. Looking at ipmic

Re: [Freeipmi-devel] ipmiconsole_engine_teardown does not seem to block as advertised

2007-06-28 Thread Al Chu
Hey Levi, I looked at the code some more to remind myself what it does. (It's been over a year :-) Ignore my last e-mail, lets start over ... > The comment in ipmiconsole.h for ipmiconsole_engine_teardown() says that > > the function will block until all active contexts are closed, but > > inst

Re: [Freeipmi-devel] ipmiconsole_engine_teardown does not seem to block as advertised

2007-06-28 Thread Levi Pearson
On Thu, 2007-06-28 at 08:42 -0700, Al Chu wrote: > Hey Levi, > > Thanks for noticing this. I'm guessing that the implementation changed > awhile back and I forgot to change the comments. > > I need to look at the code again the refresh my memory on how best to > implement this. Looking at ipmic

Re: [Freeipmi-devel] ipmiconsole_engine_teardown does not seem to block as advertised

2007-06-28 Thread Al Chu
Hey Levi, Thanks for noticing this. I'm guessing that the implementation changed awhile back and I forgot to change the comments. I need to look at the code again the refresh my memory on how best to implement this. Looking at ipmiconsole (the tool, not the lib) it seems neither ipmiconsole_ctx