Re: [PATCH stable-2.16 6/7] Allow migrate --cleanup to adopt an instance

On Thu, Oct 13, 2016 at 3:01 PM, Brian Foley wrote: > On Fri, Oct 07, 2016 at 08:38:05PM +0100, 'Viktor Bachraty' via > ganeti-devel wrote: > > In some failure modes, Ganeti state of record may desync from actual > > state of world. This patch allows migrate --cleanup to

Re: [PATCH stable-2.16 0/7] Make migrations on Xen more robust

On Fri, Oct 07, 2016 at 08:37:55PM +0100, 'Viktor Bachraty' via ganeti-devel wrote: > > This is my try to make Xen migrations more robust. I'm not entirely sure if > the approach is acceptable, but couldn't come up with a nicer solution within > the current design/limitations. Considering that

Re: Issue 1191 in ganeti: sample logrotate conf breaks with >=logrotate-3.8 and split-user

Comment #2 on issue 1191 by sascha.l...@gisa.de: sample logrotate conf breaks with >=logrotate-3.8 and split-user https://code.google.com/p/ganeti/issues/detail?id=1191 create and su do not the same. create is for setting the owner/permission on newly created logfile. su is for setting

Re: [PATCH stable-2.16 3/7] Make FinalizeMigration{Src,Dst} more robust

On Fri, Oct 07, 2016 at 08:38:00PM +0100, 'Viktor Bachraty' via ganeti-devel wrote: > Migration is supported on KVM/Xen hypervisors only. Finalize methods are > called in both success or suspected failure (the master node can't > certainly know about failures - e.g. in case of timeouts). Thus

Re: [PATCH stable-2.16 1/7] Code cleanup in hypervisor backend

On Fri, Oct 07, 2016 at 08:37:57PM +0100, 'Viktor Bachraty' via ganeti-devel wrote: > Non-functional changes, smaller code cleanup. > > Signed-off-by: Viktor Bachraty As you say, just cleanup and minor refactoring. LGTM. Thanks.

Re: [PATCH stable-2.16 2/7] Fix instance state detection in _Shutdowninstance

On Fri, Oct 07, 2016 at 08:37:59PM +0100, 'Viktor Bachraty' via ganeti-devel wrote: > GetInstanceInfo returns info that is already parsed with state being an > enum value coverted from string using _XenToHypervisorInstanceState() typo: s/coverted/converted/ > > Signed-off-by: Viktor Bachraty

Re: [PATCH stable-2.16 5/7] Make migrate --cleanup more robust

On Fri, Oct 07, 2016 at 08:38:03PM +0100, 'Viktor Bachraty' via ganeti-devel wrote: > In case of Xen migrations, the most common failure case is when the > instance fails to freeze so the migration fails with domains running on > both target and source node. This patchs allows migrate --cleanup

Re: [PATCH stable-2.16 4/7] Make finalize_migration_{src,dst} 'atomic'

On Thu, Oct 13, 2016 at 01:16:39PM +0100, Viktor Bachraty wrote: >On Thu, Oct 13, 2016 at 12:48 PM, 'Brian Foley' via ganeti-devel ><[1]ganeti-devel@googlegroups.com> wrote: > > On Fri, Oct 07, 2016 at 08:38:02PM +0100, 'Viktor Bachraty' via > ganeti-devel wrote: > This

Re: [PATCH stable-2.16 4/7] Make finalize_migration_{src,dst} 'atomic'

On Thu, Oct 13, 2016 at 12:48 PM, 'Brian Foley' via ganeti-devel < ganeti-devel@googlegroups.com> wrote: > On Fri, Oct 07, 2016 at 08:38:02PM +0100, 'Viktor Bachraty' via > ganeti-devel wrote: > > This should definitely help cleaning up after migrates. LGTM modulo nits > below. > > >

Re: [PATCH stable-2.16 4/7] Make finalize_migration_{src,dst} 'atomic'

On Fri, Oct 07, 2016 at 08:38:02PM +0100, 'Viktor Bachraty' via ganeti-devel wrote: This should definitely help cleaning up after migrates. LGTM modulo nits below. > FinalizeMigrationSource and FinalizeMigrationDst should compose an > 'atomic' operation consisting of 2 idempotent steps, that

Re: [PATCH stable-2.16 6/7] Allow migrate --cleanup to adopt an instance

On Fri, Oct 07, 2016 at 08:38:05PM +0100, 'Viktor Bachraty' via ganeti-devel wrote: > In some failure modes, Ganeti state of record may desync from actual > state of world. This patch allows migrate --cleanup to adopt an instance > if it is detected running on an unexpected node. I'm trying to

Re: [PATCH stable-2.16 7/7] StartInstance restores instance state if running

On Fri, Oct 07, 2016 at 08:38:07PM +0100, 'Viktor Bachraty' via ganeti-devel wrote: > Add a side effect to StartInstance on Xen hypervisor that restores the > Xen configuration in case it is missing. This is a common failure > scenario during migrations. The generic backend checks if the instance