[Aarch64] Fix conditional branches with target far away.

2018-02-14 Thread Sameera Deshpande
Hi! Please find attached the patch to fix bug in branches with offsets over 1MiB. There has been an attempt to fix this issue in commit 050af05b9761f1979f11c151519e7244d5becd7c However, the far_branch attribute defined in above patch used insn_length - which computes incorrect offset. Hence,

Re: [SFN+LVU+IEPM v4 7/9] [LVU] Introduce location views

2018-02-14 Thread Andreas Schwab
On Feb 13 2018, Alexandre Oliva wrote: > The patch I posted last night should work around this problem, in that > it will disable LVU by default if the assembler doesn't support .loc > views, and then you won't get this error any more, unless you explicitly > ask for location

Re: [PATCH] Fix PR84101, account for function ABI details in vectorization costs

2018-02-14 Thread Richard Biener
On Tue, 13 Feb 2018, Jeff Law wrote: > On 01/30/2018 02:59 AM, Richard Biener wrote: > > > > This patch tries to deal with the "easy" part of a function ABI, > > the return value location, in vectorization costing. The testcase > > shows that if we vectorize the returned value but the function

Re: [PATCH] FIx endless match.pd recursion on cst1 + cst2 + cst3 (PR tree-optimization/84334)

2018-02-14 Thread Marc Glisse
On Wed, 14 Feb 2018, Richard Biener wrote: On Tue, 13 Feb 2018, Marc Glisse wrote: On Tue, 13 Feb 2018, Richard Biener wrote: On February 13, 2018 6:51:29 PM GMT+01:00, Jakub Jelinek wrote: Hi! On the following testcase, we recurse infinitely, because we have float

Re: [C++ Patch] tsubst_flags_t fixlet

2018-02-14 Thread Jason Merrill
OK. On Wed, Feb 14, 2018 at 6:01 AM, Paolo Carlini wrote: > Hi, > > today, while having a look to c++/84350, I noticed that in a couple of > places we aren't forwarding the tsubst_flags_t argument to > do_auto_deduction. I think we can elegantly solve the problem by

Re: [PATCH] FIx endless match.pd recursion on cst1 + cst2 + cst3 (PR tree-optimization/84334)

2018-02-14 Thread Richard Biener
On Tue, 13 Feb 2018, Marc Glisse wrote: > On Tue, 13 Feb 2018, Richard Biener wrote: > > > On February 13, 2018 6:51:29 PM GMT+01:00, Jakub Jelinek > > wrote: > > > Hi! > > > > > > On the following testcase, we recurse infinitely, because > > > we have float re-association

Re: [Patch, Fortran, F08] PR 84313: reject procedure pointers in COMMON blocks

2018-02-14 Thread Jakub Jelinek
On Wed, Feb 14, 2018 at 12:30:14PM +0100, Jakub Jelinek wrote: > On Tue, Feb 13, 2018 at 07:24:35PM +0100, Janus Weil wrote: > > as the subject line says, the attached patch rejects procedure > > pointers in COMMON blocks (which is forbidden in F08). Since it's > > apparently legal in F03, I'm

Re: [PATCH] Handle PowerPC64 ELFv1 function descriptors in libbacktrace (PR other/82368)

2018-02-14 Thread Segher Boessenkool
Hi Jakub, On Wed, Feb 14, 2018 at 12:41:38PM +0100, Jakub Jelinek wrote: > As mentioned in detail in the PR, PowerPC64 ELFv1 function symbols > point to function descriptors in .opd section rather than actual > code, and one needs to read the code address from the .opd section > in order to

Re: [RX] Fix PR 83831 -- Unused bclr, bnot, bset insns

2018-02-14 Thread Oleg Endo
On Tue, 2018-02-13 at 17:04 +, Nick Clifton wrote: > > > gcc/ChangeLog: > > > > PR target/83831 > > * config/rx/rx-protos.h (rx_reg_dead_or_unused_after_insn, > > rx_copy_reg_dead_or_unused_notes, rx_fuse_in_memory_bitop): New > > declarations. > > (set_of_reg): New

Re: [PING] [PATCH] [MSP430] PR79242: Implement Complex Partial Integers

2018-02-14 Thread Jozef Lawrynowicz
On 14/02/18 07:25, Jeff Law wrote: On 02/08/2018 09:54 AM, Jozef Lawrynowicz wrote: ping x1 Complex Partial Integers are unimplemented, resulting in an ICE when attempting to use them. https://gcc.gnu.org/bugzilla/show_bug.cgi?id=79242 This results in GCC7/8 for msp430-elf failing to build.

[PATCH] Handle PowerPC64 ELFv1 function descriptors in libbacktrace (PR other/82368)

2018-02-14 Thread Jakub Jelinek
Hi! As mentioned in detail in the PR, PowerPC64 ELFv1 function symbols point to function descriptors in .opd section rather than actual code, and one needs to read the code address from the .opd section in order to associate symbols with .text addresses. Fixed thusly, bootstrapped/regtested on

Re: [PR tree-optimization/84047] missing -Warray-bounds on an out-of-bounds index

2018-02-14 Thread Richard Biener
On Thu, Feb 8, 2018 at 9:45 PM, Martin Sebor wrote: > On 02/08/2018 03:38 AM, Richard Biener wrote: >> >> On Thu, Feb 1, 2018 at 6:42 PM, Aldy Hernandez wrote: >>> >>> Since my patch isn't the easy one liner I wanted it to be, perhaps we >>> should concentrate

[C++ Patch] tsubst_flags_t fixlet

2018-02-14 Thread Paolo Carlini
Hi, today, while having a look to c++/84350, I noticed that in a couple of places we aren't forwarding the tsubst_flags_t argument to do_auto_deduction. I think we can elegantly solve the problem by removing the do_auto_deduction overload taking three arguments and adding two defaults to the

Re: [Patch, Fortran, F08] PR 84313: reject procedure pointers in COMMON blocks

2018-02-14 Thread Jakub Jelinek
On Tue, Feb 13, 2018 at 07:24:35PM +0100, Janus Weil wrote: > Hi all, > > as the subject line says, the attached patch rejects procedure > pointers in COMMON blocks (which is forbidden in F08). Since it's > apparently legal in F03, I'm still accepting it with -std=f2003 and > add that flag to a

Re: [Patch, Fortran, F08] PR 84313: reject procedure pointers in COMMON blocks

2018-02-14 Thread Janus Weil
2018-02-14 12:47 GMT+01:00 Jakub Jelinek : > On Wed, Feb 14, 2018 at 12:30:14PM +0100, Jakub Jelinek wrote: >> On Tue, Feb 13, 2018 at 07:24:35PM +0100, Janus Weil wrote: >> > as the subject line says, the attached patch rejects procedure >> > pointers in COMMON blocks (which is

Re: Check array indices in object_address_invariant_in_loop_p (PR 84357)

2018-02-14 Thread Richard Biener
On Wed, Feb 14, 2018 at 10:44 AM, Richard Sandiford wrote: > object_address_invariant_in_loop_p ignored ARRAY_REF indices on > the basis that: > > /* Index of the ARRAY_REF was zeroed in analyze_indices, thus we > only > need to check the

Re: [PATCH] Fix PR84101, account for function ABI details in vectorization costs

2018-02-14 Thread Jakub Jelinek
On Wed, Feb 14, 2018 at 12:52:45PM +0100, Richard Biener wrote: > On Tue, 13 Feb 2018, Jeff Law wrote: > > > On 01/30/2018 02:59 AM, Richard Biener wrote: > > > > > > This patch tries to deal with the "easy" part of a function ABI, > > > the return value location, in vectorization costing. The

Re: [PATCH] jit: fix link on OS X and Solaris (PR jit/64089 and PR jit/84288)

2018-02-14 Thread Rainer Orth
Hi David, >> * added LD_SONAME_OPTION, done in the same way [...] >> Does this fix the jit linker issues on OS X and Solaris? > > I'll give it a whirl tomorrow, including the jit-recording.c part of my > patch to allow the build to complete. actually, I've replaced the Makefile and configure

Check array indices in object_address_invariant_in_loop_p (PR 84357)

2018-02-14 Thread Richard Sandiford
object_address_invariant_in_loop_p ignored ARRAY_REF indices on the basis that: /* Index of the ARRAY_REF was zeroed in analyze_indices, thus we only need to check the stride and the lower bound of the reference. */ That was true back in 2007 when the code was added:

[PATCH][i386] Adjust vec_construct cost for AVX256/512, penaltize elementwise load vectorization

2018-02-14 Thread Richard Biener
The following tries to account for the fact that when constructing AVX256 or AVX512 vectors from elements we can only use insertps to insert into the low 128bits of a vector but have to use vinserti128 or vinserti64x4 to build larger AVX256/512 vectors. Those operations also have higher latency

Re: [PATCH, rs6000] (v2) PR84220 remove RS6000_BTI_NOT_OPAQUE refs from builtins table

2018-02-14 Thread Segher Boessenkool
Hi! On Tue, Feb 13, 2018 at 05:40:08PM -0600, Will Schmidt wrote: > Some of our builtin definitions were allowing invalid parameters, and a > subsequent ICE (on invalid code) were the result. This is due to the use of > RS6000_BTI_NOT_OPAQUE (which allowed vector arguments), where a >

Re: [PATCH] diagnose specializations of deprecated templates (PR c++/84318)

2018-02-14 Thread Martin Sebor
On 02/13/2018 10:28 PM, Jason Merrill wrote: On Tue, Feb 13, 2018 at 5:20 PM, Martin Sebor wrote: On 02/13/2018 01:09 PM, Jason Merrill wrote: On Tue, Feb 13, 2018 at 2:59 PM, Martin Sebor wrote: On 02/13/2018 12:15 PM, Jason Merrill wrote: On Tue,

Re: [PATCH, rs6000] Fix PR84279, powerpc64le ICE on cvc4

2018-02-14 Thread Peter Bergner
On 2/13/18 5:51 PM, Segher Boessenkool wrote: > We can backport without having a failing testcase. Let's do that for 7 > at least? Ok, the backport tested clean, so I committed it. Thanks. Peter

Re: [C++ Patch] PR 84350 ("[7/8 Regression] ICE with new and auto")

2018-02-14 Thread Jason Merrill
OK. On Wed, Feb 14, 2018 at 9:53 AM, Paolo Carlini wrote: > Hi, > > today I spent some time on this: basing on r245826, when we started ICEing. > For example I wondered if we wanted to rework the use of do_auto_deduction > from build_new, and check

Re: [PATCH] FIx endless match.pd recursion on cst1 + cst2 + cst3 (PR tree-optimization/84334)

2018-02-14 Thread Jakub Jelinek
On Wed, Feb 14, 2018 at 12:09:57PM +0100, Richard Biener wrote: > On Tue, 13 Feb 2018, Marc Glisse wrote: > > > On Tue, 13 Feb 2018, Richard Biener wrote: > > > > > On February 13, 2018 6:51:29 PM GMT+01:00, Jakub Jelinek > > > > > > wrote: > > > > Hi! > > > > > > > > On the

[C++ Patch] PR 84350 ("[7/8 Regression] ICE with new and auto")

2018-02-14 Thread Paolo Carlini
Hi, today I spent some time on this: basing on r245826, when we started ICEing. For example I wondered if we wanted to rework the use of do_auto_deduction from build_new, and check CLASS_PLACEHOLDER_TEMPLATE (auto_node) and possibly directly call do_class_deduction when d_init stays

wwwdocs: An additional release note for powerpc for GCC 8

2018-02-14 Thread Kelvin Nilsen
Is this revision to the existing draft GCC 8 release notes ok for commit? Thanks ? cvs.diffs Index: htdocs/gcc-8/changes.html === RCS file: /cvs/gcc/wwwdocs/htdocs/gcc-8/changes.html,v retrieving revision 1.36 diff -u -3 -p

Re: [PATCH, rs6000] (v2) PR84220 remove RS6000_BTI_NOT_OPAQUE refs from builtins table

2018-02-14 Thread Will Schmidt
On Wed, 2018-02-14 at 04:53 -0600, Segher Boessenkool wrote: > Hi! > > On Tue, Feb 13, 2018 at 05:40:08PM -0600, Will Schmidt wrote: > > Some of our builtin definitions were allowing invalid parameters, and a > > subsequent ICE (on invalid code) were the result. This is due to the use of > >

Re: [PATCH, rs6000] PR84220 fix altivec_vec_sld and vec_sldw intrinsic definitions

2018-02-14 Thread Bill Schmidt
> On Feb 13, 2018, at 5:28 PM, Will Schmidt wrote: > > On Thu, 2018-02-08 at 17:48 -0600, Segher Boessenkool wrote: >> Hi! >> >> On Wed, Feb 07, 2018 at 09:14:59AM -0600, Will Schmidt wrote: >>> Our VEC_SLD definitions were mistakenly allowing the third argument to

Re: [PATCH] diagnose specializations of deprecated templates (PR c++/84318)

2018-02-14 Thread Jason Merrill
On Wed, Feb 14, 2018 at 10:18 AM, Martin Sebor wrote: > On 02/13/2018 10:28 PM, Jason Merrill wrote: >> On Tue, Feb 13, 2018 at 5:20 PM, Martin Sebor wrote: >>> On 02/13/2018 01:09 PM, Jason Merrill wrote: On Tue, Feb 13, 2018 at 2:59 PM, Martin Sebor

Re: [Patch, Fortran, F08] PR 84313: reject procedure pointers in COMMON blocks

2018-02-14 Thread Janus Weil
>>> Adding ! { dg-additional-options "-std=f2003" } >>> doesn't work, because the test uses >>> call abort > > I actually think we should get rid of such extensions in the > testsuite, where possible. This particular one is used all over the > place, but could be easily replaces by something

Re: [PATCH] __VA_OPT__ fixes (PR preprocessor/83063, PR preprocessor/83708)

2018-02-14 Thread Jason Merrill
On 01/10/2018 07:04 AM, Jakub Jelinek wrote: I've also cross-checked the libcpp implementation with this patch against trunk clang which apparently also implements __VA_OPT__ now, on the testcases included here the output is the same and on their macro_vaopt_expand.cpp testcase, if I remove all

Re: wwwdocs: An additional release note for powerpc for GCC 8

2018-02-14 Thread Segher Boessenkool
On Wed, Feb 14, 2018 at 09:06:55AM -0600, Kelvin Nilsen wrote: > > Is this revision to the existing draft GCC 8 release notes ok for > commit? That looks fine to me, thanks! Segher > --- htdocs/gcc-8/changes.html 12 Feb 2018 07:23:11 - 1.36 > +++ htdocs/gcc-8/changes.html 14 Feb

[C++ PATCH]: instantiation via vtable marking

2018-02-14 Thread Nathan Sidwell
We had encountered a bogus warning about class visibility. Namely a lambda had captured a variable whose type was in the anonymous namespace. The problem was that in_main_input_context was returning false (i.e. we're in a header file), as that was the location of the outermost template

Re: [PATCH] adjust warning_n() to take uhwi (PR 84207)

2018-02-14 Thread Martin Sebor
On 02/13/2018 02:05 PM, Joseph Myers wrote: On Mon, 12 Feb 2018, Martin Sebor wrote: Bug 84207 - Hard coded plural in gimple-fold.c points out one of a number of warning_at() calls where warning_n() should have been used. The attached patch both replaces the calls and also changes the

Re: [PATCH 0/5] Make std::future::wait_* use std::chrono::steady_clock when required

2018-02-14 Thread Mike Crowe
On Sunday 14 January 2018 at 20:44:10 +, Mike Crowe wrote: > On Sunday 14 January 2018 at 16:08:09 +, Mike Crowe wrote: > > Hi Torvald, > > > > Thanks for reviewing this change. > > > > On Saturday 13 January 2018 at 16:29:57 +0100, Torvald Riegel wrote: > > > On Sun, 2018-01-07 at 20:55

[PATCH] MPX and CET changes in release notes

2018-02-14 Thread Tsimbalist, Igor V
MPX is going to be deprecated in gcc-8. Control-flow protection support is in gcc-8. Reflect these in Release Notes for gcc-8. Ok for trunk? Igor Index: changes.html === RCS file: /cvs/gcc/wwwdocs/htdocs/gcc-8/changes.html,v

RFA: PATCH to build_type_attribute_qual_variant for c++/84314, ICE with fastcall

2018-02-14 Thread Jason Merrill
This testcase involves a fastcall-qualified function type. During mangling, we use build_type_attribute_qual_variant to look up an attribute-unqualified version of that type. build_type_attribute_qual_variant calls type_hash_canon and finds the original unqualified type, but then clobbers its

Re: [PATCH] jit: fix link on OS X and Solaris (PR jit/64089 and PR jit/84288)

2018-02-14 Thread FX
> Does this fix the jit linker issues on OS X and Solaris? The patch fails to bootstrap on x86_64-apple-darwin17. gcc/config.log says: gcc_cv_ld_version_script=no ld_version_script_option='--version-script’ gcc/Makefile says: LD_VERSION_SCRIPT_OPTION = --version-script LD_SONAME_OPTION =

Patch ping

2018-02-14 Thread Jakub Jelinek
Hi! I'd like to ping these patches: PR84146 fix -fcompare-debug issues with -mcet -fcf-protection=full http://gcc.gnu.org/ml/gcc-patches/2018-02/msg00390.html PR83708 __VA_OPT__ assorted fixes http://gcc.gnu.org/ml/gcc-patches/2018-01/msg00727.html Thanks Jakub

Re: [PATCH] adjust warning_n() to take uhwi (PR 84207)

2018-02-14 Thread Joseph Myers
On Wed, 14 Feb 2018, Martin Sebor wrote: > I was also hoping to test it, either now if it's easy, or if > it's complicated, sometime in the future but I couldn't find > a .po file where it would make a difference. I could have > easily missed one but none of those I've looked seems to do > much

[PATCH] CET shouldn't be enabled in 32-bit run-time libraries by defualt

2018-02-14 Thread Tsimbalist, Igor V
ENDBR32 and RDSSPD are multi-byte NOPs on x86-64 processors and newer x86 processors, starting Pentium Pro. They are UD on older 32-bit processors. Detect this at configure time and adjust the default value for enable_cet. GCC will enable CET in 32-bit run-time libraries in any case if

Re: [PATCH] Handle PowerPC64 ELFv1 function descriptors in libbacktrace (PR other/82368)

2018-02-14 Thread Ian Lance Taylor
On Wed, Feb 14, 2018 at 3:41 AM, Jakub Jelinek wrote: > > As mentioned in detail in the PR, PowerPC64 ELFv1 function symbols > point to function descriptors in .opd section rather than actual > code, and one needs to read the code address from the .opd section > in order to

Re: [PATCH rs6000] Fix for builtins-4-int128-runnable.c

2018-02-14 Thread Segher Boessenkool
Hi Carl, On Wed, Feb 14, 2018 at 11:09:09AM -0800, Carl Love wrote: > The following patch contains fixes an issue with the 128-bit test on > Power 7. Power 7 does not support int128 so the test must be > restricted to run on Power 8 and later. > 2018-02-14 Carl Love (blank

[committed, hppa] Fix loading of PIC labels

2018-02-14 Thread John David Anglin
The attached patch fixes the compilation of pr81687-2.c in the libgomp testsuite. Typically, when labels are "close" on hppa, it is best to load the address of the label in PIC code using a pc-relative sequence.  The code generated for pr81687-2.c is an example where the label and the

Re: [Patch, Fortran, F03] PR 84385: Reject invalid SELECT TYPE selector (allocate_with_source_22.f03)

2018-02-14 Thread Janus Weil
2018-02-14 22:16 GMT+01:00 Steve Kargl : > On Wed, Feb 14, 2018 at 10:10:09PM +0100, Janus Weil wrote: >> >> Regtests cleanly on x86_64-linux-gnu. Ok for trunk? >> > > Looks okay to me with two question below. > >> Index: gcc/fortran/match.c >>

[PATCH] Fix endless match.pd recursion on cst1 + cst2 + cst3 (PR tree-optimization/84334, take 2)

2018-02-14 Thread Jakub Jelinek
On Tue, Feb 13, 2018 at 07:04:09PM +0100, Richard Biener wrote: > On February 13, 2018 6:51:29 PM GMT+01:00, Jakub Jelinek > wrote: > >On the following testcase, we recurse infinitely, because > >we have float re-association enabled, but also rounding-math, so > >we try to

[Patch, Fortran, F03] PR 84385: Reject invalid SELECT TYPE selector (allocate_with_source_22.f03)

2018-02-14 Thread Janus Weil
Hi all, here is another small patch that fixes two invalid test cases in the test suite and also fixes the check that was supposed to reject these cases (but failed). Regtests cleanly on x86_64-linux-gnu. Ok for trunk? Cheers, Janus 2018-02-14 Janus Weil PR

Re: [Patch, Fortran, F03] PR 84385: Reject invalid SELECT TYPE selector (allocate_with_source_22.f03)

2018-02-14 Thread Steve Kargl
On Wed, Feb 14, 2018 at 10:10:09PM +0100, Janus Weil wrote: > > Regtests cleanly on x86_64-linux-gnu. Ok for trunk? > Looks okay to me with two question below. > Index: gcc/fortran/match.c > === > --- gcc/fortran/match.c

[Patch] Minor GCC documentation correction for -Wformat-overflow

2018-02-14 Thread Indu Bhagat
In section "-Wformat-overflow=1", following is stated : void f (int a, int b) { char buf [12]; sprintf (buf, "a = %i, b = %i\n", a, b); } " Increasing the size of the buffer by a single byte is sufficient to avoid the warning," [size of an unknown int for the purpose of this warning is = 1

Re: [gcc-7 backport PATCH, rs6000/PR84388] fix fold-vec-mult-int128 testcases

2018-02-14 Thread Peter Bergner
On 2/14/18 4:47 PM, Will Schmidt wrote: > -/* { dg-options "-maltivec -mvsx -mpower8-vector" } */ > +/* { dg-options "-mpower8-vector -mcpu=power8 -O2" } */ [snip] > -/* { dg-options "-maltivec -mvsx -mcpu=power9 -O2" } */ > +/* { dg-options "-mpower9-vector -mcpu=power9 -O2" } */ As we

Re: [gcc-7 backport PATCH, rs6000/PR84388] fix fold-vec-mult-int128 testcases

2018-02-14 Thread Segher Boessenkool
On Wed, Feb 14, 2018 at 04:47:56PM -0600, Will Schmidt wrote: > This backports some testcase fixes to the gcc7 branch. The testcases > touched here would now match their gcc-trunk equivalents. > > OK for gcc-7 ? Sure, thanks! But see other thread... Segher > 2018-02-14 Will Schmidt

Re: [gcc-7 backport PATCH, rs6000/PR84388] fix fold-vec-mult-int128 testcases

2018-02-14 Thread Segher Boessenkool
On Wed, Feb 14, 2018 at 05:02:19PM -0600, Peter Bergner wrote: > On 2/14/18 4:47 PM, Will Schmidt wrote: > > -/* { dg-options "-maltivec -mvsx -mpower8-vector" } */ > > +/* { dg-options "-mpower8-vector -mcpu=power8 -O2" } */ > > [snip] > > > -/* { dg-options "-maltivec -mvsx -mcpu=power9 -O2" }

update LTO test harness README

2018-02-14 Thread Martin Sebor
I was excited to find out about the recent enhancement to the LTO test harness to support the new dg-lto-warning and dg-lto-message directives (thanks, David). To make them easier to find and use (there is a C++ LTO test that uses them but no C tests yet) the attached patch updates the README to

Re: [PATCH][i386][3/3] PR target/84164: Make *cmpqi_ext_ patterns accept more zero_extract modes

2018-02-14 Thread Kyrill Tkachov
On 13/02/18 16:45, Jeff Law wrote: On 02/09/2018 07:50 AM, Kyrill Tkachov wrote: Hi Uros, On 08/02/18 22:54, Uros Bizjak wrote: On Thu, Feb 8, 2018 at 6:11 PM, Kyrill Tkachov wrote: Hi all, This patch fixes some fallout in the i386 testsuite that occurs after

[PATCH, rs6000] Add builtin support for vec_insert4b, vec_extract4b

2018-02-14 Thread Carl Love
GCC maintainers: Per Segher's comments on the first version of the patch. I split the patch into two. The first patch (this one) adds the ABI specified vec_insert4b and vec_extract builtins.  It adds a runnable file to test the ABI specified builtin instances. Note, the runnable test file does

[PATCH, rs6000] Remove non-ABI builtin support for vec_insert4b, vec_extract4b

2018-02-14 Thread Carl Love
GCC maintainers: This is the second patch that removes the non-ABI vec_insert4b and vec_extract4b builtin support. It also removes the two existing test files for the non-ABI builtin instances. A runnable test file for the ABI specified builtins was added by the first patch. This patch has

Re: [PATCH] adjust warning_n() to take uhwi (PR 84207)

2018-02-14 Thread Pedro Alves
On 02/13/2018 10:37 PM, Martin Sebor wrote: > On 02/13/2018 01:59 PM, Manuel López-Ibáñez wrote: >> > Here's a sketch of what I tried to do: > >   struct IntegerConverter >   { >     union { >   tree t; >   unsigned HOST_WIDE_INT hwi; >   // buffer for offset_int, wide_int, etc. >    

Re: [PATCH rs6000] Fix for builtins-4-int128-runnable.c

2018-02-14 Thread Peter Bergner
On 2/14/18 1:09 PM, Carl Love wrote: > The following patch contains fixes an issue with the 128-bit test on > Power 7. Power 7 does not support int128 so the test must be > restricted to run on Power 8 and later. To be pedantic, GCC POWER7 supports __int128_t just fine (in 64-bit mode). It

[PATCH, rs6000, committed] Fix PR84390: test case gcc.target/powerpc/vsxcopy.c fails for gcc 7 and gcc 6 on power9

2018-02-14 Thread Peter Bergner
This had already been fixed on trunk and just needed back porting to the release branches. Committed as obvious. Peter PR target/84390 * gcc.target/powerpc/vsxcopy.c: Also match lxv when compiling with -mcpu=power9. Index: gcc/testsuite/gcc.target/powerpc/vsxcopy.c

[PATCH rs6000] Fix for builtins-4-int128-runnable.c

2018-02-14 Thread Carl Love
GCC maintainers: The following patch contains fixes an issue with the 128-bit test on Power 7. Power 7 does not support int128 so the test must be restricted to run on Power 8 and later. The change was tested by hand on a Power 8 machine with the command: make -k check-gcc

Re: patch for PR84359

2018-02-14 Thread Uros Bizjak
> The following patch fixes > > https://gcc.gnu.org/bugzilla/show_bug.cgi?id=84359 > > Committed as rev. 257628. > > > Index: testsuite/gcc.target/i386/pr57193.c > === > --- testsuite/gcc.target/i386/pr57193.c (revision 257537) >

Re: [PATCH] adjust warning_n() to take uhwi (PR 84207)

2018-02-14 Thread Manuel López-Ibáñez
On 14 Feb 2018 8:16 pm, "Pedro Alves" wrote: Instead of a class that has to have a constructor for every type you want to pass as plural selector to the _n functions, which increases coupling, I'd suggest using a conversion function, and overload that. I.e., something like,

Re: [Patch, Fortran, F03] PR 84385: Reject invalid SELECT TYPE selector (allocate_with_source_22.f03)

2018-02-14 Thread Janus Weil
2018-02-14 22:30 GMT+01:00 Janus Weil : > 2018-02-14 22:16 GMT+01:00 Steve Kargl : >> On Wed, Feb 14, 2018 at 10:10:09PM +0100, Janus Weil wrote: >>> >>> Regtests cleanly on x86_64-linux-gnu. Ok for trunk? >>> >> >> Looks okay to me with two

Re: [PATCH] MPX and CET changes in release notes

2018-02-14 Thread Gerald Pfeifer
Hi Igor, On Wed, 14 Feb 2018, Tsimbalist, Igor V wrote: > MPX is going to be deprecated in gcc-8. Control-flow protection support > is in gcc-8. Reflect these in Release Notes for gcc-8. thanks for this update. Only some minor changes, then this is good to go. >> >> A new option

Re: [PATCH] adjust warning_n() to take uhwi (PR 84207)

2018-02-14 Thread Pedro Alves
On 02/14/2018 09:47 PM, Manuel López-Ibáñez wrote: > On 14 Feb 2018 8:16 pm, "Pedro Alves" > wrote: > > Instead of a class that has to have a constructor for every type > you want to pass as plural selector to the _n functions, which >

[gcc-7 backport PATCH, rs6000/PR84388] fix fold-vec-mult-int128 testcases

2018-02-14 Thread Will Schmidt
Hi, This backports some testcase fixes to the gcc7 branch. The testcases touched here would now match their gcc-trunk equivalents. OK for gcc-7 ? Thanks, -Will [testsuite] 2018-02-14 Will Schmidt PR target/84388 *

[PATCH] Fix up compound literal handling in C FE (PR sanitizer/84307)

2018-02-14 Thread Jakub Jelinek
On Tue, Feb 13, 2018 at 03:40:20PM +0100, Jakub Jelinek wrote: > BTW, your testcase shows a more severe problem, that we actually don't > handle compound literals correctly. > > C99 says that: > "If the compound literal occurs outside the body of a function, the object > has static storage

Re: [PATCH] combine: Update links correctly for new I2 (PR84169)

2018-02-14 Thread Jakub Jelinek
On Mon, Feb 12, 2018 at 03:59:05PM +, Segher Boessenkool wrote: > 2018-02-12 Segher Boessenkool > > PR rtl-optimization/84169 > * combine.c (try_combine): New variable split_i2i3. Set it to true if > we generated a parallel as new i3 and we

Re: [PATCH] Fix up compound literal handling in C FE (PR sanitizer/84307)

2018-02-14 Thread Joseph Myers
On Wed, 14 Feb 2018, Jakub Jelinek wrote: > 2018-02-13 Jakub Jelinek > > PR sanitizer/84340 > * c-decl.c (build_compound_literal): Call pushdecl (decl) even when > it is not TREE_STATIC. > * c-typeck.c (c_mark_addressable) : Mark > not just the

Re: [PATCH] jit: fix link on OS X and Solaris (PR jit/64089 and PR jit/84288)

2018-02-14 Thread FX
I can confirm that, with the attached revised patch, a bootstrap with --enable-languages=c,c++,jit --enable-host-shared is successful on macOS. FX patch Description: Binary data

RE: PR84239, Reimplement CET intrinsics for rdssp/incssp insn

2018-02-14 Thread Joseph Myers
This patch has broken bootstrap of a cross toolchain for x86_64 (the case where inhibit_libc is defined because there is no libc for the target available at that stage in the bootstrap process). In file included from

[PATCH] Fix LRA ICE in lra_substitute_pseudo on DEBUG_INSN (PR rtl-optimization/83723)

2018-02-14 Thread Jakub Jelinek
Hi! Unlike normal insns where SUBREGs must properly validate, in DEBUG_INSNs we allow arbitrary SUBREGs, either the dwarf2out code will be able to use it, or it will just punt. The reason for it is among other things that during analysis we usually need to ignore debug insns, so can't reject

[PATCH] Fix ICE in maybe_diag_stxncpy_trunc (PR tree-optimization/84383)

2018-02-14 Thread Jakub Jelinek
Hi! The function calls get_addr_base_and_unit_offset on 2 trees, but that can return NULL if the unit offset is not constant. The conditional tests just one of them for non-NULL and operand_equal_p ICEs if one argument is NULL, so depending on the uninitialized poly_int64

Re: [Patch] Minor GCC documentation correction for -Wformat-overflow

2018-02-14 Thread Martin Sebor
On 02/14/2018 02:28 PM, Indu Bhagat wrote: In section "-Wformat-overflow=1", following is stated : void f (int a, int b) { char buf [12]; sprintf (buf, "a = %i, b = %i\n", a, b); } " Increasing the size of the buffer by a single byte is sufficient to avoid the warning," [size of an

[PATCH] RISC-V: Change sp subtracts so prologue stores can compress.

2018-02-14 Thread Jim Wilson
This patch changes the initial stack pointer subtraction when we need two subtracts, so that the first stack pointer subtraction allows the register save stores to compress. This is only done for RVC targets, and only when it doesn't change the number of instructions required. A follow on patch

Re: [PATCH][i386][3/3] PR target/84164: Make *cmpqi_ext_ patterns accept more zero_extract modes

2018-02-14 Thread Uros Bizjak
On Wed, Feb 14, 2018 at 7:04 PM, Kyrill Tkachov wrote: > > On 13/02/18 16:45, Jeff Law wrote: >> >> On 02/09/2018 07:50 AM, Kyrill Tkachov wrote: >>> >>> Hi Uros, >>> >>> On 08/02/18 22:54, Uros Bizjak wrote: On Thu, Feb 8, 2018 at 6:11 PM, Kyrill Tkachov

Re: [PATCH] __VA_OPT__ fixes (PR preprocessor/83063, PR preprocessor/83708)

2018-02-14 Thread Jason Merrill
On 01/10/2018 07:04 AM, Jakub Jelinek wrote: The following patch attempts to fix various issues, including some ICEs, by introducing 3 new states, two of them are alternatives to INCLUDE used for the very first token after __VA_OPT__( , where we want to take into account also flags from the