Checking whether a filesystem::path constructor argument is an iterator
requires instantiating std::iterator_traits. In C++20 that checks for
satisfaction of std::iterator_traits constraints, which checks if the
type is copyable, which can end up recursing back to the path
constructor. The fix in
Hi.
Let's support automatic detection of DRs from test-suite, similarly
what we do for PR entries.
Installed.
Martin
contrib/ChangeLog:
2020-05-21 Martin Liska
* mklog.py: Support DR parsing.
* test_mklog.py: New test for DR parsing.
---
contrib/mklog.py | 9
Am 21.05.20 um 07:53 schrieb H.J. Lu via Fortran:
* m4/matmul.m4: Don't include . Use
__builtin_cpu_is/__builtin_cpu_supports
* generated/matmul_c10.c: Regenerated.
* generated/matmul_c16.c: Likewise.
* generated/matmul_c4.c: Likewise.
*
On Thu, May 21, 2020 at 10:23:38AM +0200, Martin Liška wrote:
> Hi.
>
> The patch understand DR entries in git commit messages and
> preserve them for ChangeLog entries.
Do you handle other free-style comments above the commit?
I mean, especially in gcc/cp/ Jason, Marek and others use something
On Thu, May 21, 2020 at 09:23:47AM +0200, Martin Liška wrote:
> As mentioned in the ovmf project [1], they would like to have a control
> over the -mno-outline-atomics via a function attribute. They struggle
> with configure detection and this can help them to disable the outlining.
>
> Would it
Hi,
Notice a tiny SVE-related performance issue:
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=95254
For the given test case, SLP succeeds with VNx8HImode with or without option
-msve-vector-bits=256.
The root cause for the difference is that we choose a different mode in
Hi.
The patch understand DR entries in git commit messages and
preserve them for ChangeLog entries.
Installed to master.
Martin
contrib/ChangeLog:
2020-05-21 Martin Liska
* gcc-changelog/git_commit.py: Support DR entries/
* gcc-changelog/test_email.py: New test for it.
On Thu, May 21, 2020 at 10:03:37AM +0200, Martin Liška wrote:
> On 5/21/20 9:56 AM, Jakub Jelinek wrote:
> > Can't it be __attribute__((target ("outline-atomics"))) instead?
>
> Ah sorry, I wan unclear.
> It's support the this _target_ attribute which you mentioned.
Ok, better, will defer review
On 5/21/20 1:52 AM, Fangrui Song wrote:
The above issues motivated me to touch this line in PATCH v2.
Dropped in PATCH v2.
Thank you for the updated patch.
The patch is fine except coding style issues:
$ ./contrib/check_GNU_style.py
Hi.
As mentioned in the ovmf project [1], they would like to have a control
over the -mno-outline-atomics via a function attribute. They struggle
with configure detection and this can help them to disable the outlining.
Would it be possible to add the attribute?
Thanks,
Martin
[1]
On 5/21/20 9:56 AM, Jakub Jelinek wrote:
Can't it be __attribute__((target ("outline-atomics"))) instead?
Ah sorry, I wan unclear.
It's support the this _target_ attribute which you mentioned.
Martin
On Mai 20 2020, Nathan Sidwell wrote:
> I'm reverting that change. It is not ready. The first map has a
> different string for the main file name, and we were relying on that not
> equalling the later ones via pointer comparison.
>
> I must have become confused over what tree I was testing.
> Segher Boessenkool writes:
>
> > On Wed, May 20, 2020 at 12:30:30PM +0200, Richard Biener wrote:
> >> I think this is the wrong way to approach this. You're doing too many
> >> things at once. Try to fix the powerpc regression with the extra
> >> flag_rtl_unroll_loops, that could be
Hello Martin.
Can you please compare the current mklog.py. Is there anything
you miss compared to your current script?
Thanks,
Martin
On 5/21/20 10:49 AM, Jakub Jelinek wrote:
On Thu, May 21, 2020 at 10:23:38AM +0200, Martin Liška wrote:
Hi.
The patch understand DR entries in git commit messages and
preserve them for ChangeLog entries.
Do you handle other free-style comments above the commit?
No. Note that the PR (and DR
Jan Hubicka writes:
>> Segher Boessenkool writes:
>>
>> > On Wed, May 20, 2020 at 12:30:30PM +0200, Richard Biener wrote:
>> >> I think this is the wrong way to approach this. You're doing too many
>> >> things at once. Try to fix the powerpc regression with the extra
>> >>
On 5/18/20 1:49 PM, Richard Biener wrote:
On Mon, May 18, 2020 at 1:10 PM Jakub Jelinek via Gcc-patches
wrote:
On Mon, May 18, 2020 at 01:03:40PM +0200, Jakub Jelinek wrote:
The optimize attribute is used to specify that a function is to be compiled
with different optimization options than
Hi,
this patch saves few bytes from SCC streaming. First we stream end markers
that are fully ignored at stream in.
Second I missed streaming of emtry_len in the previous change so it is
pointlessly streamed for LTO_trees. Moreover entry_len is almost always 1
(always during gcc bootstrap) and
Hi.
I've just installed changed that are prepared for script usage
at server.
Martin
contrib/ChangeLog:
2020-05-21 Martin Liska
* gcc-changelog/git_update_version.py: Prepare the script, the
only missing piece is pushing of the updated branches.
---
On 5/21/20 12:11 PM, Richard Sandiford wrote:
Yeah, agree it'd be worth having tests for both directions. The patch
itself looks good though -- thanks for doing this.
Thanks. There's a version with 2 new tests that I've just tested.
I'm going to install the patch for master. Is it also fine
Hi,
this patch seems to solve basically all collisions while building cc1.
From:
[WPA] read 3312246 unshared trees
[WPA] read 1144381 mergeable SCCs of average size 4.833785
[WPA] 8843938 tree bodies read in total
[WPA] tree SCC table: size 524287, 197767 elements, collision ratio: 0.506446
[WPA]
On Thu, May 21, 2020 at 7:35 AM Hongtao Liu wrote:
>
> On Wed, May 20, 2020 at 11:43 PM Uros Bizjak wrote:
> >
> > On Wed, May 20, 2020 at 10:35 AM Hongtao Liu wrote:
> > >
> > > Hi:
> > > Bootstrap is ok, regression test on i386/x86-64 backend is ok.
> > >
> > > gcc/ChangeLog:
> > >
Jakub Jelinek via Gcc-patches writes:
> On Thu, May 21, 2020 at 10:03:37AM +0200, Martin Liška wrote:
>> On 5/21/20 9:56 AM, Jakub Jelinek wrote:
>> > Can't it be __attribute__((target ("outline-atomics"))) instead?
>>
>> Ah sorry, I wan unclear.
>> It's support the this _target_ attribute which
On 5/18/20 10:37 PM, Martin Sebor wrote:
I know there are some somewhat complex cases the attribute exclusion
mechanism isn't general enough to handle but this seems simple enough
that it should work. Unless I'm missing something that makes it not
feasible I would suggest to use it.
Hi
On 5/18/20 5:56 PM, Florian Weimer via Gcc-patches wrote:
* Michael Matz:
So does -fcf-protection. -fno-omit-frame-pointer does not work for me at
all for some reason, the frame pointer is always missing?
Not for me:
I see. I didn't know that -fno-omit-frame-pointer only applies to
"Yangfei (Felix)" writes:
> Hi,
>
> Notice a tiny SVE-related performance issue:
> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=95254
>
> For the given test case, SLP succeeds with VNx8HImode with or without
> option -msve-vector-bits=256.
> The root cause for the difference is that we
On Tue, May 19, 2020 at 2:38 PM Uros Bizjak wrote:
>
> On Tue, May 19, 2020 at 11:37 PM H.J. Lu wrote:
> >
> > Add FEATURE_AVX512VP2INTERSECT to libgcc so that enum processor_features
> > in libgcc matches enum processor_features in i386-builtins.c. Update
> > GFNI check to support processors
On 5/20/20 1:49 PM, Jan Hubicka wrote:
On related note, I remember us discussing that std compression has
problem with bigger headers then zlib. Since we stream our header that
says if section is compressed, I wonder if we could teach stream-out
phase to skip compression if it is not benefical,
On Thu, 2020-05-21 at 17:35 +0200, Romain Naour wrote:
> As reported by several Buildroot users [1][2][3], the gcc build
> may fail while running selftests makefile target.
>
> The problem only occurs when ccache is used with gcc 9 and 10,
> probably due to a race condition.
>
> While debuging
On Tue, May 19, 2020 at 2:26 AM Martin Liška wrote:
>
> We've just installed server git hooks that verify git messages
> for a correct ChangeLog format. For a limited time period, please
> still apply ChangeLog changes to the corresponding ChangeLog files.
> We'll use it for comparison of
On 5/21/20 11:01 PM, Jason Merrill wrote:
Why? What is the use of requiring ChangeLog entries at all for these changes?
I must confirm a common test-suite ChangeLog entry is something like:
$ grep ':' gcc/testsuite/ChangeLog | sed 's/.*://' | sort | uniq -c | sort -n |
tac | head -n 15
On Fri, May 15, 2020 at 11:39 AM Martin Liška wrote:
>
> On 5/15/20 3:22 PM, Marek Polacek wrote:
> > On Fri, May 15, 2020 at 03:12:27PM +0200, Martin Liška wrote:
> >> On 5/15/20 2:42 PM, Marek Polacek wrote:
> >>> I actually use mklog -i all the time. But I can work around it if it
> >>>
On May 19, 2020, Richard Biener wrote:
> On Tue, 19 May 2020, Alexandre Oliva wrote:
>> I've refreshed the patch, approved back on Jan 22 for gcc-11, in
>> refs/users/aoliva/heads/aux-dump-revamp, and committed 3 other related
>> patches on top of it, that I hope to get approved for folding and
Jiufu Guo writes:
> Jan Hubicka writes:
>
>>> Segher Boessenkool writes:
>>>
>>> > On Wed, May 20, 2020 at 12:30:30PM +0200, Richard Biener wrote:
>>> >> I think this is the wrong way to approach this. You're doing too many
>>> >> things at once. Try to fix the powerpc regression with the
On Thu, May 21, 2020 at 4:27 PM Martin Liška wrote:
> On 5/21/20 9:51 PM, Jason Merrill wrote:
> > Modified. Adjustments to expected errors in testcases don't seem to me
> worth documenting in a ChangeLog.
>
> I see. As Jakub mentioned, I would keep the hook stricter for now.
>
Why? What is
This is on top of the stdbool.h and stdint.h patches.
This adds a flag to c_parser so we know when we were trying to
constract a string literal. If there is a parse error and we were
constructing a string literal, and the next token is an unknown
identifier name, and we know there is a standard
On Thu, May 21, 2020 at 03:12:21PM -0700, Ian Lance Taylor via Gcc wrote:
> Hi, this unfortunately breaks gccgo development. Significant parts of
> the gccgo sources are simply copied from other repositories. Those
> other repositories do not use ChangeLog files. The git commit hook
> should
On 2020-05-21, Martin Liška wrote:
On 5/21/20 1:52 AM, Fangrui Song wrote:
The above issues motivated me to touch this line in PATCH v2.
Dropped in PATCH v2.
Thank you for the updated patch.
The patch is fine except coding style issues:
$ ./contrib/check_GNU_style.py
On Thu, May 21, 2020 at 7:18 PM Uros Bizjak wrote:
>
> On Thu, May 21, 2020 at 7:35 AM Hongtao Liu wrote:
> >
> > On Wed, May 20, 2020 at 11:43 PM Uros Bizjak wrote:
> > >
> > > On Wed, May 20, 2020 at 10:35 AM Hongtao Liu wrote:
> > > >
> > > > Hi:
> > > > Bootstrap is ok, regression test
On Wed, May 20, 2020 at 4:21 AM H.J. Lu wrote:
>
> On Tue, May 19, 2020 at 11:10 PM Uros Bizjak wrote:
> >
> > On Tue, May 19, 2020 at 11:40 PM H.J. Lu wrote:
> >
> > > > > > > > > > I will take a look to see if we share the same CPU
> > > > > > > > > > detection code between
> > > > > > > > >
Hi!
On Thu, May 21, 2020 at 03:29:49PM +0200, Martin Liška wrote:
> Adding Segher to CC, he can help us.
Oh dear. Are you sure?
> On 5/21/20 2:51 PM, Martin Liška wrote:
> >Back to this I noticed that ppc64le target build is broken due to:
> >insn-emit.o -MMD -MP -MF ./.deps/insn-emit.TPo
On Thu, May 21, 2020 at 9:22 AM Martin Liška wrote:
>
> Hi.
>
> Similarly to:
>
> case OPT_mstrict_align:
>if (val)
> opts->x_target_flags |= MASK_STRICT_ALIGN;
>else
> opts->x_target_flags &= ~MASK_STRICT_ALIGN;
>return true;
>
> the
On Thu, 2020-05-21 at 19:31 +0200, Richard Biener via Gcc-patches wrote:
> On May 21, 2020 5:35:19 PM GMT+02:00, Romain Naour via Gcc-patches <
> gcc-patches@gcc.gnu.org> wrote:
> > As reported by several Buildroot users [1][2][3], the gcc build
> > may fail while running selftests makefile
If a parameter is erroneous, we currently drop it, leading to "too many
arguments" errors later. Treating the function as (...) avoids those
errors.
Tested x86_64-pc-linux-gnu, applying to trunk.
gcc/cp/ChangeLog
2020-05-21 Jason Merrill
* decl.c (grokparms): Return NULL_TREE if any
In a template we were happily embedding error_mark_node in a MODOP_EXPR,
leading to confusion later.
Tested x86_64-pc-linux-gnu, applying to trunk.
gcc/cp/ChangeLog
2020-05-21 Jason Merrill
* typeck.c (build_x_modify_expr): Handle error_mark_node arguments.
---
gcc/cp/typeck.c
We give a better diagnostic for non-constant array bounds in
compute_array_index_type_loc, we don't need to diagnose it in the parser.
But to avoid a regression on parse/varmod1.C we need to actually check
non-dependent expressions in a template.
Tested x86_64-pc-linux-gnu, applying to trunk.
The difference between a "potential" constant-expression and a regular
constant-expression is the treatment of parameters; in a constexpr function,
a parameter is potentially constant when evaluating a call to that function,
but it is not constant during parsing of the function.
Ah, you are right. Please forget about this patch
mgeneral-regs-only
Target Report RejectNegative Mask(GENERAL_REGS_ONLY) Save
also contains the RejectNegative keyword.
Martin
Was there a decision somewhere to require ChangeLog entries for all
testcase changes now, as the hook is enforcing? They were optional before.
remote: *** ChangeLog format failed:
remote: ERR: changed file not mentioned in a
ChangeLog:"gcc/testsuite/g++.dg/parse/error33.C"
On Thu, May 21, 2020
On Thu, 21 May 2020, Jonathan Wakely wrote:
On 27/04/20 17:09 +0200, Matthias Kretz wrote:
From: Matthias Kretz
PR libstdc++/84949
* include/std/limits: Let is_iec559 reflect whether
__GCC_IEC_559 says float and double support IEEE 754-2008.
*
On 21/05/20 17:46 +0200, Marc Glisse wrote:
On Thu, 21 May 2020, Jonathan Wakely wrote:
On 27/04/20 17:09 +0200, Matthias Kretz wrote:
From: Matthias Kretz
PR libstdc++/84949
* include/std/limits: Let is_iec559 reflect whether
__GCC_IEC_559 says float and double support
On May 21, 2020 5:35:19 PM GMT+02:00, Romain Naour via Gcc-patches
wrote:
>As reported by several Buildroot users [1][2][3], the gcc build
>may fail while running selftests makefile target.
>
>The problem only occurs when ccache is used with gcc 9 and 10,
>probably due to a race condition.
Just
On Thu, May 21, 2020 at 2:58 PM Martin Liška wrote:
> On 5/21/20 8:52 PM, Jason Merrill wrote:
> > Was there a decision somewhere to require ChangeLog entries for all
> testcase changes now, as the hook is enforcing? They were optional before.
>
> Right now we ignore newly added test-case,
On 5/21/20 9:51 PM, Jason Merrill wrote:
Modified. Adjustments to expected errors in testcases don't seem to me worth
documenting in a ChangeLog.
I see. As Jakub mentioned, I would keep the hook stricter for now.
Martin
Hi Martin
> -Original Message-
> From: Martin Liška
> Sent: 21 May 2020 16:01
> To: gcc-patches@gcc.gnu.org
> Cc: Sudakshina Das
> Subject: [PATCH] Fix handling of OPT_mgeneral_regs_only in attribute.
>
> Hi.
>
> Similarly to:
>
> case OPT_mstrict_align:
>if (val)
>
On Thu, May 21, 2020 at 02:52:37PM -0400, Jason Merrill wrote:
> Was there a decision somewhere to require ChangeLog entries for all
> testcase changes now, as the hook is enforcing? They were optional before.
>
> remote: *** ChangeLog format failed:
> remote: ERR: changed file not mentioned in
On 5/21/20 8:52 PM, Jason Merrill wrote:
Was there a decision somewhere to require ChangeLog entries for all testcase
changes now, as the hook is enforcing? They were optional before.
Right now we ignore newly added test-case, these don't have to be mentioned.
Can you please attach the patch
Hi
I got a bit over-zealous in the attempt to make better use of the higher-
level APIs in the c++ FE, this reverts that part of the change,
Tested on x86_64-darwin,
applied to master,
thanks
Iain
co_returns are statements, not expressions; they do not need
to be wrapped in an
Hi.
Back to this I noticed that ppc64le target build is broken due to:
g++ -fno-PIE -c -g -DIN_GCC -DCROSS_DIRECTORY_STRUCTURE -fno-exceptions
-fno-rtti -fasynchronous-unwind-tables -W -Wall -Wno-narrowing -Wwrite-strings
-Wcast-qual -Wmissing-format-attribute -Woverloaded-virtual
Add -mavx512vpopcntdq for -march=native if AVX512VPOPCNTDQ is available.
PR target/95258
* config/i386/driver-i386.c (host_detect_local_cpu): Detect
AVX512VPOPCNTDQ.
---
gcc/config/i386/driver-i386.c | 9 ++---
1 file changed, 6 insertions(+), 3 deletions(-)
diff
Hi.
It fixes:
./gcc/xgcc -Bgcc
/home/marxin/Programming/gcc/gcc/testsuite/g++.target/i386/pr95229.C -c -O3
-march=znver1 -Werror -std=gnu++98
/home/marxin/Programming/gcc/gcc/testsuite/g++.target/i386/pr95229.C:13:3: error:
unnamed type with no linkage used to declare variable ‘ e’ with
On 23/04/20 12:58 +0200, Matthias Kretz wrote:
I noticed this inconvenience while learning dejagnu.
From: Matthias Kretz
* testsuite/Makefile.am: Remove dup target_triplet and set tool,
allowing runtest to work without arguments.
Committed to master, thanks.
PING^1
On 3/20/20 4:55 PM, Martin Liška wrote:
Ok, it would be possible, but if you take a look at options-save.c there's no
function that will leverage that. It's a generated code so I guess we can
live with that?
On 5/21/20 4:02 AM, Andreas Schwab wrote:
On Mai 20 2020, Nathan Sidwell wrote:
I'm reverting that change. It is not ready. The first map has a
different string for the main file name, and we were relying on that not
equalling the later ones via pointer comparison.
I must have become
On 07/05/20 09:12 +0200, François Dumont via Libstdc++ wrote:
   This patch purpose is to make sure that existing
std::copy/std::copy_n overloads for char* will also be used for
std::deque iterators when dealing with istreambuf_iterator. It
also make sure that it still works when
On Thu, 2020-05-21 at 00:48 +0200, Mark Wielaard wrote:
> Hi,
>
> On Mon, May 18, 2020 at 07:30:58PM -0400, Marek Polacek wrote:
> > > + /* Returns a replacement function as text if it
> > > exists. Currently
> > > + only "exit" has a signal-safe replacement "_exit", which
> > > does
> > >
On May 21, 2020 1:11:33 PM GMT+02:00, Jan Hubicka wrote:
>Hi,
>this patch saves few bytes from SCC streaming. First we stream end
>markers
>that are fully ignored at stream in.
>Second I missed streaming of emtry_len in the previous change so it is
>pointlessly streamed for LTO_trees. Moreover
Adding Segher to CC, he can help us.
Martin
On 5/21/20 2:51 PM, Martin Liška wrote:
Hi.
Back to this I noticed that ppc64le target build is broken due to:
g++ -fno-PIE -c -g -DIN_GCC -DCROSS_DIRECTORY_STRUCTURE -fno-exceptions
-fno-rtti -fasynchronous-unwind-tables -W -Wall
Hi Martin,
> We've just installed server git hooks that verify git messages
> for a correct ChangeLog format. For a limited time period, please
> still apply ChangeLog changes to the corresponding ChangeLog files.
> We'll use it for comparison of auto-generated CangeLog entries.
>
> The format is
On 5/21/20 5:14 PM, Rainer Orth wrote:
Hi Martin,
We've just installed server git hooks that verify git messages
for a correct ChangeLog format. For a limited time period, please
still apply ChangeLog changes to the corresponding ChangeLog files.
We'll use it for comparison of auto-generated
As reported by several Buildroot users [1][2][3], the gcc build
may fail while running selftests makefile target.
The problem only occurs when ccache is used with gcc 9 and 10,
probably due to a race condition.
While debuging with "make -p" we can notice that s-selftest-c target
contain only
Hi Martin,
>> two comments:
>>
>> * Can you please avoid the use grey highlighting in that section? Black
>>script on a grey background is already hard to read for someone with
>>reasonable vision. I suspect it will be much harder for
>>vision-impaired people.
>
> You are right, I
Martin Liška writes:
> On 5/21/20 12:11 PM, Richard Sandiford wrote:
>> Yeah, agree it'd be worth having tests for both directions. The patch
>> itself looks good though -- thanks for doing this.
>
> Thanks. There's a version with 2 new tests that I've just tested.
>
> I'm going to install the
Hi.
Similarly to:
case OPT_mstrict_align:
if (val)
opts->x_target_flags |= MASK_STRICT_ALIGN;
else
opts->x_target_flags &= ~MASK_STRICT_ALIGN;
return true;
the MASK_GENERAL_REGS_ONLY mask should be handled the same way.
@Sudakshina: The
Hi Kito,
> Tested and committed with fixes, thanks your review :)
this patch broke SPARC bootstrap:
In file included from ./tm_p.h:4,
from /vol/gcc/src/hg/master/local/gcc/adjust-alignment.c:28:
/vol/gcc/src/hg/master/local/gcc/config/sparc/sparc-protos.h:45:47: error: use
of
Since Intel SDM uses hexadecimal, use hexadecimal in comments.
PR target/95260
* config/i386/cpuid.h: Use hexadecimal in comments.
---
gcc/ChangeLog | 5 +
gcc/config/i386/cpuid.h | 6 +++---
2 files changed, 8 insertions(+), 3 deletions(-)
diff --git
On 27/04/20 17:09 +0200, Matthias Kretz wrote:
From: Matthias Kretz
PR libstdc++/84949
* include/std/limits: Let is_iec559 reflect whether
__GCC_IEC_559 says float and double support IEEE 754-2008.
* testsuite/18_support/numeric_limits/is_iec559.cc: Test IEC559
On 5/21/20 5:28 AM, Martin Liška wrote:
On 5/18/20 10:37 PM, Martin Sebor wrote:
I know there are some somewhat complex cases the attribute exclusion
mechanism isn't general enough to handle but this seems simple enough
that it should work. Unless I'm missing something that makes it not
78 matches
Mail list logo
