[Geany-devel] stash - Re: save documents automatically before compiling

2010-09-22 Thread Nick Treleaven
On Wed, 22 Sep 2010 22:13:56 +1000 Lex Trotman wrote: > > OK, let's keep it simple and just have a global pref. > > Ok, you're gonna have to explain "how to use stash for dummies" then > :-) I don't see how it creates and connects to the widgets. Stash doesn't create widgets. You tell it when t

Re: [Geany-devel] [Patch] : On closing the last tab create new untitled document.

2010-09-21 Thread Nick Treleaven
On Tue, 21 Sep 2010 08:51:30 +1000 Erik de Castro Lopo wrote: > > When opening a project file with project sessions enabled, the first > > tab is always a new document, which shouldn't be there. > > > > Now committed a change with the idle callback. > > Unfortunately, this does work. With this

Re: [Geany-devel] [Patch] : On closing the last tab create new untitled document.

2010-09-20 Thread Nick Treleaven
On Sun, 19 Sep 2010 18:46:47 +1000 Erik de Castro Lopo wrote: > > > > > > Well, the responses are all positive. But I don't think that > > > > > > keybindings.c is the best place for this code. What about writing it > > > > > > as an idle callback from document_remove_page? > > > > > > > > > > A

Re: [Geany-devel] [PATCH] Open files in Geany at the same workspace

2010-09-17 Thread Nick Treleaven
On Wed, 15 Sep 2010 18:07:45 +0100 Nick Treleaven wrote: > On Thu, 9 Sep 2010 20:12:18 +1000 > Erik de Castro Lopo wrote: > > > Attached is a version of this patch updated to apply cleanly against > > SVN HEAD. > > Thanks, applied. I discovered that Geany's ins

Re: [Geany-devel] [Patch] : On closing the last tab create new untitled document.

2010-09-16 Thread Nick Treleaven
On Thu, 16 Sep 2010 08:32:05 +1000 Erik de Castro Lopo wrote: > > > Well, the responses are all positive. But I don't think that > > > keybindings.c is the best place for this code. What about writing it > > > as an idle callback from document_remove_page? > > > > Actually, doesn't even need a c

Re: [Geany-devel] [PATCH 14/19] Rewrite tab switching queue

2010-09-16 Thread Nick Treleaven
On Wed, 15 Sep 2010 21:34:52 +0200 Jiří Techet wrote: > > Thanks, I'd like to commit this now. I realize it's been a while, but > > the patch doesn't apply cleanly and I can't see any commits since that > > would have caused conflicts. Any chance you could update and resubmit > > please? > > Hi

Re: [Geany-devel] [PATCH 05/19] Don't be annoying when not necessary

2010-09-16 Thread Nick Treleaven
On Wed, 15 Sep 2010 23:15:05 +0200 Colomban Wendling wrote: > >> When reloading a file with ctrl+R don't display the warning dialog > >> that the unsaved changes might be lost when the file has not been > >> modified. > > > > I've been running with this patch for about a week. Looks good to me.

[Geany-devel] regex autoindentation - Re: [PATCH 14/19] Rewrite tab switching queue

2010-09-16 Thread Nick Treleaven
On Thu, 16 Sep 2010 10:23:41 +1000 Lex Trotman wrote: > By the way, the last > > commit in my tree performes indentation based on regex matching as I > > was proposing some time ago. I haven't published it yet because there > > are already quite many of my patches pending here and I want them to

Re: [Geany-devel] editor context menu - Re: Search submenu for editor popup menu

2010-09-16 Thread Nick Treleaven
On Thu, 16 Sep 2010 09:54:09 +1000 Lex Trotman wrote: > >> 2. let the user pick say four most used top level commands since we > >> are *never* going to agree on them.  Use a simplified version of the > >> customise toolbar dialog. > > > > Personally I don't think it's worth doing this. Put the m

Re: [Geany-devel] [PATCH] Open files in Geany at the same workspace

2010-09-15 Thread Nick Treleaven
On Thu, 9 Sep 2010 20:12:18 +1000 Erik de Castro Lopo wrote: > Attached is a version of this patch updated to apply cleanly against > SVN HEAD. Thanks, applied. This is a great improvement IMO :) BTW, the patch code style did not fit with Geany - I fixed it. You might want to read: http://gean

[Geany-devel] insert submenu - Re: editor context menu

2010-09-15 Thread Nick Treleaven
On Wed, 15 Sep 2010 15:33:50 +0100 Nick Treleaven wrote: > > insert > insert submenu including the insert comments > > I think at least me and Enrico use insert comments a lot, we'd like it > to be toplevel. The other insert items could maybe be in a submenu > (

Re: [Geany-devel] [PATCH 19/19] Use per document indent sizes

2010-09-15 Thread Nick Treleaven
On Thu, 5 Aug 2010 01:59:53 +0200 Jiří Techet wrote: > The current implementation doesn't save the indent size to the project and > session file - this can be added if desired. Now added in SVN. Regards, Nick ___ Geany-devel mailing list Geany-devel@

Re: [Geany-devel] [Patch] : On closing the last tab create new untitled document.

2010-09-15 Thread Nick Treleaven
On Tue, 14 Sep 2010 18:03:52 +1000 Erik de Castro Lopo wrote: > Currently, when closing the last tab, I get a geany window without > any text area. > > The attached patch fixes that, by creating a new untitled document > when the last tab is closed. I've been running with this patch > for over a

[Geany-devel] editor context menu - Re: Search submenu for editor popup menu

2010-09-15 Thread Nick Treleaven
On Wed, 15 Sep 2010 11:15:23 +1000 Lex Trotman wrote: > As noted in another response, IAW Gnome HIG right click popups S/B > context related things. What does S/B mean? > FWIW I'd: > > 1. remove undo/redo/select all as they are not context related Then are common editor popup menu commands th

Re: [Geany-devel] [Patch] Per document indent sizes

2010-09-14 Thread Nick Treleaven
On Fri, 10 Sep 2010 19:59:24 +1000 Erik de Castro Lopo wrote: > Here's an updated version of Jiří Techet's per document indent > sizes patch that applies to SVN HEAD. I used geany all day today > at work with this version of the patch. The original version of > this patch was discussed on this li

Re: [Geany-devel] [PATCH 19/19] Use per document indent sizes

2010-09-14 Thread Nick Treleaven
On Mon, 9 Aug 2010 23:45:02 +0200 Jiří Techet wrote: > I wanted to avoid 8 callback functions for each menu entry by reading > the label but apparently it wasn't a good idea. When thinking about > it, the label can be localized and completely changed so I shouldn't > rely on its value. > > Inste

Re: [Geany-devel] [PATCH 14/19] Rewrite tab switching queue

2010-09-14 Thread Nick Treleaven
On Thu, 5 Aug 2010 01:59:48 +0200 Jiří Techet wrote: > There was one more bug related to the tab switching. When we switch > so many times that we return back to the original document (so we > actually don't switch at all) then the following switch attempt > doesn't switch immediately to the nex

[Geany-devel] Search submenu for editor popup menu

2010-09-14 Thread Nick Treleaven
Hi, I propose we add a new menubar Search submenu which is also shown in the popup editor menu. This would be similar to what we do for the Edit submenu items Format and Commands. Reasoning: 1. We can help new users to find all the various keybinding commands grouped into logical submenus. 2. We

Re: [Geany-devel] [Patch] : On closing the last tab create new untitled document.

2010-09-14 Thread Nick Treleaven
On Tue, 14 Sep 2010 18:03:52 +1000 Erik de Castro Lopo wrote: > Currently, when closing the last tab, I get a geany window without > any text area. > > The attached patch fixes that, by creating a new untitled document > when the last tab is closed. I've been running with this patch > for over a

Re: [Geany-devel] Glade 2.12 won't build with recent GTK

2010-09-14 Thread Nick Treleaven
On Sun, 12 Sep 2010 01:24:34 +0200 Colomban Wendling wrote: > >> Glade 2.12.2 is about 2.5 years old so I think it's not too old for GTK > >> to drop support for it. > > > > Nobody is interested in it, its even hard to find a download of 2.12 > > Latest Fedora still seem

Re: [Geany-devel] [PATCH] : Don't open directories passed in on the command line

2010-09-14 Thread Nick Treleaven
On Tue, 14 Sep 2010 18:40:23 +1000 Erik de Castro Lopo wrote: > Doing something like: > >geany /tmp > > on the command line geany will open with a empty file named "/tmp" > which cannot be saved because there is a directory /tmp already. > > The attached patch just ignores all filenames pa

[Geany-devel] Remove 3 popup menu items to save space

2010-09-14 Thread Nick Treleaven
On Tue, 14 Sep 2010 11:59:54 +1000 Lex Trotman wrote: > > Le 14/09/2010 00:57, Lex Trotman a écrit : > >> On 14 September 2010 00:39,   wrote: > >>> [...] > >>> Remove 3 popup menu items to save space: > >>> Find Document Usage because Find Usage can be used instead. > >> > >> Gives a lot of rubb

Re: [Geany-devel] [Patch] Fix 3 possible NULL pointer dereferences.

2010-09-13 Thread Nick Treleaven
On Fri, 10 Sep 2010 18:03:52 +1000 Erik de Castro Lopo wrote: > Three possible NULL pointer dereferences fixed in the attached patch. I assume you found these with a static analyzer? The first 2 I fixed in a different way so they don't occur. The last one I applied, thanks. Regards, Nick

[Geany-devel] Stash

2010-09-13 Thread Nick Treleaven
On Sat, 11 Sep 2010 11:31:47 +1000 Lex Trotman wrote: > > A similar situation: I think using Stash for prefs everywhere would be > > much cleaner, but no one really wants to make the change, and it could > > introduce bugs. > > Yes, and new contributors don't understand about stash and (gently)

Re: [Geany-devel] Upgrading to glade 3 - Re: Glade 2.12 won't build with recent GTK

2010-09-13 Thread Nick Treleaven
On Sat, 11 Sep 2010 11:31:47 +1000 Lex Trotman wrote: > >> Indeed, maybe its time to think about the whole UI implementation, eg > >> using UIManager for the menu & toolbar which helps with integration of > >> plugin extensions and allows things like build systems to add to them > >> easily :-).

Re: [Geany-devel] GIO

2010-09-10 Thread Nick Treleaven
On Sat, 05 Jun 2010 09:10:41 -0500 Brad Wilson wrote: > Hi all, > > I am just curious what the current thought is on compiling with GIO when > available. > > The only reason I ask is that it (seems to) solve the GVfs bug issues at > least after I applied Алексей's patch and for me that is rea

[Geany-devel] g_file_replace_contents patch - Re: Safe file saving - permissions issue

2010-09-10 Thread Nick Treleaven
On Tue, 6 Apr 2010 12:10:13 +0100 Nick Treleaven wrote: > On Sat, 03 Apr 2010 03:51:18 +0400 > Алексей Антипов <1a_anti...@mail.ru> wrote: > > > Please find the patch in attachment. When building with GIO, it would use > > g_file_replace_contents > > I think

Re: [Geany-devel] snippet keybindings? - Re: [PATCH] Some editor/snippets/keybindings enhancements

2010-09-10 Thread Nick Treleaven
On Fri, 10 Sep 2010 11:11:02 +0400 Eugene Arshinov wrote: > > IIUC, I think it would make the code much simpler if the user has to > > say which snippets they want keybindings for, not offering all > > snippets for keybindings. > > > > Maybe, but what will the interface look like? I thought it

[Geany-devel] Upgrading to glade 3 - Re: Glade 2.12 won't build with recent GTK

2010-09-10 Thread Nick Treleaven
On Fri, 10 Sep 2010 09:50:51 +1000 Lex Trotman wrote: > >> Note that Glade 3.7 (current) claims to support GTK2.8 > > > > Interesting. > > > >> but only via > >> libglade loading XML, not code generation like interface.c.  That > >> would entail a major change in Geany and another dependency > >>

Re: [Geany-devel] Glade 2.12 won't build with recent GTK

2010-09-10 Thread Nick Treleaven
On Fri, 10 Sep 2010 03:48:41 +0200 Colomban Wendling wrote: > > [1] at least it wasn't possible without fixing an issue in GTK 2.20, see > > https://bugzilla.gnome.org/show_bug.cgi?id=618639 > > So part of GTK 2.x isn't usable? Why won't they fix the bug? Surely > deprecate

Re: [Geany-devel] STATA support

2010-09-09 Thread Nick Treleaven
On Mon, 9 Aug 2010 17:10:18 +0200 Alessio Caiazza wrote: > some STATA programmers asked me to develop a STATA lexer for geany here at > work. > > I did it in the past month and they tested it. Today a opened a feature > request [1] on > SourceForge but I discovered that Scintilla gets a major

Re: [Geany-devel] [PATCH] FIx document_need_save_as() logic

2010-09-09 Thread Nick Treleaven
On Thu, 9 Sep 2010 19:57:07 +1000 Erik de Castro Lopo wrote: > > Had a minor niggle which i decided to fix. If I do: > > > > geany some_file_which_doesn't_exist > > > > geany will open a new tab with the right file name for the tab. If > > I then add some code/text and try to save the file,

Re: [Geany-devel] [PATCH] Removed unnecessary pointer checks before g_free

2010-09-09 Thread Nick Treleaven
On Thu, 9 Sep 2010 18:19:51 +1000 Erik de Castro Lopo wrote: > I found three instances of code like: > > if (ptr) >g_free(ptr); > > The test nefore g_free is completely unneessary. Thanks, applied. Regards, Nick ___ Geany-devel mailing l

Re: [Geany-devel] Glade 2.12 won't build with recent GTK

2010-09-09 Thread Nick Treleaven
On Thu, 9 Sep 2010 16:10:16 +0100 Nick Treleaven wrote: > > now. In fact Geany probably should have a tarball on the hacking page > > with the GTK docs. > > Good idea. http://download.geany.org/glade-2.12.2.tar.gz Also added a link for HACKING in S

Re: [Geany-devel] Glade 2.12 won't build with recent GTK

2010-09-09 Thread Nick Treleaven
On Thu, 9 Sep 2010 22:09:18 +1000 Lex Trotman wrote: > >> [1] at least it wasn't possible without fixing an issue in GTK 2.20, see > >> https://bugzilla.gnome.org/show_bug.cgi?id=618639 > > > > So part of GTK 2.x isn't usable? Why won't they fix the bug? Surely > > deprecated stuff should be supp

[Geany-devel] Glade 2.12 won't build with recent GTK

2010-09-09 Thread Nick Treleaven
On Thu, 09 Sep 2010 03:15:55 +0200 Colomban Wendling wrote: > Since Glade 2.x doesn't really exist anymore (its out-of-date and > couldn't even be compiled with recent GTK version [1]), I don't think it > is reasonable to think that every possible contributor have it. ... > [1] at least it wasn't

Re: [Geany-devel] snippet keybindings? - Re: [PATCH] Some editor/snippets/keybindings enhancements

2010-09-09 Thread Nick Treleaven
On Thu, 9 Sep 2010 11:35:18 +0100 Nick Treleaven wrote: > > No, I didn't mean to read/save keybindings in snippets.conf. It is > > very strange that my patch does it, maybe I forgot to remove > > something from the code :) I'll recheck the patch, probably tomor

Re: [Geany-devel] snippet keybindings? - Re: [PATCH] Some editor/snippets/keybindings enhancements

2010-09-09 Thread Nick Treleaven
On Thu, 9 Sep 2010 11:01:04 +0400 Eugene Arshinov wrote: > > > OK, I didn't explain before what I had in mind but I think this > > > patch is too complex. > > > > > > What I think we could accept is setting up the snippet keybinding > > > group size and items (like a plugin) when snippets.conf i

Re: [Geany-devel] snippet keybindings? - Re: [PATCH] Some editor/snippets/keybindings enhancements

2010-09-09 Thread Nick Treleaven
On Wed, 8 Sep 2010 23:47:28 +0400 Eugene Arshinov wrote: > > > > Unfortunately, keybindings_set_item was not enough for me to > > > > implement this. For example, I had to extend GeanyKeyGroup > > > > struct so that I have a way to tweak loading from / saving to > > > > keybindings.conf. Anyway,

Re: [Geany-devel] [PATCH] Better-looking comments indenting

2010-09-08 Thread Nick Treleaven
On Wed, 8 Sep 2010 15:32:17 +0100 Nick Treleaven wrote: > Also if some lines have tab indentation and some spaces then the > comments could be inserted at the wrong position on some lines. Not > sure how big an issue this is. I've just realized, for the tabs & spaces

Re: [Geany-devel] [PATCH] Better-looking comments indenting

2010-09-08 Thread Nick Treleaven
On Wed, 8 Sep 2010 17:55:36 +0300 Tambet Arak wrote: > >> I think the idea is good, but I've just tried the patch and it doesn't > >> work if there are empty lines in the middle of the selected block. Then > >> the comments are all inserted at column 0. > > Yes, this happens because the empty li

Re: [Geany-devel] snippet keybindings? - Re: [PATCH] Some editor/snippets/keybindings enhancements

2010-09-08 Thread Nick Treleaven
On Sun, 29 Aug 2010 21:59:32 +0400 Eugene Arshinov wrote: > > > >> >> If we do want snippet keybindings perhaps it would be better > > > >> >> to integrate with the existing keybindings rather than > > > >> >> storing them separately - then users could configure them in > > > >> >> the normal way

Re: [Geany-devel] [PATCH] Better-looking comments indenting

2010-09-08 Thread Nick Treleaven
On Wed, 8 Sep 2010 15:32:17 +0100 Nick Treleaven wrote: > I think the idea is good, but I've just tried the patch and it doesn't > work if there are empty lines in the middle of the selected block. Then > the comments are all inserted at column 0. Forgot to mention: this i

Re: [Geany-devel] [PATCH] Better-looking comments indenting

2010-09-08 Thread Nick Treleaven
Hi, On Tue, 31 Aug 2010 17:54:45 +0300 Tambet Arak wrote: > Any word on whether the patch will be rejected or accepted? It's > almost two months since the last correspondence. Sorry for the delay. I think the idea is good, but I've just tried the patch and it doesn't work if there are empty li

[Geany-devel] Vala plugins - Re: GOject Introspection for Geany

2010-09-07 Thread Nick Treleaven
On Sat, 04 Sep 2010 15:00:44 +0200 Colomban Wendling wrote: > Well, beside this, I worked a while ago on a little hand-crafted Vala > VAPI file for Geany [1], and although it's probably buggy because not > well-tested, it worked. I've not told anyone about it because it isn't > production-ready,

Re: [Geany-devel] Geany-Plugins: Having just one copy of GPL inside source tree / Waf size

2010-08-25 Thread Nick Treleaven
On Wed, 25 Aug 2010 15:41:25 +0200 Frank Lanitz wrote: > > >Also what if an author wanted to distribute their plugin separately? > > > > Also agree. > > Basically this I don't see as a valid argument, as if a developer is > really planning to do so he will need to build up its own build system.

Re: [Geany-devel] What's the point of compiling geany without regex support?

2010-08-25 Thread Nick Treleaven
On Mon, 16 Aug 2010 17:02:45 +0100 Nick Treleaven wrote: > > The Waf based build system builds with the shipped mini implementation > > if the --enable-gnu-regex option is given. > > Otherwise it checks whether the system provides something usable and > > uses this

Re: [Geany-devel] Geany-Plugins: Having just one copy of GPL inside source tree / Waf size

2010-08-24 Thread Nick Treleaven
Accidentally left an edited subject line, please ignore :-/ (./waf seems to be only 60k so not an issue) Regards, Nick ___ Geany-devel mailing list Geany-devel@uvena.de http://lists.uvena.de/cgi-bin/mailman/listinfo/geany-devel

Re: [Geany-devel] Geany-Plugins: Having just one copy of GPL inside source tree / Waf size

2010-08-24 Thread Nick Treleaven
On Mon, 23 Aug 2010 01:49:36 +0200 Frank Lanitz wrote: > during the work on Updatecheker I recognized another time that nearly > every plugin is having its own copy of GPL. As most of the plugins code > is licensed under GPL2+, what do you think of moving the individual > copies of GPL into a cen

Re: [Geany-devel] [PATCH 15/19] Do not insert --include= when the search pattern entry is empty

2010-08-24 Thread Nick Treleaven
On Thu, 5 Aug 2010 01:59:49 +0200 Jiří Techet wrote: > --- a/src/search.c > +++ b/src/search.c > @@ -1329,7 +1329,8 @@ static GString *get_grep_options(void) > g_strstrip(settings.fif_files); > tmp = g_string_new(settings.fif_files); > do {} while (utils

Re: [Geany-devel] [PATCH 09/19] Use wider entry for project file path

2010-08-24 Thread Nick Treleaven
On Thu, 5 Aug 2010 01:59:43 +0200 Jiří Techet wrote: > > 30 is too little. For instance > > /home/techet/projects/geany/geany.geany > > is 39 characters long and this is really short path. I find 50 > characters to be about minimal usable size so users do not have > to scroll inside the edit

Re: [Geany-devel] [PATCH] Minor autotool cleanups

2010-08-24 Thread Nick Treleaven
On Tue, 24 Aug 2010 07:08:16 +1000 Erik de Castro Lopo wrote: > > Thanks, committed. After ./autogen.sh, we now have m4/intltool.m4. I > > suppose this may be needed by people using ./autogen.sh without the > > intltool macros. > > I would not commit that because different versions of the tools

Re: [Geany-devel] [PATCH] Minor autotool cleanups

2010-08-23 Thread Nick Treleaven
On Wed, 4 Aug 2010 09:16:04 +1000 Erik de Castro Lopo wrote: > > Patch below fixes a number of warnings when running autogen.sh. > > Just remembered, if someone applies this patch, they should also > do (from the top level dir): > > mkdir m4 > svn add m4 Thanks, committed. After ./au

Re: [Geany-devel] build geany-plugins on Windows

2010-08-20 Thread Nick Treleaven
On Fri, 20 Aug 2010 09:48:18 +0200 Johann SAUNIER wrote: > I need to apply my own patches to Geany and Geany-plugins too, but I now > work on Windows. I can build Geany using makefile.win32 but I can't find an > equivalent for Geany-plugins. > I know Geany-plugins is built on Windows by maintaine

[Geany-devel] ANN: New Release: Geany 0.19.1

2010-08-19 Thread Nick Treleaven
Hi all, Geany 0.19.1 has been released. This is a bugfix release including fixes for broken autocompletion, document detection on Windows and various other issues. There are also some tweaks including ignoring background colors when printing. For a list of changes in Geany 0.19.1, please see: ht

[Geany-devel] glib version required - Re: Warnings in tagmanager/regex.c on x86-64

2010-08-17 Thread Nick Treleaven
On Tue, 17 Aug 2010 10:26:18 +1000 Lex Trotman wrote: > I tried to see if the Glib regex could be used instead and AFAICT Glib > 2.14 or above has regex, but I can't tell what version of Glib Geany > needs, the config only tests for GTK2.8 and I can't find anywhere > which Glib it needs. Note Gl

Re: [Geany-devel] snippet keybindings? - Re: [PATCH] Some editor/snippets/keybindings enhancements

2010-08-17 Thread Nick Treleaven
On Tue, 17 Aug 2010 10:08:08 +1000 Lex Trotman wrote: > >> If we do want snippet keybindings perhaps it would be better to > >> integrate with the existing keybindings rather than storing them > >> separately - then users could configure them in the normal way. > >> > > > > It's worth thinking. >

Re: [Geany-devel] Warnings in tagmanager/regex.c on x86-64

2010-08-16 Thread Nick Treleaven
On Mon, 16 Aug 2010 14:54:54 +0200 Jiří Techet wrote: > > I tried compiling latest SVN with --enable-gnu-regex on an x86-64 system. > > > > I only had time to look at the first few of them but the following > > errors seem to be due to casting between pointers and int but on > > x86-64 int is 32

Re: [Geany-devel] What's the point of compiling geany without regex support?

2010-08-16 Thread Nick Treleaven
On Sun, 15 Aug 2010 13:55:11 +1000 Lex Trotman wrote: > I'd agree that using regex should be the default, either the system or > the included one or glib regex lots of choices. Not the GLib one, the version that provides it isn't required by Geany. Regards, Nick ___

Re: [Geany-devel] What's the point of compiling geany without regex support?

2010-08-16 Thread Nick Treleaven
On Sun, 15 Aug 2010 14:37:38 +0200 Enrico Tröger wrote: > >> I started implementing the idea of indenting based on regular > >> expressions and have noticed that geany can be compiled without regex > >> support. Obviously in this case the indent thing wouldn't work. I > >> don't quite understand

[Geany-devel] snippet keybindings? - Re: [PATCH] Some editor/snippets/keybindings enhancements

2010-08-16 Thread Nick Treleaven
On Sat, 10 Jul 2010 21:48:35 +0400 Eugene Arshinov wrote: > I attach three patches: Thanks; as we're preparing a bugfix release I haven't looked at them, but anyway: > 2. Snippet keybindings support Not sure about this - shouldn't the keybinding be typing the snippet name and pressing tab ;-)

Re: [Geany-devel] [PATCH] Scintilla: Infinite loop in Markdown lexer

2010-08-16 Thread Nick Treleaven
On Sat, 14 Aug 2010 19:25:43 +0200 Colomban Wendling wrote: > As reported in Debian's bug #590284 [1] the Scintilla Markdown lexer has > a bug that causes an infinite loop on certain circumstances. > > In facts, it happens when HasPrevLineContent() is called on the second > line and the first li

Re: [Geany-devel] [PATCH] fix memory leak

2010-08-12 Thread Nick Treleaven
On Thu, 12 Aug 2010 07:51:35 +0200 Frank Lanitz wrote: > However, maybe we should revisit the function as it appears to me at > the moment that search_text could be replaced completely by using > utf8_search_text. We sometimes want search_text to be a different encoding than UTF-8 - see the lin

Re: [Geany-devel] [PATCH] Open files in Geany at the same workspace

2010-08-12 Thread Nick Treleaven
On Thu, 12 Aug 2010 16:16:28 +0300 Dimitar Zhekov wrote: > On Thu, 12 Aug 2010 12:51:21 +0100 > Nick Treleaven wrote: > > > On Thu, 12 Aug 2010 13:30:25 +1000 > > Erik de Castro Lopo wrote: > > > > > > Thanks for your work on this. From a very brief l

Re: [Geany-devel] R lexer should consider "." (dot) as part of word

2010-08-12 Thread Nick Treleaven
On Wed, 11 Aug 2010 19:53:25 +0100 Liviu Andronic wrote: > > > > I've been investigating filetypes.r to see if it is possible to > > > > make Geany more friendly (when +right/left, selecting, > > > > double-click selecting, etc.) toward strings containing > > > > "." (dot), and I noticed this lin

Re: [Geany-devel] [PATCH] Open files in Geany at the same workspace

2010-08-12 Thread Nick Treleaven
On Thu, 12 Aug 2010 13:30:25 +1000 Erik de Castro Lopo wrote: > > Thanks for your work on this. From a very brief look the design looks > > good but I haven't tested it. > > As I think Dimitar mentioned, windows has named rather than numbered > workspaces. It would be relatively trivial to rewor

Re: [Geany-devel] [PATCH] Open files in Geany at the same workspace

2010-08-11 Thread Nick Treleaven
On Fri, 6 Aug 2010 09:19:57 +1000 Erik de Castro Lopo wrote: > Erik de Castro Lopo wrote: > > > Erik de Castro Lopo wrote: > > > > > I still think this functionality can be improved on to do the right > > > thing for most people most of the time. > > > > Ah, its in the TODO list anyway: > > >

Re: [Geany-devel] Per document tab width

2010-08-11 Thread Nick Treleaven
On Fri, 23 Jul 2010 19:23:49 +0200 Jiří Techet wrote: > >> I would propose to have one more entry in the Document menu called > >> e.g. "Tab size" and placed under "Indent type" with a submenu > >> containing numbers from 2 to 8 (I hope there is nobody so crazy that > >> he would use tab for a si

Re: [Geany-devel] When is the scintilla component going to be updated?

2010-08-10 Thread Nick Treleaven
On Tue, 10 Aug 2010 09:02:30 +1000 Erik de Castro Lopo wrote: > Erik de Castro Lopo wrote: > > > Anyone have any idea when the scintilla component is going to be > > updated? > > I notice the documentation here: > >http://www.geany.org/manual/hacking.html#syntax-highlighting > > says: >

Re: [Geany-devel] Building Geany from SVN

2010-07-30 Thread Nick Treleaven
On Sat, 24 Jul 2010 12:02:19 +0400 Eugene Arshinov wrote: > > I want to build Geany from the sources in SVN. Since the configure > > script is not included in the repository I had to use automake to > > generate it. I tried the following: > > > > ./aclocal > > ./automake --add-missing > > > > U

Re: [Geany-devel] RFC: remove includes

2010-07-30 Thread Nick Treleaven
On Sun, 25 Jul 2010 14:38:51 +0200 Daniel Marjamäki wrote: > Hello! > > Do you have any comments about this patch that remove includes? IIRC geany.h is needed because of its defines - maybe as it includes config.h. Regards, Nick ___ Geany-devel maili

Re: [Geany-devel] Problem with setting position in document after reloading

2010-07-12 Thread Nick Treleaven
On Sat, 10 Jul 2010 01:57:27 +0200 Jiří Techet wrote: > There's one more problem related to wrong cursor position. After > updating to Scintilla 2.12 (also bisected) when a file is opened from > a message window at certain line (e.g. by clicking at ./foo.c:80: > resulting from find in files) the

Re: [Geany-devel] [PATCH] Ensure convert line endings before save

2010-07-12 Thread Nick Treleaven
On Fri, 09 Jul 2010 20:50:38 +0200 Manuel Bua wrote: > i > implemented this simple feature, that basically ensure no mixed line > endings control characters (le-cc) will be saved in the document, patch > is attached (i used the latest SVN head, 5089). > Let me explain the use case: i'm currently

Re: [Geany-devel] GProject - the second attempt

2010-07-12 Thread Nick Treleaven
On Fri, 9 Jul 2010 22:53:17 +0200 Jiří Techet wrote: > > Can you send the patches by email please - my git-fu is not yet good > > enough (slowly improving though). > > OK, will do (maybe I'll wait for a while to collect everyone else's > comments and possibly modify the patches). Suits me :) >

Re: [Geany-devel] GProject - the second attempt

2010-07-09 Thread Nick Treleaven
On Thu, 8 Jul 2010 23:59:04 +0200 Jiří Techet wrote: > Hi Nick, > > thanks for looking at the patches. Let me know if I should re-send > them by email or modify them in some way. Can you send the patches by email please - my git-fu is not yet good enough (slowly improving though). > > I'll try

Re: [Geany-devel] GProject - the second attempt

2010-07-07 Thread Nick Treleaven
On Sun, 4 Jul 2010 00:54:17 +0200 Jiří Techet wrote: > This time I did my best to integrate the plugin to geany as well as > possible so there are more patches for geany itself than before. Apart > from patches needed for gproject there are several more patches that > fix some bugs in geany or ar

Re: [Geany-devel] regular|symlink file tests

2010-07-05 Thread Nick Treleaven
On Sun, 4 Jul 2010 15:26:09 +0300 Dimitar Zhekov wrote: > On Sun, 4 Jul 2010 11:09:28 +0200 > Frank Lanitz wrote: > > > > I think G_FILE_TEST_IS_REGULAR | G_FILE_TEST_IS_SYMLINK should be > > > replaced with G_FILE_TEST_IS_REGULAR. > > > > Yes indeed. The or doesn't seem to make big sense here

Re: [Geany-devel] Patches required by gproject

2010-07-02 Thread Nick Treleaven
On Fri, 2 Jul 2010 15:15:44 +0200 Jiří Techet wrote: > > I applied your patch though so that plugins can add messages before FIF > > is used. Although if a plugin is doing that then we should probably add > > a function to set msgwindow.find_in_files_dir (and also rename it > > to messages_dir) s

Re: [Geany-devel] Patches required by gproject

2010-07-02 Thread Nick Treleaven
On Sun, 20 Jun 2010 17:24:48 +0200 Jiří Techet wrote: > >> >> [PATCH 3/3] Open files from msgwindow even if find_in_files_dir is not > >> >> set > >> > >> Currently if you want to open a file by double clicking the filename > >> in the msgwindow (e.g. after searching in files), the file is opene

Re: [Geany-devel] [Patch] use g_free instead of free after g_malloc/g_strdup/etc

2010-06-30 Thread Nick Treleaven
On Wed, 30 Jun 2010 13:09:58 +0200 Daniel Marjamäki wrote: > Hello! > > This patch has simple code cleanups. Thanks, applied. (Also fixed a possible memory leak). Regards, Nick ___ Geany-devel mailing list Geany-devel@uvena.de http://lists.uvena.de/c

Re: [Geany-devel] configurable status line?

2010-06-29 Thread Nick Treleaven
On Sun, 27 Jun 2010 21:41:17 +0400 Eugene Arshinov wrote: > > Personally I find the total number of lines quite useful - it tells > > you quickly how big the file is. Also the space "wasted" by its > > presence is relatively small because it shares the caption with the > > current line number. Fo

Re: [Geany-devel] configurable status line?

2010-06-29 Thread Nick Treleaven
(The list seems to not be sending mails ATM, so sorry if I missed any reply.) On Tue, 29 Jun 2010 11:42:01 +0100 Nick Treleaven wrote: > > > To preserve the status bar speed, I used only g_string_append(), as in > > > the current code, instead of utils_string_replace_all

Re: [Geany-devel] configurable status line?

2010-06-29 Thread Nick Treleaven
On Mon, 28 Jun 2010 13:13:11 +0100 Nick Treleaven wrote: > On Sun, 27 Jun 2010 15:20:24 +0300 > Dimitar Zhekov wrote: > > > Hi, > > > > Here is a slightly newer version of the $subject patch. > > > > Support for %_ has been removed, it doesn't ma

Re: [Geany-devel] configurable status line?

2010-06-28 Thread Nick Treleaven
On Sun, 27 Jun 2010 15:20:24 +0300 Dimitar Zhekov wrote: > Hi, > > Here is a slightly newer version of the $subject patch. > > Support for %_ has been removed, it doesn't make sense if the number of > spaces can not be set, and only makes the text harder to read. > > The default status line te

Re: [Geany-devel] configurable status line?

2010-06-26 Thread Nick Treleaven
On Wed, 23 Jun 2010 17:58:11 +0100 Nick Treleaven wrote: > On Wed, 23 Jun 2010 19:31:03 +0300 > Dimitar Zhekov wrote: > > > Hi, everyone, > > > > The status line is pretty crowded, as you know, so how about making it > > configurable? Something like: > >

Re: [Geany-devel] remove some status bar fields - Re: configurable status line?

2010-06-25 Thread Nick Treleaven
On Fri, 25 Jun 2010 19:55:43 +0300 Dimitar Zhekov wrote: > On Fri, 25 Jun 2010 12:37:52 +0100 > Nick Treleaven wrote: > > > Also, I don't think we need the INS / OVR indication - the cursor > > changes from vertical to an underline and this is probably clear enough

Re: [Geany-devel] Find in files - Re: Patches required by gproject

2010-06-25 Thread Nick Treleaven
On Fri, 25 Jun 2010 14:32:38 +0200 Jiří Techet wrote: > > I wanted the Files box to be there and wanted to tidy up some things in > > the GUI code so that's done now. > > Looks good. I was just wondering about what separator should be used > to separate the individual patterns - in gproject I us

Re: [Geany-devel] build dialog default entries color

2010-06-25 Thread Nick Treleaven
On Tue, 22 Jun 2010 20:56:39 +0300 Dimitar Zhekov wrote: > Hi again, > > Firefox uses fg[GTK_STATE_INSENSITIVE] for the search field. If we > consider this acceptable, can someone please change "text" in the patch > to "fg" and apply it? Lex committed a change to use that, looks good. Thanks.

[Geany-devel] remove some status bar fields - Re: configurable status line?

2010-06-25 Thread Nick Treleaven
On Wed, 23 Jun 2010 17:58:11 +0100 Nick Treleaven wrote: > On Wed, 23 Jun 2010 19:31:03 +0300 > Dimitar Zhekov wrote: > > > Hi, everyone, > > > > The status line is pretty crowded, as you know, so how about making it > > configurable? Something like: > >

Re: [Geany-devel] Find in files - Re: Patches required by gproject

2010-06-24 Thread Nick Treleaven
On Wed, 23 Jun 2010 22:57:00 +0200 Jiří Techet wrote: > >> Let's use --include then if the user ticks a checkbox. That way a > >> non-gnu system will still be able to do non-recursive all files search. > > > > BTW I've just added a dummy Files checkbox and combobox to the dialog in > > SVN, and w

Re: [Geany-devel] configurable status line?

2010-06-23 Thread Nick Treleaven
On Wed, 23 Jun 2010 19:31:03 +0300 Dimitar Zhekov wrote: > Hi, everyone, > > The status line is pretty crowded, as you know, so how about making it > configurable? Something like: > > line: %l / %n\t col: %c\t sel: %s ... > > I can write it, if you think that's a good idea. I don't think it's

Re: [Geany-devel] Find in files - Re: Patches required by gproject

2010-06-22 Thread Nick Treleaven
On Tue, 22 Jun 2010 16:48:29 +0100 Nick Treleaven wrote: > > To me it looks much easier to use what's already present in grep right > > now and if this isn't satisfactory, it could be reimplemented the way > > you propose in the future. In addition if no patterns a

Re: [Geany-devel] Find in files - Re: Patches required by gproject

2010-06-22 Thread Nick Treleaven
On Tue, 22 Jun 2010 15:19:02 +0200 Jiří Techet wrote: > >> > think it may be best if Geany does the filtering (and hence also the > >> > recursing). Also we may want to always filter out hidden files and > >> > broken links. > >> > >> There is one problem here - the command line may be too long.

Re: [Geany-devel] Find in files - Re: Patches required by gproject

2010-06-22 Thread Nick Treleaven
On Mon, 21 Jun 2010 20:53:58 +0200 Jiří Techet wrote: > >> Having a filetype pattern in the find in files dialog could be useful. > >>  Note that --include is a GNU grep extension, so a blank file pattern > >> should be the default and should not generate the option to grep so as > >> to maintain

[Geany-devel] project base path - Re: save all on build - Re: Patches required by gproject

2010-06-22 Thread Nick Treleaven
On Mon, 21 Jun 2010 18:41:11 +0200 Jiří Techet wrote: > > The base path should be the root of all project files. > > I believe the base path is the path where make (and other build > commands) are called. I can set base path to build only one subsystem > of the project so in this case not all pr

Re: [Geany-devel] save all on build - Re: Patches required by gproject

2010-06-22 Thread Nick Treleaven
On Tue, 22 Jun 2010 09:05:02 +1000 Lex Trotman wrote: > On 21 June 2010 22:29, Nick Treleaven wrote: > > On Mon, 21 Jun 2010 08:57:16 +1000 > > Lex Trotman wrote: > > > >> >> I agree that there should be an option in preferences. On the other > >>

[Geany-devel] Find in files - Re: Patches required by gproject

2010-06-21 Thread Nick Treleaven
On Mon, 21 Jun 2010 08:47:54 +1000 Lex Trotman wrote: > > I like your idea in general, the only thing I don't like about it is > > that you wouldn't see the patterns in the FIF dialog, which would make > > it a bit unclear what you are searching for. I would propose to have a > > "file types" edi

Re: [Geany-devel] save all on build - Re: Patches required by gproject

2010-06-21 Thread Nick Treleaven
On Mon, 21 Jun 2010 08:57:16 +1000 Lex Trotman wrote: > >> I agree that there should be an option in preferences. On the other > >> hand, I understand that with how the geany project works it doesn't > >> know what files belong to the project - the subtree starting from > >> base_path may be a su

Re: [Geany-devel] save all on build - Re: Patches required by gproject

2010-06-18 Thread Nick Treleaven
On Fri, 18 Jun 2010 21:42:59 +1000 Lex Trotman wrote: > >> I remember there was some discussion about saving everything when I > >> started the build system changes.  I don't remember why it wasn't > >> done. Can anyone think of a reason to not save all files? If no one > >> can then I'll conside

Re: [Geany-devel] [PATCH 1/3] Add a signal that is emitted before build starts

2010-06-18 Thread Nick Treleaven
On Wed, 9 Jun 2010 21:49:04 +0200 Jiří Techet wrote: > --- a/src/build.c > +++ b/src/build.c > @@ -1243,6 +1243,8 @@ static void on_build_menu_item(GtkWidget *w, gpointer > user_data) > gint grp = GPOINTER_TO_GRP(user_data); > gint cmd = GPOINTER_TO_CMD(user_data); > > + g_sig

<    1   2   3   4   5   6   7   >