Re: [gem5-dev] Review Request 2901: ruby: replace global cycle counter w/ cycle per ruby system

2015-06-23 Thread Joel Hestness
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2901/#review6573 --- Overall, it seems like there should be a better way to do this using

Re: [gem5-dev] Review Request 2902: ruby: removes g_system_ptr and replaces with object based references

2015-06-23 Thread Joel Hestness
On June 23, 2015, 1:35 a.m., Joel Hestness wrote: src/mem/ruby/system/Sequencer.cc, line 529 http://reviews.gem5.org/r/2902/diff/1/?file=46572#file46572line529 Currently, all references to warm-up and cool-down variables should use the static accessors,

Re: [gem5-dev] Review Request 2901: ruby: replace global cycle counter w/ cycle per ruby system

2015-06-23 Thread Joel Hestness
On June 19, 2015, 3:29 p.m., Joel Hestness wrote: Can you please expand on the commit message? I understand that these changes are to allow multiple RubySystem instances, but some detailed information about this should be available in the commit log. Brandon Potter wrote: Hello

Re: [gem5-dev] Review Request 2902: ruby: removes g_system_ptr and replaces with object based references

2015-06-23 Thread Andreas Hansson
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2902/#review6571 --- src/python/swig/pyobject.cc (line 47)

Re: [gem5-dev] Review Request 2882: mem: Add clean evicts and overloaded writebacks

2015-06-23 Thread Andreas Hansson
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2882/ --- (Updated June 23, 2015, 12:20 p.m.) Review request for Default. Repository: gem5

Re: [gem5-dev] gem5 Governance document

2015-06-23 Thread Steve Reinhardt
Thanks, Jason! This is a great start. I made a bunch of comments, and just a few edits. I think it would be good to have a few more of the core developers (our de facto PMC I guess) read through this before advertising it more widely---Ali, Andreas *, Nilay, Joel, Brad, Nate, etc. I see some

Re: [gem5-dev] Ruby serialize removing event queue head

2015-06-23 Thread Timothy M Jones
On 23/06/2015 01:12, Joel Hestness wrote: (C) seems most probable given that the changeset 10524 moved memories out of Ruby (note in that changeset that memory checkpointing occurred in RubySystem::serialize() AFTER the cache flush operation). Can you check whether the RubySystem or the

Re: [gem5-dev] Problem Loading SimpleNetwork from INI Config File

2015-06-23 Thread Nilay Vaish
On Tue, 23 Jun 2015, Gross, Joe wrote: Hello, I'm having a problem correctly running a config that was generated by using the config ini loading mechanism. The binary was built using --with-cxx-config. It then runs correctly and generates a config.ini file in the m5out directory (when

Re: [gem5-dev] gem5 Governance document

2015-06-23 Thread Jason Power
Yes. We should definitely put this on the wiki when it's finalized. I started it on Google Docs since it's easier to collaborate there. Also, I think we should have a governance.md file (or whatever markup we want to use) committed in the repo. Thanks for the comments, Steve! Jason On Tue, Jun

Re: [gem5-dev] Review Request 2882: mem: Add clean evicts and overloaded writebacks

2015-06-23 Thread Andreas Hansson
On June 22, 2015, 4:57 a.m., Nilay Vaish wrote: src/mem/abstract_mem.cc, line 340 http://reviews.gem5.org/r/2882/diff/1/?file=46237#file46237line340 Are you moving this because size of the packet would be zero for clean evicts? Indeed. We are simply checking for the transactions

Re: [gem5-dev] gem5 Governance document

2015-06-23 Thread Steve Reinhardt
A meta-process question: how do people feel about google docs vs the wiki? Google docs is much more user-friendly, but for consistency it seems like we'd want this on the wiki at some point. On Tue, Jun 23, 2015 at 5:40 AM Steve Reinhardt ste...@gmail.com wrote: Thanks, Jason! This is a great

Re: [gem5-dev] Review Request 2905: ruby: drop NetworkMessage class

2015-06-23 Thread Nilay Vaish
On June 22, 2015, 2:35 p.m., Jason Power wrote: LGTM. As an aside, since this is yet another patch that requires blanket changes to all slicc protocols, maybe we should require the patch submitter to include a script to update the other slicc protocols similar to how we have a

Re: [gem5-dev] Review Request 2896: ruby: remove wire buffer

2015-06-23 Thread Nilay Vaish
On June 19, 2015, 5:07 p.m., Steve Reinhardt wrote: yYes, we use the wire buffer in our protocols and oppose its removal. (What's the opposite of the Ship It button?) Brad is on vacation today so I'll comment on his behalf :). Brad Beckmann wrote: Nilay **please** when

[gem5-dev] Review Request 2911: Ruby: Remove assert in RubyPort retry list logic

2015-06-23 Thread Jason Power
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2911/ --- Review request for Default. Repository: gem5 Description --- Changeset

Re: [gem5-dev] Review Request 2869: dev, arm: Add a device model that uses the NoMali model

2015-06-23 Thread Nilay Vaish
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2869/#review6578 --- Ship it! Ship It! - Nilay Vaish On June 21, 2015, 8:05 p.m., Andreas

Re: [gem5-dev] Review Request 2903: ruby: move g_abs_controls from global into RubySystem

2015-06-23 Thread Nilay Vaish
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2903/#review6576 --- Ship it! Ship It! - Nilay Vaish On June 23, 2015, 1:03 a.m., Brandon

Re: [gem5-dev] Review Request 2896: ruby: remove wire buffer

2015-06-23 Thread Nilay Vaish
On June 19, 2015, 5:07 p.m., Steve Reinhardt wrote: yYes, we use the wire buffer in our protocols and oppose its removal. (What's the opposite of the Ship It button?) Brad is on vacation today so I'll comment on his behalf :). Brad Beckmann wrote: Nilay **please** when

Re: [gem5-dev] Problem Loading SimpleNetwork from INI Config File

2015-06-23 Thread Gross, Joe
Hi Nilay, I've looked through these but don't see any obvious special behaviors that would apply to the SimpleNetwork deserialization. However, neither of these have changed significantly in quite a while, so I think whatever broke was in Network or SimpleNetwork. Since you're the author of a

Re: [gem5-dev] Problem Loading SimpleNetwork from INI Config File

2015-06-23 Thread Nilay Vaish
On Tue, 23 Jun 2015, Beckmann, Brad wrote: Nilay, Please be more professional when responding to questions. If you have a particular idea on how to fix the problem, we would appreciate if you described it rather than leaving us a trail of breadcrumbs. First, this is the second time you

Re: [gem5-dev] Review Request 2856: cpu: o3: Commit stage updates for hw threads priority list

2015-06-23 Thread Andreas Sandberg
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2856/#review6569 --- Ship it! I'm happy with this. I agree with Nilay that the difference

[gem5-dev] Cron m5test@zizzer /z/m5/regression/do-regression quick

2015-06-23 Thread Cron Daemon
* build/ALPHA/tests/opt/quick/se/50.memtest/alpha/linux/memtest-ruby passed. * build/ALPHA/tests/opt/quick/se/50.vortex/alpha/tru64/simple-timing passed. * build/ALPHA/tests/opt/quick/se/70.twolf/alpha/tru64/simple-atomic passed. *

[gem5-dev] Problem Loading SimpleNetwork from INI Config File

2015-06-23 Thread Gross, Joe
Hello, I'm having a problem correctly running a config that was generated by using the config ini loading mechanism. The binary was built using --with-cxx-config. It then runs correctly and generates a config.ini file in the m5out directory (when configuring using python/swig). However, when

[gem5-dev] pd-gem5: simulating a parallel/distributed system on multiple physical hosts

2015-06-23 Thread Mohammad Alian
Hello All, I have submitted a chain of patches which enables gem5 to simulate a cluster on multiple physical hosts: http://reviews.gem5.org/r/2909/ http://reviews.gem5.org/r/2910/ http://reviews.gem5.org/r/2912/ http://reviews.gem5.org/r/2913/ http://reviews.gem5.org/r/2914/

Re: [gem5-dev] pd-gem5: simulating a parallel/distributed system on multiple physical hosts

2015-06-23 Thread Steve Reinhardt
Thanks for posting, Mohammad! I will try to look your patches over later this week. Steve On Tue, Jun 23, 2015 at 9:05 PM Mohammad Alian al...@wisc.edu wrote: Hello All, I have submitted a chain of patches which enables gem5 to simulate a cluster on multiple physical hosts:

[gem5-dev] Review Request 2915: tests: scripts for taking checkpoint and a simple test for pd-gem5

2015-06-23 Thread Mohammad Alian
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2915/ --- Review request for Default. Repository: gem5 Description ---

[gem5-dev] Review Request 2914: config: pd-gem5 extention, parallel/distirbuted simulation of a cluster

2015-06-23 Thread Mohammad Alian
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2914/ --- Review request for Default. Repository: gem5 Description ---

[gem5-dev] Review Request 2912: dev: Add a network switch model for pd-gem5

2015-06-23 Thread Mohammad Alian
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2912/ --- Review request for Default. Repository: gem5 Description ---

Re: [gem5-dev] Problem Loading SimpleNetwork from INI Config File

2015-06-23 Thread Beckmann, Brad
Nilay, Please be more professional when responding to questions. If you have a particular idea on how to fix the problem, we would appreciate if you described it rather than leaving us a trail of breadcrumbs. Please note that your patch, 10311, is the one that breaks the tenet that

[gem5-dev] Review Request 2909: dev: replace pollevent in ethertap

2015-06-23 Thread Mohammad Alian
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2909/ --- Review request for Default. Repository: gem5 Description ---

[gem5-dev] Review Request 2910: base, dev: enable client/server socket for ethertap

2015-06-23 Thread Mohammad Alian
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2910/ --- Review request for Default. Repository: gem5 Description ---

Re: [gem5-dev] Problem Loading SimpleNetwork from INI Config File

2015-06-23 Thread Nilay Vaish
On Tue, 23 Jun 2015, Gross, Joe wrote: Hi Nilay, I've looked through these but don't see any obvious special behaviors that would apply to the SimpleNetwork deserialization. However, neither of these have changed significantly in quite a while, so I think whatever broke was in Network or