---
This is an automatically generated e-mail. To reply, visit:
http://reviews.gem5.org/r/3778/#review9288
---
Ship it!
Comment below is just in case anyone else was confused, like I
---
This is an automatically generated e-mail. To reply, visit:
http://reviews.gem5.org/r/3757/#review9286
---
Ship it!
Seems OK to me. Don't let anyone ever tell you that C++ makes
---
This is an automatically generated e-mail. To reply, visit:
http://reviews.gem5.org/r/3756/#review9285
---
Does converting this to a class have any impact on performance?
---
This is an automatically generated e-mail. To reply, visit:
http://reviews.gem5.org/r/3754/#review9284
---
I've looked through the patch... but I really don't know anything about
---
This is an automatically generated e-mail. To reply, visit:
http://reviews.gem5.org/r/3360/#review9283
---
Ship it!
Ship It!
- Matthias Jung
On Dez. 16, 2016, 4:24 nachm.,
---
This is an automatically generated e-mail. To reply, visit:
http://reviews.gem5.org/r/3780/#review9282
---
Ship it!
Ship It!
- Brandon Potter
On Jan. 18, 2017, 5:39 p.m., Alec
---
This is an automatically generated e-mail. To reply, visit:
http://reviews.gem5.org/r/3773/#review9281
---
Overall this patch looks really good. I'm sure it helps out GPU
---
This is an automatically generated e-mail. To reply, visit:
http://reviews.gem5.org/r/3676/#review9280
---
Ship it!
Ship It!
- Tony Gutierrez
On Nov. 16, 2016, 9:59 a.m.,
---
This is an automatically generated e-mail. To reply, visit:
http://reviews.gem5.org/r/3789/#review9279
---
Ship it!
Ship It!
- Tony Gutierrez
On Jan. 19, 2017, 10:28 a.m.,
---
This is an automatically generated e-mail. To reply, visit:
http://reviews.gem5.org/r/3676/#review9278
---
Ship it!
Ship It!
- Michael LeBeane
On Nov. 16, 2016, 5:59 p.m.,
---
This is an automatically generated e-mail. To reply, visit:
http://reviews.gem5.org/r/3779/#review9277
---
Ship it!
This is similar to the fix I locally apply on my local CentOS
---
This is an automatically generated e-mail. To reply, visit:
http://reviews.gem5.org/r/3789/
---
(Updated Jan. 19, 2017, 6:28 p.m.)
Review request for Default.
Repository: gem5
> On Jan. 19, 2017, 5:33 p.m., Tony Gutierrez wrote:
> > LGTM, but just to clarify, you don't need to guard the inclusion of any
> > system headers?
There's a preexisting macro in that file for stat64 which uses the same
exclusion method. It's verbatim what I copied except that I don't check
---
This is an automatically generated e-mail. To reply, visit:
http://reviews.gem5.org/r/3677/#review9275
---
Ship it!
Ship It!
- Tony Gutierrez
On Jan. 19, 2017, 8:05 a.m.,
---
This is an automatically generated e-mail. To reply, visit:
http://reviews.gem5.org/r/3789/#review9274
---
Ship it!
LGTM, but just to clarify, you don't need to guard the
changeset e034a4566653 in /z/repo/gem5
details: http://repo.gem5.org/gem5?cmd=changeset;node=e034a4566653
description:
ruby: guard usage of GPUCoalescer code in Profiler
the GPUCoalescer code is used in the ruby profiler regardless of
whether or not the coalescer code has
changeset f61fbb7ceb88 in /z/repo/gem5
details: http://repo.gem5.org/gem5?cmd=changeset;node=f61fbb7ceb88
description:
ruby: Check MessageBuffer space in garnet NetworkInterface
Garnet's NetworkInterface does not consider the size of MessageBuffers
when
ejecting a Message
changeset 315e133f45df in /z/repo/gem5
details: http://repo.gem5.org/gem5?cmd=changeset;node=315e133f45df
description:
ruby: Add occupancy stats to MessageBuffers
This patch is an updated version of /r/3297.
"The most important statistic for measuring memory hierarchy
changeset 588a45268ce4 in /z/repo/gem5
details: http://repo.gem5.org/gem5?cmd=changeset;node=588a45268ce4
description:
ruby: Check all VNETs for injection in garnet NetworkInterface
The NetworkInterface wakeup currently iterates over all VNETs and
breaks the
loop if a
---
This is an automatically generated e-mail. To reply, visit:
http://reviews.gem5.org/r/3360/#review9273
---
Ship it!
Ship It!
- Christian Menard
On Dec. 16, 2016, 4:24 p.m.,
* build/ALPHA/tests/opt/quick/se/00.hello/alpha/linux/minor-timing: CHANGED!
* build/ALPHA/tests/opt/quick/se/00.hello/alpha/linux/o3-timing: CHANGED!
* build/ALPHA/tests/opt/quick/se/01.hello-2T-smt/alpha/linux/o3-timing-mt:
CHANGED!
*
21 matches
Mail list logo