Re: [gem5-dev] Review Request 3778: Fix order of object construction in the CxxConfigManager

2017-01-19 Thread Jason Lowe-Power
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3778/#review9288 --- Ship it! Comment below is just in case anyone else was confused, like I

Re: [gem5-dev] Review Request 3757: arch: added generic vector register

2017-01-19 Thread Jason Lowe-Power
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3757/#review9286 --- Ship it! Seems OK to me. Don't let anyone ever tell you that C++ makes

Re: [gem5-dev] Review Request 3756: cpu: Result refactoring

2017-01-19 Thread Jason Lowe-Power
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3756/#review9285 --- Does converting this to a class have any impact on performance?

Re: [gem5-dev] Review Request 3754: cpu: Simplify the rename interface and use RegId

2017-01-19 Thread Jason Lowe-Power
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3754/#review9284 --- I've looked through the patch... but I really don't know anything about

Re: [gem5-dev] Review Request 3360: misc: Add support for switching multiple cores in SystemC

2017-01-19 Thread Matthias Jung
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3360/#review9283 --- Ship it! Ship It! - Matthias Jung On Dez. 16, 2016, 4:24 nachm.,

Re: [gem5-dev] Review Request 3780: riscv: Fix crash when syscall argument reg index is too high

2017-01-19 Thread Brandon Potter
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3780/#review9282 --- Ship it! Ship It! - Brandon Potter On Jan. 18, 2017, 5:39 p.m., Alec

Re: [gem5-dev] Review Request 3773: ruby: PerfectSwitch add assured access arbitration

2017-01-19 Thread Brad Beckmann
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3773/#review9281 --- Overall this patch looks really good. I'm sure it helps out GPU

Re: [gem5-dev] Review Request 3676: syscall_emul: [patch 10/22] refactor fdentry and add fdarray class

2017-01-19 Thread Tony Gutierrez
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3676/#review9280 --- Ship it! Ship It! - Tony Gutierrez On Nov. 16, 2016, 9:59 a.m.,

Re: [gem5-dev] Review Request 3789: syscall_emul: #ifdef new system calls to allow builds on OSX and BSD

2017-01-19 Thread Tony Gutierrez
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3789/#review9279 --- Ship it! Ship It! - Tony Gutierrez On Jan. 19, 2017, 10:28 a.m.,

Re: [gem5-dev] Review Request 3676: syscall_emul: [patch 10/22] refactor fdentry and add fdarray class

2017-01-19 Thread Michael LeBeane
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3676/#review9278 --- Ship it! Ship It! - Michael LeBeane On Nov. 16, 2016, 5:59 p.m.,

Re: [gem5-dev] Review Request 3779: proto: Fix warnings for protoc v3

2017-01-19 Thread Joe Gross
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3779/#review9277 --- Ship it! This is similar to the fix I locally apply on my local CentOS

Re: [gem5-dev] Review Request 3789: syscall_emul: #ifdef new system calls to allow builds on OSX and BSD

2017-01-19 Thread Brandon Potter
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3789/ --- (Updated Jan. 19, 2017, 6:28 p.m.) Review request for Default. Repository: gem5

Re: [gem5-dev] Review Request 3789: syscall_emul: #ifdef new system calls to allow builds on OSX and BSD

2017-01-19 Thread Brandon Potter
> On Jan. 19, 2017, 5:33 p.m., Tony Gutierrez wrote: > > LGTM, but just to clarify, you don't need to guard the inclusion of any > > system headers? There's a preexisting macro in that file for stat64 which uses the same exclusion method. It's verbatim what I copied except that I don't check

Re: [gem5-dev] Review Request 3677: syscall_emul: [patch 11/22] extend functionality of fcntl

2017-01-19 Thread Tony Gutierrez
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3677/#review9275 --- Ship it! Ship It! - Tony Gutierrez On Jan. 19, 2017, 8:05 a.m.,

Re: [gem5-dev] Review Request 3789: syscall_emul: #ifdef new system calls to allow builds on OSX and BSD

2017-01-19 Thread Tony Gutierrez
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3789/#review9274 --- Ship it! LGTM, but just to clarify, you don't need to guard the

[gem5-dev] changeset in gem5: ruby: guard usage of GPUCoalescer code in Pro...

2017-01-19 Thread Tony Gutierrez
changeset e034a4566653 in /z/repo/gem5 details: http://repo.gem5.org/gem5?cmd=changeset;node=e034a4566653 description: ruby: guard usage of GPUCoalescer code in Profiler the GPUCoalescer code is used in the ruby profiler regardless of whether or not the coalescer code has

[gem5-dev] changeset in gem5: ruby: Check MessageBuffer space in garnet Net...

2017-01-19 Thread Matthew Poremba
changeset f61fbb7ceb88 in /z/repo/gem5 details: http://repo.gem5.org/gem5?cmd=changeset;node=f61fbb7ceb88 description: ruby: Check MessageBuffer space in garnet NetworkInterface Garnet's NetworkInterface does not consider the size of MessageBuffers when ejecting a Message

[gem5-dev] changeset in gem5: ruby: Add occupancy stats to MessageBuffers

2017-01-19 Thread Matthew Poremba
changeset 315e133f45df in /z/repo/gem5 details: http://repo.gem5.org/gem5?cmd=changeset;node=315e133f45df description: ruby: Add occupancy stats to MessageBuffers This patch is an updated version of /r/3297. "The most important statistic for measuring memory hierarchy

[gem5-dev] changeset in gem5: ruby: Check all VNETs for injection in garnet...

2017-01-19 Thread Matthew Poremba
changeset 588a45268ce4 in /z/repo/gem5 details: http://repo.gem5.org/gem5?cmd=changeset;node=588a45268ce4 description: ruby: Check all VNETs for injection in garnet NetworkInterface The NetworkInterface wakeup currently iterates over all VNETs and breaks the loop if a

Re: [gem5-dev] Review Request 3360: misc: Add support for switching multiple cores in SystemC

2017-01-19 Thread Christian Menard
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3360/#review9273 --- Ship it! Ship It! - Christian Menard On Dec. 16, 2016, 4:24 p.m.,

[gem5-dev] Cron <m5test@zizzer> /z/m5/regression/do-regression quick

2017-01-19 Thread Cron Daemon
* build/ALPHA/tests/opt/quick/se/00.hello/alpha/linux/minor-timing: CHANGED! * build/ALPHA/tests/opt/quick/se/00.hello/alpha/linux/o3-timing: CHANGED! * build/ALPHA/tests/opt/quick/se/01.hello-2T-smt/alpha/linux/o3-timing-mt: CHANGED! *