[gem5-dev] Review Request 2527: config: ruby: Get rid of an eval and an exec operating on generated code.

2014-11-23 Thread Gabe Black via gem5-dev
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2527/ --- Review request for Default. Repository: gem5 Description --- Changeset

Re: [gem5-dev] Review Request 2527: config: ruby: Get rid of an eval and an exec operating on generated code.

2014-11-23 Thread Nilay Vaish via gem5-dev
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2527/#review5521 --- Ship it! Ship It! - Nilay Vaish On Nov. 23, 2014, 11:03 a.m., Gabe

Re: [gem5-dev] Review Request 2527: config: ruby: Get rid of an eval and an exec operating on generated code.

2014-11-23 Thread Steve Reinhardt via gem5-dev
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2527/#review5529 --- Looks like importlib is only available in 2.7

Re: [gem5-dev] Review Request 2527: config: ruby: Get rid of an eval and an exec operating on generated code.

2014-11-23 Thread Andreas Hansson via gem5-dev
Hi all, I strongly suggest to not go beyond 2.6 at the moment. All Ubuntu 12.04 machines and RHE6 machines have 2.6 as their default, and that matches with our previous assumptions also regarding gcc etc. I agree with Steve that we can consider a move to 2.7, but it should be for stronger

Re: [gem5-dev] Review Request 2527: config: ruby: Get rid of an eval and an exec operating on generated code.

2014-11-23 Thread Gabe Black via gem5-dev
On Nov. 23, 2014, 7:37 p.m., Steve Reinhardt wrote: Looks like importlib is only available in 2.7 (https://docs.python.org/2/library/importlib.html), and according to http://gem5.org/Dependencies we still support 2.5 and 2.6 as well. Is that accurate? In isolation, this seems

Re: [gem5-dev] Review Request 2527: config: ruby: Get rid of an eval and an exec operating on generated code.

2014-11-23 Thread Nilay Vaish via gem5-dev
On Sun, 23 Nov 2014, Andreas Hansson via gem5-dev wrote: Hi all, I strongly suggest to not go beyond 2.6 at the moment. All Ubuntu 12.04 machines and RHE6 machines have 2.6 as their default, and that matches with our previous assumptions also regarding gcc etc. I agree with Steve that we

Re: [gem5-dev] Review Request 2527: config: ruby: Get rid of an eval and an exec operating on generated code.

2014-11-23 Thread Steve Reinhardt via gem5-dev
On Sun, Nov 23, 2014 at 5:28 PM, Nilay Vaish via gem5-dev gem5-dev@gem5.org wrote: I want to keep the changeset for a little while and see if users complain about it. The versions of Linux you mention are going to be around for a significant amount of time, so I do not want to base my