[gem5-dev] Cron <m5test@zizzer> /z/m5/regression/do-regression quick

2016-04-13 Thread Cron Daemon
* build/ALPHA/tests/opt/quick/fs/10.linux-boot/alpha/linux/tsunami-simple-atomic-dual passed. * build/ALPHA/tests/opt/quick/fs/10.linux-boot/alpha/linux/tsunami-simple-timing passed. * build/ALPHA/tests/opt/quick/se/30.eon/alpha/tru64/simple-atomic passed. *

Re: [gem5-dev] Review Request 3194: Properly space pad the X86IntelMPBus Entry descriptions.

2016-04-13 Thread Jason Lowe-Power
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3194/#review8198 --- Ship it! Seems fine to me. The linux kernel I'm using boots correctly

Re: [gem5-dev] Review Request 3194: Properly space pad the X86IntelMPBus Entry descriptions.

2016-04-13 Thread Bjoern A. Zeeb
> On Nov. 5, 2015, 3:21 p.m., Nilay Vaish wrote: > > src/arch/x86/bios/IntelMP.py, lines 118-122 > > > > > > This is a comment. I don't see how changing it helps. I would rather > > add the "6 byte" comment near the

Re: [gem5-dev] Review Request 3446: hsail, gpu-compute: fixes to appease clang++

2016-04-13 Thread Tony Gutierrez
> On April 12, 2016, 11:15 a.m., Andreas Hansson wrote: > > Thanks! There were a few more issues when I tried to run on zizzer, which has clang 3.6. These fixes allow the regressions to pass, disregarding the skipped eio tests. - Tony

Re: [gem5-dev] Review Request 3446: hsail, gpu-compute: fixes to appease clang++

2016-04-13 Thread Tony Gutierrez
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3446/ --- (Updated April 13, 2016, 7:58 a.m.) Review request for Default. Repository: gem5

Re: [gem5-dev] Review Request 3378: scons: make build better on FreeBSD

2016-04-13 Thread Bjoern A. Zeeb
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3378/ --- (Updated April 13, 2016, 2:18 p.m.) Review request for Default. Changes ---

Re: [gem5-dev] Review Request 2691: mem: implement x86 locked accesses in timing-mode classic cache

2016-04-13 Thread Bjoern A. Zeeb
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2691/#review8197 --- Can you please update it? It neither applies cleanly nor does it compile

[gem5-dev] Review Request 3447: x86, dev: properly space the APIC registers

2016-04-13 Thread Bjoern A. Zeeb
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3447/ --- Review request for Default, Jason Lowe-Power and Steve Reinhardt. Repository: gem5

Re: [gem5-dev] Review Request 3446: hsail, gpu-compute: fixes to appease clang++

2016-04-13 Thread Tony Gutierrez
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3446/ --- (Updated April 13, 2016, 8:09 a.m.) Review request for Default. Repository: gem5

Re: [gem5-dev] Review Request 3442: ruby: allows multiple instances of ruby to be invoked

2016-04-13 Thread Joel Hestness
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3442/#review8203 --- Cool! This is much slimmer than prior review requests, and a lot easier

Re: [gem5-dev] Review Request 3446: hsail, gpu-compute: fixes to appease clang++

2016-04-13 Thread Tony Gutierrez
> On April 13, 2016, 9:24 a.m., Andreas Hansson wrote: > > On the X86 side of things (but somewhat unrelated)...when compiled with > > clang-3.6 the following regression fails with a segfault: > > > > build/X86/tests/opt/quick/fs/10.linux-boot/x86/linux/pc-simple-timing > > > > Not sure why,

[gem5-dev] changeset in gem5: misc: Fix issues flagged by gcc 6

2016-04-13 Thread Andreas Hansson
changeset df24b9af42c7 in /z/repo/gem5 details: http://repo.gem5.org/gem5?cmd=changeset;node=df24b9af42c7 description: misc: Fix issues flagged by gcc 6 A few warnings (and thus errors) pop up after being added to -Wall: 1. -Wmisleading-indentation In the

Re: [gem5-dev] Review Request 3378: scons: make build better on FreeBSD

2016-04-13 Thread Andreas Hansson
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3378/#review8200 --- SConstruct (line 639)

Re: [gem5-dev] Review Request 3446: hsail, gpu-compute: fixes to appease clang++

2016-04-13 Thread Andreas Hansson
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3446/#review8201 --- On the X86 side of things (but somewhat unrelated)...when compiled with

Re: [gem5-dev] Review Request 3446: hsail, gpu-compute: fixes to appease clang++

2016-04-13 Thread Andreas Hansson
> On April 13, 2016, 4:24 p.m., Andreas Hansson wrote: > > On the X86 side of things (but somewhat unrelated)...when compiled with > > clang-3.6 the following regression fails with a segfault: > > > > build/X86/tests/opt/quick/fs/10.linux-boot/x86/linux/pc-simple-timing > > > > Not sure why,

[gem5-dev] Review Request 3449: Add support for McVerSi memory consistency verification framework

2016-04-13 Thread Marco Elver
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3449/ --- Review request for Default. Repository: gem5 Description --- Add support

Re: [gem5-dev] Memory consistency verification (and some bugs)

2016-04-13 Thread Marco Elver
Hi Andreas, Thanks for the comments. I hope pruning ext/ (McPat?) is not a pre-requisite for getting my library in. Regarding MemChecker: I can imagine that it keeps accumulating and allocating more and more addresses over time, the longer the system is running. McVerSi is very different from

Re: [gem5-dev] Review Request 3449: Add support for McVerSi memory consistency verification framework

2016-04-13 Thread Marco Elver
> On April 13, 2016, 5:49 p.m., Andreas Hansson wrote: > > Really nice to see more work along these lines. > > > > I am keen to make sure we "finish what we started", and for that reason I > > would like to understand how this relates to the existing MemChecker. Also, > > I'd really like to

Re: [gem5-dev] Review Request 3441: ruby: fix MESI_Three_Level protocol

2016-04-13 Thread Jason Lowe-Power
> On April 13, 2016, 6:17 p.m., Jason Lowe-Power wrote: > > Before this patch this protocol was broken? From the changes, it doesn't > > even look like it would have compiled. Is this true? In one way I'm shocked > > this happend. In another I'm not surprised at all... :( > > Brandon Potter

Re: [gem5-dev] Review Request 3194: Properly space pad the X86IntelMPBus Entry descriptions.

2016-04-13 Thread Bjoern A. Zeeb
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3194/ --- (Updated April 13, 2016, 2:23 p.m.) Review request for Default, Jason Lowe-Power

[gem5-dev] Python 2.7 dependency (was Re: changeset in gem5: scons, style: Rename style.py to hgstyle.py)

2016-04-13 Thread Steve Reinhardt
So this construct: +with open(hgrc_old.abspath, 'r') as old, \ + open(hgrc.abspath, 'w') as new: only works in Python 2.7, yet we continue to claim to support Python 2.5 and 2.6. Someday we'll want to bump that up, but for now I'd prefer to at least keep supporting 2.6 (we

[gem5-dev] Review Request 3448: Add mc2lib to ext/

2016-04-13 Thread Marco Elver
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3448/ --- Review request for Default. Repository: gem5 Description --- Add mc2lib to

Re: [gem5-dev] Memory consistency verification (and some bugs)

2016-04-13 Thread Marco Elver
Hi Brad, Many thanks for your comments, the patches are now on the RB. Marco On Tue, 12 Apr 2016, Beckmann, Brad wrote: > Hi Marco, > > Thank you for initiating the discussion. You mentioned concerns with > checking in your patch >

Re: [gem5-dev] Review Request 3441: ruby: fix MESI_Three_Level protocol

2016-04-13 Thread Joel Hestness
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3441/#review8142 --- I'm not clear how this change fixes the exception noted above. Can you

Re: [gem5-dev] Review Request 3449: Add support for McVerSi memory consistency verification framework

2016-04-13 Thread Brad Beckmann
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3449/#review8214 --- Thank you Marco for posting the patch. Unfortunately most of your patch

Re: [gem5-dev] Review Request 3441: ruby: fix MESI_Three_Level protocol

2016-04-13 Thread Brandon Potter
> On April 13, 2016, 6:17 p.m., Jason Lowe-Power wrote: > > Before this patch this protocol was broken? From the changes, it doesn't > > even look like it would have compiled. Is this true? In one way I'm shocked > > this happend. In another I'm not surprised at all... :( It doesn't make it

Re: [gem5-dev] Review Request 3441: ruby: fix MESI_Three_Level protocol

2016-04-13 Thread Brandon Potter
> On April 13, 2016, 6:17 p.m., Jason Lowe-Power wrote: > > Before this patch this protocol was broken? From the changes, it doesn't > > even look like it would have compiled. Is this true? In one way I'm shocked > > this happend. In another I'm not surprised at all... :( > > Brandon Potter

Re: [gem5-dev] Review Request 3448: Add mc2lib to ext/

2016-04-13 Thread Marco Elver
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3448/ --- (Updated April 13, 2016, 7:50 p.m.) Review request for Default. Changes ---

Re: [gem5-dev] Review Request 3449: Add support for McVerSi memory consistency verification framework

2016-04-13 Thread Marco Elver
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3449/ --- (Updated April 13, 2016, 7:53 p.m.) Review request for Default. Changes ---

Re: [gem5-dev] Review Request 3441: ruby: fix MESI_Three_Level protocol

2016-04-13 Thread Brandon Potter
> On April 13, 2016, 7:08 p.m., Joel Hestness wrote: > > I'm not clear how this change fixes the exception noted above. Can you > > elaborate? > > > > Also, the diff here doesn't apply cleanly to the current mainline head. Is > > there another patch that needs to be applied before this? This

Re: [gem5-dev] Review Request 3441: ruby: fix MESI_Three_Level protocol

2016-04-13 Thread Brandon Potter
> On April 13, 2016, 7:08 p.m., Joel Hestness wrote: > > configs/ruby/MESI_Three_Level.py, line 153 > > > > > > This change connects the L0 caches to the network rather than > > connecting them directly to the L1 caches.

Re: [gem5-dev] Review Request 3441: ruby: fix MESI_Three_Level protocol

2016-04-13 Thread Brad Beckmann
> On April 13, 2016, 7:08 p.m., Joel Hestness wrote: > > configs/ruby/MESI_Three_Level.py, line 153 > > > > > > This change connects the L0 caches to the network rather than > > connecting them directly to the L1 caches.

Re: [gem5-dev] Review Request 3441: ruby: fix MESI_Three_Level protocol

2016-04-13 Thread Jason Lowe-Power
> On April 13, 2016, 7:08 p.m., Joel Hestness wrote: > > I'm not clear how this change fixes the exception noted above. Can you > > elaborate? > > > > Also, the diff here doesn't apply cleanly to the current mainline head. Is > > there another patch that needs to be applied before this? > >

Re: [gem5-dev] Review Request 3449: Add support for McVerSi memory consistency verification framework

2016-04-13 Thread Andreas Hansson
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3449/#review8206 --- Really nice to see more work along these lines. I am keen to make sure

Re: [gem5-dev] Review Request 3441: ruby: fix MESI_Three_Level protocol

2016-04-13 Thread Jason Lowe-Power
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3441/#review8209 --- Before this patch this protocol was broken? From the changes, it doesn't

Re: [gem5-dev] changeset in gem5: misc: Don't build region.py as a PySource

2016-04-13 Thread Gross, Joe
Hi Andreas, This checkin recently made it downstream to our internal repo and I notice that you've added a SequenceMatcher with the autojunk parameter. Currently gem5 claims to require python 2.5-2.7 (http://www.m5sim.org/Dependencies). However, adding this parameter now requires

Re: [gem5-dev] Review Request 3449: Add support for McVerSi memory consistency verification framework

2016-04-13 Thread Andreas Hansson
> On April 13, 2016, 5:49 p.m., Andreas Hansson wrote: > > Really nice to see more work along these lines. > > > > I am keen to make sure we "finish what we started", and for that reason I > > would like to understand how this relates to the existing MemChecker. Also, > > I'd really like to

Re: [gem5-dev] Review Request 3449: Add support for McVerSi memory consistency verification framework

2016-04-13 Thread Marco Elver
> On April 13, 2016, 5:49 p.m., Andreas Hansson wrote: > > Really nice to see more work along these lines. > > > > I am keen to make sure we "finish what we started", and for that reason I > > would like to understand how this relates to the existing MemChecker. Also, > > I'd really like to