Re: [gem5-dev] testing

2014-12-03 Thread Gabe Black via gem5-dev
What I'd like is for us not to use stats as a pass/fail criteria. I'm not sure how that would work, but using the stats is pretty fragile and hard to maintain. It's tricky because you want to make sure the stats themselves are still correct, but there are lots of "correct" stats which are different

Re: [gem5-dev] testing

2014-12-03 Thread Steve Reinhardt via gem5-dev
Hi Gabe, There's a long history here; I think everyone agrees the status quo wrt testing is inadequate, but there are a lot of different needs as well. I won't go into a lot of detail, but there is a wiki page left over from our last attempt: http://gem5.org/NewRegressionFramework. Actually I se

Re: [gem5-dev] Syscall emulation/fake Linux/KVM/SE FS integration

2014-12-03 Thread Gabe Black via gem5-dev
Basically, I'd like the distinction between SE and FS to be in how the user chooses to use the simulator. Right now, there are two parallel systems inherited from two separate builds, and having two ways to do certain things (write to memory, execute a syscall instruction, etc.) leads to some redun

Re: [gem5-dev] Syscall emulation/fake Linux/KVM/SE FS integration

2014-12-03 Thread Steve Reinhardt via gem5-dev
Hi Gabe, I can see how the KVM SE-mode support does look like a piece of what you're proposing. In this case there's a clear need for that functionality though. I'm curious what you see as the benefits of taking this model farther than strictly necessary for KVM SE mode. Not that I'm necessarily

Re: [gem5-dev] Protocol Specific Profiling

2014-12-03 Thread Nilay Vaish via gem5-dev
On Wed, 3 Dec 2014, Beckmann, Brad wrote: I have more questions/issues on this topic of protocol specific profiling. I do not believe this issues should be fixed by having SLICC understand more STL types. I should have pointed out before that many times it is not one specific protocol that n

[gem5-dev] Review Request 2548: arm: Add unlinkat syscall implementation

2014-12-03 Thread mike upton via gem5-dev
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2548/ --- Review request for Default. Repository: gem5 Description --- arm: Add unlink

Re: [gem5-dev] Review Request 2545: dev: Prevent MC146818 timer RTC events firing before startup

2014-12-03 Thread Cagdas Dirik via gem5-dev
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2545/ --- (Updated Dec. 3, 2014, 5:16 p.m.) Review request for Default, Andrew Bardsley, Andr

Re: [gem5-dev] changeset in gem5: ruby: slicc: change the way configurable memb...

2014-12-03 Thread Beckmann, Brad via gem5-dev
In SLICC we also use commas to separate parameters passed into a function or class...like most other languages I'm aware of. Using semi-colons seems awkward. I understand your point about message buffers, but that is only a problem because we are trying to pass these objects as parameters. Ac

Re: [gem5-dev] Review Request 2547: x86: Clean up style in process.cc.

2014-12-03 Thread Gabe Black via gem5-dev
> On Dec. 2, 2014, 6:26 a.m., Steve Reinhardt wrote: > > It would be nice to actually test this code just to be sure nothing slipped > > through, but style-wise it does look like an improvement. I might spend some personal time (vs. work time) at some point seeing if I can figure out what the

[gem5-dev] changeset in gem5: x86: Clean up style in process.cc.

2014-12-03 Thread Gabe Black via gem5-dev
changeset ad9146bb5598 in /z/repo/gem5 details: http://repo.gem5.org/gem5?cmd=changeset;node=ad9146bb5598 description: x86: Clean up style in process.cc. diffstat: src/arch/x86/process.cc | 98 1 files changed, 49 insertions(+), 49 deleti

Re: [gem5-dev] Review Request 2505: arch: Allow named constants as decode case values.

2014-12-03 Thread Gabe Black via gem5-dev
> On Dec. 2, 2014, 5:44 a.m., Steve Reinhardt wrote: > > src/arch/isa_parser.py, line 1991 > > > > > > update comment I assume you mean just making it plural? The values do still have to be constant or C++ will get angry.

Re: [gem5-dev] Review Request 2505: arch: Allow named constants as decode case values.

2014-12-03 Thread Gabe Black via gem5-dev
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2505/ --- (Updated Dec. 3, 2014, 11:56 a.m.) Review request for Default. Repository: gem5

Re: [gem5-dev] Review Request 2510: Let other objects set up memory like regions in a KVM VM.

2014-12-03 Thread Gabe Black via gem5-dev
> On Dec. 3, 2014, 11:42 a.m., Andreas Hansson wrote: > > As this is quite invasive, how broadly would this be used? Also, is there > > any chance of rather using devices that do not have memory of their own > > (and rely on the "normal" system memory that is already mapped)? The one example I

Re: [gem5-dev] Review Request 2510: Let other objects set up memory like regions in a KVM VM.

2014-12-03 Thread Andreas Hansson via gem5-dev
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2510/#review5613 --- As this is quite invasive, how broadly would this be used? Also, is there

Re: [gem5-dev] Review Request 2510: Let other objects set up memory like regions in a KVM VM.

2014-12-03 Thread Gabe Black via gem5-dev
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2510/#review5611 --- Ping - Gabe Black On Nov. 23, 2014, 2:51 p.m., Gabe Black wrote: > >

[gem5-dev] changeset in gem5: sim: Make it possible to override the breakpo...

2014-12-03 Thread Gabe Black via gem5-dev
changeset 5962812f80fe in /z/repo/gem5 details: http://repo.gem5.org/gem5?cmd=changeset;node=5962812f80fe description: sim: Make it possible to override the breakpoint length check. The check which makes sure the length of the breakpoint being written is the same as a Mach

[gem5-dev] Cron /z/m5/regression/do-regression quick

2014-12-03 Thread Cron Daemon via gem5-dev
* build/ALPHA/tests/opt/quick/se/00.hello/alpha/linux/o3-timing passed. * build/ALPHA/tests/opt/quick/se/00.hello/alpha/linux/simple-timing-ruby passed. * build/ALPHA/tests/opt/quick/se/20.eio-short/alpha/eio/simple-timing passed. * build/ALPHA/tests/opt/quick/se/30.eio-mp/alpha/

Re: [gem5-dev] Review Request 2538: misc: Make the GDB register cache accessible in various sized chunks.

2014-12-03 Thread Gabe Black via gem5-dev
> On Dec. 2, 2014, 5:47 p.m., Nilay Vaish wrote: > > src/base/remote_gdb.hh, line 143 > > > > > > Should this not be divCeil() * sizeof(uint64_t)? No. The "size" member reflects the size you asked for, not the size you got

Re: [gem5-dev] Review Request 2524: config: Add two options for setting the kernel command line.

2014-12-03 Thread Gabe Black via gem5-dev
> On Nov. 30, 2014, 6:38 p.m., Nilay Vaish wrote: > > I do not see much value though, but I am fine with patch. > > Gabe Black wrote: > The ChromeOS kernel needs lots of command line arguments, both to > configure the kernel and to leave information for the system at large. This > is so we

[gem5-dev] changeset in gem5: config: Get rid of some extra spaces around d...

2014-12-03 Thread Gabe Black via gem5-dev
changeset 145c436a3854 in /z/repo/gem5 details: http://repo.gem5.org/gem5?cmd=changeset;node=145c436a3854 description: config: Get rid of some extra spaces around default arguments. diffstat: configs/common/FSConfig.py | 16 +++- 1 files changed, 7 insertions(+), 9 deletions

Re: [gem5-dev] changeset in gem5: ide: Accept the IDLE (0xe3) ATA command.

2014-12-03 Thread Gabe Black via gem5-dev
Ah, darn it. I meant to update the tag before I pushed this. Sorry about that. Gabe On Wed, Dec 3, 2014 at 2:59 AM, Gabe Black via gem5-dev wrote: > changeset 24abf21b548d in /z/repo/gem5 > details: http://repo.gem5.org/gem5?cmd=changeset;node=24abf21b548d > description: > ide: Accept t

[gem5-dev] changeset in gem5: ide: Accept the IDLE (0xe3) ATA command.

2014-12-03 Thread Gabe Black via gem5-dev
changeset 24abf21b548d in /z/repo/gem5 details: http://repo.gem5.org/gem5?cmd=changeset;node=24abf21b548d description: ide: Accept the IDLE (0xe3) ATA command. This command is supposed to set up a timer which will put the drive into a standby mode if it isn't sent a comman

[gem5-dev] changeset in gem5: dev: Support translating left and right ALT k...

2014-12-03 Thread Gabe Black via gem5-dev
changeset 9a4a926f7fe1 in /z/repo/gem5 details: http://repo.gem5.org/gem5?cmd=changeset;node=9a4a926f7fe1 description: dev: Support translating left and right ALT keys. This is used primarily for VNC. diffstat: src/dev/ps2.cc | 7 +++ 1 files changed, 7 insertions(+), 0 del

Re: [gem5-dev] Protocol Specific Profiling

2014-12-03 Thread Andreas Hansson via gem5-dev
Hi guys, Slightly off topic, but it sounds like you want some form of inheritance structure between the protocols. Andreas On 03/12/2014 01:16, "Beckmann, Brad via gem5-dev" wrote: >I have more questions/issues on this topic of protocol specific >profiling. I do not believe this issues should