> On Dec. 2, 2014, 5:44 a.m., Steve Reinhardt wrote: > > src/arch/isa_parser.py, line 1991 > > <http://reviews.gem5.org/r/2505/diff/2/?file=42744#file42744line1991> > > > > update comment
I assume you mean just making it plural? The values do still have to be constant or C++ will get angry. > On Dec. 2, 2014, 5:44 a.m., Steve Reinhardt wrote: > > src/arch/isa_parser.py, line 1994 > > <http://reviews.gem5.org/r/2505/diff/2/?file=42744#file42744line1994> > > > > it would be nice to update this variable name too ('case_list'?) How about decode_vals? I'm open to suggestions. > On Dec. 2, 2014, 5:44 a.m., Steve Reinhardt wrote: > > src/arch/isa_parser.py, line 2025 > > <http://reviews.gem5.org/r/2505/diff/2/?file=42744#file42744line2025> > > > > do you really mean "C++ symbols" not "C++ strings"? > > Steve Reinhardt wrote: > OK, I see from the other patch that it really is strings. If you put in > a string that doesn't evaluate to a constant, is that caught by the C++ > compiler? If so, it might be more accurate to say "strings (which must > evaluate to constants to avoid a compilation error)" rather than just > "strings which evaluate to constants" I changed it to "strings which evaluate to constants when compiled as C++" - Gabe ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2505/#review5598 ----------------------------------------------------------- On Dec. 3, 2014, 11:56 a.m., Gabe Black wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/2505/ > ----------------------------------------------------------- > > (Updated Dec. 3, 2014, 11:56 a.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > Changeset 10590:1c185336bb80 > --------------------------- > arch: Allow named constants as decode case values. > > The values in a "bitfield" or in an ExtMachInst structure member may not be a > literal value, it might select from an arbitrary collection of options. > Instead > of using the raw value of those constants in the decoder, it's easier to tell > what's going on if they can be referred to as a symbolic constant/enum. > > To support that, the ISA description language is extended slightly so that in > addition to integer literals, the case value for decode blobs can also be a > string literal. It's up to the ISA author to ensure that the string evaluates > to a legal constant value when interpretted as C++. > > > Diffs > ----- > > src/arch/isa_parser.py 5962812f80fef83240fcb023806e523aa257c2fd > > Diff: http://reviews.gem5.org/r/2505/diff/ > > > Testing > ------- > > > Thanks, > > Gabe Black > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
