[gem5-dev] Review Request 3658: gpu-compute: support in-order data delivery in GM pipe

--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3658/ --- Review request for Default. Repository: gem5 Description --- Changeset

Re: [gem5-dev] macro (and identifier) problems in our source code

Hi Andreas, I thought that the _name designations were meant for private members with accessors; that's what the style guide says: "Class members that have accessor methods should have a leading underscore to indicate that the user should be using an accessor. The accessor functions themselves

Re: [gem5-dev] Review Request 3647: ruby: Fix broken regressions

> On Oct. 7, 2016, 7:15 a.m., Jason Lowe-Power wrote: > > configs/ruby/Ruby.py, line 50 > > > > > > I think I'm missing something, but isn't the network directory and the > > topologies directory both in configs/? Why are

Re: [gem5-dev] Review Request 3647: ruby: Fix broken regressions

--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3647/#review8812 --- Ship it! Ship It! - Tony Gutierrez On Oct. 7, 2016, 10:29 a.m.,

Re: [gem5-dev] Review Request 3647: ruby: Fix broken regressions

> On Oct. 7, 2016, 2:15 p.m., Jason Lowe-Power wrote: > > configs/ruby/Ruby.py, line 50 > > > > > > I think I'm missing something, but isn't the network directory and the > > topologies directory both in configs/? Why are

Re: [gem5-dev] macro (and identifier) problems in our source code

Hi Brandon, No objection on the header include guards. When it comes to private members, I would suggest to just stick with nameOfVar. We have only used _name when there is a constructor parameter name, and it is actually not necessary. It is fine to have the private member be just name, and let

Re: [gem5-dev] Review Request 3493: dev: Redefine 'length' in EthPacketData

> On Oct. 3, 2016, 5:27 p.m., Andreas Sandberg wrote: > > src/dev/net/etherpkt.cc, line 44 > > > > > > I really don't like the way this is breaking checkpoints. > > > > The right thing to do here would be to

Re: [gem5-dev] Review Request 3648: style: Add options to select checkers and apply fixes

> On Oct. 7, 2016, 11:24 p.m., Brandon Potter wrote: > > Do you think it's worthwhile to adopt a more detailed organization for > > headers? > > > > Currently, we have this: > > 1) primary header (foo.hh for foo.cc) > > 2) mix of C/C++ headers alphabetically ordered > > 3) project headers

Re: [gem5-dev] Review Request 3650: style: remove err.h to prevent a name collision

--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3650/#review8807 --- Ship it! The inclusion of err.h (which is a non-standard BSD extension)

[gem5-dev] Review Request 3656: dram: add DDR3-1866/2400

--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3656/ --- Review request for Default. Repository: gem5 Description --- Changeset

Re: [gem5-dev] Review Request 3493: dev: Redefine 'length' in EthPacketData

> On Oct. 3, 2016, 4:27 p.m., Andreas Sandberg wrote: > > src/dev/net/etherpkt.cc, line 44 > > > > > > I really don't like the way this is breaking checkpoints. > > > > The right thing to do here would be to

Re: [gem5-dev] Review Request 3653: gpu-compute: use System cache line size in the GPU

--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3653/#review8805 --- Ship it! May want to move away from _cacheLineSize per Brandon's email:

Re: [gem5-dev] Review Request 3602: mem: Add DRAM low-power functionality

--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3602/#review8804 --- Ship it! Ship It! - Matthew Poremba On Aug. 11, 2016, 9:08 a.m.,

Re: [gem5-dev] Review Request 3602: mem: Add DRAM low-power functionality

> On Oct. 6, 2016, 10:27 p.m., Matthew Poremba wrote: > > I suggest there be a parameter to enable or disable the low-power > > functionality. Ideally, when disabled the model would behave exactly as it > > does prior to the patch. I would be interested to be able to evaluate any > >

Re: [gem5-dev] Review Request 3596: mem: make DDR4 x16

> On Aug. 12, 2016, 2:35 p.m., Matthias Jung wrote: > > Technically everything seams right. However, I think the x8 configuration > > could also be interesting as an default option. E.g. when people want to > > see the effect on their application when having more **banks** (16). I > > suggest

[gem5-dev] Review Request 3655: gpu-compute, hsail: make the PC a byte address, not an instruction index

--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3655/ --- Review request for Default. Repository: gem5 Description --- Changeset

[gem5-dev] Review Request 3654: gpu-compute, hsail: pass GPUDynInstPtr to getRegisterIndex()

--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3654/ --- Review request for Default. Repository: gem5 Description --- Changeset

[gem5-dev] Review Request 3653: gpu-compute: use System cache line size in the GPU

--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3653/ --- Review request for Default. Repository: gem5 Description --- Changeset

[gem5-dev] Review Request 3652: gpu-compute: use the GPUISA object to advance the PC

--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3652/ --- Review request for Default. Repository: gem5 Description --- Changeset

[gem5-dev] Review Request 3651: gpu-compute: add gpu_isa.hh to switch hdrs, add GPUISA to WF

--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3651/ --- Review request for Default. Repository: gem5 Description --- Changeset

Re: [gem5-dev] Review Request 3648: style: Add options to select checkers and apply fixes

> On Oct. 7, 2016, 10:24 p.m., Brandon Potter wrote: > > Do you think it's worthwhile to adopt a more detailed organization for > > headers? > > > > Currently, we have this: > > 1) primary header (foo.hh for foo.cc) > > 2) mix of C/C++ headers alphabetically ordered > > 3) project headers

[gem5-dev] macro (and identifier) problems in our source code

Hello all, I just posted a patch, http://reviews.gem5.org/r/3650/, which deals with a name collision between a macro that's defined in our source and a function declaration included from a standard header. Seems like a rare collision that I stumbled into, but we should do a better job of

Re: [gem5-dev] Review Request 3648: style: Add options to select checkers and apply fixes

> On Oct. 7, 2016, 11:24 p.m., Brandon Potter wrote: > > Do you think it's worthwhile to adopt a more detailed organization for > > headers? > > > > Currently, we have this: > > 1) primary header (foo.hh for foo.cc) > > 2) mix of C/C++ headers alphabetically ordered > > 3) project headers

[gem5-dev] Review Request 3650: style: remove err.h to prevent a name collision

--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3650/ --- Review request for Default. Repository: gem5 Description --- Changeset

[gem5-dev] Garnet2.0 released

Hi gem5 users and developers, I am pleased to announce the release of Garnet2.0 inside gem5! Garnet2.0 replaces the original garnet network model within Ruby. Note: This change only affects users of the Ruby memory system (not the classic memory system). Moreover, the default network model

Re: [gem5-dev] Review Request 3624: arch: [Patch 1/5] Added RISC-V base instruction set RV64I

--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3624/ --- (Updated Oct. 10, 2016, 4:59 p.m.) Review request for Default. Repository: gem5

Re: [gem5-dev] Review Request 3602: mem: Add DRAM low-power functionality

> On Oct. 6, 2016, 10:27 p.m., Matthew Poremba wrote: > > I suggest there be a parameter to enable or disable the low-power > > functionality. Ideally, when disabled the model would behave exactly as it > > does prior to the patch. I would be interested to be able to evaluate any > >

[gem5-dev] Cron <m5test@zizzer> /z/m5/regression/do-regression quick

* build/ALPHA/tests/opt/quick/se/00.hello/alpha/linux/simple-timing-ruby: FAILED! * build/ALPHA/tests/opt/quick/se/50.memtest/alpha/linux/memtest-ruby: FAILED! * build/ALPHA/tests/opt/quick/se/00.hello/alpha/tru64/simple-timing-ruby: FAILED! *