[gem5-dev] Commit changes

2017-01-26 Thread Rahul Thakur
Hi, Requesting folks with commit access to please commit these 2 reviewed changes: http://reviews.gem5.org/r/3708/ http://reviews.gem5.org/r/3740/ Thanks, Rahul. ___ gem5-dev mailing list gem5-dev@gem5.org http://m5sim.org/mailman/listinfo/gem5-dev

Re: [gem5-dev] Compilation error for gem5 after statfs change

2017-01-26 Thread Jason Lowe-Power
Hi Brandon, BTW, here's a Travis-CI config file that will run tests on GCC and Clang on both Mac and Linux hosts. We can add many more parameters for different versions of compilers, etc., but this is something that should allow you to test changes on more than just your current platform. If you

Re: [gem5-dev] Review Request 3785: sim, kvm: make KvmVM a System parameter

2017-01-26 Thread Alexandru Dutu
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3785/#review9330 --- src/sim/system.cc (line 98)

Re: [gem5-dev] Review Request 3785: sim, kvm: make KvmVM a System parameter

2017-01-26 Thread Curtis Dunham
> On Jan. 26, 2017, 5:21 p.m., Alexandru Dutu wrote: > > src/sim/system.cc, line 98 > > > > > > It seems we don't need #if here, p->kvm_vm will be nullptr in case > > there is no initialization from python. Right?

Re: [gem5-dev] Ideas for sprint projects

2017-01-26 Thread Jason Lowe-Power
Thanks everyone who came up with some ideas! I've compiled them on this page on the wiki: http://gem5.org/Sprint_Ideas. Feel free to edit or add more ideas. I tried to expand on each idea with a few sentences, but I didn't get to all of them. I also included the person who suggested the idea with

Re: [gem5-dev] Review Request 3793: x86: Fix implicit stack addressing in 64-bit mode

2017-01-26 Thread Steve Reinhardt
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3793/#review9328 --- src/arch/x86/isa/microops/ldstop.isa (line 382)

Re: [gem5-dev] Compilation error for gem5 after statfs change

2017-01-26 Thread Andreas Hansson
Thanks Brandon! For those attending the workshop at HPCA, it would be great if you could spend a few minutes and see if you can come up with some recommendations around this. Andreas On 26/01/2017, 18:04, "gem5-dev on behalf of Potter, Brandon"

Re: [gem5-dev] Compilation error for gem5 after statfs change

2017-01-26 Thread Bjoern A. Zeeb
On 26 Jan 2017, at 17:04, Potter, Brandon wrote: Hi, in case you are having troubles getting gem5 compiling on it in general please give me a shout as I might have fixes that are either in review or on my local disk and I am more than happy to work with someone to make sure they are all in.

Re: [gem5-dev] Review Request 3788: arm, kvm: remove KvmGic

2017-01-26 Thread Alexandru Dutu
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3788/#review9327 --- Ship it! Ship It! - Alexandru Dutu On Jan. 17, 2017, 10:04 p.m.,

Re: [gem5-dev] Review Request 3784: sim,kvm,arm: fix typos

2017-01-26 Thread Alexandru Dutu
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3784/#review9326 --- Ship it! Ship It! - Alexandru Dutu On Jan. 17, 2017, 10:04 p.m.,

Re: [gem5-dev] Review Request 3766: tests: check for gem5 binary before tests

2017-01-26 Thread Alexandru Dutu
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3766/#review9325 --- Ship it! Ship It! - Alexandru Dutu On Dec. 15, 2016, 4:51 p.m.,

Re: [gem5-dev] Review Request 3787: arm, kvm: Automatically use the MuxingKvmGic

2017-01-26 Thread Alexandru Dutu
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3787/#review9324 --- Ship it! Ship It! - Alexandru Dutu On Jan. 17, 2017, 10:04 p.m.,

Re: [gem5-dev] Review Request 3785: sim, kvm: make KvmVM a System parameter

2017-01-26 Thread Alexandru Dutu
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3785/#review9323 --- src/sim/system.cc (line 98)

Re: [gem5-dev] Bug in x86 stack instructions

2017-01-26 Thread Jason Lowe-Power
I think I get it now. x86 is complicated! Here's a first stab at the patch: http://reviews.gem5.org/r/3793/ Cheers, Jason On Thu, Jan 26, 2017 at 5:23 AM Gabe Black wrote: > As far as explicitly vs. implicitly using the stack segment, I wasn't able > to find a very

Re: [gem5-dev] Compilation error for gem5 after statfs change

2017-01-26 Thread Potter, Brandon
Hello all, I'm trying to resolve this issue. I'm setting up FreeBSD 11 on a VirtualBox instance now to see if I can resolve the problems. Hopefully this covers OSX indirectly as well. I don't expect that moving the offending system calls into Linux specific files will resolve the problem

Re: [gem5-dev] Review Request 3756: cpu: Result refactoring

2017-01-26 Thread Jason Lowe-Power
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3756/#review9322 --- Ship it! Ship It! - Jason Lowe-Power On Jan. 26, 2017, 1:40 p.m.,

Re: [gem5-dev] Review Request 3756: cpu: Result refactoring

2017-01-26 Thread Jason Lowe-Power
> On Jan. 19, 2017, 10:18 p.m., Jason Lowe-Power wrote: > > Does converting this to a class have any impact on performance? > > Rekai Gonzalez Alberquilla wrote: > The honest reply is I do not know. The long reply is: I did differential > performance analysis between the base of the 5

[gem5-dev] Review Request 3793: x86: Fix implicit stack addressing in 64-bit mode

2017-01-26 Thread Jason Lowe-Power
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3793/ --- Review request for Default. Repository: gem5 Description --- x86: Fix

[gem5-dev] Review Request 3792: misc: Update #!env calls for python to explicit version

2017-01-26 Thread Jason Lowe-Power
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3792/ --- Review request for Default. Repository: gem5 Description --- misc: Update

Re: [gem5-dev] Review Request 3756: cpu: Result refactoring

2017-01-26 Thread Rekai Gonzalez Alberquilla
> On Jan. 19, 2017, 10:18 p.m., Jason Lowe-Power wrote: > > Does converting this to a class have any impact on performance? The honest reply is I do not know. The long reply is: I did differential performance analysis between the base of the 5 patches and each of the patches. The 2nd or 3rd

Re: [gem5-dev] Review Request 3756: cpu: Result refactoring

2017-01-26 Thread Rekai Gonzalez Alberquilla
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3756/ --- (Updated Jan. 26, 2017, 1:40 p.m.) Review request for Default. Repository: gem5

Re: [gem5-dev] Review Request 3757: arch: added generic vector register

2017-01-26 Thread Rekai Gonzalez Alberquilla
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3757/ --- (Updated Jan. 26, 2017, 11:20 a.m.) Review request for Default. Repository: gem5

Re: [gem5-dev] Compilation error for gem5 after statfs change

2017-01-26 Thread Andreas Hansson
Hi all, While I agree about the end goal (test every commit on every platform) I would suggest we go about this one step at a time. The likelihood of breakage is only high for anything related to syscall emulation, so it really only affects a small part of the developer community. Agreed? With