Re: [gem5-dev] Review Request 2511: dev: cirrus: Add a simplified device model for the cirrus graphics device.

2015-09-04 Thread Steve Reinhardt
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2511/#review7116 --- Ship it! Is there any value in making it conditional? - Steve

Re: [gem5-dev] Review Request 2511: dev: cirrus: Add a simplified device model for the cirrus graphics device.

2015-09-03 Thread Gabe Black
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2511/#review7112 --- Rebased diff. - Gabe Black On Sept. 3, 2015, 10:26 p.m., Gabe Black

Re: [gem5-dev] Review Request 2511: dev: cirrus: Add a simplified device model for the cirrus graphics device.

2015-09-03 Thread Gabe Black
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2511/ --- (Updated Sept. 3, 2015, 10:26 p.m.) Review request for Default. Repository: gem5

Re: [gem5-dev] Review Request 2511: dev: cirrus: Add a simplified device model for the cirrus graphics device.

2014-12-24 Thread Gabe Black via gem5-dev
On Dec. 23, 2014, 10:25 a.m., Andreas Hansson wrote: Looks fine. Could you mark the issues that are fixed as fixed (or dropped for that matter)? Thanks. I am still not sure if I like the USE_KVM better, or perhaps having a NullKvm object. Yeah. There was one other mistake I

Re: [gem5-dev] Review Request 2511: dev: cirrus: Add a simplified device model for the cirrus graphics device.

2014-12-23 Thread Andreas Hansson via gem5-dev
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2511/#review5708 --- Ship it! Looks fine. Could you mark the issues that are fixed as fixed

Re: [gem5-dev] Review Request 2511: dev: cirrus: Add a simplified device model for the cirrus graphics device.

2014-12-22 Thread Gabe Black via gem5-dev
On Dec. 18, 2014, 10:39 a.m., Gabe Black wrote: src/dev/cirrus.hh, line 48 http://reviews.gem5.org/r/2511/diff/6/?file=43227#file43227line48 They probably shouldn't be. I'll fix that. These default to private, but I'll make that explicit. - Gabe

Re: [gem5-dev] Review Request 2511: dev: cirrus: Add a simplified device model for the cirrus graphics device.

2014-12-22 Thread Gabe Black via gem5-dev
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2511/ --- (Updated Dec. 23, 2014, 1:04 a.m.) Review request for Default. Repository: gem5

Re: [gem5-dev] Review Request 2511: dev: cirrus: Add a simplified device model for the cirrus graphics device.

2014-12-18 Thread Gabe Black via gem5-dev
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2511/#review5696 --- src/dev/Cirrus.py http://reviews.gem5.org/r/2511/#comment5087

Re: [gem5-dev] Review Request 2511: dev: cirrus: Add a simplified device model for the cirrus graphics device.

2014-12-17 Thread Andreas Hansson via gem5-dev
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2511/#review5693 --- src/dev/Cirrus.py http://reviews.gem5.org/r/2511/#comment5067

Re: [gem5-dev] Review Request 2511: dev: cirrus: Add a simplified device model for the cirrus graphics device.

2014-12-16 Thread Gabe Black via gem5-dev
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2511/ --- (Updated Dec. 17, 2014, 7:27 a.m.) Review request for Default. Repository: gem5

Re: [gem5-dev] Review Request 2511: dev: cirrus: Add a simplified device model for the cirrus graphics device.

2014-12-16 Thread Gabe Black via gem5-dev
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2511/ --- (Updated Dec. 17, 2014, 7:39 a.m.) Review request for Default. Repository: gem5

Re: [gem5-dev] Review Request 2511: dev: cirrus: Add a simplified device model for the cirrus graphics device.

2014-11-23 Thread Gabe Black via gem5-dev
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2511/ --- (Updated Nov. 23, 2014, 2:52 p.m.) Review request for Default. Repository: gem5

[gem5-dev] Review Request 2511: dev: cirrus: Add a simplified device model for the cirrus graphics device.

2014-11-17 Thread Gabe Black via gem5-dev
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2511/ --- Review request for Default. Repository: gem5 Description --- Changeset