Re: [gem5-dev] Review Request 3781: riscv: Remove ECALL tests from insttest

> On Jan. 25, 2017, 11:28 a.m., Andreas Sandberg wrote: > > Ship It! > > Andreas Hansson wrote: > What was the verdict? Is it just a matter of an updated patch > description/summary and then this should be pushed? > > Andreas Sandberg wrote: > Yes, the description needs to be updated.

Re: [gem5-dev] Review Request 3781: riscv: Remove ECALL tests from insttest

> On Jan. 25, 2017, 11:28 a.m., Andreas Sandberg wrote: > > Ship It! > > Andreas Hansson wrote: > What was the verdict? Is it just a matter of an updated patch > description/summary and then this should be pushed? > > Andreas Sandberg wrote: > Yes, the description needs to be updated.

Re: [gem5-dev] Review Request 3781: riscv: Remove ECALL tests from insttest

--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3781/ --- (Updated Feb. 13, 2017, 3 p.m.) Review request for Default. Repository: gem5

Re: [gem5-dev] Review Request 3781: riscv: Remove ECALL tests from insttest

> On Jan. 25, 2017, 11:28 a.m., Andreas Sandberg wrote: > > Ship It! > > Andreas Hansson wrote: > What was the verdict? Is it just a matter of an updated patch > description/summary and then this should be pushed? Yes, the description needs to be updated. I'm not sure what happened to the

Re: [gem5-dev] Review Request 3781: riscv: Remove ECALL tests from insttest

> On Jan. 25, 2017, 11:28 a.m., Andreas Sandberg wrote: > > Ship It! What was the verdict? Is it just a matter of an updated patch description/summary and then this should be pushed? - Andreas --- This is an automatically generated

Re: [gem5-dev] Review Request 3781: riscv: Remove ECALL tests from insttest

--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3781/#review9316 --- Ship it! Ship It! - Andreas Sandberg On Jan. 24, 2017, 4:33 p.m.,

Re: [gem5-dev] Review Request 3781: riscv: Remove ECALL tests from insttest

> On Jan. 24, 2017, 9:43 a.m., Andreas Sandberg wrote: > > Did you remove all files from the reference output directory? In that case, > > you'll need to add a an empty placeholder file called EMPTY in the > > reference directories. Some VCS systems (git being one of them) don't track > >

Re: [gem5-dev] Review Request 3781: riscv: Remove ECALL tests from insttest

Hi Alec, Don’t worry about it. It is the reviewboard being silly. Andreas On 24/01/2017, 16:34, "gem5-dev on behalf of Alec Roelke" wrote: > > >> On Jan. 24, 2017, 9:43 a.m., Andreas Sandberg wrote: >> > Did you remove all files from

Re: [gem5-dev] Review Request 3781: riscv: Remove ECALL tests from insttest

> On Jan. 24, 2017, 9:43 a.m., Andreas Sandberg wrote: > > Did you remove all files from the reference output directory? In that case, > > you'll need to add a an empty placeholder file called EMPTY in the > > reference directories. Some VCS systems (git being one of them) don't track > >

Re: [gem5-dev] Review Request 3781: riscv: Remove ECALL tests from insttest

--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3781/#review9301 --- Did you remove all files from the reference output directory? In that

Re: [gem5-dev] Review Request 3781: riscv: Remove ECALL tests from insttest

--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3781/#review9298 --- Ship it! Ship It! - Andreas Hansson On Jan. 23, 2017, 7:36 p.m.,

Re: [gem5-dev] Review Request 3781: riscv: Remove ECALL tests from insttest

> On Jan. 23, 2017, 4:59 p.m., Andreas Hansson wrote: > > Another option is to remove the stats.txt from the stats results directory. > > This will turn the test into a functional-only test. > > > > In fact that may be there better option here as we also don't have to worry > > about

Re: [gem5-dev] Review Request 3781: riscv: Remove ECALL tests from insttest

--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3781/ --- (Updated Jan. 23, 2017, 7:36 p.m.) Review request for Default. Repository: gem5

Re: [gem5-dev] Review Request 3781: riscv: Remove ECALL tests from insttest

> On Jan. 23, 2017, 4:59 p.m., Andreas Hansson wrote: > > Another option is to remove the stats.txt from the stats results directory. > > This will turn the test into a functional-only test. > > > > In fact that may be there better option here as we also don't have to worry > > about

Re: [gem5-dev] Review Request 3781: riscv: Remove ECALL tests from insttest

--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3781/#review9294 --- Another option is to remove the stats.txt from the stats results

Re: [gem5-dev] Review Request 3781: riscv: Remove ECALL tests from insttest

> On Jan. 18, 2017, 4:04 p.m., Jason Lowe-Power wrote: > > tests/test-progs/insttest/src/riscv/rv64i.cpp, line 238 > > > > > > Can you block-comment instead of delete? I think we'll want to add this > > back in sometime in

Re: [gem5-dev] Review Request 3781: riscv: Remove ECALL tests from insttest

--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3781/ --- (Updated Jan. 18, 2017, 4:42 p.m.) Review request for Default. Repository: gem5

Re: [gem5-dev] Review Request 3781: riscv: Remove ECALL tests from insttest

--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3781/#review9260 --- Ship it! tests/test-progs/insttest/src/riscv/rv64i.cpp