That does look nice. It can be a lot of work slogging through O3 trace
output to figure out what's going on, and I expect this to make that a
lot easier. I glanced through the code and didn't see anything
particularly objectionable, although I wouldn't necessarily consider
that a thorough review
---
This is an automatically generated e-mail. To reply, visit:
http://reviews.m5sim.org/r/720/#review1262
---
What does Self.all do? What is it for? You have one use in the change so
scons: `build/ALPHA_SE/m5.debug' is up to date.
scons: `build/ALPHA_SE_MOESI_hammer/m5.debug' is up to date.
scons: `build/ALPHA_SE_MESI_CMP_directory/m5.debug' is up to date.
scons: `build/ALPHA_SE_MOESI_CMP_directory/m5.debug' is up to date.
scons: `build/ALPHA_SE_MOESI_CMP_token/m5.debug' is up
For #1 and #4, these are pretty much the same right? The contextID is
really all possible sharers rather then just threadContext. Seems like you
should keep the meaning of contextID as it pertains to thread and then
generate a sharerID that would be a superset of the contextIDs. Objects
that dont
For #1 and #4, these are pretty much the same right? The contextID is
really all possible sharers rather then just threadContext. Seems like you
should keep the meaning of contextID as it pertains to thread and then
generate a sharerID that would be a superset of the contextIDs. Objects
that
I'd really like to know is if we should have just one ID or two. I'd
personally rather stick with one. Maybe we just call it
memoryAccessID or sharerID
memoryAccessID sounds like the right term here.
I'm not sure that it would complicate things much. The idea is to
just put the things
---
This is an automatically generated e-mail. To reply, visit:
http://reviews.m5sim.org/r/684/
---
(Updated 2011-05-27 11:41:44.345753)
Review request for Default.
Summary
---
This is an automatically generated e-mail. To reply, visit:
http://reviews.m5sim.org/r/718/#review1263
---
I think this type of change is necessary for reasonable performance, but
---
This is an automatically generated e-mail. To reply, visit:
http://reviews.m5sim.org/r/720/#review1265
---
src/python/m5/SimObject.py
http://reviews.m5sim.org/r/720/#comment1742
On 2011-05-26 23:29:05, Gabe Black wrote:
What does Self.all do? What is it for? You have one use in the change so I
have a basic idea, but it would be helpful to know the specifics.
Ali Saidi wrote:
It's similar to Parent.any in that it traverses the object hierarchy and
finds
10 matches
Mail list logo