Re: [m5-dev] Idea for error messages

2009-01-30 Thread Ali Saidi
Yea I thought about that. Pretty much if you update an error message, you need to move the old hash to the new hash on the wiki. Ali On Jan 30, 2009, at 2:48 AM, Gabe Black wrote: That sounds like a good idea, but what if I had panic(Soemthing bad) and changed it to panic(Something bad)?

Re: [m5-dev] Idea for error messages

2009-01-30 Thread Ali Saidi
Anyone else? To make this work we would either have to include a md5 algorithm is base (I found a BSD licensed one) or require libopenssl. Ali On Jan 30, 2009, at 11:52 AM, Ali Saidi wrote: Yea I thought about that. Pretty much if you update an error message, you need to move the old hash

Re: [m5-dev] Idea for error messages

2009-01-30 Thread Gabe Black
Would we need such a strong hash? A dumb CRC would likely be sufficient if that would be easier to bring in. Gabe Ali Saidi wrote: Anyone else? To make this work we would either have to include a md5 algorithm is base (I found a BSD licensed one) or require libopenssl. Ali On Jan 30,

Re: [m5-dev] Idea for error messages

2009-01-30 Thread Ali Saidi
I would be worried that the collision probability would be too high with a crc. Ali On Jan 30, 2009, at 1:46 PM, Gabe Black wrote: Would we need such a strong hash? A dumb CRC would likely be sufficient if that would be easier to bring in. Gabe Ali Saidi wrote: Anyone else? To make

Re: [m5-dev] Idea for error messages

2009-01-30 Thread Steve Reinhardt
Yea, since these only get printed when an error occurs, performance shouldn't be an issue. Steve On Fri, Jan 30, 2009 at 10:48 AM, Ali Saidi sa...@umich.edu wrote: I would be worried that the collision probability would be too high with a crc. Ali On Jan 30, 2009, at 1:46 PM, Gabe Black

Re: [m5-dev] Idea for error messages

2009-01-30 Thread Ali Saidi
On Jan 30, 2009, at 2:53 PM, nathan binkert wrote: We've talked for a while about needing better error messages, links, more descriptions on the website, etc. How about we modify panic(), fatal(), and warn() to hash the format string for the message and print out a url with some portion of

Re: [m5-dev] Idea for error messages

2009-01-30 Thread nathan binkert
I suggest putting the error messages in a different directory (e.g. m5sim.org/e/error id). With this we could either re-write to the normal wiki, re-write to another wiki for errors where we had a custom not-found page, or re-write to some php/python that checked and did the appropriate

Re: [m5-dev] Idea for error messages

2009-01-30 Thread gblack
I'd probably lean towards Ali's proposal due to its simplicity, but I think we'd need to run ispell on all of the messages to make sure that they're ok and I think we also need to find out how many duplicates we have because the same message is in multiple places. Yes. I don't think we

Re: [m5-dev] Idea for error messages

2009-01-30 Thread Steve Reinhardt
One thing we should consider is the fact that not everyone will be using the same version of the source. If a message changes and we move the page, the old message could still be out there but have no explanation. If old wiki pages live forever that may start to get crowded. Good

Re: [m5-dev] Idea for error messages

2009-01-30 Thread Ali Saidi
On Jan 30, 2009, at 5:02 PM, Steve Reinhardt wrote: One thing we should consider is the fact that not everyone will be using the same version of the source. If a message changes and we move the page, the old message could still be out there but have no explanation. If old wiki pages

Re: [m5-dev] Idea for error messages

2009-01-30 Thread Ali Saidi
The quick thing to do is to just modify the page not found message on the wiki. Does this work for everyone for now? In the future we could do something more complex to check the wiki (there is an api) and then display a special page if we want. Ali

Re: [m5-dev] Idea for error messages

2009-01-30 Thread nathan binkert
The quick thing to do is to just modify the page not found message on the wiki. Does this work for everyone for now? In the future we could do something more complex to check the wiki (there is an api) and then display a special page if we want. This would affect all wiki pages, right? I

Re: [m5-dev] Idea for error messages

2009-01-29 Thread Gabe Black
That sounds like a good idea, but what if I had panic(Soemthing bad) and changed it to panic(Something bad)? They'd be the same thing but with different hashes. Gabe Ali Saidi wrote: We've talked for a while about needing better error messages, links, more descriptions on the website, etc.