Re: [m5-dev] Review Request: NDEBUG for Ruby Assert statement

Thanks Brad. On Wed, 8 Dec 2010, Beckmann, Brad wrote: Done. Brad -Original Message- From: Nilay Vaish [mailto:ni...@cs.wisc.edu] Sent: Tuesday, December 07, 2010 4:43 PM To: Beckmann, Brad Cc: Default Subject: Re: Review Request: NDEBUG for Ruby Assert statement Brad, Since Steve

Re: [m5-dev] Review Request: NDEBUG for Ruby Assert statement

Done. Brad -Original Message- From: Nilay Vaish [mailto:ni...@cs.wisc.edu] Sent: Tuesday, December 07, 2010 4:43 PM To: Beckmann, Brad Cc: Default Subject: Re: Review Request: NDEBUG for Ruby Assert statement Brad, Since Steve and you have reviewed the patch, I guess we can commit it.

Re: [m5-dev] Review Request: NDEBUG for Ruby Assert statement

Brad, Since Steve and you have reviewed the patch, I guess we can commit it. I have one more patch in the queue. Nilay On Fri, 3 Dec 2010, Brad Beckmann wrote: --- This is an automatically generated e-mail. To reply, visit: http://rev

Re: [m5-dev] Review Request: NDEBUG for Ruby Assert statement

That's what is going on right now. Nilay On Mon, December 6, 2010 10:16 pm, nathan binkert wrote: >> >> I think the reason is that we would like to have the line numbers from >> the .sm file. If we use ASSERT(), then the line numbers from the >> generated .cc files will be put in place. >> >> Th

Re: [m5-dev] Review Request: NDEBUG for Ruby Assert statement

> > I think the reason is that we would like to have the line numbers from the > .sm file. If we use ASSERT(), then the line numbers from the generated .cc > files will be put in place. > > That makes sense, thanks... > > Better would be to eventually make SLICC emit #file and #line directives.

Re: [m5-dev] Review Request: NDEBUG for Ruby Assert statement

> On 2010-12-06 15:56:33, Steve Reinhardt wrote: > > src/mem/ruby/common/Debug.hh, line 146 > > > > > > What changed in these lines? I don't see any difference here. Was it > > just a whitespace thing? If so, was it intent

Re: [m5-dev] Review Request: NDEBUG for Ruby Assert statement

--- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/337/#review515 --- Ship it! - Steve On 2010-12-02 20:35:31, Nilay Vaish wrote: > > --

Re: [m5-dev] Review Request: NDEBUG for Ruby Assert statement

> On 2010-12-06 15:56:33, Steve Reinhardt wrote: > > src/mem/ruby/common/Debug.hh, line 146 > > > > > > What changed in these lines? I don't see any difference here. Was it > > just a whitespace thing? If so, was it intent

Re: [m5-dev] Review Request: NDEBUG for Ruby Assert statement

--- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/337/#review510 --- src/mem/ruby/common/Debug.hh

Re: [m5-dev] Review Request: NDEBUG for Ruby Assert statement

--- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/337/#review509 --- Ship it! Looks good to me. - Brad On 2010-12-02 20:35:31, Nilay Vaish

Re: [m5-dev] Review Request: NDEBUG for Ruby Assert statement

--- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/337/ --- (Updated 2010-12-02 20:35:31.660861) Review request for Default. Summary ---

[m5-dev] Review Request: NDEBUG for Ruby Assert statement

--- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/337/ --- Review request for Default, Ali Saidi, Gabe Black, Steve Reinhardt, and Nathan Binke