Re: [m5-dev] Review Request: SCons: Clean up some inconsistent capitalization in scons options.

2011-03-03 Thread Gabe Black
--- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/522/ --- (Updated 2011-03-03 02:45:15.055168) Review request for Default, Ali Saidi, Gabe

Re: [m5-dev] Review Request: SCons: Clean up some inconsistent capitalization in scons options.

2011-03-03 Thread Steve Reinhardt
--- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/522/#review927 --- Ship it! - Steve On 2011-03-03 02:45:15, Gabe Black wrote:

Re: [m5-dev] Review Request: SCons: Clean up some inconsistent capitalization in scons options.

2011-03-02 Thread Steve Reinhardt
--- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/522/#review922 --- I'm willing to be convinced on this one, but I'd argue that the

Re: [m5-dev] Review Request: SCons: Clean up some inconsistent capitalization in scons options.

2011-03-02 Thread Steve Reinhardt
On 2011-03-02 09:21:38, Steve Reinhardt wrote: I'm willing to be convinced on this one, but I'd argue that the inconsistency is that VERBOSE should be lowercase, not that update_ref should be uppercase... I think I originally made update_ref lowercase to distinguish it from the

Re: [m5-dev] Review Request: SCons: Clean up some inconsistent capitalization in scons options.

2011-03-02 Thread Gabe Black
On 2011-03-02 09:21:38, Steve Reinhardt wrote: I'm willing to be convinced on this one, but I'd argue that the inconsistency is that VERBOSE should be lowercase, not that update_ref should be uppercase... I think I originally made update_ref lowercase to distinguish it from the

Re: [m5-dev] Review Request: SCons: Clean up some inconsistent capitalization in scons options.

2011-03-01 Thread Gabe Black
I don't think so. update_refs/UPDATE_REFS is used to replace the expected regression outputs, so that shouldn't have any impact on actually running the regressions. If that's not right somebody please speak up. Gabe On 02/28/11 18:32, nathan binkert wrote: Do the regression scripts need to be

Re: [m5-dev] Review Request: SCons: Clean up some inconsistent capitalization in scons options.

2011-02-28 Thread Ali Saidi
--- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/522/#review917 --- Ship it! Looks fine. Two things though: 1) The documentation on the wiki

Re: [m5-dev] Review Request: SCons: Clean up some inconsistent capitalization in scons options.

2011-02-28 Thread nathan binkert
Do the regression scripts need to be fixed? On Mon, Feb 28, 2011 at 11:59 AM, Ali Saidi sa...@umich.edu wrote: This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/522/ Ship it! Looks fine. Two things though: 1) The documentation on the wiki needs to be