Re: [m5-dev] Review Request: SConstruct: automatically update .hg/hgrc with style hooks

2011-05-02 Thread Gabe Black
> On 2011-05-02 12:51:56, Nathan Binkert wrote: > > SConstruct, line 247 > > > > > > Should we prompt the user for permission? That way the user would at > > least know that something happened. > > Steve Reinhardt wrote:

Re: [m5-dev] Review Request: SConstruct: automatically update .hg/hgrc with style hooks

2011-05-02 Thread Steve Reinhardt
> On 2011-05-02 12:51:56, Nathan Binkert wrote: > > SConstruct, line 247 > > > > > > Should we prompt the user for permission? That way the user would at > > least know that something happened. > > Steve Reinhardt wrote:

Re: [m5-dev] Review Request: SConstruct: automatically update .hg/hgrc with style hooks

2011-05-02 Thread Nathan Binkert
> On 2011-05-02 12:51:56, Nathan Binkert wrote: > > SConstruct, line 247 > > > > > > Should we prompt the user for permission? That way the user would at > > least know that something happened. > > Steve Reinhardt wrote:

Re: [m5-dev] Review Request: SConstruct: automatically update .hg/hgrc with style hooks

2011-05-02 Thread Nathan Binkert
> On 2011-05-02 12:51:56, Nathan Binkert wrote: > > SConstruct, line 243 > > > > > > I know you didn't change this, but should we check for both hooks? (I > > added the pre-qrefresh one a while ago) > > Steve Reinhardt wr

Re: [m5-dev] Review Request: SConstruct: automatically update .hg/hgrc with style hooks

2011-05-02 Thread Ali Saidi
--- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/668/#review1180 --- Ship it! - Ali On 2011-05-02 12:34:56, Steve Reinhardt wrote: > > ---

Re: [m5-dev] Review Request: SConstruct: automatically update .hg/hgrc with style hooks

2011-05-02 Thread Gabe Black
> On 2011-05-02 12:51:56, Nathan Binkert wrote: > > SConstruct, line 247 > > > > > > Should we prompt the user for permission? That way the user would at > > least know that something happened. > > Steve Reinhardt wrote:

Re: [m5-dev] Review Request: SConstruct: automatically update .hg/hgrc with style hooks

2011-05-02 Thread Steve Reinhardt
> On 2011-05-02 12:51:56, Nathan Binkert wrote: > > SConstruct, line 243 > > > > > > I know you didn't change this, but should we check for both hooks? (I > > added the pre-qrefresh one a while ago) > > Steve Reinhardt wr

Re: [m5-dev] Review Request: SConstruct: automatically update .hg/hgrc with style hooks

2011-05-02 Thread Nathan Binkert
--- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/668/#review1176 --- Ship it! Whether you decide to change this or not, it's a good idea. -

Re: [m5-dev] Review Request: SConstruct: automatically update .hg/hgrc with style hooks

2011-05-02 Thread Nathan Binkert
> On 2011-05-02 12:51:56, Nathan Binkert wrote: > > SConstruct, line 247 > > > > > > Should we prompt the user for permission? That way the user would at > > least know that something happened. > > Steve Reinhardt wrote:

Re: [m5-dev] Review Request: SConstruct: automatically update .hg/hgrc with style hooks

2011-05-02 Thread Steve Reinhardt
> On 2011-05-02 12:51:56, Nathan Binkert wrote: > > SConstruct, line 243 > > > > > > I know you didn't change this, but should we check for both hooks? (I > > added the pre-qrefresh one a while ago) Doesn't make me much d

Re: [m5-dev] Review Request: SConstruct: automatically update .hg/hgrc with style hooks

2011-05-02 Thread Nathan Binkert
--- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/668/#review1173 --- SConstruct I know you

[m5-dev] Review Request: SConstruct: automatically update .hg/hgrc with style hooks

2011-05-02 Thread Steve Reinhardt
--- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/668/ --- Review request for Default, Ali Saidi, Gabe Black, Steve Reinhardt, and Nathan Binke