Re: [gem5-dev] Review Request 2511: dev: cirrus: Add a simplified device model for the cirrus graphics device.
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2511/#review7116 --- Ship it! Is there any value in making it conditional? - Steve Reinhardt On Sept. 3, 2015, 3:26 p.m., Gabe Black wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/2511/ > --- > > (Updated Sept. 3, 2015, 3:26 p.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > --- > > Changeset 10608:45b160d14246 > --- > dev: cirrus: Add a simplified device model for the cirrus graphics device. > > All control register accesses are dropped on the floor. If used with KVM, the > frame buffer is set up as a memory like region to keep performance from > tanking. If a VNC server is configured, the buffer is marked dirty once every > simulated 100ms. > > > Diffs > - > > configs/common/FSConfig.py 95eb22928d0f > > Diff: http://reviews.gem5.org/r/2511/diff/ > > > Testing > --- > > > Thanks, > > Gabe Black > > ___ gem5-dev mailing list gem5-dev@gem5.org http://m5sim.org/mailman/listinfo/gem5-dev
Re: [gem5-dev] Review Request 2511: dev: cirrus: Add a simplified device model for the cirrus graphics device.
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2511/#review7112 --- Rebased diff. - Gabe Black On Sept. 3, 2015, 10:26 p.m., Gabe Black wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/2511/ > --- > > (Updated Sept. 3, 2015, 10:26 p.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > --- > > Changeset 10608:45b160d14246 > --- > dev: cirrus: Add a simplified device model for the cirrus graphics device. > > All control register accesses are dropped on the floor. If used with KVM, the > frame buffer is set up as a memory like region to keep performance from > tanking. If a VNC server is configured, the buffer is marked dirty once every > simulated 100ms. > > > Diffs > - > > configs/common/FSConfig.py 95eb22928d0f > > Diff: http://reviews.gem5.org/r/2511/diff/ > > > Testing > --- > > > Thanks, > > Gabe Black > > ___ gem5-dev mailing list gem5-dev@gem5.org http://m5sim.org/mailman/listinfo/gem5-dev
Re: [gem5-dev] Review Request 2511: dev: cirrus: Add a simplified device model for the cirrus graphics device.
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2511/ --- (Updated Sept. 3, 2015, 10:26 p.m.) Review request for Default. Repository: gem5 Description --- Changeset 10608:45b160d14246 --- dev: cirrus: Add a simplified device model for the cirrus graphics device. All control register accesses are dropped on the floor. If used with KVM, the frame buffer is set up as a memory like region to keep performance from tanking. If a VNC server is configured, the buffer is marked dirty once every simulated 100ms. Diffs (updated) - configs/common/FSConfig.py 95eb22928d0f Diff: http://reviews.gem5.org/r/2511/diff/ Testing --- Thanks, Gabe Black ___ gem5-dev mailing list gem5-dev@gem5.org http://m5sim.org/mailman/listinfo/gem5-dev
Re: [gem5-dev] Review Request 2511: dev: cirrus: Add a simplified device model for the cirrus graphics device.
On Dec. 23, 2014, 10:25 a.m., Andreas Hansson wrote: Looks fine. Could you mark the issues that are fixed as fixed (or dropped for that matter)? Thanks. I am still not sure if I like the USE_KVM better, or perhaps having a NullKvm object. Yeah. There was one other mistake I noticed which I'm fixing. I'm not going to push this until I get back into the office after New Years and can actually test it. - Gabe --- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2511/#review5708 --- On Dec. 23, 2014, 1:04 a.m., Gabe Black wrote: --- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2511/ --- (Updated Dec. 23, 2014, 1:04 a.m.) Review request for Default. Repository: gem5 Description --- Changeset 10608:7c8363f44c5b --- dev: cirrus: Add a simplified device model for the cirrus graphics device. All control register accesses are dropped on the floor. If used with KVM, the frame buffer is set up as a memory like region to keep performance from tanking. If a VNC server is configured, the buffer is marked dirty once every simulated 100ms. Diffs - src/dev/Cirrus.py PRE-CREATION src/dev/SConscript b3ea7444f4f020332d1c6fe8635aa81f719a src/dev/cirrus.hh PRE-CREATION src/dev/cirrus.cc PRE-CREATION Diff: http://reviews.gem5.org/r/2511/diff/ Testing --- Thanks, Gabe Black ___ gem5-dev mailing list gem5-dev@gem5.org http://m5sim.org/mailman/listinfo/gem5-dev
Re: [gem5-dev] Review Request 2511: dev: cirrus: Add a simplified device model for the cirrus graphics device.
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2511/#review5708 --- Ship it! Looks fine. Could you mark the issues that are fixed as fixed (or dropped for that matter)? Thanks. I am still not sure if I like the USE_KVM better, or perhaps having a NullKvm object. - Andreas Hansson On Dec. 23, 2014, 1:04 a.m., Gabe Black wrote: --- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2511/ --- (Updated Dec. 23, 2014, 1:04 a.m.) Review request for Default. Repository: gem5 Description --- Changeset 10608:7c8363f44c5b --- dev: cirrus: Add a simplified device model for the cirrus graphics device. All control register accesses are dropped on the floor. If used with KVM, the frame buffer is set up as a memory like region to keep performance from tanking. If a VNC server is configured, the buffer is marked dirty once every simulated 100ms. Diffs - src/dev/Cirrus.py PRE-CREATION src/dev/SConscript b3ea7444f4f020332d1c6fe8635aa81f719a src/dev/cirrus.hh PRE-CREATION src/dev/cirrus.cc PRE-CREATION Diff: http://reviews.gem5.org/r/2511/diff/ Testing --- Thanks, Gabe Black ___ gem5-dev mailing list gem5-dev@gem5.org http://m5sim.org/mailman/listinfo/gem5-dev
Re: [gem5-dev] Review Request 2511: dev: cirrus: Add a simplified device model for the cirrus graphics device.
On Dec. 18, 2014, 10:39 a.m., Gabe Black wrote: src/dev/cirrus.hh, line 48 http://reviews.gem5.org/r/2511/diff/6/?file=43227#file43227line48 They probably shouldn't be. I'll fix that. These default to private, but I'll make that explicit. - Gabe --- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2511/#review5696 --- On Dec. 23, 2014, 12:55 a.m., Gabe Black wrote: --- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2511/ --- (Updated Dec. 23, 2014, 12:55 a.m.) Review request for Default. Repository: gem5 Description --- Changeset 10608:7a321b7e3dac --- dev: cirrus: Add a simplified device model for the cirrus graphics device. All control register accesses are dropped on the floor. If used with KVM, the frame buffer is set up as a memory like region to keep performance from tanking. If a VNC server is configured, the buffer is marked dirty once every simulated 100ms. Diffs - src/dev/Cirrus.py PRE-CREATION src/dev/SConscript b3ea7444f4f020332d1c6fe8635aa81f719a src/dev/cirrus.hh PRE-CREATION src/dev/cirrus.cc PRE-CREATION Diff: http://reviews.gem5.org/r/2511/diff/ Testing --- Thanks, Gabe Black ___ gem5-dev mailing list gem5-dev@gem5.org http://m5sim.org/mailman/listinfo/gem5-dev
Re: [gem5-dev] Review Request 2511: dev: cirrus: Add a simplified device model for the cirrus graphics device.
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2511/ --- (Updated Dec. 23, 2014, 1:04 a.m.) Review request for Default. Repository: gem5 Description (updated) --- Changeset 10608:7c8363f44c5b --- dev: cirrus: Add a simplified device model for the cirrus graphics device. All control register accesses are dropped on the floor. If used with KVM, the frame buffer is set up as a memory like region to keep performance from tanking. If a VNC server is configured, the buffer is marked dirty once every simulated 100ms. Diffs (updated) - src/dev/Cirrus.py PRE-CREATION src/dev/SConscript b3ea7444f4f020332d1c6fe8635aa81f719a src/dev/cirrus.hh PRE-CREATION src/dev/cirrus.cc PRE-CREATION Diff: http://reviews.gem5.org/r/2511/diff/ Testing --- Thanks, Gabe Black ___ gem5-dev mailing list gem5-dev@gem5.org http://m5sim.org/mailman/listinfo/gem5-dev
Re: [gem5-dev] Review Request 2511: dev: cirrus: Add a simplified device model for the cirrus graphics device.
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2511/#review5696 --- src/dev/Cirrus.py http://reviews.gem5.org/r/2511/#comment5087 Remove, I think. src/dev/cirrus.hh http://reviews.gem5.org/r/2511/#comment5086 They probably shouldn't be. I'll fix that. src/dev/cirrus.cc http://reviews.gem5.org/r/2511/#comment5088 Ok. src/dev/cirrus.cc http://reviews.gem5.org/r/2511/#comment5085 I don't know what's going on here. This device model was originally written by someone else, and I added a small fix patch on top of it recently. I'll need to look into what this is for. src/dev/cirrus.cc http://reviews.gem5.org/r/2511/#comment5084 Since USE_KVM is constant at compile time, this if will get compiled away if it's false. We could check kvmVM only, but it would be slightly less efficient. That's probably ok, though. src/dev/cirrus.cc http://reviews.gem5.org/r/2511/#comment5081 Unfortunately no. We can't have the kvmVM parameter in the SimObject if KVM isn't available because we won't have access to that type. In that case, p-kvmVM won't compile. src/dev/cirrus.cc http://reviews.gem5.org/r/2511/#comment5082 It's const everywhere else, we just need to un-constify it here so we can set it up initially. src/dev/cirrus.cc http://reviews.gem5.org/r/2511/#comment5083 Yeah, we should deschedule that. - Gabe Black On Dec. 17, 2014, 7:39 a.m., Gabe Black wrote: --- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2511/ --- (Updated Dec. 17, 2014, 7:39 a.m.) Review request for Default. Repository: gem5 Description --- Changeset 10609:07584c650657 --- dev: cirrus: Add a simplified device model for the cirrus graphics device. All control register accesses are dropped on the floor. If used with KVM, the frame buffer is set up as a memory like region to keep performance from tanking. If a VNC server is configured, the buffer is marked dirty once every simulated 100ms. Diffs - src/dev/Cirrus.py PRE-CREATION src/dev/SConscript a0cb57e1c072965dcdd51465beff37b264b41424 src/dev/cirrus.hh PRE-CREATION src/dev/cirrus.cc PRE-CREATION Diff: http://reviews.gem5.org/r/2511/diff/ Testing --- Thanks, Gabe Black ___ gem5-dev mailing list gem5-dev@gem5.org http://m5sim.org/mailman/listinfo/gem5-dev
Re: [gem5-dev] Review Request 2511: dev: cirrus: Add a simplified device model for the cirrus graphics device.
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2511/#review5693 --- src/dev/Cirrus.py http://reviews.gem5.org/r/2511/#comment5067 Remove? Or add a comment src/dev/cirrus.hh http://reviews.gem5.org/r/2511/#comment5068 all of these public? Why? src/dev/cirrus.cc http://reviews.gem5.org/r/2511/#comment5069 Please use getConstPtr src/dev/cirrus.cc http://reviews.gem5.org/r/2511/#comment5070 Remove? Or add a more elaborate comment src/dev/cirrus.cc http://reviews.gem5.org/r/2511/#comment5071 Can we not simply check if kvmkvm is nullptr? src/dev/cirrus.cc http://reviews.gem5.org/r/2511/#comment5072 I am not too fond of this. Can we note make it null or have a NullKVMVM or similar? src/dev/cirrus.cc http://reviews.gem5.org/r/2511/#comment5073 Rather unfortunate imho. src/dev/cirrus.cc http://reviews.gem5.org/r/2511/#comment5074 What if we have a scheduled updateEvent? - Andreas Hansson On Dec. 17, 2014, 7:39 a.m., Gabe Black wrote: --- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2511/ --- (Updated Dec. 17, 2014, 7:39 a.m.) Review request for Default. Repository: gem5 Description --- Changeset 10609:07584c650657 --- dev: cirrus: Add a simplified device model for the cirrus graphics device. All control register accesses are dropped on the floor. If used with KVM, the frame buffer is set up as a memory like region to keep performance from tanking. If a VNC server is configured, the buffer is marked dirty once every simulated 100ms. Diffs - src/dev/Cirrus.py PRE-CREATION src/dev/SConscript a0cb57e1c072965dcdd51465beff37b264b41424 src/dev/cirrus.hh PRE-CREATION src/dev/cirrus.cc PRE-CREATION Diff: http://reviews.gem5.org/r/2511/diff/ Testing --- Thanks, Gabe Black ___ gem5-dev mailing list gem5-dev@gem5.org http://m5sim.org/mailman/listinfo/gem5-dev
Re: [gem5-dev] Review Request 2511: dev: cirrus: Add a simplified device model for the cirrus graphics device.
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2511/ --- (Updated Dec. 17, 2014, 7:27 a.m.) Review request for Default. Repository: gem5 Description (updated) --- Changeset 10609:e591eadc0c63 --- dev: cirrus: Add a simplified device model for the cirrus graphics device. All control register accesses are dropped on the floor. If used with KVM, the frame buffer is set up as a memory like region to keep performance from tanking. If a VNC server is configured, the buffer is marked dirty once every simulated 100ms. Diffs (updated) - src/dev/Cirrus.py PRE-CREATION src/dev/SConscript a0cb57e1c072965dcdd51465beff37b264b41424 src/dev/cirrus.hh PRE-CREATION src/dev/cirrus.cc PRE-CREATION Diff: http://reviews.gem5.org/r/2511/diff/ Testing --- Thanks, Gabe Black ___ gem5-dev mailing list gem5-dev@gem5.org http://m5sim.org/mailman/listinfo/gem5-dev
Re: [gem5-dev] Review Request 2511: dev: cirrus: Add a simplified device model for the cirrus graphics device.
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2511/ --- (Updated Dec. 17, 2014, 7:39 a.m.) Review request for Default. Repository: gem5 Description (updated) --- Changeset 10609:07584c650657 --- dev: cirrus: Add a simplified device model for the cirrus graphics device. All control register accesses are dropped on the floor. If used with KVM, the frame buffer is set up as a memory like region to keep performance from tanking. If a VNC server is configured, the buffer is marked dirty once every simulated 100ms. Diffs (updated) - src/dev/Cirrus.py PRE-CREATION src/dev/SConscript a0cb57e1c072965dcdd51465beff37b264b41424 src/dev/cirrus.hh PRE-CREATION src/dev/cirrus.cc PRE-CREATION Diff: http://reviews.gem5.org/r/2511/diff/ Testing --- Thanks, Gabe Black ___ gem5-dev mailing list gem5-dev@gem5.org http://m5sim.org/mailman/listinfo/gem5-dev
Re: [gem5-dev] Review Request 2511: dev: cirrus: Add a simplified device model for the cirrus graphics device.
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2511/ --- (Updated Nov. 23, 2014, 2:52 p.m.) Review request for Default. Repository: gem5 Description (updated) --- Changeset 10553:6c662841f2b8 --- dev: cirrus: Add a simplified device model for the cirrus graphics device. All control register accesses are dropped on the floor. If used with KVM, the frame buffer is set up as a memory like region to keep performance from tanking. If a VNC server is configured, the buffer is marked dirty once every simulated 100ms. Diffs (updated) - src/dev/Cirrus.py PRE-CREATION src/dev/SConscript f9fb64a72259a2514080151b5250a04c575d443a src/dev/cirrus.hh PRE-CREATION src/dev/cirrus.cc PRE-CREATION Diff: http://reviews.gem5.org/r/2511/diff/ Testing --- Thanks, Gabe Black ___ gem5-dev mailing list gem5-dev@gem5.org http://m5sim.org/mailman/listinfo/gem5-dev
