[m5-dev] Cron /z/m5/regression/do-regression quick

2011-04-25 Thread Cron Daemon
* build/ALPHA_SE/tests/opt/quick/20.eio-short/alpha/eio/simple-atomic passed. * build/ALPHA_SE/tests/opt/quick/20.eio-short/alpha/eio/simple-timing passed. * build/ALPHA_SE/tests/opt/quick/30.eio-mp/alpha/eio/simple-atomic-mp passed. * build/ALPHA_SE/tests/opt/quick/00.hello/alph

[m5-dev] Review Request: ISA parser: Simplify operand type handling.

2011-04-25 Thread Gabe Black
--- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/655/ --- Review request for Default, Ali Saidi, Gabe Black, Steve Reinhardt, and Nathan Binke

[m5-dev] Review Request: ISA parser: Allow defining operand types with a ctype directly.

2011-04-25 Thread Gabe Black
--- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/656/ --- Review request for Default, Ali Saidi, Gabe Black, Steve Reinhardt, and Nathan Binke

[m5-dev] Review Request: X86: Convert operand types to the new style.

2011-04-25 Thread Gabe Black
--- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/657/ --- Review request for Default, Ali Saidi, Gabe Black, Steve Reinhardt, and Nathan Binke

[m5-dev] Review Request: ISA parser: Stop supporting the old style operand types.

2011-04-25 Thread Gabe Black
--- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/658/ --- Review request for Default, Ali Saidi, Gabe Black, Steve Reinhardt, and Nathan Binke

Re: [m5-dev] Review Request: X86: Convert operand types to the new style.

2011-04-25 Thread Gabe Black
This patch is for x86, but I have patches for all the other ISAs as well. It's really simple so I didn't want to post all of them, but I should post at least one as an example. Gabe On 04/25/11 06:04, Gabe Black wrote: > --- > This is an aut

Re: [m5-dev] Review Request: ISA parser: Simplify operand type handling.

2011-04-25 Thread Gabe Black
For anybody that's familiar with ISA definitions, these changes refer specifically to the def operand_types dict, not the types maintained by the parser for specifying operands in def operands. Gabe On 04/25/11 06:03, Gabe Black wrote: > ---

Re: [m5-dev] Review Request: network: convert links & switches to first class C++ SimObjects

2011-04-25 Thread Tushar Krishna
--- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/653/#review1150 --- src/mem/ruby/network/BasicLink.py

Re: [m5-dev] Review Request: ruby: removed dated comment in SimpleNetwork

2011-04-25 Thread Tushar Krishna
--- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/650/#review1151 --- Ship it! - Tushar On 2011-04-22 15:16:42, Brad Beckmann wrote: > > --

Re: [m5-dev] Review Request: Ruby: Add support for functional accesses

2011-04-25 Thread Nilay Vaish
> On 2011-04-13 10:28:08, Brad Beckmann wrote: > > src/mem/protocol/MESI_CMP_directory-L1cache.sm, line 141 > > > > > > Why are you adding this function? SLICC already generates a similar > > function: getPermission(). > >

Re: [m5-dev] Review Request: ruby: moved topology to the top network directory

2011-04-25 Thread Brad Beckmann
> On 2011-04-23 20:36:40, Nathan Binkert wrote: > > Did you use hg mv? The diff doesn't seem to include that information, > > though maybe reviewboard whacks that. Yes, I did. diff --git a/src/mem/ruby/network/simple/Topology.cc b/src/mem/ruby/network/Topology.cc rename from src/mem/ruby/net

[m5-dev] changeset in m5: base: include types.hh in base/stats/mysql.hh

2011-04-25 Thread Nilay Vaish
changeset ea37585785ab in /z/repo/m5 details: http://repo.m5sim.org/m5?cmd=changeset;node=ea37585785ab description: base: include types.hh in base/stats/mysql.hh Due to certain changes made via changeset 8229, the compilation was failing in certain cases. The compiler point

[m5-dev] Trace Help

2011-04-25 Thread Nilay Vaish
The option trace-help is not working currently. When I execute the following ./build/ALPHA_SE_MESI_CMP_directory/m5.debug --trace-help I get a list of all the m5 options. Can some one confirm this? Thanks Nilay ___ m5-dev mailing list m5-dev@m5sim.or

Re: [m5-dev] Review Request: network: convert links & switches to first class C++ SimObjects

2011-04-25 Thread Brad Beckmann
> On 2011-04-23 20:44:57, Nathan Binkert wrote: > > The main question I have about this code is, should new Ruby code adhere to > > the style guide instead of the old Ruby style? Eventually, we should try > > migrate Ruby to the style guide, no? (I'm mostly talking about variable > > naming

Re: [m5-dev] Review Request: network: convert links & switches to first class C++ SimObjects

2011-04-25 Thread Brad Beckmann
> On 2011-04-25 09:38:07, Tushar Krishna wrote: > > src/mem/ruby/network/BasicLink.py, line 37 > > > > > > could you add a comment somewhere that the bw_multiplier field is only > > used by the simple network? Thanks for po

Re: [m5-dev] Review Request: network: convert links & switches to first class C++ SimObjects

2011-04-25 Thread Brad Beckmann
--- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/653/ --- (Updated 2011-04-25 11:54:17.874303) Review request for Default, Ali Saidi, Gabe Bl

[m5-dev] changeset in m5: stats: update 20.parser o3 now that it works. ...

2011-04-25 Thread Nathan Binkert
changeset b02bca5aed04 in /z/repo/m5 details: http://repo.m5sim.org/m5?cmd=changeset;node=b02bca5aed04 description: stats: update 20.parser o3 now that it works. realview-o3 works too. diffstat: tests/long/10.linux-boot/ref/arm/linux/realview-o3/status |2 +- tests/long/20.parser/re

Re: [m5-dev] Review Request: network: convert links & switches to first class C++ SimObjects

2011-04-25 Thread Tushar Krishna
--- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/653/#review1157 --- Hi Brad, the updated patch hasn't applied cleanly and so the diff is not

[m5-dev] Trace not working

2011-04-25 Thread Nilay Vaish
On Mon, 25 Apr 2011, Nilay Vaish wrote: The option trace-help is not working currently. When I execute the following ./build/ALPHA_SE_MESI_CMP_directory/m5.debug --trace-help I get a list of all the m5 options. Can some one confirm this? Thanks Nilay Seems like trace facility is not workin

Re: [m5-dev] Review Request: network: convert links & switches to first class C++ SimObjects

2011-04-25 Thread Brad Beckmann
--- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/653/ --- (Updated 2011-04-25 15:30:56.730543) Review request for Default, Ali Saidi, Gabe Bl

Re: [m5-dev] Review Request: network: convert links & switches to first class C++ SimObjects

2011-04-25 Thread Brad Beckmann
--- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/653/ --- (Updated 2011-04-25 15:36:00.076799) Review request for Default, Ali Saidi, Gabe Bl

Re: [m5-dev] Review Request: network: convert links & switches to first class C++ SimObjects

2011-04-25 Thread Brad Beckmann
--- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/653/ --- (Updated 2011-04-25 15:40:47.284324) Review request for Default, Ali Saidi, Gabe Bl

Re: [m5-dev] Review Request: network: convert links & switches to first class C++ SimObjects

2011-04-25 Thread Brad Beckmann
--- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/653/ --- (Updated 2011-04-25 15:43:08.923680) Review request for Default, Ali Saidi, Gabe Bl

Re: [m5-dev] Review Request: network: convert links & switches to first class C++ SimObjects

2011-04-25 Thread Tushar Krishna
--- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/653/#review1158 --- Ship it! Looks good to me Brad. I presume you already did extensive test

Re: [m5-dev] Review Request: garnet: cleaned up flexible netwok header file

2011-04-25 Thread Tushar Krishna
--- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/652/#review1159 --- Ship it! - Tushar On 2011-04-22 15:16:47, Brad Beckmann wrote: > > --

[m5-dev] Review Request: NetworkTest: added sim_cycles parameter to the network tester.

2011-04-25 Thread Tushar Krishna
--- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/660/ --- Review request for Default, Ali Saidi, Gabe Black, Steve Reinhardt, Nathan Binkert,

Re: [m5-dev] Trace not working

2011-04-25 Thread Beckmann, Brad
Hi Nilay, In one of Nate's recent patches he changed the name from trace-help to debug-help. Similarly the command line "trace-flag" is now "debug-flag". However, I am confused as well on how to add a new TraceFlag/DebugFlag. It seems that all the previous flags are still specified using the

Re: [m5-dev] Trace not working

2011-04-25 Thread nathan binkert
> However, I am confused as well on how to add a new TraceFlag/DebugFlag.  It > seems that all the previous flags are still specified using the "TraceFlag()" > function, but I can't seem to be able to specify a new one.    Also to be > consistent, should we change the name of the TraceFlag funct

Re: [m5-dev] Trace not working

2011-04-25 Thread Beckmann, Brad
Maybe I'm doing something stupid here, but on a clean checkout, the following short patch encounters the subsequent compiler error: diff --git a/src/mem/SConscript b/src/mem/SConscript --- a/src/mem/SConscript +++ b/src/mem/SConscript @@ -57,6 +57,7 @@ TraceFlag('BusAddrRanges') TraceFlag('Bus

Re: [m5-dev] Trace not working

2011-04-25 Thread nathan binkert
Oh, one thing you need to do now is add #include "debug/FlagCheck.hh" To your .cc file. I should probably write some new documentation about that. Basically, we're generating a header per flag now. One huge benefit of this is that you don't have to recompile the entire system after you add a t