@Twice
Hi,the link [1] introduce the treatment of third-party works.
1.https://www.apache.org/legal/src-headers.html#3party
Twice 于2023年2月13日周一 16:52写道:
> Hi @kezhenxu94,
>
> Thank you for taking the time to vote and for your valuable input.
>
> However, I would like to point out that
> - You
Hi Tison
AFAIK, this is not a failed vote. You are still have more +1 than -1.
You could consider whether waiting for another round, or any voted IPMC
member would change votes.
-1 is veto.
tison 于2023年2月14日 周二20:32写道:
> Hi Justin,
>
> Thanks for your information! I made this patch
>
Hi Justin,
Thanks for your information! I made this patch
https://github.com/apache/incubator-kvrocks/pull/1259 to resolve the
license issue. Since we're going to make a new RC with only this change,
could you take a look at the patch whether there still remains some
concerns? Then we can avoid
Hi,
> It can be a case of The Ship of Theseus. When you take a look at the issued
> files[1][2], you may find a commit history touching them and modifying
> them. Anyway, it's not an identical copy or one-shot translation.
This has been discussed many times on various lists, translating an
Hello Incubator PMC,
I'm cancelling this vote due to license issues:
https://lists.apache.org/thread/q11wxgg3hdw694w5csf43trgv7yvj2jt
I will start a new vote after we have resolved those issues.
Best,
Pengbo Cai
Due to doubts, I will cancel this release vote. I will start a new vote after
we have resolved @kezhenxu94's issue.
-
To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org
For additional commands, e-mail:
I submit a patch: https://github.com/apache/incubator-kvrocks/pull/1259
@zhenxu you're welcome to help verify if it fixes your concerns.
... and -1 (binding)
@Myth I think we need a new release candidate :)
Best,
tison.
tison 于2023年2月14日周二 10:47写道:
> Thanks for your confirmation. Then I
Thanks for your confirmation. Then I agree the content should be updated to
avoid risk.
kezhenxu94 于2023年2月14日 周二10:43写道:
> But at the same time, the file header has `/* from valgrind tests */`,
> I assumed you ported the variation of Valgrind.
>
> A good practice is not to add more license
But at the same time, the file header has `/* from valgrind tests */`,
I assumed you ported the variation of Valgrind.
A good practice is not to add more license information than you
actually do, i.e., don't declare it's from valgrind tests if you
believe you are using the original Public Domain
Hi zhenxu,
When you look at the header, it writes:
SHA-1 in C
By Steve Reid
100% Public Domain
Zhenxu Ke 于2023年2月14日 周二10:00写道:
> Hi, sorry the mailer-dae...@apache.org just says it can't deliver my
> email, which should be sent out last night (2023/02/13 22:49), here is my
> reply:
>
> Hi,
Hi, sorry the mailer-dae...@apache.org just says it can't deliver my email,
which should be sent out last night (2023/02/13 22:49), here is my reply:
Hi, now I would continue to vote -1 and I believe this should be fixed ASAP,
because you might copy the file[1] from Redis, but the file is not
Hi Justin,
It can be a case of The Ship of Theseus. When you take a look at the issued
files[1][2], you may find a commit history touching them and modifying
them. Anyway, it's not an identical copy or one-shot translation. And we
keep the origin comments.
Even a one-shot translation, if it's
Hi,
In general porting a file from one language to another would not change the
original license.
Kind Regards,
Justin
-
To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org
For additional commands, e-mail:
> you believe the original authors agree that the modifications
> are significant and can be relicensed, then I'm totally OK
> to add ASF license headers there
Hi zhenxu,
This is the case for Kvrocks. Kvrocks contributors port the file to cpp and
the original license is BSD 3-Clause which allows
Hi,
When it comes to human feelings there is no quantifiable standard,
if the original authors granted you to relicense the file, or,
you believe the original authors agree that the modifications
are significant and can be relicensed, then I'm totally OK
to add ASF license headers there.
If
Hi @kezhenxu94,
Thank you for taking the time to vote and for your valuable input.
However, I would like to point out that
- You can see the changes we have made to these files in the commit log,
and I have included some links [1-2] for your convenience.
- I cannot find an official description
Hi sorry -1 (binding) due to license issue, the following files [1] have ASF
license headers along with the original license header,
I saw you mentioned it's a conversion from C to C++ from Redis project, but
from my comparison they look to
be mostly the same so you might want to remove the ASF
+1 (binding)
I checked :
- [X] Download links are valid.
- [X] signatures and hashes are ok.
- [X] No binary files
- [X] LICENSE and NOTICE are ok
- [X] incubating in name, all source files have ASF headers.
Regards
Liang
On 2023/02/13 02:41:51 hulk wrote:
> +1 (non-binding)
>
> I checked:
>
+1 (non-binding)
I checked:
[x] Download links are valid.
[x] Checksums and signatures.
[x] LICENSE/NOTICE files exist
[x] No unexpected binary files
[x] All source files have ASF headers
[x] Can compile from source
[x] All Tests Passed
[x] Docker image with right
+1 (binding).
- Download links are valid.
- Checksums and signatures are valid.
- LICENSE, NOTICE and DISCLAIMER files exist.
- All source files have apache license declare if necessary.
- Compile from source passed.
- No compiled archives bundled in the source archive.
- Run successfully simple
+1 (binding)
Verified:
- [X] Download links are valid.
- [X] Checksums and PGP signatures are valid.
- [X] Source code artifacts have correct names matching the current release.
- [X] LICENSE, NOTICE and DISCLAIMER are correct for the repository.
- [X] All files have license headers if
Hi,
+1 (non-binding) from me. I have checked:
1. All the above links are correct;
2. The signature and checksum are correct;
3. LICENSE and NOTICE files exist;
Best regards
Chao Zhang
https://github.com/tokers
On Sat, Feb 11, 2023 at 10:44 PM Myth wrote:
>
> Hello Incubator PMC,
>
> The
Hello Incubator PMC,
The Apache Kvrocks community has voted and approved the release of Apache
Kvrocks(incubating) 2.3.0. We now kindly request the IPMC members review
and vote for this release.
This is the second call for a vote. The first call for a vote, which is
cancelled:
23 matches
Mail list logo