Re: [gentoo-dev] [PATCH v2] ruby-ng.eclass: Include (-) in RUBY_TARGETS USE-dependencies

2020-01-05 Thread Hans de Graaff
On Thu, 2020-01-02 at 22:08 +0100, Michał Górny wrote: > On Thu, 2020-01-02 at 21:15 +0100, Ulrich Mueller wrote: > > > Hadn't we established that ruby_samelib() is dead code, no longer > > used > > since 2010? > > > > You did. However, it isn't marked as private API and I'm not the > eclass >

Re: [gentoo-dev] [PATCH v2] ruby-ng.eclass: Include (-) in RUBY_TARGETS USE-dependencies

2020-01-05 Thread Hans de Graaff
On Thu, 2020-01-02 at 16:57 +0100, Michał Górny wrote: > Using 2-style USE dependencies on packages not having the flag > in question is forbidden by PMS. Looks good to me, thanks for proposing a fix for this. Hans signature.asc Description: This is a digitally signed message part

Re: [gentoo-dev] [PATCH v2] ruby-ng.eclass: Include (-) in RUBY_TARGETS USE-dependencies

2020-01-03 Thread James Le Cuirot
On Fri, 3 Jan 2020 22:34:19 + Michael 'veremitz' Everitt wrote: > On 03/01/20 10:36, David Seifert wrote: > > On Thu, 2020-01-02 at 21:54 +, Michael 'veremitz' Everitt wrote: > >> On 02/01/20 21:08, Michał Górny wrote: > >>> On Thu, 2020-01-02 at 21:15 +0100, Ulrich Mueller wrote:

Re: [gentoo-dev] [PATCH v2] ruby-ng.eclass: Include (-) in RUBY_TARGETS USE-dependencies

2020-01-03 Thread Luca Barbato
On 03/01/2020 23:34, Michael 'veremitz' Everitt wrote: On 03/01/20 10:36, David Seifert wrote: On Thu, 2020-01-02 at 21:54 +, Michael 'veremitz' Everitt wrote: On 02/01/20 21:08, Michał Górny wrote: On Thu, 2020-01-02 at 21:15 +0100, Ulrich Mueller wrote: On Thu, 02 Jan 2020, Michał

Re: [gentoo-dev] [PATCH v2] ruby-ng.eclass: Include (-) in RUBY_TARGETS USE-dependencies

2020-01-03 Thread Michael 'veremitz' Everitt
On 03/01/20 10:36, David Seifert wrote: > On Thu, 2020-01-02 at 21:54 +, Michael 'veremitz' Everitt wrote: >> On 02/01/20 21:08, Michał Górny wrote: >>> On Thu, 2020-01-02 at 21:15 +0100, Ulrich Mueller wrote: > On Thu, 02 Jan 2020, Michał Górny wrote: > --- a/eclass/ruby-ng.eclass

Re: [gentoo-dev] [PATCH v2] ruby-ng.eclass: Include (-) in RUBY_TARGETS USE-dependencies

2020-01-03 Thread David Seifert
On Thu, 2020-01-02 at 21:54 +, Michael 'veremitz' Everitt wrote: > On 02/01/20 21:08, Michał Górny wrote: > > On Thu, 2020-01-02 at 21:15 +0100, Ulrich Mueller wrote: > > > > > > > > On Thu, 02 Jan 2020, Michał Górny wrote: > > > > --- a/eclass/ruby-ng.eclass > > > > +++

Re: [gentoo-dev] [PATCH v2] ruby-ng.eclass: Include (-) in RUBY_TARGETS USE-dependencies

2020-01-02 Thread Michael 'veremitz' Everitt
On 02/01/20 21:08, Michał Górny wrote: > On Thu, 2020-01-02 at 21:15 +0100, Ulrich Mueller wrote: >>> On Thu, 02 Jan 2020, Michał Górny wrote: >>> --- a/eclass/ruby-ng.eclass >>> +++ b/eclass/ruby-ng.eclass >>> @@ -137,7 +137,7 @@ ruby_samelib() { >>> local res= >>> for

Re: [gentoo-dev] [PATCH v2] ruby-ng.eclass: Include (-) in RUBY_TARGETS USE-dependencies

2020-01-02 Thread Michał Górny
On Thu, 2020-01-02 at 21:15 +0100, Ulrich Mueller wrote: > > > > > > On Thu, 02 Jan 2020, Michał Górny wrote: > > --- a/eclass/ruby-ng.eclass > > +++ b/eclass/ruby-ng.eclass > > @@ -137,7 +137,7 @@ ruby_samelib() { > > local res= > > for _ruby_implementation in $(_ruby_get_all_impls); do >

Re: [gentoo-dev] [PATCH v2] ruby-ng.eclass: Include (-) in RUBY_TARGETS USE-dependencies

2020-01-02 Thread Ulrich Mueller
> On Thu, 02 Jan 2020, Michał Górny wrote: > --- a/eclass/ruby-ng.eclass > +++ b/eclass/ruby-ng.eclass > @@ -137,7 +137,7 @@ ruby_samelib() { > local res= > for _ruby_implementation in $(_ruby_get_all_impls); do > has -${_ruby_implementation} $@ || \ > -

[gentoo-dev] [PATCH v2] ruby-ng.eclass: Include (-) in RUBY_TARGETS USE-dependencies

2020-01-02 Thread Michał Górny
Using 2-style USE dependencies on packages not having the flag in question is forbidden by PMS. Signed-off-by: Michał Górny --- eclass/ruby-ng.eclass | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/eclass/ruby-ng.eclass b/eclass/ruby-ng.eclass index