Re: [gentoo-dev] [PATCH v3] mount-boot.eclass: Check if /boot is sane, but don't try to mount it.

2019-12-06 Thread Ulrich Mueller
> On Sat, 07 Dec 2019, Sergei Trofimovich wrote: >> # The user wants us to leave things be. >> -if [[ -n ${DONT_MOUNT_BOOT} ]] ; then >> +if [[ -n ${I_KNOW_WHAT_I_AM_DOING} ]] ; then >> return 0 >> fi > The rest of patch looks ok but I find

Re: [gentoo-dev] [PATCH] cargo.eclass: use verbose cargo invocations

2019-12-06 Thread Georgy Yakovlev
On Friday, December 6, 2019 3:44:38 PM PST Sergei Trofimovich wrote: > On Fri, 6 Dec 2019 12:09:31 -0800 > > Georgy Yakovlev wrote: > > Default output just prints crate name. > > With -vv we can see all cargo options and rustc args. > > > > Signed-off-by: Georgy Yakovlev > > --- > > Looks

Re: [gentoo-dev] [PATCH v3] mount-boot.eclass: Check if /boot is sane, but don't try to mount it.

2019-12-06 Thread Sergei Trofimovich
On Fri, 06 Dec 2019 16:35:53 +0100 Ulrich Müller wrote: > # The user wants us to leave things be. > - if [[ -n ${DONT_MOUNT_BOOT} ]] ; then > + if [[ -n ${I_KNOW_WHAT_I_AM_DOING} ]] ; then > return 0 > fi The rest of patch looks ok but I find

Re: [gentoo-dev] [PATCH] cargo.eclass: use verbose cargo invocations

2019-12-06 Thread Sergei Trofimovich
On Fri, 6 Dec 2019 12:09:31 -0800 Georgy Yakovlev wrote: > Default output just prints crate name. > With -vv we can see all cargo options and rustc args. > > Signed-off-by: Georgy Yakovlev > --- Looks good! I had to do an equivalent locally at least a few times. While at it I also suggest

[gentoo-dev] RFC: UID/GID assignment for net-analyzer/suricata

2019-12-06 Thread Marek Szuba
Hello, I hereby order... no, wait. Let me start over. Seeing as I am now in the process of reviving net-analyzer/suricata in the tree (5.0.0 builds and tests fine for me, there are however a few installation-time QA issues I'd like to take care of before pushing this), I would like to request

[gentoo-portage-dev] [PATCH] emerge: drop FEATURES=distcc-pump support, bug #702146

2019-12-06 Thread Sergei Trofimovich
'distcc' dustributes code generation for preprocessed files. 'pump' distributes preprocessing and code generation of files and imposes very strict requirement: """ Note that distcc's pump-mode assumes that sources files will not be modified during the lifetime of the include server, so modifying

Re: [gentoo-dev] unsanctioned python 2.7 crusade

2019-12-06 Thread Michael 'veremitz' Everitt
On 06/12/19 20:10, Andreas Sturmlechner wrote: > On Friday, 6 December 2019 20:47:31 CET Thomas Deutschmann wrote: >> On 2019-12-06 17:44, Mike Gilbert wrote: >>> 1. Keep the old version installed. >>> 2. Emit a confusing error message to the user since the use-dependency >>> on

Re: [gentoo-dev] unsanctioned python 2.7 crusade

2019-12-06 Thread Thomas Deutschmann
On 2019-12-06 21:10, Andreas Sturmlechner wrote: > Just so we're on the same page, a recent example of what some people > suggesting to keep py27 ad nauseam are asking users to deal with: > [...] > WARNING: One or more updates/rebuilds have been skipped due to a dependency > conflict: Yes, like

Re: [gentoo-dev] unsanctioned python 2.7 crusade

2019-12-06 Thread Andreas Sturmlechner
On Friday, 6 December 2019 20:47:31 CET Thomas Deutschmann wrote: > On 2019-12-06 17:44, Mike Gilbert wrote: > > 1. Keep the old version installed. > > 2. Emit a confusing error message to the user since the use-dependency > > on dev-python/example[python_targets_python2_7] cannot be resolved > >

[gentoo-dev] [PATCH] cargo.eclass: use verbose cargo invocations

2019-12-06 Thread Georgy Yakovlev
Default output just prints crate name. With -vv we can see all cargo options and rustc args. Signed-off-by: Georgy Yakovlev --- eclass/cargo.eclass | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/eclass/cargo.eclass b/eclass/cargo.eclass index 5b6d1f050f1..13dd5c355fb

Re: [gentoo-dev] unsanctioned python 2.7 crusade

2019-12-06 Thread Thomas Deutschmann
On 2019-12-06 17:44, Mike Gilbert wrote: > That's going to cause a very confusing user-experience due to > conflicting PYTHON_TARGETS values on the various packages. It's also > going to cause users to have old/unsupported/buggy versions of various > random python packages depending on what set of

Re: [gentoo-dev] [PATCH] package.deprecated: Create initial template

2019-12-06 Thread Michael Orlitzky
On 12/6/19 11:29 AM, Alexis Ballier wrote: > > Without good integration from the checker it is probably a PITA to > figure out that 23 too If you're reading through your commit log and if you see something wrong, you can $ git rebase -i to do a rebase starting at the one you'd like to fix.

Re: [gentoo-dev] [PATCH] package.deprecated: Create initial template

2019-12-06 Thread Michael 'veremitz' Everitt
On 06/12/19 16:28, Mike Gilbert wrote: > On Fri, Dec 6, 2019 at 10:46 AM Michael 'veremitz' Everitt > wrote: >> I hope you're not suggesting a rebase of any sort in gentoo.git, Matt ;) > He's talking about rebasing local commits that haven't yet been > pushed. That's perfectly normal. > Fair

Re: [gentoo-dev] unsanctioned python 2.7 crusade

2019-12-06 Thread Mike Gilbert
On Fri, Dec 6, 2019 at 11:12 AM Thomas Deutschmann wrote: > > On 2019-12-06 16:48, Mike Gilbert wrote: > > It's not quite so simple as you make it sound. There really isn't a > > viable way to defer removal of python2-only packages until we remove > > dev-lang/python:2.7. > > > > An increasing

Re: [gentoo-dev] unsanctioned python 2.7 crusade

2019-12-06 Thread Thomas Deutschmann
On 2019-12-06 17:35, Mart Raudsepp wrote: > I don't see anything wrong with the idea of p.masking it in case it > could be causing problems for others (such as py2). Sure, in *case* it *is* causing problems. ACK. But so far nobody was able to provide any reasons. That's the thing which drives me

Re: [gentoo-dev] unsanctioned python 2.7 crusade

2019-12-06 Thread Mart Raudsepp
Ühel kenal päeval, R, 06.12.2019 kell 14:06, kirjutas Thomas Deutschmann: > Since when is it acceptable for anyone to remove packages (the > package.mask entry clearly says that this package is scheduled for > removal and suspecting that any *user* will step and contact p-m for > example is naive)

Re: [gentoo-dev] [PATCH] package.deprecated: Create initial template

2019-12-06 Thread Mike Gilbert
On Fri, Dec 6, 2019 at 10:46 AM Michael 'veremitz' Everitt wrote: > I hope you're not suggesting a rebase of any sort in gentoo.git, Matt ;) He's talking about rebasing local commits that haven't yet been pushed. That's perfectly normal.

Re: [gentoo-dev] [PATCH] package.deprecated: Create initial template

2019-12-06 Thread Alexis Ballier
On Fri, 6 Dec 2019 10:41:56 -0500 Matt Turner wrote: > On Fri, Dec 6, 2019 at 5:51 AM Alexis Ballier > wrote: > > > > On Fri, 6 Dec 2019 04:33:36 -0500 > > Tim Harder wrote: > > > > > On 2019-12-06 Fri 04:03, Alexis Ballier wrote: > > > > it's not just like repoman and cvs since repoman commit

Re: [gentoo-dev] stable-bot is down. Temporary? Forever? Can we have a contacts page for it?

2019-12-06 Thread Matt Turner
stable-bot appears to be down again. I've been unsuccessful in reaching kensington on IRC. I think stable-bot has become an integral part of the workflow and as such (1) we should have the code available and (2) we should run it on some hardware that others are able to administer. Can we please?

Re: [gentoo-dev] unsanctioned python 2.7 crusade

2019-12-06 Thread Thomas Deutschmann
On 2019-12-06 16:48, Mike Gilbert wrote: > It's not quite so simple as you make it sound. There really isn't a > viable way to defer removal of python2-only packages until we remove > dev-lang/python:2.7. > > An increasing number of python packages are dropping support for > python2 when upstream

Re: [gentoo-dev] unsanctioned python 2.7 crusade

2019-12-06 Thread Mike Gilbert
On Fri, Dec 6, 2019 at 8:52 AM Rich Freeman wrote: > > On Fri, Dec 6, 2019 at 8:06 AM Thomas Deutschmann wrote: > > > > Sure, if packages don't work anymore or are blocking something, we will > > start last-rite process. But for the sabnzbd example (I haven't looked > > closely on any other

Re: [gentoo-dev] [PATCH] package.deprecated: Create initial template

2019-12-06 Thread Michael 'veremitz' Everitt
On 06/12/19 15:41, Matt Turner wrote: > On Fri, Dec 6, 2019 at 5:51 AM Alexis Ballier wrote: >> On Fri, 6 Dec 2019 04:33:36 -0500 >> Tim Harder wrote: >> >>> On 2019-12-06 Fri 04:03, Alexis Ballier wrote: it's not just like repoman and cvs since repoman commit did push ;) it will never

Re: [gentoo-dev] [PATCH] package.deprecated: Create initial template

2019-12-06 Thread Matt Turner
On Fri, Dec 6, 2019 at 5:51 AM Alexis Ballier wrote: > > On Fri, 6 Dec 2019 04:33:36 -0500 > Tim Harder wrote: > > > On 2019-12-06 Fri 04:03, Alexis Ballier wrote: > > > it's not just like repoman and cvs since repoman commit did push ;) > > > it will never be perfect but i really like repoman

[gentoo-dev] [PATCH v3] mount-boot.eclass: Check if /boot is sane, but don't try to mount it.

2019-12-06 Thread Ulrich Müller
MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The eclass failed to remount a read-only mounted /boot, because package collision sanity checks in recent Portage versions prevented it from reaching pkg_preinst() at all. Furthermore, with the

Re: [gentoo-dev] [PATCH] mount-boot.eclass: Check if /boot is sane, but don't try to mount it.

2019-12-06 Thread Michał Górny
On Fri, 2019-12-06 at 15:45 +0100, Ulrich Mueller wrote: > > > + local fstabstate=$(awk '!/^[[:blank:]]*#|^\/dev\/BOOT/ && $2 == "/boot" > > > \ > > > + {print $2}' /etc/fstab) > > The 'print' here is used as a boolean... why not use a boolean output > > instead? > > Changed, it's

[gentoo-dev] [PATCH v2] mount-boot.eclass: Check if /boot is sane, but don't try to mount it.

2019-12-06 Thread Ulrich Müller
The eclass failed to remount a read-only mounted /boot, because package collision sanity checks in recent Portage versions prevented it from reaching pkg_preinst() at all. Furthermore, with the "mount-sandbox" feature enabled, the mount won't be propagated past pkg_preinst() and installed files

Re: [gentoo-dev] [PATCH] mount-boot.eclass: Check if /boot is sane, but don't try to mount it.

2019-12-06 Thread Ulrich Mueller
> On Fri, 06 Dec 2019, Michał Górny wrote: >> reaching pkg_pretend() at all. Furthermore, with the "mount-sandbox" > Did you mean: pkg_preinst? Of course. >> -if [[ "${ROOT:-/}" != "/" ]] ; then >> +if [[ ${ROOT:-/} != "/" ]] ; then > I suppose you can unquote RHS too since it

Re: [gentoo-dev] [PATCH] mount-boot.eclass: Check if /boot is sane, but don't try to mount it.

2019-12-06 Thread Michał Górny
On Fri, 2019-12-06 at 14:11 +0100, Ulrich Müller wrote: > The eclass failed to remount a read-only mounted /boot, because package > collision sanity checks in recent Portage versions prevented it from > reaching pkg_pretend() at all. Furthermore, with the "mount-sandbox" Did you mean:

Re: [gentoo-dev] unsanctioned python 2.7 crusade

2019-12-06 Thread Rich Freeman
On Fri, Dec 6, 2019 at 8:06 AM Thomas Deutschmann wrote: > > Sure, if packages don't work anymore or are blocking something, we will > start last-rite process. But for the sabnzbd example (I haven't looked > closely on any other package from that list) there isn't anything > blocking and it's a

[gentoo-dev] [PATCH] mount-boot.eclass: Check if /boot is sane, but don't try to mount it.

2019-12-06 Thread Ulrich Müller
The eclass failed to remount a read-only mounted /boot, because package collision sanity checks in recent Portage versions prevented it from reaching pkg_pretend() at all. Furthermore, with the "mount-sandbox" feature enabled, the mount won't be propagated past pkg_preinst() and installed files

Re: [gentoo-dev] unsanctioned python 2.7 crusade

2019-12-06 Thread Thomas Deutschmann
Hi, On 2019-12-06 09:11, Mart Raudsepp wrote: > I don't think anyone can have a valid problem with package.mask of some > of the things mentioned (sabnzbd, abcde, etc), because they were indeed > maintainer-needed or sound@ (which David is part of, and is known > crickets territory) or whatnot.

Re: [gentoo-dev] [PATCH] package.deprecated: Create initial template

2019-12-06 Thread Tim Harder
On 2019-12-06 Fri 06:33, Michał Górny wrote: > If you need something convenient to commit, app-portage/mgorny-dev- > scripts has pkgcommit tool which does the only useful part of what > repoman did -- that is, prepends package name to the commit message. > For pre-push checks, I use the following

Re: [gentoo-dev] [PATCH] package.deprecated: Create initial template

2019-12-06 Thread Michał Górny
On Fri, 2019-12-06 at 03:23 -0500, Tim Harder wrote: > On 2019-12-05 Thu 17:00, Alexis Ballier wrote: > > > > pkgcheck is mostly used by your CI checks for > > > > producing huge reports, which is nice but addresses a different > > > > problem > > > There is nothing stopping you from running

Re: [gentoo-dev] [PATCH] package.deprecated: Create initial template

2019-12-06 Thread Alexis Ballier
On Fri, 6 Dec 2019 04:33:36 -0500 Tim Harder wrote: > On 2019-12-06 Fri 04:03, Alexis Ballier wrote: > > it's not just like repoman and cvs since repoman commit did push ;) > > it will never be perfect but i really like repoman commit to refuse > > to even commit if there's something obviously

Re: [gentoo-dev] unsanctioned python 2.7 crusade

2019-12-06 Thread David Seifert
On Fri, 2019-12-06 at 10:11 +0200, Mart Raudsepp wrote: > Ühel kenal päeval, N, 05.12.2019 kell 23:23, kirjutas David Seifert: > > When we started removing Qt4, tons of code still used it. To put > > things > > in perspective: > > > > grep -rl 'IUSE.*python_targets_python2_7' > >

Re: [gentoo-dev] [PATCH] package.deprecated: Create initial template

2019-12-06 Thread Tim Harder
On 2019-12-06 Fri 04:03, Alexis Ballier wrote: > it's not just like repoman and cvs since repoman commit did push ;) > it will never be perfect but i really like repoman commit to refuse to > even commit if there's something obviously wrong I'm more of the opinion (and am working towards that

Re: [gentoo-dev] [PATCH] package.deprecated: Create initial template

2019-12-06 Thread Alexis Ballier
On Fri, 2019-12-06 at 03:23 -0500, Tim Harder wrote: > On 2019-12-05 Thu 17:00, Alexis Ballier wrote: > > > > pkgcheck is mostly used by your CI checks for > > > > producing huge reports, which is nice but addresses a different > > > > problem > > > There is nothing stopping you from running

Re: [gentoo-dev] [PATCH] package.deprecated: Create initial template

2019-12-06 Thread Tim Harder
On 2019-12-05 Thu 17:00, Alexis Ballier wrote: > > > pkgcheck is mostly used by your CI checks for > > > producing huge reports, which is nice but addresses a different > > > problem > > There is nothing stopping you from running pkgcheck locally. In > > fact, > > it should work out of the box

Re: [gentoo-dev] unsanctioned python 2.7 crusade

2019-12-06 Thread Mart Raudsepp
Ühel kenal päeval, N, 05.12.2019 kell 23:23, kirjutas David Seifert: > When we started removing Qt4, tons of code still used it. To put > things > in perspective: > > grep -rl 'IUSE.*python_targets_python2_7' /usr/portage/metadata/md5- > cache/ | wc -l > > gives me 7070 ebuilds currently. 7070