>
> [1] <https://bugs.gentoo.org/show_bug.cgi?id=404157>
> - --
> Alexander
> berna...@gentoo.org
Let's see if we can get another release out the weekend of Sept 13-14
So, how about another meeting for finalizing that Next
Wednesday/Thursday? But hopefully not in t
On Wed, 3 Sep 2014 17:35:40 -0700
Brian Dolbec wrote:
>
> Most of you know about the plugin-sync branch of our portage.git repo.
> I believe it is ready for review and merge into master to become the
> new sync code for the future.
>
> Rather than follow this with 49 patch ma
review it using githubs
interface. You have that option too.
Thank you to all those that contributed to the code and testing.
--
Brian Dolbec
diff --git a/bin/emerge-webrsync b/bin/emerge-webrsync
index 2f0689c..43f92b6 100755
--- a/bin/emerge-webrsync
+++ b/bin/emerge-webrsync
@@ -501,8 +501,8
ope that's not until 9am local
> time me, because that's already about 6h too early. ;-)
> - --
> Alexander
> berna...@gentoo.org
It's 6 hours too early for me too! Midnight my time.
WhenIsGood Results
Event: Portage meeting
Date: September 3, 2014
Time: 7:0
d to explain the logic for
future troubleshooting or changes.
Since Arfever confirmed it fixed the bug for him, I think this is
clear to merge.
--
Brian Dolbec
On Fri, 29 Aug 2014 10:08:04 -0700
Brian Dolbec wrote:
>
>
> I have changed the version to and rebased your new-install branch
> on currrent master, and pushed it to my github account.
>
> https://github.com/dol-sen/portage
>
> I also am attaching the ebuilds
o.org',
> +
...
Also, setup.py sdist does not produce an installable tarball. It keeps
failing with unicode decode errors on various files on the different
target pythons.
eg:
copying and adjusting bin/fixpackages
->
/var/tmp/portage/sys-apps/portage-2.2.13_pre2/work/portage-2.2.13_pre2-python2_7/scripts/sbin/
Traceback (most recent call last): File
"/usr/lib64/python3.2/tokenize.py", line 298, in find_cookie
line_string = line.decode('utf-8') UnicodeDecodeError: 'utf-8' codec
can't decode byte 0xee in position 0: invalid continuation byte
---
I have changed the version to and rebased your new-install branch
on currrent master, and pushed it to my github account.
https://github.com/dol-sen/portage
I also am attaching the ebuilds I edited slightly
I have uploaded the 2.2.13_pre1 and _pre2 tarballs to my dev space.
_pre2 differs from _pre1 in that _pre2 is with the rebased git sources,
while _pre1 is Michal's original branch code.
you can rename the _pre2.ebuild to _pre1.ebuild to test at your
pleasure.
--
Brian Dolbec
portage-.ebuild
Description: Binary data
portage-2.2.13_pre2.ebuild
Description: Binary data
specify a slot explicitly or use
> a proper slot operator. This is meant to help fixing mistakes like:
>
> dev-libs/openssl -> dev-libs/openssl:0
> [:0.9.8 comes with no headers]
>
> --
> Best regards,
> Michał Górny
>
>
You need to get an ack from Chris and/or Tom for the repoman check
--
Brian Dolbec
;;
*)
Michał can you supply me a patch to fix this in catalyst and I will apply it.
I haven't started testing myself yet.
--
Brian Dolbec
self.build_dir = os.path.join(self.top_dir, 'bin')
> +
> + def run(self):
> + self.run_command('build_py')
> +
> + # install all scripts $build_lib/../bin
> + # (we can't do a symlink since we want shebangs
> corrected)
> + x_build_scripts_custom.run(self)
> +
> + # symlink 'cnf' directory
> + conf_dir = os.path.join(self.top_dir, 'cnf')
> + if os.path.exists(conf_dir):
> + if not os.path.islink(conf_dir):
> + raise SystemError('%s exists and is
> not a symlink (collision)'
> + % repr(conf_dir))
> + os.unlink(conf_dir)
> + conf_src = os.path.relpath('cnf', self.top_dir)
> + print('Symlinking %s -> %s' % (conf_dir, conf_src))
> + os.symlink(conf_src, conf_dir)
> +
> + # create $build_lib/../.portage_not_installed
> + # to enable proper paths in tests
> + with open(os.path.join(self.top_dir,
> '.portage_not_installed'), 'w') as f:
> + pass
> +
> +
> +class test(Command):
> + """ run tests """
> +
> + user_options = []
> +
> + def initialize_options(self):
> + self.build_lib = None
> +
> + def finalize_options(self):
> + self.set_undefined_options('build',
> + ('build_lib', 'build_lib'))
> +
> + def run(self):
> + self.run_command('build_tests')
> + subprocess.check_call([
> + sys.executable, '-bWd',
> + os.path.join(self.build_lib,
> 'portage/tests/runTests.py')
> + ])
> +
> +
> +def find_packages():
> + for dirpath, dirnames, filenames in os.walk('pym'):
> + if '__init__.py' in filenames:
> + yield os.path.relpath(dirpath, 'pym')
> +
> +
> +def find_scripts():
> + for dirpath, dirnames, filenames in os.walk('bin'):
> + for f in filenames:
> + yield os.path.join(dirpath, f)
> +
> +
> +def get_manpages():
> + linguas = os.environ.get('LINGUAS')
> + if linguas is not None:
> + linguas = linguas.split()
> +
> + for dirpath, dirnames, filenames in os.walk('man'):
> + groups = collections.defaultdict(list)
> + for f in filenames:
> + fn, suffix = f.rsplit('.', 1)
> + groups[suffix].append(os.path.join(dirpath,
> f)) +
> + topdir = dirpath[len('man/'):]
> + if not topdir or linguas is None or topdir in
> linguas:
> + for g, mans in groups.items():
> + yield [os.path.join('$mandir',
> topdir, 'man%s' % g), mans] +
> +setup(
> + name = 'portage',
> + version = '2.2.12',
> + url = 'https://wiki.gentoo.org/wiki/Project:Portage',
> + author = 'Gentoo Portage Development Team',
> + author_email = 'dev-port...@gentoo.org',
> +
> + package_dir = {'': 'pym'},
> + packages = list(find_packages()),
> + # something to cheat build & install commands
> + scripts = list(find_scripts()),
> +
> + data_files = list(get_manpages()) + [
> + ['$sysconfdir', ['cnf/etc-update.conf',
> 'cnf/dispatch-conf.conf']],
> + ['$logrotatedir',
> ['cnf/logrotate.d/elog-save-summary']],
> + ['$portage_confdir', [
> + 'cnf/make.conf.example', 'cnf/make.globals',
> 'cnf/repos.conf']],
> + ['$portage_setsdir', ['cnf/sets/portage.conf']],
> + ['$docdir', ['NEWS', 'RELEASE-NOTES']],
> + ],
> +
> + cmdclass = {
> + 'build_scripts': x_build_scripts,
> + 'build_scripts_bin': x_build_scripts_bin,
> + 'build_scripts_portagebin':
> x_build_scripts_portagebin,
> + 'build_scripts_sbin': x_build_scripts_sbin,
> + 'build_tests': build_tests,
> + 'clean': x_clean,
> + 'docbook': docbook,
> + 'epydoc': epydoc,
> + 'install': x_install,
> + 'install_data': x_install_data,
> + 'install_docbook': install_docbook,
> + 'install_epydoc': install_epydoc,
> + 'install_lib': x_install_lib,
> + 'install_scripts': x_install_scripts,
> + 'install_scripts_bin': x_install_scripts_bin,
> + 'install_scripts_portagebin':
> x_install_scripts_portagebin,
> + 'install_scripts_sbin': x_install_scripts_sbin,
> + 'sdist': x_sdist,
> + 'test': test,
> + },
> +
> + classifiers = [
> + 'Development Status :: 5 - Production/Stable',
> + 'Environment :: Console',
> + 'Intended Audience :: System Administrators',
> + 'License :: OSI Approved :: GNU General Public
> License v2 (GPLv2)',
> + 'Operating System :: POSIX',
> + 'Programming Language :: Python',
> + 'Topic :: System :: Installation/Setup'
> + ]
> +)
--
Brian Dolbec
_PATH before spawning
> them. The correct values can be obtained using portageq:
>
> $ portageq envvar PORTAGE_BIN_PATH
> /usr/lib/portage/python3.4
> $ portageq envvar PORTAGE_PYM_PATH
> /usr/lib64/python3.4/site-packages
>
>
> Please look through the patches and test at will :). Thanks.
>
> --
> Michał Górny
>
>
I have not tested these yet, but they mostly look good aside for the
couple questions I had (see individual replies).
I will begin some testing.
--
Brian Dolbec
> +package_name = 'portage'
> +package_version = '2.2.12'
Why hard code the version? can you not import it? or did you add this
to the sed list in mkrelease.sh?
--
Brian Dolbec
join(self.cnf_path,
> "make.globals") d = getconfig(make_globals_file)
> for k, v in self._cases.items():
> self.assertEqual(d[k], v)
Why was "import portage" added but not used anywhere in additional code?
--
Brian Dolbec
age/package/ebuild/doebuild.py | 8 ++--
> 2 files changed, 9 insertions(+), 2 deletions(-)
>
Seems fine to me...
--
Brian Dolbec
ve stated this is an EAPI 6
involved change. Also, EAPI 6 is no where near started to be supported
in portage. So if this is an EAPI 6 change, it is the first.
--
Brian Dolbec
signature.asc
Description: PGP signature
from portage/const.py:
EAPI = 5
which is clearly an integer.
Shouldn't it be a list of supported EAPI's if it is a string?
Then you'd also have to change the range() use to a len of EAPI.split()
--
Brian Dolbec
urrent master without disrupting the rewrite. The rewrite
should be easily rebased including this patch plus the few others
recently applied.
But yes, having QA's approval is needed...
I know it is already scheduled with them. :)
- --
Brian Dolbec
-BEGIN PGP
implied
behavior the actual behavior. So while I was originally objecting to
them, then was not opposing them (last time we discussed inclusion), I
now see them much clearer and agree with them.
The --ask implying --autounmask-write is something people would not
object to so strongly like th
easier to eyeball upstream builds for new warnings.
>
> This behaviour is more in line with EXTRA_ECONF variable.
>
> Signed-off-by: Sergei Trofimovich
> ---
Applied, thank you for this patch.
--
Brian Dolbec
--
emerge: fix invalid locale setting (bug 519074)
Don't die when the user has an invalid locale setting.
Resolves bug 519074.
--
Brian Dolbec
ails["dependency.missingslot"].append(
+
relative_path +
+ ": %s:
'%s' matches more than one slot, please specify an explicit slot and/or use the
:= or :* slot operator" %
+
(mytype, atom))
if catdir != "virtual":
if not is_blocker and \
--
2.0.4
--
Brian Dolbec
>>>>>>>>>>>>>>>>>>>>>>>>>=sys-apps/dbus-1.6.18-r1[abi_x86_32(-)],
> >>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>=sys-apps/file-5.18-r1[abi_x86_32(-)],
> >>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>=sys-apps/tcp-wrappers-7.6.22-r1[abi_x86_32(-)],
> >>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>=sys-apps/util-linux-2.24.1-r3[abi_x86_32(-)],
> >>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>=sys-devel/gettext-0.18.3.2[abi_x86_32(-)],
> >>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>=sys-devel/libtool-2.4.2-r1[abi_x86_32(-)],
> >>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>=sys-devel/llvm-3.3-r3[abi_x86_32(-)],
> >>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>=sys-libs/e2fsprogs-libs-1.42.9[abi_x86_32(-)],
> >>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>=sys-libs/gdbm-1.10-r1[abi_x86_32(-)],
> >>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>=sys-libs/gpm-1.20.7-r2[abi_x86_32(-)],
> >>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>=sys-libs/libavc1394-0.5.4-r1[abi_x86_32(-)],
> >>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>=sys-libs/libraw1394-2.1.0-r1[abi_x86_32(-)],
> >>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>=sys-libs/ncurses-5.9-r3[abi_x86_32(-)],
> >>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>=sys-libs/readline-6.2_p5-r1:0[abi_x86_32(-)],
> >>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>=sys-libs/slang-2.2.4-r1[abi_x86_32(-)],
> >>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>=sys-libs/zlib-1.2.8-r1[abi_x86_32(-)]
>
> CC-ing multilib@ for consultation :).
>
> I don't think this should prevent us from committing the patch,
> however. If we believe the potential false positives are important
> enough, we should just add explanatory 'if False' instead of keeping
> a code bug ;).
>
Since, TomWij isn't around atm.
ack to commit this patch.
--
Brian Dolbec
signature.asc
Description: PGP signature
mat('%d', num_kib, grouping=True) + ' KiB'
> + formatted_num = locale.format('%d', num_kib, grouping=True)
> + return (_unicode_decode(formatted_num,
> encoding=_encodings['stdio']) + ' KiB')
DOH, repliied to the wrong one... this is the one I meant.
--
Brian Dolbec
tes / 1024)
> - return locale.format('%d', num_kib, grouping=True) + ' KiB'
> + return (_unicode_decode(locale.format('%d', num_kib,
> grouping=True))
> + + ' KiB')
OK, commit this one. mark the bug inVCS, add it to the tracker bug.
--
Brian Dolbec
om portage.eapi import (eapi_has_iuse_defaults, eapi_has_required_use,
+ eapi_has_slot_operator)
Please use brackets for long imports instead of using line continuation
backslashes
--
Brian Dolbec
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA512
On Fri, 1 Aug 2014 14:45:11 -0700
Brian Dolbec wrote:
> -BEGIN PGP SIGNED MESSAGE-
> Hash: SHA512
>
> On Fri, 01 Aug 2014 22:08:12 +0200
> Alexander Berntsen wrote:
>
> > -BEGIN PGP SIGNED MESSA
Alexander
> berna...@gentoo.org
> https://secure.plaimi.net/~alexander
>
Have fun on your vacation
There will be a delay in the release, I am getting 2 test fails in
py-3.2 and py-3.3. I'll work on fixing those first, I will also
...
SO will not be running the meeting... but try to participate :D
- --
Brian Dolbec
-BEGIN PGP SIGNATURE-
Version: GnuPG v2.0.22 (GNU/Linux)
iQF8BAEBCgBmBQJTydGoXxSAAC4AKGlzc3Vlci1mcHJAbm90YXRpb25zLm9w
ZW5wZ3AuZmlmdGhob3JzZW1hbi5uZXQ4Njg4RkQxQ0M3MUMxQzA0RUFFQTQyMzcy
MjE0R
writemsg_level("\nAll selected packages: %s\n" % "
> ".join(all_selected), noiselevel=-1)
> + writemsg_level("\nAll selected packages: =%s\n" %
> + " =".join(all_selected),
> noiselevel=-1)
> writemsg_level(&qu
one breakup has started
subslots, backtracking, resolver <== we really need to get a sub team
together to to handle the bugs, learn the code, create a new code model
to work towards implementing. Sebastian is all alone on this. He needs
help.
--
Brian Dolbec
On Sun, 18 May 2014 08:59:59 -0700
Brian Dolbec wrote:
> The next team meeting scheduler:
>
> http://whenisgood.net/3547ndr
>
> Proposed dates are from Saturday, May 24 through Sunday June 1.
>
> Please try to pick as wide a time period as possible to allow for the
&
s you feel need to be dealt with.
I will also try using portholes (supybot) meeting plug-in, so if anyone
is familiar with it's commands. Please feel free to help out as
meeting secretary.
--
Brian Dolbec
ng a little
Gibbs'ish today :)
http://www.youtube.com/watch?v=4nXtcNnC3wY
- --
Brian Dolbec
-BEGIN PGP SIGNATURE-
Version: GnuPG v2.0.22 (GNU/Linux)
iQF8BAEBCgBmBQJTcUFxXxSAAC4AKGlzc3Vlci1mcHJAbm90YXRpb25zLm9w
ZW5wZ3AuZmlmdGhob3JzZW1hbi5uZXQ4
ar to me which. And instead of tracebacking like it did,
have it error out instead.
In the short term it likely won't hurt (we may need to dis-able it for
a new release) and will allow them to do more testing, to establish the
official parameters of the new feature
hose 2 simple line
changes..
quoting the original email/patch:
This adds proof-of-concept support for bug #282296.
NOTE the words "proof-of-concept"
- --
Brian Dolbec
-BEGIN PGP SIGNATURE-
Version: GnuPG v2.0.22 (GNU/Linux)
iQF8BAEBCgBmBQJTcRa9XxSAAC4AKGlz
=proj/portage.git;a=commit;h=54e439500e9c95582973c2350f293796b9455d44
--
Brian Dolbec
ortage.git;a=commit;h=1970d866b67ddbcdbd4eb5d20a5762f9efbd17aa
--
Brian Dolbec
signature.asc
Description: PGP signature
On Fri, 18 Apr 2014 12:26:13 -0700
Pavel Kazakov wrote:
> On 04/11/2014 04:03 PM, Brian Dolbec wrote:
> > On Fri, 11 Apr 2014 15:05:09 -0700
> > Pavel Kazakov wrote:
> >
> >> On 03/31/2014 12:00 AM, Alexander Berntsen wrote:
> >>> On 31/03/14 04:06
On Fri, 11 Apr 2014 15:05:09 -0700
Pavel Kazakov wrote:
> On 03/31/2014 12:00 AM, Alexander Berntsen wrote:
> > On 31/03/14 04:06, Brian Dolbec wrote:
> >> It all looked really good to me. {:-D
> > Yep.
> >
> > Please update the commit messages to follow DE
> Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/
>
> iF4EAREIAAYFAlNBYpsACgkQRtClrXBQc7XgFwD+LSILTSjYCR2D5Z6IFbIEwAiK
> Hi+kp+X0zWN7MwimUdMBAIuVnutZ8zb0VBCdgF/zANV/SEZ4Y60mcLzDMNK1pJxT
> =eA08
> -END PGP SIGNATURE-
>
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA512
On Fri, 04 Apr 2014 22:01:39 +0200
Alexander Berntsen wrote:
> -BEGIN PGP SIGNED MESSAGE-
> Hash: SHA256
>
> On 04/04/14 21:36, Brian Dolbec wrote:
> > Is there any other bugfixes to go in? I am merging some other
> &
[PATCH 1/2] portage/util/writeable_check.py: Fix RO check bug (505428)
[PATCH 2/2] TaskSequence.py: Fix starting an empty queue (bug 506186)
These are the fixes for 2 recent bugs. I'd like to merge them and push out a
release
again soon. Perhaps this weekend.
Is there any other bugfixes to go
---
pym/_emerge/TaskSequence.py | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/pym/_emerge/TaskSequence.py b/pym/_emerge/TaskSequence.py
index 1fecf63..b4bfefe 100644
--- a/pym/_emerge/TaskSequence.py
+++ b/pym/_emerge/TaskSequence.py
@@ -30,8 +30,9 @@ class TaskSequence(
Use /proc/self/mountinfo which only contains the relevant chroot mounts.
Mountinfo changes are thanks to jcallen for the valuable info he provided.
---
pym/portage/util/writeable_check.py | 31 +++
1 file changed, 19 insertions(+), 12 deletions(-)
diff --git a/pym/port
all looked really good to me.
{:-D
Now if we can only get the rest of the portage code nice, clean like
this :)
--
Brian Dolbec
;
> diff --git a/pym/portage/const.py b/pym/portage/const.py
> index 1785bff..50f0719 100644
> --- a/pym/portage/const.py
> +++ b/pym/portage/const.py
It all looked really good to me.
{:-D
--
Brian Dolbec
hon is to explicitly name
> functions (and modules) which you use, rather than importing
> everything in a single namespace and having people scroll up and down
> to see where functions come from.
>
Yes, I agree for this, it is only used once and is clearer in this
instance. It might be dif
columns
> DEVELOPING: Add note on commits
> DEVELOPING: Add note on commit messages
>
> DEVELOPING | 98
> +----- 1 file
> changed, 65 insertions(+), 33 deletions(-)
>
Ack on the revised commits. go ahead and commit. :) Thanks
--
Brian Dolbec
specific things to big commits that
> +change a lot of unrelated things. This makes it easier to see what
> +parts of the system have actually changed. It also makes it easier
> to +cherry-pick and revert commits. Use your commonsense!
>
> Releases
>
ack
--
Brian Dolbec
On Thu, 27 Mar 2014 13:48:38 +0100
Alexander Berntsen wrote:
> ---
> Nothing to see here, move along.
>
do it.
--
Brian Dolbec
ormat
or if your worried about the space since bug is 2 char. longer than #,
drop the 2 () characters. It'll be the same length so:
+emerge: Fix --tree output bug 55
--
Brian Dolbec
%
("Parent Dep:".ljust(15), dep.atom,
uneval, myparent),
lines 1-16/16 (END)
This takes advantage of the fact that uneval is initialized to ""
Then only reassigns it if there is actually a mismatch.
--
Brian Dolbec
On Sat, 15 Mar 2014 21:48:59 +0100
Sebastian Luther wrote:
> Am 15.03.2014 21:32, schrieb Brian Dolbec:
> > I've started working on the repository/config.py changes needed for
> > the plugin-sync system.
> >
> > First:
> > The following class performed ch
continue
###
# end remove
###
# For backward compatibility with locations set via
PORTDIR and
# PORTDIR_OVERLAY, delay validation of the location and
repo.name
# until after PORTDIR and PORTDIR_OVERLAY have been
processed.
prepos[sname] = repo
--
Brian Dolbec
stian I believe, has had the most experience with the tests, so I
will leave the review up to him, Mike.
--
Brian Dolbec
---
pym/_emerge/depgraph.py | 5 +++--
pym/_emerge/main.py | 5 +
2 files changed, 8 insertions(+), 2 deletions(-)
diff --git a/pym/_emerge/depgraph.py b/pym/_emerge/depgraph.py
index 835bd6b..04d7aae 100644
--- a/pym/_emerge/depgraph.py
+++ b/pym/_emerge/depgraph.py
@@ -7692,8 +7692,9 @@
---
pym/_emerge/actions.py | 4 ++--
pym/_emerge/main.py| 6 +++---
2 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/pym/_emerge/actions.py b/pym/_emerge/actions.py
index 95c5c14..9783689 100644
--- a/pym/_emerge/actions.py
+++ b/pym/_emerge/actions.py
@@ -3486,7 +3486,7 @@ def e
This is a multi-part message in MIME format.
Hopefully there isn't anything else Seabastian finds in this one.
Thank you Sebastian for your review and fixes :)
Brian Dolbec (2):
As per bug #472104 add option --verbose-slot-rebuilds=y|n
Whitespace cleanup
pym/_emerge/actions.py
---
pym/_emerge/depgraph.py | 5 +++--
pym/_emerge/main.py | 5 +
pym/portage/package/ebuild/config.py | 3 +++
3 files changed, 11 insertions(+), 2 deletions(-)
diff --git a/pym/_emerge/depgraph.py b/pym/_emerge/depgraph.py
index 835bd6b..291d18c 100644
--- a/py
---
pym/_emerge/actions.py | 4 ++--
pym/_emerge/main.py| 6 +++---
2 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/pym/_emerge/actions.py b/pym/_emerge/actions.py
index 95c5c14..9783689 100644
--- a/pym/_emerge/actions.py
+++ b/pym/_emerge/actions.py
@@ -3486,7 +3486,7 @@ def e
This is a multi-part message in MIME format.
After clearing up the communication error between Sebastian and myself...
Him beating me with a clue bat ;)
(That's what I get for answering an email before being fully awake :)
Here is a less involved patch.
Brian Dolbec (2):
As per bug #47210
On Sun, 23 Feb 2014 18:31:54 +0100
Sebastian Luther wrote:
> Am 23.02.2014 09:07, schrieb Brian Dolbec:
> > ---
> > pym/_emerge/actions.py | 5 +
> > pym/_emerge/depgraph.py | 5 +++--
> > pym/_emerge/main.py | 5 +++
As per bug 472104. Add the emerge option --verbose-slot-rebuild to have
the ability to turn off the option. It is defaulted to "ON".
Second patch is some automatic whitespace cleanup my editor did while working
on this change.
---
pym/_emerge/actions.py | 4 ++--
pym/_emerge/main.py| 6 +++---
2 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/pym/_emerge/actions.py b/pym/_emerge/actions.py
index a3f7813..f3e3b0c 100644
--- a/pym/_emerge/actions.py
+++ b/pym/_emerge/actions.py
@@ -3491,7 +3491,7 @@ def e
---
pym/_emerge/actions.py | 5 +
pym/_emerge/depgraph.py | 5 +++--
pym/_emerge/main.py | 5 +
pym/portage/package/ebuild/config.py | 3 +++
4 files changed, 16 insertions(+), 2 deletions(-)
diff --git a/pym/_emerge/actions.py b/pym/_emerge/act
file.
8) I also think we should add the date/time info when they ere
added to the tracking file and cleaned from the filesystem
P.S. I can help with this if you like.
--
Brian Dolbec
},
'module2':{
'name': "movebin",
'class': "MoveBinary",
'description': "Perform package move updates for binary
packages",
'functions': ['check', 'fi
>
>
> > + # Delete failed merge
> > directory
> > + # XXX: Would be a good
> > idea to attempt try removing
> > + # package contents to
> > prevent orphaned files
> >
>
> # XXX is terrible style. I realize a bunch of code does that, and it is
> stupid.
> # use
> # TODO: foo
>
>
>
>
> > + shutil.rmtree(pkg_path)
> > + # Re-emerge package
> >
> + pkg_name = '=' +
> > failed_pkg.replace('-MERGING-', '')
> > +
> > features='FEATURES="-collision-detect -protect-owned"'
> > + emerge_cmd="emerge
> > --verbose --oneshot --complete-graph=y"
> > + os.system('%s %s %s' %
> > (features, emerge_cmd, pkg_name))
> >
>
> This is a security vulnerability :)
>
> -A
>
Yeah, but it is the only way to actually fix a failed merge. You must
turn off collision protect so it can overwrite the stray files from
the previously failed merge. There often is not a valid CONTENTS file.
Plus it may not be accurate as to the files actually merged. This
module is for fixing pkgs that fail during the merge phase to the live
filesystem.
--
Brian Dolbec
writemsg('Unable to fix failed package: %s' % str(ex))
Really
? don't use os.system() It is nearly obsolete. use subprocess.call()
or Popen(). call() is a direct sub. Use Popen for piping output...
Also, it would be better to call emerge with all pkgs in one command.
I know it will rarely be more than 1, maybe 2 but, emerge is slow
enough just intitializing.
You might also want to turn off the progressbar for fix unless you
intend to pipe emerge's output and hide it. I might be inclined to
just run emerge in minimum output mode. It will display what it is
doing and any more failed builds/merges. I know I had the other
modules output the data without displaying and let the cli handle any
display. We should be able to do similar to the progressbar, and
connect the emerge stdout pipe to a display code. That way any other
frontend could do with the output what they like.
--
Brian Dolbec
On Wed, 19 Feb 2014 10:33:15 -0800
Brian Dolbec wrote:
> On Wed, 19 Feb 2014 13:10:04 -0500
> Chris Reffett wrote:
>
> > This wraps the output of emerge checks so that a list of length 1-2 is
> > generated. The first element is the file, the second element (optional)
>
alized by
the code at the bottom of the page when the page is first loaded into
memory. This format saves writing out each individual class by hand
and makes changes easy. It also reduced the size of the file to about
1/3. I have done similar to tis in 3 modules in the catalys rewrite
as well.
The data is then available in many ways and will have a consistent
output.
--
Brian Dolbec
t from your review link. But I am
unable to fetch it from your link to test.
fatal: remote error: Git repository not found.
Mike, if you can confirm the tests pass. Go ahead and merge it.
--
Brian Dolbec
signature.asc
Description: PGP signature
On Sat, 15 Feb 2014 13:40:23 +0100
Sebastian Luther wrote:
> ---
> pym/portage/package/ebuild/fetch.py | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
Yeah, looks fine. Merge it :)
Sorry for the delay reviewing.
--
Brian Dolbec
On Thu, 13 Feb 2014 10:03:50 -0800
Alec Warner wrote:
> On Thu, Feb 13, 2014 at 7:42 AM, Brian Dolbec
> wrote:
>
> > well actually, for simple additions like that, string1 + string2,
> > it is actually faster.
> > But for multiple additions, %s is much better, fast
iteral_data("%s" % number)
>
well actually, for simple additions like that, string1 + string2, it is
actually faster.
But for multiple additions, %s is much better, faster. Also if the
string is translated, then use %s regardless. That way the %s can be
moved around for the translation.
> str(number)
> -mike
--
Brian Dolbec
signature.asc
Description: PGP signature
add_line_break()
> + if not dofull:
> + if not full and dofail and category in
> qawarnings:
> + # warnings are considered noise when
> there are failures
> + continue
> + fails_list = fails[category]
> + if not full and len(fails_list) > 12:
> + fails_list = fails_list[:12]
> + for failure in fails_list:
> + formatter.add_literal_data(category
> + " " + failure)
> + formatter.add_line_break()
> +
> def editor_is_executable(editor):
> """
> Given an EDITOR string, validate that it refers to
looks good to me.
--
Brian Dolbec
else:
> + formatter.push_style("BAD")
> + formatter.add_literal_data("%s" % number)
> + formatter.pop_style()
> + formatter.add_line_break()
> + if not dofull:
> + if not full and dofail and category in
> qawarnings:
> + # warnings are considered noise when
> there are failures
> + continue
> + fails_list = fails[category]
> + if not full and len(fails_list) > 12:
> + fails_list = fails_list[:12]
> + for failure in fails_list:
> + formatter.add_literal_data(category
> + " " + failure)
> + formatter.add_line_break()
> +
> def editor_is_executable(editor):
> """
> Given an EDITOR string, validate that it refers to
--
Brian Dolbec
morrow at Feb. 9, 19:00 UTC in #gentoo-meetings, join us and we can
discuss it more with the others. There have been a few bug fixes, but
I don't know if there is some others that should be dealt with before a
2.2.9 release.
If you can't attend the meeting, at least I will have a bet
ult is improved by solving 4 out of 5 conflicts.
>
>
>
I'm replying to all the series. I saw no glaring obvious mistakes.
This code is in areas I know little about, but your changes do seem
logical. Your additional fixes to these patches also look good.
If Mike/Arfrever gives the thumbs up. They're good to go in my opinion.
--
Brian Dolbec
On Fri, 31 Jan 2014 08:13:56 +0100
Sebastian Luther wrote:
> Am 31.01.2014 06:27, schrieb Brian Dolbec:
>
> > I have updated the Proposal page [2] with more things to do as well
> > as some insights I discovered during the initial porting.
> >
>
> > 6. Dete
On Thu, 09 Jan 2014 09:33:51 -0800
Brian Dolbec wrote:
>
> I have started a Proposals sub-page under the Portage project page in
> the wiki. It has a link to a diagram I made showing how the plug-in
> system is laid out. This thread will be used to discuss the proposal
>
d utilities. I am doing the same for several other small
utility libs to avoid copy/pasting the same code over and over again.
Besides, portage will have the python code as an emergency backup.
--
Brian Dolbec
On Wed, 22 Jan 2014 00:29:27 -0500
Mike Frysinger wrote:
> Acked-by: Mike Frysinger
> -mike
Done, pushed.
allows emerge to continue with an yes answer rather than have to start
the dep calc's over again.
So, I agree that having to have both --ask and --pretend to get the
same functionality is just bad and not intuitive.
Brian Dolbec,
On Mon, 2014-01-13 at 19:10 -0500, Jesus Rivero wrote:
> Signed-off-by: Jesus Rivero
sounds good. clear to push
signature.asc
Description: This is a digitally signed message part
orry, that was me that told him to. I didn't know about a bugzilla
workflow doc. Plus I didn't see it at www.gentoo.org. So it wasn't
converted to the wiki.
--
Brian Dolbec
signature.asc
Description: This is a digitally signed message part
On Mon, 2014-01-13 at 07:43 +0100, Sebastian Luther wrote:
> Am 10.01.2014 11:35, schrieb Brian Dolbec:
> > First off. Welcome and than you for responding to help with
> > portage.
> >
> > With this many people, we should be able to make good progress
> > w
ubmissions.
Thank you
[1] https://wiki.gentoo.org/wiki/Project:Portage/Meetings
--
Brian Dolbec
signature.asc
Description: This is a digitally signed message part
On Sun, 2014-01-05 at 21:33 -0800, Brian Dolbec wrote:
> This is a general call for developers to join the portage development
> team.
>
> aka: Recruiting Drive
>
> If you have some "Good" python and/or bash skills and want/need to or
> already know portage'
have (with g.o.g.o down) and a
brief summary of how it works please. The we can start to have a look
at it. Possibly come up with some better (if possible) ideas on
integrating it.
P.S. add yourself to the project wiki page as a member.
--
Brian Dolbec
signature.asc
Description: This is a digitally signed message part
On Fri, 2014-01-10 at 22:07 -0500, Chris Reffett wrote:
> Hi all,
> Attached is a patch to test if Portage is going to write to a
> read-only filesystem and print out the list of filesystems that need
> to be remounted RW. This leaves ${D} intact rather than having some
> files moved before hitting
months, then hold an election
for lead in March. Is that alright with everyone?
Thanks
--
Brian Dolbec
signature.asc
Description: This is a digitally signed message part
that
problem is not a concern. Also a lock file could be used to prevent
another emerge process form interfering with an ongoing sync run. Just
like it does now for merging completed builds.
--
Brian Dolbec
signature.asc
Description: This is a digitally signed message part
On Thu, 2014-01-09 at 19:46 +0100, Sebastian Luther wrote:
> The layout makes sense. Except the problems I see with where the
> modules are installed (see later).
>
> Not sure about module_spec yet.
>
> > [...]
> >
The module_spec is a means to make available to the operational manager
what th
On Thu, 2014-01-09 at 09:33 -0800, Brian Dolbec wrote:
> I have started a Proposals sub-page under the Portage project page in
> the wiki. It has a link to a diagram I made showing how the plug-in
> system is laid out. This thread will be used to discuss the proposal
> and the de
layman -s some-overlay", "emerge --sync some-overlay"
P.S. sorry for such a long email
--
Brian Dolbec
signature.asc
Description: This is a digitally signed message part
/Project:Portage/Ongoing-TODO
https://wiki.gentoo.org/wiki/Project:Portage/Proposals
--
Brian Dolbec
signature.asc
Description: This is a digitally signed message part
nt on that, then there
will also be that to implement.
So for now, join, start delving into the code, see what you can do.
Ask questions...
We will need to establish some meetings after some newcomers have had a
bit of time to see what needs doing. We can start making some decisions
then.
Thank
Once we get an indication that new volunteers are no longer coming
forward to join. We will elect a new lead.
Those interested in joining, please subscribe to the gentoo-portage-dev
list and send an email stating what you can offer and any ideas you have
to improve portage's code base.
--
B
On Sun, 2014-01-05 at 18:04 -0500, Mike Frysinger wrote:
> On Sunday 05 January 2014 17:54:12 Alexander Berntsen wrote:
> > On 05/01/14 23:30, Brian Dolbec wrote:
> > > If you open the tracker bug. The bug numbers listed as blockers.
> > > Hover your mouse over the
501 - 600 of 634 matches
Mail list logo
