Re: [gentoo-portage-dev] [PATCH] repoman: Add commit message verification

2018-02-04 Thread Michał Górny
W dniu nie, 04.02.2018 o godzinie 22∶15 +0100, użytkownik Ulrich Mueller napisał: > > > > > > On Sun, 04 Feb 2018, Michał Górny wrote: > > W dniu sob, 03.02.2018 o godzinie 09∶58 +0100, użytkownik Ulrich Mueller > > napisał: > > > > Add a check for common mistakes in commit messages. For now, it >

Re: [gentoo-portage-dev] [PATCH] repoman: Add commit message verification

2018-02-04 Thread Ulrich Mueller
> On Sun, 04 Feb 2018, Michał Górny wrote: > W dniu sob, 03.02.2018 o godzinie 09∶58 +0100, użytkownik Ulrich Mueller > napisał: >> > Add a check for common mistakes in commit messages. For now, it >> > is pretty rough and exits immediately but it should be integrated >> > with the editor in

Re: [gentoo-portage-dev] [PATCH] repoman: Add commit message verification

2018-02-04 Thread Michał Górny
W dniu sob, 03.02.2018 o godzinie 09∶58 +0100, użytkownik Ulrich Mueller napisał: > > > > > > On Fri, 2 Feb 2018, Michał Górny wrote: > > Add a check for common mistakes in commit messages. For now, it is > > pretty rough and exits immediately but it should be integrated with > > the editor in the

Re: [gentoo-portage-dev] [PATCH] repoman: Add commit message verification

2018-02-04 Thread Brian Dolbec
On Sun, 04 Feb 2018 18:58:21 +0100 Michał Górny wrote: > W dniu nie, 04.02.2018 o godzinie 09∶51 -0800, użytkownik Brian Dolbec > napisał: > > > > I know there are not a lot of repoman unit tests, but, can you > > please create some to test this? That way it doesn't get any

Re: [gentoo-portage-dev] [PATCH] repoman: Add commit message verification

2018-02-04 Thread Michał Górny
W dniu nie, 04.02.2018 o godzinie 09∶51 -0800, użytkownik Brian Dolbec napisał: > On Fri, 2 Feb 2018 23:53:05 +0100 > Michał Górny wrote: > > > Add a check for common mistakes in commit messages. For now, it is > > pretty rough and exits immediately but it should be

Re: [gentoo-portage-dev] [PATCH] repoman: Add commit message verification

2018-02-04 Thread Brian Dolbec
On Fri, 2 Feb 2018 23:53:05 +0100 Michał Górny wrote: > Add a check for common mistakes in commit messages. For now, it is > pretty rough and exits immediately but it should be integrated with > the editor in the future. > --- > repoman/pym/repoman/actions.py | 68 >

Re: [gentoo-portage-dev] [PATCH] repoman: Add commit message verification

2018-02-03 Thread Michał Górny
W dniu sob, 03.02.2018 o godzinie 09∶58 +0100, użytkownik Ulrich Mueller napisał: > > > > > > On Fri, 2 Feb 2018, Michał Górny wrote: > > Add a check for common mistakes in commit messages. For now, it is > > pretty rough and exits immediately but it should be integrated with > > the editor in the

Re: [gentoo-portage-dev] [PATCH] repoman: Add commit message verification

2018-02-03 Thread Ulrich Mueller
> On Fri, 2 Feb 2018, Michał Górny wrote: > Add a check for common mistakes in commit messages. For now, it is > pretty rough and exits immediately but it should be integrated with > the editor in the future. Have you tested this against existing commits in the gentoo repo? Ulrich