libosmo-netif[master]: osmux: Re-write osmux_snprintf

2017-09-19 Thread Pablo Neira Ayuso
;nhofm...@sysmocom.de> Gerrit-Reviewer: Pablo Neira Ayuso <pa...@gnumonks.org> Gerrit-Reviewer: Pau Espin Pedrol <pes...@sysmocom.de> Gerrit-HasComments: No

[MERGED] libosmo-netif[master]: src: _snprintf() helper functions nul-terminate buffers, if ...

2017-09-18 Thread Pablo Neira Ayuso
Pablo Neira Ayuso has submitted this change and it was merged. Change subject: src: _snprintf() helper functions nul-terminate buffers, if possible .. src: _snprintf() helper functions nul-terminate buffers, if possible

[PATCH] openbsc[master]: libmsc: sms_route_mt_sms() may return uninitialized return v...

2017-09-13 Thread Pablo Neira Ayuso
mocom.org/3899 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I0c0bcd919cc3275d491995d17c6a32bb61c6afe1 Gerrit-PatchSet: 4 Gerrit-Project: openbsc Gerrit-Branch: master Gerrit-Owner: Pablo Neira Ayuso <pa...@gnumonks.org> Gerrit-Reviewer:

openbsc[master]: libmsc: db_subscriber_alloc_exten() remove infinite loop

2017-09-13 Thread Pablo Neira Ayuso
omatica.org> Gerrit-Reviewer: Neels Hofmeyr <nhofm...@sysmocom.de> Gerrit-Reviewer: Pablo Neira Ayuso <pa...@gnumonks.org> Gerrit-HasComments: No

openbsc[master]: libmsc: db_subscriber_alloc_exten() remove infinite loop

2017-09-12 Thread Pablo Neira Ayuso
Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Keith Whyte <ke...@rhizomatica.org> Gerrit-Reviewer: Neels Hofmeyr <nhofm...@sysmocom.de> Gerrit-Reviewer: Pablo Neira Ayuso <pa...@gnumonks.org> Gerrit-HasComments: No

openbsc[master]: libmsc: db_subscriber_alloc_exten() remove infinite loop

2017-09-12 Thread Pablo Neira Ayuso
Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Keith Whyte <ke...@rhizomatica.org> Gerrit-Reviewer: Neels Hofmeyr <nhofm...@sysmocom.de> Gerrit-Reviewer: Pablo Neira Ayuso <pa...@gnumonks.org> Gerrit-HasComments: No

openbsc[master]: libmsc: db_subscriber_alloc_exten() remove infinite loop

2017-09-12 Thread Pablo Neira Ayuso
rit-Reviewer: Neels Hofmeyr <nhofm...@sysmocom.de> Gerrit-Reviewer: Pablo Neira Ayuso <pa...@gnumonks.org> Gerrit-HasComments: Yes

[PATCH] libosmo-netif[master]: src: _snprintf() helper functions nul-terminate buffers, if ...

2017-09-12 Thread Pablo Neira Ayuso
ibosmo-netif Gerrit-Branch: master Gerrit-Owner: Pablo Neira Ayuso <pa...@gnumonks.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Pablo Neira Ayuso <pa...@gnumonks.org> Gerrit-Reviewer: Pau Espin Pedrol <pes...@sysmocom.de>

openbsc[master]: libmsc: Log Rx DELIVER-SM RESP before calling gsm411_send_rp...

2017-09-12 Thread Pablo Neira Ayuso
-Owner: Keith Whyte <ke...@rhizomatica.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Pablo Neira Ayuso <pa...@gnumonks.org> Gerrit-HasComments: No

[PATCH] libosmo-netif[master]: src: _snprintf() helper functions always nul-terminate buffers

2017-09-12 Thread Pablo Neira Ayuso
visit https://gerrit.osmocom.org/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I97e517f2d98e83894ea707c63489559302ff6bd2 Gerrit-PatchSet: 2 Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Owner: Pablo Neira Ayuso <pa...@gnumonks.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Pab

openbsc[master]: libmsc: sms_route_mt_sms() may return uninitialized return v...

2017-09-11 Thread Pablo Neira Ayuso
: I0c0bcd919cc3275d491995d17c6a32bb61c6afe1 Gerrit-PatchSet: 2 Gerrit-Project: openbsc Gerrit-Branch: master Gerrit-Owner: Pablo Neira Ayuso <pa...@gnumonks.org> Gerrit-Reviewer: Harald Welte <lafo...@gnumonks.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Keith Whyte <ke...@rhizomat

openbsc[master]: libmsc: annotate esme route in the sms object from deliver_t...

2017-09-11 Thread Pablo Neira Ayuso
-Owner: Pablo Neira Ayuso <pa...@gnumonks.org> Gerrit-Reviewer: Harald Welte <lafo...@gnumonks.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Keith Whyte <ke...@rhizomatica.org> Gerrit-Reviewer: Neels Hofmeyr <nhofm...@sysmocom.de> Gerrit-Reviewer: Pablo Neira Ayuso <

[MERGED] openbsc[master]: libmsc: annotate esme route in the sms object from deliver_t...

2017-09-11 Thread Pablo Neira Ayuso
Pablo Neira Ayuso has submitted this change and it was merged. Change subject: libmsc: annotate esme route in the sms object from deliver_to_esme() .. libmsc: annotate esme route in the sms object from deliver_to_esme

[PATCH] openbsc[master]: libmsc: sms_route_mt_sms() may return uninitialized return v...

2017-09-11 Thread Pablo Neira Ayuso
mocom.org/3899 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I0c0bcd919cc3275d491995d17c6a32bb61c6afe1 Gerrit-PatchSet: 2 Gerrit-Project: openbsc Gerrit-Branch: master Gerrit-Owner: Pablo Neira Ayuso <pa...@gnumonks.org> Gerrit-Reviewer:

[MERGED] libosmo-netif[master]: osmux: fix buffer management mess in snprintf() calls

2017-09-11 Thread Pablo Neira Ayuso
Pablo Neira Ayuso has submitted this change and it was merged. Change subject: osmux: fix buffer management mess in snprintf() calls .. osmux: fix buffer management mess in snprintf() calls SNPRINTF_BUFFER_SIZE() looks too

libosmo-netif[master]: osmux: fix buffer management mess in snprintf() calls

2017-09-11 Thread Pablo Neira Ayuso
Gerrit-MessageType: comment Gerrit-Change-Id: I5b5d6ec57a02f57c23b1ae86dbd894bad28ea797 Gerrit-PatchSet: 3 Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Owner: Pablo Neira Ayuso <pa...@gnumonks.org> Gerrit-Reviewer: Harald Welte <lafo...@gnumonks.org> Gerrit-Reviewer: Jenkins Bu

openbsc[master]: libmsc: annotate esme route in the sms object from deliver_t...

2017-09-11 Thread Pablo Neira Ayuso
sit https://gerrit.osmocom.org/3900 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib8a8fd9bbb0d3b6aff7931e4bacbea99d000e484 Gerrit-PatchSet: 1 Gerrit-Project: openbsc Gerrit-Branch: master Gerrit-Owner: Pablo Neira Ayuso <pa...@gnumonks.org>

[PATCH] openbsc[master]: libmsc: annotate esme route in the sms object from deliver_t...

2017-09-10 Thread Pablo Neira Ayuso
Set: 1 Gerrit-Project: openbsc Gerrit-Branch: master Gerrit-Owner: Pablo Neira Ayuso <pa...@gnumonks.org>

openbsc[master]: libmsc: Either route report to ESME or send it, not both

2017-09-10 Thread Pablo Neira Ayuso
rit-Branch: master Gerrit-Owner: Keith Whyte <ke...@rhizomatica.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Keith Whyte <ke...@rhizomatica.org> Gerrit-Reviewer: Neels Hofmeyr <nhofm...@sysmocom.de> Gerrit-Reviewer: Pablo Neira Ayuso <pa...@gnumonks.org> Gerrit-HasComments: Yes

openbsc[master]: libmsc: Either route report to ESME or send it, not both

2017-09-10 Thread Pablo Neira Ayuso
nch: master Gerrit-Owner: Keith Whyte <ke...@rhizomatica.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Keith Whyte <ke...@rhizomatica.org> Gerrit-Reviewer: Neels Hofmeyr <nhofm...@sysmocom.de> Gerrit-Reviewer: Pablo Neira Ayuso <pa...@gnumonks.org> Gerrit-HasComments: Yes

openbsc[master]: libmsc: Either route report to ESME or send it, not both

2017-09-10 Thread Pablo Neira Ayuso
ject: openbsc Gerrit-Branch: master Gerrit-Owner: Keith Whyte <ke...@rhizomatica.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Keith Whyte <ke...@rhizomatica.org> Gerrit-Reviewer: Neels Hofmeyr <nhofm...@sysmocom.de> Gerrit-Reviewer: Pablo Neira Ayuso <pa...@gnumonks.org> Gerrit-HasComments: Yes

[PATCH] openbsc[master]: libmsc: sms_route_mt_sms() may return uninitialized return v...

2017-09-10 Thread Pablo Neira Ayuso
bcd919cc3275d491995d17c6a32bb61c6afe1 Gerrit-PatchSet: 1 Gerrit-Project: openbsc Gerrit-Branch: master Gerrit-Owner: Pablo Neira Ayuso <pa...@gnumonks.org>

libosmo-netif[master]: src: _snprintf() helper functions always nul-terminate buffers

2017-09-10 Thread Pablo Neira Ayuso
rit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Owner: Pablo Neira Ayuso <pa...@gnumonks.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Pablo Neira Ayuso <pa...@gnumonks.org> Gerrit-Reviewer: Pau Espin Pedrol <pes...@sysmocom.de> Gerrit-HasComments: Yes

[PATCH] libosmo-netif[master]: osmux: fix buffer management mess in snprintf() calls

2017-09-10 Thread Pablo Neira Ayuso
msg = msgb_alloc(1500, "test"); -- To view, visit https://gerrit.osmocom.org/3825 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I5b5d6ec57a02f57c23b1ae86dbd894bad28ea797 Gerrit-PatchSet: 3 Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Owner: Pablo Neira Ayuso <pa...@gnumonks.org> Gerrit-Reviewer: Harald Welte <lafo...@gnumonks.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Pablo Neira Ayuso <pa...@gnumonks.org> Gerrit-Reviewer: Pau Espin Pedrol <pes...@sysmocom.de>

libosmo-netif[master]: osmux: fix buffer management mess in snprintf() calls

2017-09-10 Thread Pablo Neira Ayuso
ect: libosmo-netif Gerrit-Branch: master Gerrit-Owner: Pablo Neira Ayuso <pa...@gnumonks.org> Gerrit-Reviewer: Harald Welte <lafo...@gnumonks.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Pablo Neira Ayuso <pa...@gnumonks.org> Gerrit-Reviewer: Pau Espin Pedrol <pes...@sysmoco

[MERGED] libosmo-netif[master]: rtp: return offset in osmo_rtp_snprintf()

2017-09-10 Thread Pablo Neira Ayuso
Pablo Neira Ayuso has submitted this change and it was merged. Change subject: rtp: return offset in osmo_rtp_snprintf() .. rtp: return offset in osmo_rtp_snprintf() Instead of the result of the last snprintf() call. Change

[PATCH] libosmo-netif[master]: src: _snprintf() helper functions always nul-terminate buffers

2017-09-05 Thread Pablo Neira Ayuso
rrit-MessageType: newchange Gerrit-Change-Id: I97e517f2d98e83894ea707c63489559302ff6bd2 Gerrit-PatchSet: 1 Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Owner: Pablo Neira Ayuso <pa...@gnumonks.org>

[PATCH] libosmo-netif[master]: osmux: fix buffer management mess in snprintf() calls

2017-09-05 Thread Pablo Neira Ayuso
seq; + struct msgb *msg; int i, j, k = 0; + char buf[1024]; + uint16_t seq; for (i = 1; i < 65; i++) { msg = msgb_alloc(1500, "test"); -- To view, visit https://gerrit.osmocom.org/3825 To unsubscribe, visit https://gerrit.osmocom.org/se

libosmo-netif[master]: osmux: Re-write osmux_snprintf

2017-09-04 Thread Pablo Neira Ayuso
t-Reviewer: Jenkins Builder Gerrit-Reviewer: Neels Hofmeyr <nhofm...@sysmocom.de> Gerrit-Reviewer: Pablo Neira Ayuso <pa...@gnumonks.org> Gerrit-Reviewer: Pau Espin Pedrol <pes...@sysmocom.de> Gerrit-HasComments: Yes

libosmo-netif[master]: osmux: Re-write osmux_snprintf

2017-09-04 Thread Pablo Neira Ayuso
Harald Welte <lafo...@gnumonks.org> Gerrit-Reviewer: Holger Freyther <hol...@freyther.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Neels Hofmeyr <nhofm...@sysmocom.de> Gerrit-Reviewer: Pablo Neira Ayuso <pa...@gnumonks.org> Gerrit-Reviewer: Pau Espin Pedrol <pes...@sysmocom.de> Gerrit-HasComments: Yes

libosmo-netif[master]: osmux: Re-write osmux_snprintf

2017-08-21 Thread Pablo Neira Ayuso
: I695771d099833842db37a415b636035d17f1bba7 Gerrit-PatchSet: 1 Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Owner: Pau Espin Pedrol <pes...@sysmocom.de> Gerrit-Reviewer: Holger Freyther <hol...@freyther.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Pablo Nei

libosmo-netif[master]: osmux: Re-write osmux_snprintf

2017-08-21 Thread Pablo Neira Ayuso
Type: comment Gerrit-Change-Id: I695771d099833842db37a415b636035d17f1bba7 Gerrit-PatchSet: 1 Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Owner: Pau Espin Pedrol <pes...@sysmocom.de> Gerrit-Reviewer: Holger Freyther <hol...@freyther.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Re

libosmo-netif[master]: osmux: Re-write osmux_snprintf

2017-08-21 Thread Pablo Neira Ayuso
Gerrit-Owner: Pau Espin Pedrol <pes...@sysmocom.de> Gerrit-Reviewer: Holger Freyther <hol...@freyther.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Pablo Neira Ayuso <pa...@gnumonks.org> Gerrit-HasComments: No

openbsc[master]: libmsc: Fix wrong handling of user_message_reference parameter

2017-08-18 Thread Pablo Neira Ayuso
: openbsc Gerrit-Branch: master Gerrit-Owner: Pau Espin Pedrol <pes...@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Pablo Neira Ayuso <pa...@gnumonks.org> Gerrit-HasComments: No

libosmocore[master]: gsm0411_utils: GSM03.40 9.2.3.11 SCTS should be local

2017-08-18 Thread Pablo Neira Ayuso
; Gerrit-Reviewer: Pablo Neira Ayuso <pa...@gnumonks.org> Gerrit-HasComments: No

libosmo-netif[master]: osmux: Re-write osmux_snprintf

2017-08-18 Thread Pablo Neira Ayuso
Gerrit-Owner: Pau Espin Pedrol <pes...@sysmocom.de> Gerrit-Reviewer: Holger Freyther <hol...@freyther.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Pablo Neira Ayuso <pa...@gnumonks.org> Gerrit-HasComments: Yes

libosmocore[master]: gsm0411_utils: GSM03.40 9.2.3.11 SCTS should be local

2017-08-18 Thread Pablo Neira Ayuso
r: Jenkins Builder Gerrit-Reviewer: Pablo Neira Ayuso <pa...@gnumonks.org> Gerrit-HasComments: No

openbsc[master]: libmsc: Use actual delivery time in delivery reports.

2017-08-18 Thread Pablo Neira Ayuso
-Owner: Keith Whyte <ke...@rhizomatica.org> Gerrit-Reviewer: Holger Freyther <hol...@freyther.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Keith Whyte <ke...@rhizomatica.org> Gerrit-Reviewer: Pablo Neira Ayuso <pa...@gnumonks.org> Gerrit-HasComments: No

openbsc[master]: SMS Delivery reports: Use actual delivery time, not time of ...

2017-08-17 Thread Pablo Neira Ayuso
it-MessageType: comment Gerrit-Change-Id: I9056429d40bf02731f004b7833f1de45a0d1add8 Gerrit-PatchSet: 1 Gerrit-Project: openbsc Gerrit-Branch: master Gerrit-Owner: Keith Whyte <ke...@rhizomatica.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Keith Whyte <ke...@rhizomatica.org&

openbsc[master]: SMS Delivery reports: Use actual delivery time, not time of ...

2017-08-17 Thread Pablo Neira Ayuso
tica.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Keith Whyte <ke...@rhizomatica.org> Gerrit-Reviewer: Pablo Neira Ayuso <pa...@gnumonks.org> Gerrit-HasComments: Yes

[PATCH] openbsc[master]: libmsc: use SMPP34_DELIVERY_RECEIPT_* in libsmpp34

2017-08-15 Thread Pablo Neira Ayuso
sit https://gerrit.osmocom.org/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ie78e17323796120f576b9c0e1bc5ccc32da8ee12 Gerrit-PatchSet: 2 Gerrit-Project: openbsc Gerrit-Branch: master Gerrit-Owner: Pablo Neira Ayuso <pa...@gnumonks.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Review

openbsc[master]: smpp: Fix compilation warning

2017-08-15 Thread Pablo Neira Ayuso
-Owner: Pau Espin Pedrol <pes...@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Pablo Neira Ayuso <pa...@gnumonks.org> Gerrit-HasComments: No

openbsc[master]: smpp: Fix compilation warning

2017-08-14 Thread Pablo Neira Ayuso
: I0901ddadb5f72e1585cb1797ac22c8ab95e83146 Gerrit-PatchSet: 1 Gerrit-Project: openbsc Gerrit-Branch: master Gerrit-Owner: Pau Espin Pedrol <pes...@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Pablo Neira Ayuso <pa...@gnumonks.org> Gerrit-HasComments: Yes

openbsc[master]: LIBMSC: Place correct dst address in status report

2017-08-14 Thread Pablo Neira Ayuso
Gerrit-Branch: master Gerrit-Owner: Keith Whyte <ke...@rhizomatica.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Pablo Neira Ayuso <pa...@gnumonks.org> Gerrit-HasComments: No

[MERGED] libsmpp34[master]: add delivery receipt definitions

2017-08-14 Thread Pablo Neira Ayuso
Pablo Neira Ayuso has submitted this change and it was merged. Change subject: add delivery receipt definitions .. add delivery receipt definitions The registered_delivery field in SMPP message is a toggle on/off, this patch

libsmpp34[master]: add delivery receipt definitions

2017-08-14 Thread Pablo Neira Ayuso
-PatchSet: 1 Gerrit-Project: libsmpp34 Gerrit-Branch: master Gerrit-Owner: Pablo Neira Ayuso <pa...@gnumonks.org> Gerrit-Reviewer: Harald Welte <lafo...@gnumonks.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Pablo Neira Ayuso <pa...@gnumonks.org> Gerrit-HasComments: No

openbsc[master]: libmsc: use SMPP34_DELIVERY_RECEIPT_* in libsmpp34

2017-08-14 Thread Pablo Neira Ayuso
: Ie78e17323796120f576b9c0e1bc5ccc32da8ee12 Gerrit-PatchSet: 1 Gerrit-Project: openbsc Gerrit-Branch: master Gerrit-Owner: Pablo Neira Ayuso <pa...@gnumonks.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Pablo Neira Ayuso <pa...@gnumonks.org> Gerrit-HasComments: No

[PATCH] openbsc[master]: libmsc: use SMPP34_DELIVERY_RECEIPT_* in libsmpp34

2017-08-14 Thread Pablo Neira Ayuso
12 Gerrit-PatchSet: 1 Gerrit-Project: openbsc Gerrit-Branch: master Gerrit-Owner: Pablo Neira Ayuso <pa...@gnumonks.org>

[PATCH] libsmpp34[master]: add delivery receipt definitions

2017-08-14 Thread Pablo Neira Ayuso
://gerrit.osmocom.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I5b3afff1b3b77cccd949e0606914c7ac3ba6114c Gerrit-PatchSet: 1 Gerrit-Project: libsmpp34 Gerrit-Branch: master Gerrit-Owner: Pablo Neira Ayuso <pa...@gnumonks.org>

osmo-msc[master]: 04.08: log protocol discriminators and message types by name

2017-08-11 Thread Pablo Neira Ayuso
Gerrit-Owner: Neels Hofmeyr <nhofm...@sysmocom.de> Gerrit-Reviewer: Harald Welte <lafo...@gnumonks.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Neels Hofmeyr <nhofm...@sysmocom.de> Gerrit-Reviewer: Pablo Neira Ayuso <pa...@gnumonks.org> Gerrit-HasComments: No

osmo-gsm-manuals[master]: osmux: Fix description for Dummy frames FT field

2017-08-11 Thread Pablo Neira Ayuso
: master Gerrit-Owner: Pau Espin Pedrol <pes...@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Pablo Neira Ayuso <pa...@gnumonks.org> Gerrit-HasComments: No

openbsc[master]: mgcp_osmux: Remove unused parameter

2017-08-11 Thread Pablo Neira Ayuso
-Owner: Pau Espin Pedrol <pes...@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Pablo Neira Ayuso <pa...@gnumonks.org> Gerrit-HasComments: No

[PATCH] openbsc[master]: libmsc: use smpp34_tlv_for_each() to avoid suboptimal TLV ha...

2017-08-11 Thread Pablo Neira Ayuso
lue.val16); *psms = sms; return ESME_ROK; -- To view, visit https://gerrit.osmocom.org/3470 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I53a65164a6cc4abc6bf57d9a8dc275cf21c90222 Gerrit-PatchSet: 3 Gerrit-Project: openbsc Ge

[PATCH] libsmpp34[master]: add esm_class definitions

2017-08-11 Thread Pablo Neira Ayuso
://gerrit.osmocom.org/3473 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I91afd8b462b8fd3b2c4c5b54f4eeb7ec5b730b65 Gerrit-PatchSet: 2 Gerrit-Project: libsmpp34 Gerrit-Branch: master Gerrit-Owner: Pablo Neira Ayuso <pa...@gnumonks.org> Gerrit-Re

[MERGED] libsmpp34[master]: add smpp34_tlv_for_each() helper

2017-08-11 Thread Pablo Neira Ayuso
Pablo Neira Ayuso has submitted this change and it was merged. Change subject: add smpp34_tlv_for_each() helper .. add smpp34_tlv_for_each() helper So we don't need to remember this is an opencoded list of TLVs. Change-Id

openbsc[master]: libmsc: use smpp34_tlv_for_each() to avoid suboptimal TLV ha...

2017-08-11 Thread Pablo Neira Ayuso
Gerrit-Change-Id: I53a65164a6cc4abc6bf57d9a8dc275cf21c90222 Gerrit-PatchSet: 2 Gerrit-Project: openbsc Gerrit-Branch: master Gerrit-Owner: Pablo Neira Ayuso <pa...@gnumonks.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Pablo Neira Ayuso <pa...@gnumonks.org> Gerrit-Reviewer: Pau

openbsc[master]: libmsc: use smpp34_tlv_for_each() to avoid suboptimal TLV ha...

2017-08-11 Thread Pablo Neira Ayuso
: I53a65164a6cc4abc6bf57d9a8dc275cf21c90222 Gerrit-PatchSet: 2 Gerrit-Project: openbsc Gerrit-Branch: master Gerrit-Owner: Pablo Neira Ayuso <pa...@gnumonks.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Pablo Neira Ayuso <pa...@gnumonks.org> Gerrit-Reviewer: Pau Espin Pedrol <pes...@sysm

openbsc[master]: libmsc: use new smpp34 esm_class definitions

2017-08-11 Thread Pablo Neira Ayuso
: I6c458690da60c8f3637680efbd718f6e8c6feb4c Gerrit-PatchSet: 1 Gerrit-Project: openbsc Gerrit-Branch: master Gerrit-Owner: Pablo Neira Ayuso <pa...@gnumonks.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Pablo Neira Ayuso <pa...@gnumonks.org> Gerrit-HasComments: No

[PATCH] openbsc[master]: libmsc: use new smpp34 esm_class definitions

2017-08-11 Thread Pablo Neira Ayuso
https://gerrit.osmocom.org/3474 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I6c458690da60c8f3637680efbd718f6e8c6feb4c Gerrit-PatchSet: 1 Gerrit-Project: openbsc Gerrit-Branch: master Gerrit-Owner: Pablo Neira Ayuso <pa...@gnumonks.org>

openbsc[master]: libmsc: use smpp34_tlv_for_each() to avoid suboptimal TLV ha...

2017-08-11 Thread Pablo Neira Ayuso
Gerrit-Project: openbsc Gerrit-Branch: master Gerrit-Owner: Pablo Neira Ayuso <pa...@gnumonks.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Pablo Neira Ayuso <pa...@gnumonks.org> Gerrit-HasComments: No

[PATCH] libsmpp34[master]: add esm_class definitions

2017-08-11 Thread Pablo Neira Ayuso
-MessageType: newchange Gerrit-Change-Id: I91afd8b462b8fd3b2c4c5b54f4eeb7ec5b730b65 Gerrit-PatchSet: 1 Gerrit-Project: libsmpp34 Gerrit-Branch: master Gerrit-Owner: Pablo Neira Ayuso <pa...@gnumonks.org>

openbsc[master]: libmsc: update database to accomodate SMS status-report fields

2017-08-11 Thread Pablo Neira Ayuso
Gerrit-PatchSet: 4 Gerrit-Project: openbsc Gerrit-Branch: master Gerrit-Owner: Pablo Neira Ayuso <pa...@gnumonks.org> Gerrit-Reviewer: Harald Welte <lafo...@gnumonks.org> Gerrit-Reviewer: Holger Freyther <hol...@freyther.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewe

[PATCH] openbsc[master]: libmsc: use smpp34_tlv_for_each() to avoid suboptimal TLV ha...

2017-08-11 Thread Pablo Neira Ayuso
VID_user_message_reference); - if (t) - sms->msg_ref = ntohs(t->value.val16); *psms = sms; return ESME_ROK; -- To view, visit https://gerrit.osmocom.org/3470 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id

[PATCH] openbsc[master]: libmsc: use smpp34_tlv_for_each() to avoid suboptimal TLV ha...

2017-08-11 Thread Pablo Neira Ayuso
t = find_tlv(submit->tlv, TLVID_user_message_reference); - if (t) - sms->msg_ref = ntohs(t->value.val16); *psms = sms; return ESME_ROK; -- To view, visit https://gerrit.osmocom.org/3470 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-Me

openbsc[master]: libmsc: update database to accomodate SMS status-report fields

2017-08-11 Thread Pablo Neira Ayuso
-Change-Id: I7276d356d805a83ebeec72b02c8563b7135ea0b6 Gerrit-PatchSet: 4 Gerrit-Project: openbsc Gerrit-Branch: master Gerrit-Owner: Pablo Neira Ayuso <pa...@gnumonks.org> Gerrit-Reviewer: Harald Welte <lafo...@gnumonks.org> Gerrit-Reviewer: Holger Freyther <hol...@freyther.de&g

[PATCH] libsmpp34[master]: add smpp34_tlv_for_each() helper

2017-08-11 Thread Pablo Neira Ayuso
rit-MessageType: newchange Gerrit-Change-Id: I446929feed049d0411e1629ca263e2bc41f714cc Gerrit-PatchSet: 1 Gerrit-Project: libsmpp34 Gerrit-Branch: master Gerrit-Owner: Pablo Neira Ayuso <pa...@gnumonks.org>

[PATCH] openbsc[master]: libmsc: gsm340_gen_oa_sub() may return negative value

2017-08-10 Thread Pablo Neira Ayuso
ange Gerrit-Change-Id: I47215d7d89771730a7f84efa8aeeb187a0911fdb Gerrit-PatchSet: 1 Gerrit-Project: openbsc Gerrit-Branch: master Gerrit-Owner: Pablo Neira Ayuso <pa...@gnumonks.org>

[MERGED] openbsc[master]: libmsc: handle delivery ack via SMPP SUBMIT SM / send GSM 03...

2017-08-09 Thread Pablo Neira Ayuso
Pablo Neira Ayuso has submitted this change and it was merged. Change subject: libmsc: handle delivery ack via SMPP SUBMIT SM / send GSM 03.40 status report .. libmsc: handle delivery ack via SMPP SUBMIT SM / send GSM 03.40

[MERGED] openbsc[master]: libmsc: support GSM 03.40 status report for nitb

2017-08-09 Thread Pablo Neira Ayuso
Pablo Neira Ayuso has submitted this change and it was merged. Change subject: libmsc: support GSM 03.40 status report for nitb .. libmsc: support GSM 03.40 status report for nitb This patch adds support for GSM 03.40 in nitb

openbsc[master]: libmsc: handle delivery ack via SMPP SUBMIT SM / send GSM 03...

2017-08-09 Thread Pablo Neira Ayuso
-Owner: Pablo Neira Ayuso <pa...@gnumonks.org> Gerrit-Reviewer: Harald Welte <lafo...@gnumonks.org> Gerrit-Reviewer: Holger Freyther <hol...@freyther.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Keith Whyte <ke...@rhizomatica.org> Gerrit-Reviewer: Neels Hofmeyr <n

[MERGED] openbsc[master]: utils: smpp_mirror: bounce Delivery Receipts as Delivery Ack...

2017-08-09 Thread Pablo Neira Ayuso
Pablo Neira Ayuso has submitted this change and it was merged. Change subject: utils: smpp_mirror: bounce Delivery Receipts as Delivery Acknowledgments .. utils: smpp_mirror: bounce Delivery Receipts as Delivery

openbsc[master]: utils: smpp_mirror: bounce Delivery Receipts as Delivery Ack...

2017-08-09 Thread Pablo Neira Ayuso
-Owner: Pablo Neira Ayuso <pa...@gnumonks.org> Gerrit-Reviewer: Harald Welte <lafo...@gnumonks.org> Gerrit-Reviewer: Holger Freyther <hol...@freyther.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Keith Whyte <ke...@rhizomatica.org> Gerrit-Reviewer: Neels Hofmeyr <n

openbsc[master]: libmsc: update database to accomodate SMS status-report fields

2017-08-09 Thread Pablo Neira Ayuso
, visit https://gerrit.osmocom.org/3435 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7276d356d805a83ebeec72b02c8563b7135ea0b6 Gerrit-PatchSet: 4 Gerrit-Project: openbsc Gerrit-Branch: master Gerrit-Owner: Pablo Neira Ayuso <pa...@gnum

[MERGED] openbsc[master]: libmsc: update database to accomodate SMS status-report fields

2017-08-09 Thread Pablo Neira Ayuso
Pablo Neira Ayuso has submitted this change and it was merged. Change subject: libmsc: update database to accomodate SMS status-report fields .. libmsc: update database to accomodate SMS status-report fields SMPP DELIVER_SM

[MERGED] openbsc[master]: utils: smpp_mirror: temporarily munch SMPP delivery receipts

2017-08-09 Thread Pablo Neira Ayuso
Pablo Neira Ayuso has submitted this change and it was merged. Change subject: utils: smpp_mirror: temporarily munch SMPP delivery receipts .. utils: smpp_mirror: temporarily munch SMPP delivery receipts Just munch and log

[MERGED] openbsc[master]: utils: smpp_mirror: set registered_delivery field in SMPP SU...

2017-08-09 Thread Pablo Neira Ayuso
Pablo Neira Ayuso has submitted this change and it was merged. Change subject: utils: smpp_mirror: set registered_delivery field in SMPP SUBMIT_SM .. utils: smpp_mirror: set registered_delivery field in SMPP SUBMIT_SM To test

[MERGED] openbsc[master]: libmsc: add support for SMPP delivery receipts

2017-08-09 Thread Pablo Neira Ayuso
Pablo Neira Ayuso has submitted this change and it was merged. Change subject: libmsc: add support for SMPP delivery receipts .. libmsc: add support for SMPP delivery receipts If the mobile phone requests a status report via

[MERGED] openbsc[master]: libmsc: report status report request flag from SMPP SUBMIT_SM

2017-08-09 Thread Pablo Neira Ayuso
Pablo Neira Ayuso has submitted this change and it was merged. Change subject: libmsc: report status report request flag from SMPP SUBMIT_SM .. libmsc: report status report request flag from SMPP SUBMIT_SM Restore the sms

[MERGED] openbsc[master]: libmsc: missing bit shift in status report flag when stored ...

2017-08-09 Thread Pablo Neira Ayuso
Pablo Neira Ayuso has submitted this change and it was merged. Change subject: libmsc: missing bit shift in status report flag when stored in sms object .. libmsc: missing bit shift in status report flag when stored in sms

[MERGED] openbsc[master]: libmsc: set registered_delivery field in SMPP 3.4 DELIVER_SM...

2017-08-09 Thread Pablo Neira Ayuso
Pablo Neira Ayuso has submitted this change and it was merged. Change subject: libmsc: set registered_delivery field in SMPP 3.4 DELIVER_SM messages .. libmsc: set registered_delivery field in SMPP 3.4 DELIVER_SM messages

[PATCH] openbsc[master]: libmsc: update database to accomodate SMS status-report fields

2017-08-09 Thread Pablo Neira Ayuso
s_report = dbi_result_get_ulonglong(result, "is_report"); + sms->msg_ref = dbi_result_get_ulonglong(result, "msg_ref"); sms->ud_hdr_ind = dbi_result_get_ulonglong(result, "ud_hdr_ind"); sms->protocol_id = dbi_result_get_ulonglong(result, "protocol_id");

openbsc[master]: libmsc: report status report request flag from SMPP SUBMIT_SM

2017-08-09 Thread Pablo Neira Ayuso
-Owner: Pablo Neira Ayuso <pa...@gnumonks.org> Gerrit-Reviewer: Harald Welte <lafo...@gnumonks.org> Gerrit-Reviewer: Holger Freyther <hol...@freyther.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Keith Whyte <ke...@rhizomatica.org> Gerrit-Reviewer: Neels Hofmeyr <n

[PATCH] openbsc[master]: libmsc: update database to accomodate SMS status-report fields

2017-08-09 Thread Pablo Neira Ayuso
et_uchar, but sqlite3 is braindead */ sms->reply_path_req = dbi_result_get_ulonglong(result, "reply_path_req"); sms->status_rep_req = dbi_result_get_ulonglong(result, "status_rep_req"); + sms->is_report = dbi_result_get_ulonglong(result, "is_rep

[PATCH] openbsc[master]: utils: smpp_mirror: bounce Delivery Receipts as Delivery Ack...

2017-08-09 Thread Pablo Neira Ayuso
: newpatchset Gerrit-Change-Id: I877e228d8e174430f700631edbf9955972da7892 Gerrit-PatchSet: 3 Gerrit-Project: openbsc Gerrit-Branch: master Gerrit-Owner: Pablo Neira Ayuso <pa...@gnumonks.org> Gerrit-Reviewer: Harald Welte <lafo...@gnumonks.org> Gerrit-Reviewer: Holger Freyther <

[PATCH] openbsc[master]: libmsc: support GSM 03.40 status report for nitb

2017-08-09 Thread Pablo Neira Ayuso
tps://gerrit.osmocom.org/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I5cc7bb4ebadde0940f44d10c3df34707b0615160 Gerrit-PatchSet: 3 Gerrit-Project: openbsc Gerrit-Branch: master Gerrit-Owner: Pablo Neira Ayuso <pa...@gnumonks.org> Gerrit-Reviewer: Harald Welte <lafo...@gnumonks.org>

[PATCH] openbsc[master]: libmsc: add support for SMPP delivery receipts

2017-08-09 Thread Pablo Neira Ayuso
rit.osmocom.org/3434 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ic1a9023074bfa938099377980b6aff9b262fab2a Gerrit-PatchSet: 2 Gerrit-Project: openbsc Gerrit-Branch: master Gerrit-Owner: Pablo Neira Ayuso <pa...@gnumonks.org> Gerrit-

[PATCH] openbsc[master]: libmsc: handle delivery ack via SMPP SUBMIT SM / send GSM 03...

2017-08-09 Thread Pablo Neira Ayuso
49de3f907 Gerrit-PatchSet: 3 Gerrit-Project: openbsc Gerrit-Branch: master Gerrit-Owner: Pablo Neira Ayuso <pa...@gnumonks.org> Gerrit-Reviewer: Harald Welte <lafo...@gnumonks.org> Gerrit-Reviewer: Holger Freyther <hol...@freyther.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Keith Whyte <ke...@rhizomatica.org> Gerrit-Reviewer: Neels Hofmeyr <nhofm...@sysmocom.de>

openbsc[master]: libmsc: set registered_delivery field in SMPP 3.4 DELIVER_SM...

2017-08-09 Thread Pablo Neira Ayuso
g/settings Gerrit-MessageType: comment Gerrit-Change-Id: I59af60fa89cd10ae973c5e122789e3e03e3728ee Gerrit-PatchSet: 1 Gerrit-Project: openbsc Gerrit-Branch: master Gerrit-Owner: Pablo Neira Ayuso <pa...@gnumonks.org> Gerrit-Reviewer: Harald Welte <lafo...@gnumonks.org> Gerrit-Reviewer

[MERGED] openbsc[master]: libmsc: move gsm340_rx_sms_submit() to sms_route_mt_sms()

2017-08-09 Thread Pablo Neira Ayuso
Pablo Neira Ayuso has submitted this change and it was merged. Change subject: libmsc: move gsm340_rx_sms_submit() to sms_route_mt_sms() .. libmsc: move gsm340_rx_sms_submit() to sms_route_mt_sms() Move the sms message-type

[MERGED] openbsc[master]: libmsc: remove 'deferred' parameter in sms_route_mt_sms()

2017-08-09 Thread Pablo Neira Ayuso
Pablo Neira Ayuso has submitted this change and it was merged. Change subject: libmsc: remove 'deferred' parameter in sms_route_mt_sms() .. libmsc: remove 'deferred' parameter in sms_route_mt_sms() No need to cache the sms

[MERGED] openbsc[master]: libmsc: remove duplicate lines in deliver_to_esme()

2017-08-09 Thread Pablo Neira Ayuso
Pablo Neira Ayuso has submitted this change and it was merged. Change subject: libmsc: remove duplicate lines in deliver_to_esme() .. libmsc: remove duplicate lines in deliver_to_esme() This code is accidentally doing the same

[MERGED] openbsc[master]: gsm_04_11: get rid of unused parameter in sms_route_mt_sms()

2017-08-09 Thread Pablo Neira Ayuso
Pablo Neira Ayuso has submitted this change and it was merged. Change subject: gsm_04_11: get rid of unused parameter in sms_route_mt_sms() .. gsm_04_11: get rid of unused parameter in sms_route_mt_sms() This parameter

[MERGED] openbsc[master]: libmsc: remove dead code in sms_route_mt_sms()

2017-08-09 Thread Pablo Neira Ayuso
Pablo Neira Ayuso has submitted this change and it was merged. Change subject: libmsc: remove dead code in sms_route_mt_sms() .. libmsc: remove dead code in sms_route_mt_sms() The following branch: if (!rc &&am

[MERGED] openbsc[master]: libmsc: do not leak pending SMPP command object on error path

2017-08-09 Thread Pablo Neira Ayuso
Pablo Neira Ayuso has submitted this change and it was merged. Change subject: libmsc: do not leak pending SMPP command object on error path .. libmsc: do not leak pending SMPP command object on error path Make sure the SMPP

openbsc[master]: gsm_04_11: get rid of unused parameter in sms_route_mt_sms()

2017-08-09 Thread Pablo Neira Ayuso
-Change-Id: I797abce3f91447e8f397c7cf726db7425479fe0e Gerrit-PatchSet: 1 Gerrit-Project: openbsc Gerrit-Branch: master Gerrit-Owner: Pablo Neira Ayuso <pa...@gnumonks.org> Gerrit-Reviewer: Harald Welte <lafo...@gnumonks.org> Gerrit-Reviewer: Holger Freyther <hol...@freyther.de> Gerrit

[PATCH] openbsc[master]: libmsc: support GSM 03.40 status report for nitb

2017-08-08 Thread Pablo Neira Ayuso
tps://gerrit.osmocom.org/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I5cc7bb4ebadde0940f44d10c3df34707b0615160 Gerrit-PatchSet: 2 Gerrit-Project: openbsc Gerrit-Branch: master Gerrit-Owner: Pablo Neira Ayuso <pa...@gnumonks.org> Gerrit-Reviewer: Harald Welte <lafo...@g

[PATCH] openbsc[master]: libmsc: update database to accomodate SMS status-report fields

2017-08-08 Thread Pablo Neira Ayuso
dead */ sms->reply_path_req = dbi_result_get_ulonglong(result, "reply_path_req"); sms->status_rep_req = dbi_result_get_ulonglong(result, "status_rep_req"); + sms->report = dbi_result_get_ulonglong(result, "report"); + sms->msg_

openbsc[master]: utils: smpp_mirror: reflect message reference TLV

2017-08-08 Thread Pablo Neira Ayuso
ent Gerrit-Change-Id: I1b0abaa7e06ffe1bd2242c70813d8b70e9fa954f Gerrit-PatchSet: 1 Gerrit-Project: openbsc Gerrit-Branch: master Gerrit-Owner: Pablo Neira Ayuso <pa...@gnumonks.org> Gerrit-Reviewer: Harald Welte <lafo...@gnumonks.org> Gerrit-Reviewer: Holger Freyther <hol...@freyther.d

openbsc[master]: libmsc: add support for SMPP delivery receipts

2017-08-08 Thread Pablo Neira Ayuso
gs Gerrit-MessageType: comment Gerrit-Change-Id: Ic1a9023074bfa938099377980b6aff9b262fab2a Gerrit-PatchSet: 1 Gerrit-Project: openbsc Gerrit-Branch: master Gerrit-Owner: Pablo Neira Ayuso <pa...@gnumonks.org> Gerrit-Reviewer: Harald Welte <lafo...@gnumonks.org> Gerrit-Reviewer: Ho

openbsc[master]: gsm_04_11: get rid of unused parameter in sms_route_mt_sms()

2017-08-08 Thread Pablo Neira Ayuso
-Id: I797abce3f91447e8f397c7cf726db7425479fe0e Gerrit-PatchSet: 1 Gerrit-Project: openbsc Gerrit-Branch: master Gerrit-Owner: Pablo Neira Ayuso <pa...@gnumonks.org> Gerrit-Reviewer: Harald Welte <lafo...@gnumonks.org> Gerrit-Reviewer: Holger Freyther <hol...@freyther.de> Gerrit

  1   2   >