Change in osmo-bsc[master]: om2k: Wait for OM TRX links to stabilize before trying to bring up TRX

2020-05-08 Thread tnt
tnt has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/18126 ) Change subject: om2k: Wait for OM TRX links to stabilize before trying to bring up TRX .. Patch Set 5: (1 comment) https

Change in libosmo-abis[master]: e1_input: Add VTY command to enable PCAP debug output

2020-05-08 Thread tnt
tnt has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-abis/+/18114 ) Change subject: e1_input: Add VTY command to enable PCAP debug output .. Patch Set 3: (1 comment) > Patch Set 3: Code-Revie

Change in osmo-bsc[master]: om2k: Fix the frequency specifier for TX/RX/TS conf requests

2020-05-08 Thread tnt
ber: 18119 Gerrit-PatchSet: 4 Gerrit-Owner: tnt Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-Reviewer: tnt Gerrit-MessageType: newpatchset

Change in osmo-bsc[master]: om2k: Fix the frequency specifier for TX/RX/TS conf requests

2020-05-08 Thread tnt
tnt has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/18119 ) Change subject: om2k: Fix the frequency specifier for TX/RX/TS conf requests .. Patch Set 2: (3 comments) https://gerrit.osmocom.org/c

Change in osmo-bsc[master]: om2k: Fix the frequency specifier for TX/RX/TS conf requests

2020-05-08 Thread tnt
ber: 18119 Gerrit-PatchSet: 3 Gerrit-Owner: tnt Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-Reviewer: tnt Gerrit-MessageType: newpatchset

Change in libosmo-abis[master]: e1_input: Add VTY command to enable PCAP debug output

2020-05-08 Thread tnt
tnt has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-abis/+/18114 ) Change subject: e1_input: Add VTY command to enable PCAP debug output .. Patch Set 3: (3 comments) https://gerrit.osmocom.org/c

Change in osmo-bsc[master]: om2k: Properly name message 0x0136, found to be MCTR Statistics Report

2020-05-08 Thread tnt
: I4b4389fd2e7bf0b3078b8ff60f6ea109114a4475 Gerrit-Change-Number: 18116 Gerrit-PatchSet: 2 Gerrit-Owner: tnt Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-MessageType: newpatchset

Change in libosmo-netif[master]: stream: Attempt to workaround kernel ABI breakage

2020-05-08 Thread tnt
tnt has submitted this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/18097 ) Change subject: stream: Attempt to workaround kernel ABI breakage .. stream: Attempt to workaround kernel ABI breakage See https

Change in osmo-bsc[master]: om2k: Add option to limit OML version during negotiation

2020-05-08 Thread tnt
g/c/osmo-bsc/+/18122 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Ia789f8ede3eab7eeca6c759da0109e0b53398f60 Gerrit-Change-Number: 18122 Gerrit-PatchSet: 2 Gerrit-Owner: tnt Gerrit-Revie

Change in osmo-bsc[master]: om2k: Add support for MCTR configuration

2020-05-08 Thread tnt
tnt has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bsc/+/18124 ) Change subject: om2k: Add support for MCTR configuration .. om2k: Add support for MCTR configuration Currently only supports a single

Change in osmo-bsc[master]: gsm_data: Update trx_is_usable for ericsson BTS

2020-05-08 Thread tnt
tnt has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bsc/+/18128 ) Change subject: gsm_data: Update trx_is_usable for ericsson BTS .. gsm_data: Update trx_is_usable for ericsson BTS

Change in osmo-bsc[master]: om2k: Properly update the 'fake' 12.21 states using OM2000 status

2020-05-08 Thread tnt
tnt has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bsc/+/18125 ) Change subject: om2k: Properly update the 'fake' 12.21 states using OM2000 status .. om2k: Properly update the 'fake' 12.21 states

Change in osmo-bsc[master]: bts_ericsson_rbs2000: Init all the TRX, not just C0

2020-05-08 Thread tnt
tnt has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bsc/+/18120 ) Change subject: bts_ericsson_rbs2000: Init all the TRX, not just C0 .. bts_ericsson_rbs2000: Init all the TRX, not just C0 Signed-off

Change in osmo-bsc[master]: bts_ericsson_rbs2000: Whitelist the E1d input driver

2020-05-08 Thread tnt
tnt has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bsc/+/18121 ) Change subject: bts_ericsson_rbs2000: Whitelist the E1d input driver .. bts_ericsson_rbs2000: Whitelist the E1d input driver Signed

Change in osmo-bsc[master]: om2k: Use the "from config" TS config to setup OM objects

2020-05-08 Thread tnt
tnt has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bsc/+/18117 ) Change subject: om2k: Use the "from config" TS config to setup OM objects .. om2k: Use the "from config" TS config

Change in osmo-bsc[master]: om2k: Properly name message 0x0136, found to be MCTR Statistics Report

2020-05-08 Thread tnt
tnt has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bsc/+/18116 ) Change subject: om2k: Properly name message 0x0136, found to be MCTR Statistics Report .. om2k: Properly name message 0x0136, found

Change in osmo-bsc[master]: om2k: Add option to limit OML version during negotiation

2020-05-08 Thread tnt
tnt has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bsc/+/18122 ) Change subject: om2k: Add option to limit OML version during negotiation .. om2k: Add option to limit OML version during negotiation

Change in osmo-bsc[master]: om2k: Fix the frequency specifier for TX/RX/TS conf requests

2020-05-08 Thread tnt
tnt has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bsc/+/18119 ) Change subject: om2k: Fix the frequency specifier for TX/RX/TS conf requests .. om2k: Fix the frequency specifier for TX/RX/TS conf

Change in osmo-bsc[master]: chan_alloc: Don't re-invent trx_is_usable and use existing helper

2020-05-08 Thread tnt
tnt has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bsc/+/18127 ) Change subject: chan_alloc: Don't re-invent trx_is_usable and use existing helper .. chan_alloc: Don't re-invent trx_is_usable and use

Change in osmo-bsc[master]: om2k: Wait for OM TRX links to stabilize before trying to bring up TRX

2020-05-08 Thread tnt
tnt has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bsc/+/18126 ) Change subject: om2k: Wait for OM TRX links to stabilize before trying to bring up TRX .. om2k: Wait for OM TRX links to stabilize

Change in osmo-bsc[master]: om2k: Rename MCTR config request constants for consistency

2020-05-08 Thread tnt
tnt has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bsc/+/18123 ) Change subject: om2k: Rename MCTR config request constants for consistency .. om2k: Rename MCTR config request constants

Change in osmo-bsc[master]: om2k: Dispatch TS_EV_OML_READY to TS FSM only when it's actually ready

2020-05-08 Thread tnt
tnt has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bsc/+/18118 ) Change subject: om2k: Dispatch TS_EV_OML_READY to TS FSM only when it's actually ready .. om2k: Dispatch TS_EV_OML_READY to TS FSM

Change in osmo-bsc[master]: bts_nokia_site: Fix LAPD segfault during reset procedure

2020-05-08 Thread tnt
tnt has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/18009 ) Change subject: bts_nokia_site: Fix LAPD segfault during reset procedure .. bts_nokia_site: Fix LAPD segfault during reset procedure The existing

Change in osmo-bsc[master]: bts_nokia_site: Fix LAPD segfault during reset procedure

2020-05-08 Thread tnt
tnt has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/18009 ) Change subject: bts_nokia_site: Fix LAPD segfault during reset procedure .. Patch Set 2: Code-Review+2 -- To view, visit https

Change in libosmo-abis[master]: e1_input: Add VTY command to enable PCAP debug output

2020-05-08 Thread tnt
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: I0b4251702aecd6721b9d63c320351ef6cb513454 Gerrit-Change-Number: 18114 Gerrit-PatchSet: 3 Gerrit-Owner: tnt Gerrit-Reviewer: Jenkins Builder Gerrit

Change in libosmo-netif[master]: stream: Attempt to workaround kernel ABI breakage

2020-05-08 Thread tnt
c69 Gerrit-Change-Number: 18097 Gerrit-PatchSet: 4 Gerrit-Owner: tnt Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-CC: laforge Gerrit-MessageType: newpatchset

Change in libosmo-abis[master]: e1_input: Allow to unset the pcap fd

2020-05-08 Thread tnt
/settings Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: I5c7dd740ba0a90b40c69a53b3dcc9d6d6a98f660 Gerrit-Change-Number: 18113 Gerrit-PatchSet: 2 Gerrit-Owner: tnt Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-MessageType: newpatchset

Change in libosmo-abis[master]: e1_input: Add VTY command to enable PCAP debug output

2020-05-08 Thread tnt
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: I0b4251702aecd6721b9d63c320351ef6cb513454 Gerrit-Change-Number: 18114 Gerrit-PatchSet: 2 Gerrit-Owner: tnt Gerrit-Reviewer: Jenkins Builder Gerrit

Change in libosmo-netif[master]: stream: Attempt to workaround kernel ABI breakage

2020-05-08 Thread tnt
c69 Gerrit-Change-Number: 18097 Gerrit-PatchSet: 3 Gerrit-Owner: tnt Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-CC: laforge Gerrit-MessageType: newpatchset

Change in osmo-bsc[master]: bts_nokia_site: Fix LAPD segfault during reset procedure

2020-05-08 Thread tnt
tnt has uploaded a new patch set (#2) to the change originally created by laforge. ( https://gerrit.osmocom.org/c/osmo-bsc/+/18009 ) Change subject: bts_nokia_site: Fix LAPD segfault during reset procedure .. bts_nokia_site

Change in osmo-e1-recorder[master]: make e1cap format portable

2020-05-08 Thread tnt
tnt has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-e1-recorder/+/16186 ) Change subject: make e1cap format portable .. Patch Set 6: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo

Change in libosmo-abis[master]: e1_input: Allow to unset the pcap fd

2020-05-08 Thread tnt
tnt has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-abis/+/18113 ) Change subject: e1_input: Allow to unset the pcap fd .. e1_input: Allow to unset the pcap fd Note that this only affects lines

Change in libosmo-abis[master]: e1_input: Add VTY command to enable PCAP debug output

2020-05-08 Thread tnt
tnt has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-abis/+/18114 ) Change subject: e1_input: Add VTY command to enable PCAP debug output .. e1_input: Add VTY command to enable PCAP debug output

Change in libosmo-netif[master]: stream: Attempt to workaround kernel ABI breakage

2020-05-07 Thread tnt
rit-Change-Number: 18097 Gerrit-PatchSet: 2 Gerrit-Owner: tnt Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge Gerrit-MessageType: newpatchset

Change in libosmo-netif[master]: stream: Attempt to workaround kernel ABI breakage

2020-05-07 Thread tnt
tnt has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-netif/+/18097 ) Change subject: stream: Attempt to workaround kernel ABI breakage .. stream: Attempt to workaround kernel ABI breakage See https

Change in osmo-bsc[master]: om2k: Fix TS channel config payload for non-superchannel case

2020-05-05 Thread tnt
tnt has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/18062 ) Change subject: om2k: Fix TS channel config payload for non-superchannel case .. om2k: Fix TS channel config payload for non-superchannel case

Change in osmo-bsc[master]: om2k: Acknowledge the HW Infos Reports

2020-05-05 Thread tnt
tnt has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/18064 ) Change subject: om2k: Acknowledge the HW Infos Reports .. om2k: Acknowledge the HW Infos Reports Signed-off-by: Sylvain Munaut Change-Id

Change in osmo-bsc[master]: om2k: Acknowledge the unknown MCTR messages we get from time to time

2020-05-05 Thread tnt
tnt has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/18065 ) Change subject: om2k: Acknowledge the unknown MCTR messages we get from time to time .. om2k: Acknowledge the unknown MCTR messages we get from

Change in osmo-bsc[master]: om2k: Don't use slashes in FSM IDs and use dashes instead

2020-05-05 Thread tnt
tnt has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/18061 ) Change subject: om2k: Don't use slashes in FSM IDs and use dashes instead .. om2k: Don't use slashes in FSM IDs and use dashes instead slashes

Change in osmo-bsc[master]: om2k: Fix type of msg_type in abis_om2k_tx_simple

2020-05-05 Thread tnt
tnt has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/18063 ) Change subject: om2k: Fix type of msg_type in abis_om2k_tx_simple .. om2k: Fix type of msg_type in abis_om2k_tx_simple Thoses messages IDs are 16

Change in osmo-bsc[master]: om2k: Acknowledge the HW Infos Reports

2020-05-05 Thread tnt
tnt has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bsc/+/18064 ) Change subject: om2k: Acknowledge the HW Infos Reports .. om2k: Acknowledge the HW Infos Reports Signed-off-by: Sylvain Munaut Change

Change in osmo-bsc[master]: om2k: Don't use slashes in FSM IDs and use dashes instead

2020-05-05 Thread tnt
tnt has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bsc/+/18061 ) Change subject: om2k: Don't use slashes in FSM IDs and use dashes instead .. om2k: Don't use slashes in FSM IDs and use dashes instead

Change in osmo-bsc[master]: om2k: Fix TS channel config payload for non-superchannel case

2020-05-05 Thread tnt
tnt has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bsc/+/18062 ) Change subject: om2k: Fix TS channel config payload for non-superchannel case .. om2k: Fix TS channel config payload for non

Change in osmo-bsc[master]: om2k: Acknowledge the unknown MCTR messages we get from time to time

2020-05-05 Thread tnt
tnt has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bsc/+/18065 ) Change subject: om2k: Acknowledge the unknown MCTR messages we get from time to time .. om2k: Acknowledge the unknown MCTR messages we

Change in osmo-bsc[master]: om2k: Fix type of msg_type in abis_om2k_tx_simple

2020-05-05 Thread tnt
tnt has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bsc/+/18063 ) Change subject: om2k: Fix type of msg_type in abis_om2k_tx_simple .. om2k: Fix type of msg_type in abis_om2k_tx_simple Thoses messages

Change in osmo-bsc[master]: bts_nokia_site: Fix LAPD segfault during reset procedure

2020-05-04 Thread tnt
tnt has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/18009 ) Change subject: bts_nokia_site: Fix LAPD segfault during reset procedure .. Patch Set 1: Just tested this and it fixed the segfault

Change in libosmocore[master]: configure.ac: Fix HAVE_CLOCK_GETTIME undef when func in -lrt

2020-05-01 Thread tnt
tnt has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/17993 ) Change subject: configure.ac: Fix HAVE_CLOCK_GETTIME undef when func in -lrt .. Patch Set 1: Code-Review+1 LGTM and works on both

Change in osmo-bsc[master]: om2k: Allow TG and MCTR to be manipulated via VTY

2020-04-28 Thread tnt
-PatchSet: 2 Gerrit-Owner: tnt Gerrit-Reviewer: Jenkins Builder Gerrit-MessageType: newpatchset

Change in osmo-bsc[master]: om2k: Add VTY command to allow TX of arbitrary message for testing

2020-04-28 Thread tnt
: master Gerrit-Change-Id: I5a385614fc670946f83ea79cc176c2d448675672 Gerrit-Change-Number: 17962 Gerrit-PatchSet: 2 Gerrit-Owner: tnt Gerrit-Reviewer: Jenkins Builder Gerrit-MessageType: newpatchset

Change in osmo-bsc[master]: om2k: Allow TG and MCTR to be manipulated via VTY

2020-04-28 Thread tnt
tnt has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bsc/+/17960 ) Change subject: om2k: Allow TG and MCTR to be manipulated via VTY .. om2k: Allow TG and MCTR to be manipulated via VTY Signed-off

Change in osmo-bsc[master]: om2k: Add definitions for the TG object

2020-04-28 Thread tnt
tnt has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bsc/+/17959 ) Change subject: om2k: Add definitions for the TG object .. om2k: Add definitions for the TG object Signed-off-by: Sylvain Munaut

Change in osmo-bsc[master]: om2k: Allow the CON configuration request to be triggered via VTY

2020-04-28 Thread tnt
tnt has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bsc/+/17961 ) Change subject: om2k: Allow the CON configuration request to be triggered via VTY .. om2k: Allow the CON configuration request

Change in osmo-bsc[master]: om2k: Add VTY command to allow TX of arbitrary message for testing

2020-04-28 Thread tnt
tnt has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bsc/+/17962 ) Change subject: om2k: Add VTY command to allow TX of arbitrary message for testing .. om2k: Add VTY command to allow TX of arbitrary

Change in osmo-bsc[master]: OM2000: Add some more message types and IEs we now understand

2020-01-29 Thread tnt
tnt has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/17054 ) Change subject: OM2000: Add some more message types and IEs we now understand .. Patch Set 1: Code-Review+1 lgtm -- To view, visit

Change in libosmo-abis[master]: e1d: Implement varions non-LAPD timeslot modes

2020-01-12 Thread tnt
tnt has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-abis/+/16825 ) Change subject: e1d: Implement varions non-LAPD timeslot modes .. Patch Set 4: Code-Review+1 -- To view, visit https

Change in libosmo-abis[master]: e1d: Implement varions non-LAPD timeslot modes

2020-01-12 Thread tnt
tnt has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-abis/+/16825 ) Change subject: e1d: Implement varions non-LAPD timeslot modes .. Patch Set 2: Code-Review-1 (1 comment) https

Change in libosmo-abis[master]: e1d: Remove bogus vty_show function.

2020-01-12 Thread tnt
tnt has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-abis/+/16821 ) Change subject: e1d: Remove bogus vty_show function. .. Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c

Change in libosmo-abis[master]: e1d: Use line->port_nr to specify e1d interface/line

2020-01-12 Thread tnt
tnt has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-abis/+/16822 ) Change subject: e1d: Use line->port_nr to specify e1d interface/line .. Patch Set 2: Code-Review+1 -- To view, visit ht

Change in libosmo-abis[master]: e1d: Don't use perror() directly, use osmocom logging instead

2020-01-12 Thread tnt
tnt has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-abis/+/16819 ) Change subject: e1d: Don't use perror() directly, use osmocom logging instead .. Patch Set 2: Code-Review+1 -- To view, visit

Change in libosmo-abis[master]: e1d: Don't connect to e1d at program start time

2020-01-12 Thread tnt
tnt has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-abis/+/16824 ) Change subject: e1d: Don't connect to e1d at program start time .. Patch Set 2: Code-Review+1 -- To view, visit https

Change in libosmo-abis[master]: e1d: Use LOGPIL/LOGPITS logging macros to give context

2020-01-12 Thread tnt
tnt has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-abis/+/16823 ) Change subject: e1d: Use LOGPIL/LOGPITS logging macros to give context .. Patch Set 2: Code-Review+1 -- To view, visit https

Change in libosmo-abis[master]: e1d: Remove EXCEPTFD handling

2020-01-12 Thread tnt
tnt has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-abis/+/16820 ) Change subject: e1d: Remove EXCEPTFD handling .. Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmo

Change in libosmo-abis[master]: e1d: Use HAVE_E1D in C source, not ENABLE_E1D

2020-01-12 Thread tnt
tnt has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-abis/+/14868 ) Change subject: e1d: Use HAVE_E1D in C source, not ENABLE_E1D .. Patch Set 3: Code-Review+1 -- To view, visit https

Change in libosmo-abis[master]: e1d: add missing forward-declaration of e1inp_e1d_init()

2020-01-12 Thread tnt
tnt has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-abis/+/14869 ) Change subject: e1d: add missing forward-declaration of e1inp_e1d_init() .. Patch Set 3: Code-Review+1 -- To view, visit https

Change in libosmo-abis[master]: e1d: Initial osmo-e1d support

2020-01-12 Thread tnt
tnt has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-abis/+/14867 ) Change subject: e1d: Initial osmo-e1d support .. Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmo

Change in ...osmo-e1d[master]: contrib/jenkins.sh: run "make maintainer-clean"

2019-07-10 Thread tnt
tnt has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-e1d/+/14726 ) Change subject: contrib/jenkins.sh: run "make maintainer-clean" .. Patch Set 1: Verified+1 -- To view, v

Change in ...osmo-e1d[master]: contrib/jenkins.sh: run "make maintainer-clean"

2019-07-10 Thread tnt
tnt has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmo-e1d/+/14726 ) Change subject: contrib/jenkins.sh: run "make maintainer-clean" .. contrib/jenkins.sh: run "make maintainer-clea

Change in ...osmo-e1d[master]: contrib/jenkins.sh: run "make maintainer-clean"

2019-07-10 Thread tnt
tnt has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-e1d/+/14726 ) Change subject: contrib/jenkins.sh: run "make maintainer-clean" .. Patch Set 1: Code-Review+2 -- To view, v

Change in ...osmo-e1d[master]: contrib/jenkins.sh: run "make maintainer-clean"

2019-07-10 Thread tnt
tnt has removed a vote on this change. Change subject: contrib/jenkins.sh: run "make maintainer-clean" .. Removed Verified-1 by Jenkins Builder (102) -- To view, visit https://gerrit.osmocom.org/c/osmo-e

Change in ...osmo-trx[master]: Add C/I computation

2019-07-04 Thread tnt
tnt has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/14674 ) Change subject: Add C/I computation .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/14674

Change in ...osmo-bts[master]: osmo-bts/scheduler: provide actual C/I values to OsmoPCU

2019-07-03 Thread tnt
tnt has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/14613 ) Change subject: osmo-bts/scheduler: provide actual C/I values to OsmoPCU .. Patch Set 3: Code-Review+1 (1 comment) This change

Change in libosmocore[master]: codec/ecu: Add a bit of precision about the actual frame format used

2019-05-15 Thread tnt
tnt has submitted this change and it was merged. ( https://gerrit.osmocom.org/14051 ) Change subject: codec/ecu: Add a bit of precision about the actual frame format used .. codec/ecu: Add a bit of precision about the actual

Change in libosmocore[master]: codec/ecu: Add a bit of precision about the actual frame format used

2019-05-15 Thread tnt
tnt has uploaded this change for review. ( https://gerrit.osmocom.org/14051 Change subject: codec/ecu: Add a bit of precision about the actual frame format used .. codec/ecu: Add a bit of precision about the actual frame

Change in osmo-bsc[master]: Make sure to default to AMR octet-aligned mode

2019-05-15 Thread tnt
tnt has posted comments on this change. ( https://gerrit.osmocom.org/14050 ) Change subject: Make sure to default to AMR octet-aligned mode .. Patch Set 1: Code-Review+1 lgtm. Also tested the patch and works. -- To view

Change in libosmocore[master]: gsm_23_003: add GSM23003_MSISDN_{MIN, MAX}_DIGITS

2019-05-15 Thread tnt
tnt has posted comments on this change. ( https://gerrit.osmocom.org/13961 ) Change subject: gsm_23_003: add GSM23003_MSISDN_{MIN,MAX}_DIGITS .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/13961

Change in osmo-msc[master]: libmsc: Make sure to not dereference a NULL trans

2019-05-12 Thread tnt
tnt has abandoned this change. ( https://gerrit.osmocom.org/13963 ) Change subject: libmsc: Make sure to not dereference a NULL trans .. Abandoned -- To view, visit https://gerrit.osmocom.org/13963 To unsubscribe, or for help

Change in osmo-trx[master]: transceiver: RSSI was calculated reverse.

2019-05-12 Thread tnt
tnt has posted comments on this change. ( https://gerrit.osmocom.org/9598 ) Change subject: transceiver: RSSI was calculated reverse. .. Patch Set 2: Code-Review-2 Spec for TRX interface specifies it as being reverse logic

Change in osmo-msc[master]: make LOG_TRANS() NULL-safe again

2019-05-11 Thread tnt
tnt has posted comments on this change. ( https://gerrit.osmocom.org/13992 ) Change subject: make LOG_TRANS() NULL-safe again .. Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/13992 To unsubscribe

Change in osmo-trx[master]: transceiver: RSSI was calculated reverse.

2019-05-10 Thread tnt
tnt has posted comments on this change. ( https://gerrit.osmocom.org/9598 ) Change subject: transceiver: RSSI was calculated reverse. .. Patch Set 2: The 'RSSI' definitely seems to be 'opposite' logic ... not sure why

Change in osmo-msc[master]: libmsc: Make sure to not dereference a NULL trans

2019-05-10 Thread tnt
tnt has uploaded this change for review. ( https://gerrit.osmocom.org/13963 Change subject: libmsc: Make sure to not dereference a NULL trans .. libmsc: Make sure to not dereference a NULL trans All those were identified

Change in osmo-trx[master]: lms: Use smpl_buf to recover from timestamp jumps

2019-05-03 Thread tnt
tnt has posted comments on this change. ( https://gerrit.osmocom.org/13872 ) Change subject: lms: Use smpl_buf to recover from timestamp jumps .. Patch Set 2: (1 comment) Globally looks good, just minor naming convention

Change in osmo-trx[master]: Move smpl_buf out of uhd dir to re-use it in other devices

2019-05-01 Thread tnt
tnt has posted comments on this change. ( https://gerrit.osmocom.org/13831 ) Change subject: Move smpl_buf out of uhd dir to re-use it in other devices .. Patch Set 1: Code-Review+1 -- To view, visit https

Change in osmo-trx[master]: uhd: No need to use dynamic mem for rx_buffers

2019-05-01 Thread tnt
tnt has posted comments on this change. ( https://gerrit.osmocom.org/13833 ) Change subject: uhd: No need to use dynamic mem for rx_buffers .. Patch Set 1: Code-Review-1 (1 comment) I'd like to make sure you tried running

Change in osmo-trx[master]: device: Drop unused numberRead/numberWritten APIs

2019-05-01 Thread tnt
tnt has posted comments on this change. ( https://gerrit.osmocom.org/13832 ) Change subject: device: Drop unused numberRead/numberWritten APIs .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/13832

Change in osmo-trx[master]: cosmetic: uhd: Use loglevel ERROR instead of ERR

2019-04-30 Thread tnt
tnt has posted comments on this change. ( https://gerrit.osmocom.org/13829 ) Change subject: cosmetic: uhd: Use loglevel ERROR instead of ERR .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/13829

Change in osmo-trx[master]: uhd: smpl_buf: Use TIMESTAMP type in str_status

2019-04-30 Thread tnt
tnt has posted comments on this change. ( https://gerrit.osmocom.org/13828 ) Change subject: uhd: smpl_buf: Use TIMESTAMP type in str_status .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/13828

Change in osmo-trx[master]: uhd: smpl_buf: Drop UHD specifics out back to UHDDevice

2019-04-30 Thread tnt
tnt has posted comments on this change. ( https://gerrit.osmocom.org/13810 ) Change subject: uhd: smpl_buf: Drop UHD specifics out back to UHDDevice .. Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org

Change in osmo-bsc[master]: assignment_fsm: Properly support assigning signalling mode TCH/x

2019-04-30 Thread tnt
tnt has posted comments on this change. ( https://gerrit.osmocom.org/13818 ) Change subject: assignment_fsm: Properly support assigning signalling mode TCH/x .. Patch Set 1: Code-Review+1 Yeah fix seems obviously correct

Change in osmo-trx[master]: cosmetic: uhd: Move smpl_buf out of UHDDevice, move UHDDevice class d...

2019-04-30 Thread tnt
tnt has posted comments on this change. ( https://gerrit.osmocom.org/13809 ) Change subject: cosmetic: uhd: Move smpl_buf out of UHDDevice, move UHDDevice class definition to .h .. Patch Set 1: Code-Review+1 I would probably

Change in osmo-msc[master]: libvlr: Allow 2G auth tuples to be re-used without going through AUTH

2019-03-19 Thread tnt
tnt has posted comments on this change. ( https://gerrit.osmocom.org/13248 ) Change subject: libvlr: Allow 2G auth tuples to be re-used without going through AUTH .. Patch Set 1: > looks good to me. I'm a bit wondering ab

Change in osmo-ggsn[master]: Don't return error on normal shutdown

2019-03-14 Thread tnt
tnt has posted comments on this change. ( https://gerrit.osmocom.org/13249 ) Change subject: Don't return error on normal shutdown .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/13249

Change in osmo-msc[master]: libmsc: Allow different channel types to be requested as silent calls

2019-03-14 Thread tnt
tnt has posted comments on this change. ( https://gerrit.osmocom.org/13242 ) Change subject: libmsc: Allow different channel types to be requested as silent calls .. Patch Set 3: Code-Review+2 -- To view, visit https

Change in osmo-msc[master]: libmsc: Allow different channel types to be requested as silent calls

2019-03-14 Thread tnt
tnt has submitted this change and it was merged. ( https://gerrit.osmocom.org/13242 ) Change subject: libmsc: Allow different channel types to be requested as silent calls .. libmsc: Allow different channel types

Change in libosmo-netif[master]: tests: AM_LDFLAGS = -noinstall for all tests

2019-03-14 Thread tnt
tnt has posted comments on this change. ( https://gerrit.osmocom.org/13241 ) Change subject: tests: AM_LDFLAGS = -noinstall for all tests .. Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/13241

Change in libosmo-netif[master]: gitignore: add amr_test

2019-03-14 Thread tnt
tnt has posted comments on this change. ( https://gerrit.osmocom.org/13247 ) Change subject: gitignore: add amr_test .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/13247 To unsubscribe, or for help

Change in osmo-msc[master]: libmsc: Allow different channel types to be requested as silent calls

2019-03-14 Thread tnt
tnt has posted comments on this change. ( https://gerrit.osmocom.org/13242 ) Change subject: libmsc: Allow different channel types to be requested as silent calls .. Patch Set 3: (2 comments) Fixed in latest patch set

Change in osmo-bsc[master]: assignment_fsm: Properly support assigning signalling mode TCH/x

2019-03-14 Thread tnt
tnt has submitted this change and it was merged. ( https://gerrit.osmocom.org/13172 ) Change subject: assignment_fsm: Properly support assigning signalling mode TCH/x .. assignment_fsm: Properly support assigning signalling

Change in osmo-msc[master]: libmsc: Allow different channel types to be requested as silent calls

2019-03-14 Thread tnt
: I82645708dd27864cf33ea9cc993ead0983415602 Gerrit-Change-Number: 13242 Gerrit-PatchSet: 3 Gerrit-Owner: tnt Gerrit-Reviewer: Jenkins Builder (102) Gerrit-Reviewer: tnt Gerrit-CC: Harald Welte Gerrit-CC: Max Gerrit-CC: Pau Espin Pedrol Gerrit-CC: Vadim Yanitskiy

Change in osmo-msc[master]: libmsc: Allow different channel types to be requested as silent calls

2019-03-14 Thread tnt
: I82645708dd27864cf33ea9cc993ead0983415602 Gerrit-Change-Number: 13242 Gerrit-PatchSet: 2 Gerrit-Owner: tnt Gerrit-Reviewer: Jenkins Builder (102) Gerrit-Reviewer: tnt Gerrit-CC: Harald Welte Gerrit-CC: Max Gerrit-CC: Pau Espin Pedrol Gerrit-CC: Vadim Yanitskiy

Change in osmo-msc[master]: libmsc: Allow different channel types to be requested as silent calls

2019-03-14 Thread tnt
tnt has posted comments on this change. ( https://gerrit.osmocom.org/13242 ) Change subject: libmsc: Allow different channel types to be requested as silent calls .. Patch Set 1: (1 comment) https://gerrit.osmocom.org/#/c

<    1   2   3   4   5   6   7   >