Harald Welte has submitted this change and it was merged.
Change subject: ms: Create a starter for virtphy and mobile application
..
ms: Create a starter for virtphy and mobile application
In the long run we might not want to
Patch Set 7: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/6917
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I5c6d742842d7f3e0a1858436ef3f8634d8c0582d
Gerrit-PatchSet: 7
Gerrit-Project: osmo-gsm-tester
Gerrit-Branch:
Hello Pau Espin Pedrol, Harald Welte, Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/6917
to look at the new patch set (#7).
ms: Create a starter for virtphy and mobile application
In the long run we might not want to start the virtphy but
Patch Set 6: Code-Review-1
(2 comments)
https://gerrit.osmocom.org/#/c/6917/6/src/osmo_ms_driver/starter.py
File src/osmo_ms_driver/starter.py:
Line 58: import time
You forgot to fix this one.
Line 88:
You forgot to fix this one.
--
To view, visit
Patch Set 5:
(1 comment)
https://gerrit.osmocom.org/#/c/6917/5/src/osmo_ms_driver/starter.py
File src/osmo_ms_driver/starter.py:
Line 107: def start_mobile(self, loop):
> You are the maintainer but I wouldn't do it:
* What's the issue with it being generic given that is called from a known
Patch Set 5:
(1 comment)
https://gerrit.osmocom.org/#/c/6917/5/src/osmo_ms_driver/starter.py
File src/osmo_ms_driver/starter.py:
Line 107: def start_mobile(self, loop):
> Can now be called start(), as it's already in the mobile class.
You are the maintainer but I wouldn't do it:
* start
Patch Set 5:
(3 comments)
https://gerrit.osmocom.org/#/c/6917/5/src/osmo_ms_driver/starter.py
File src/osmo_ms_driver/starter.py:
Line 58: import time
What about moving the import to the top with the other ones?
Line 88:
Extra line, can be removed
Line 107: def
Hello Pau Espin Pedrol, Harald Welte, Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/6917
to look at the new patch set (#5).
ms: Create a starter for virtphy and mobile application
In the long run we might not want to start the virtphy but
Patch Set 3: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/6917
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I5c6d742842d7f3e0a1858436ef3f8634d8c0582d
Gerrit-PatchSet: 3
Gerrit-Project: osmo-gsm-tester
Gerrit-Branch:
Patch Set 3: Code-Review-1
I think it makes a lot of sense separating these already in this commit. Better
have a OsmoMobile and OsmoVirtPhy classes (put them in the same file if it is
easier for you). Have a look for instance at osmo_bsc.py or bts_osmo_trx.py.
--
To view, visit
Review at https://gerrit.osmocom.org/6917
ms: Create a starter for virtphy and mobile application
In the long run we might not want to start the virtphy but
for now virtphy+mobile belong together. Start virtphy first
as mobile will not handle a missing socket gracefully.
Change-Id:
11 matches
Mail list logo
