osmo-gsm-tester[master]: log: Use sys._getframe() to avoid stat(2) calls

2018-02-12 Thread Holger Freyther
Patch Set 1: Motivated by https://osmocom.org/issues/2927. I have not fully tested it and didn't check how inspect behaves when we want to skip more levels than frames we have. -- To view, visit https://gerrit.osmocom.org/6377 To unsubscribe, visit https://gerrit.osmocom.org/settings

[PATCH] osmo-gsm-tester[master]: log: Use sys._getframe() to avoid stat(2) calls

2018-02-12 Thread Holger Freyther
Review at https://gerrit.osmocom.org/6377 log: Use sys._getframe() to avoid stat(2) calls The Osmo MS driver is launching many many processes and I would like to use the logging framework for the code as well. Unfortunately the inspect/traceback code will use a linecache which will execute

osmo-bsc[master]: Add support for Access Control Class ramping.

2018-02-12 Thread Stefan Sperling
Patch Set 2: (9 comments) https://gerrit.osmocom.org/#/c/6324/2/include/osmocom/bsc/acc_ramp.h File include/osmocom/bsc/acc_ramp.h: Line 1: /* (C) 2018 Stefan Sperling > (C) sysmocom / Author: Stefan Sperling, please look at other examples, than Fine, fixed in next

gapk[master]: Ignore build products

2018-02-12 Thread Max
Patch Set 1: (2 comments) https://gerrit.osmocom.org/#/c/6383/1/.gitignore File .gitignore: Line 54: /compile > Why it's starting from '/'? To match the beginning of the pathname - see https://git-scm.com/docs/gitignore Line 55: /src/gapk > I am not sure if we have this build product... Must

osmo-ggsn[master]: sgsnemu: fix: no outgoing GTP-U in "createif" mode

2018-02-12 Thread Viktor Tsymbalyuk
Patch Set 1: some debug below - just for time saving. ## stop on Breakpoint after sending packet into tun0 - ipm->pdp null as result gtp_data_req not executed ``` Breakpoint 1, cb_tun_ind (tun=, pack=0x7fffbe40, len=1028) at sgsnemu.c:1367 1367if (ipm->pdp) /* Check

osmo-gsm-tester[master]: log: Use sys._getframe() to avoid stat(2) calls

2018-02-12 Thread Holger Freyther
Patch Set 1: And the test failure seems unrelated to my change? Is the setup currently running/working? -- To view, visit https://gerrit.osmocom.org/6377 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id:

osmo-msc[master]: MNCC: Copy bearer_cap from MNCC to gsm_trans

2018-02-12 Thread Harald Welte
Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/6381 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6838dc0c8c4c2c6bba385da548c92f3fc91060c1 Gerrit-PatchSet: 1 Gerrit-Project: osmo-msc Gerrit-Branch: master

[PATCH] osmo-msc[master]: a_iface: s/Abis/L3/ for speech version/preference fields

2018-02-12 Thread Harald Welte
Review at https://gerrit.osmocom.org/6378 a_iface: s/Abis/L3/ for speech version/preference fields There is no encoding of speech version / preference on Abis, only on L3. L3 is carried on Um, Abis and A. Hence, referrin to Abis in function names and comments is irritating. Change-Id:

[PATCH] osmo-msc[master]: a_iface: Consistent and understandable function names

2018-02-12 Thread Harald Welte
Review at https://gerrit.osmocom.org/6379 a_iface: Consistent and understandable function names Change-Id: I36894e68e4b1f25f266e941c39a44e0171d24689 --- M src/libmsc/a_iface.c 1 file changed, 4 insertions(+), 4 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-msc

[PATCH] osmo-msc[master]: MT Calls: Copy bearer capabilities from NNCC primitive to trans

2018-02-12 Thread Harald Welte
Review at https://gerrit.osmocom.org/6380 MT Calls: Copy bearer capabilities from NNCC primitive to trans When we receive a MNCC_SETUP_REQ primitive from the external MNCC handler, we must not only encode it into the TS 04.08 CC SETUP, but also keep it around in the "trans" structure

gapk[master]: Ignore build products

2018-02-12 Thread Vadim Yanitskiy
Patch Set 1: Code-Review-1 (2 comments) https://gerrit.osmocom.org/#/c/6383/1/.gitignore File .gitignore: Line 54: /compile Why it's starting from '/'? Line 55: /src/gapk I am not sure if we have this build product... Correct me if I am wrong. -- To view, visit

[PATCH] osmo-ggsn[master]: sgsnemu: fix: no outgoing GTP-U in "createif" mode

2018-02-12 Thread Viktor Tsymbalyuk
Review at https://gerrit.osmocom.org/6385 sgsnemu: fix: no outgoing GTP-U in "createif" mode in "createif" mode uplink traffic not forwarding from tun interface into Gn, inside GTP-U. create_pdp_conf get iphash (ipm) with pdp == 0x0 Fix - in create_pdp_conf - instead of casting using already

osmo-gsm-tester[master]: log: Use sys._getframe() to avoid stat(2) calls

2018-02-12 Thread Pau Espin Pedrol
Patch Set 1: Code-Review-1 (1 comment) Regarding the test failure: We recently updated the unit running osmo-gsm-tester to debian9 using new ansible recipes and we are experiencing some ofono modems stability issues and I need to restart ofono every few hours. I restarted ofono and

[MERGED] osmo-msc[master]: a_iface: Consistent and understandable function names

2018-02-12 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: a_iface: Consistent and understandable function names .. a_iface: Consistent and understandable function names Change-Id:

[MERGED] osmo-msc[master]: a_iface: s/Abis/L3/ for speech version/preference fields

2018-02-12 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: a_iface: s/Abis/L3/ for speech version/preference fields .. a_iface: s/Abis/L3/ for speech version/preference fields There is no encoding of speech

gapk[master]: Add basic CI integration

2018-02-12 Thread Vadim Yanitskiy
Patch Set 1: (2 comments) https://gerrit.osmocom.org/#/c/6384/1/contrib/jenkins.sh File contrib/jenkins.sh: Line 20: osmo-build-dep.sh libosmocore "" ac_cv_path_DOXYGEN=false Should we also install both libgsm and libopencore-amrnb dependencies here? Line 37: ./configure At the moment TCH-HR

[PATCH] osmo-bsc[master]: Add support for Access Control Class ramping.

2018-02-12 Thread Stefan Sperling
Hello Harald Welte, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/6324 to look at the new patch set (#4). Add support for Access Control Class ramping. Access Control Class (ACC) ramping is used to slowly make the cell available to an

osmo-msc[master]: a_iface: s/Abis/L3/ for speech version/preference fields

2018-02-12 Thread Vadim Yanitskiy
Patch Set 1: (1 comment) https://gerrit.osmocom.org/#/c/6378/1//COMMIT_MSG Commit Message: PS1, Line 10: referrin cosmetic: referring ;) -- To view, visit https://gerrit.osmocom.org/6378 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id:

[PATCH] osmo-ttcn3-hacks[master]: Ignore symlinks and build byproducts

2018-02-12 Thread Max
Hello Harald Welte, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/6285 to look at the new patch set (#3). Ignore symlinks and build byproducts Using per-directory gitignore allows to use simpler exclude patters with fewer exceptions.

[PATCH] gapk[master]: Add --enable-sanitize configure option

2018-02-12 Thread Max
Review at https://gerrit.osmocom.org/6382 Add --enable-sanitize configure option Change-Id: Ibb26e5fc73843f3951dbc534653ee7d88e4c80e7 --- M configure.ac 1 file changed, 9 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/gapk refs/changes/82/6382/1 diff --git

[PATCH] gapk[master]: Ignore build products

2018-02-12 Thread Max
Review at https://gerrit.osmocom.org/6383 Ignore build products Change-Id: I24be6fdbd17c7877d7a9a87081107dc5a3cd2fe8 --- M .gitignore 1 file changed, 2 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/gapk refs/changes/83/6383/1 diff --git a/.gitignore b/.gitignore

[PATCH] osmo-bsc[master]: Add support for Access Control Class ramping.

2018-02-12 Thread Stefan Sperling
Hello Harald Welte, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/6324 to look at the new patch set (#3). Add support for Access Control Class ramping. Access Control Class (ACC) ramping is used to slowly make the cell available to an

osmo-ttcn3-hacks[master]: Ignore symlinks and build byproducts

2018-02-12 Thread Max
Patch Set 3: I've tried to use global gitignore but it quickly turned out into unreadable mess full of exceptions interspersed with patters. Proposed variant is much more concise yet it covers most of currently visible output of 'git status'. -- To view, visit https://gerrit.osmocom.org/6285

gapk[master]: Add --enable-sanitize configure option

2018-02-12 Thread Vadim Yanitskiy
Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/6382 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibb26e5fc73843f3951dbc534653ee7d88e4c80e7 Gerrit-PatchSet: 1 Gerrit-Project: gapk Gerrit-Branch: master

osmo-msc[master]: a_iface: s/Abis/L3/ for speech version/preference fields

2018-02-12 Thread Harald Welte
Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/6378 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id226cd1414ca2a92356801bc71f43102d03ba37e Gerrit-PatchSet: 1 Gerrit-Project: osmo-msc Gerrit-Branch: master

osmo-msc[master]: MT Calls: Copy bearer capabilities from NNCC primitive to trans

2018-02-12 Thread Harald Welte
Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/6380 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib6919d148ff6687112e8166dbde947be19e70a76 Gerrit-PatchSet: 1 Gerrit-Project: osmo-msc Gerrit-Branch: master

osmo-msc[master]: a_iface: Consistent and understandable function names

2018-02-12 Thread Harald Welte
Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/6379 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I36894e68e4b1f25f266e941c39a44e0171d24689 Gerrit-PatchSet: 1 Gerrit-Project: osmo-msc Gerrit-Branch: master

osmo-msc[master]: MT Calls: Copy bearer capabilities from NNCC primitive to trans

2018-02-12 Thread Vadim Yanitskiy
Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/6380 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib6919d148ff6687112e8166dbde947be19e70a76 Gerrit-PatchSet: 1 Gerrit-Project: osmo-msc Gerrit-Branch: master

[PATCH] osmo-msc[master]: MNCC: Copy bearer_cap from MNCC to gsm_trans

2018-02-12 Thread Harald Welte
Review at https://gerrit.osmocom.org/6381 MNCC: Copy bearer_cap from MNCC to gsm_trans When we receive bearer capabilities from MNCC and encode thme into a CC message, we have to also update our "cache" inside 'struct gsm_trans'. Only that way, the BSSMAP ASSIGNMENT code is aware of the

[PATCH] gapk[master]: Add basic CI integration

2018-02-12 Thread Max
Review at https://gerrit.osmocom.org/6384 Add basic CI integration Change-Id: Ib4b36df8f010cd7e035fe5a8b846632541b655f5 --- A contrib/jenkins.sh 1 file changed, 42 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/gapk refs/changes/84/6384/1 diff --git

gapk[master]: Add basic CI integration

2018-02-12 Thread Max
Patch Set 1: > Should we also install both libgsm and libopencore-amrnb dependencies here? No, this is for Osmocom dependencies. External packages should be added as build slave dependencies to ansible. -- To view, visit https://gerrit.osmocom.org/6384 To unsubscribe, visit

[PATCH] osmo-bts[master]: Cosmetic fixes for power ramping code.

2018-02-12 Thread Stefan Sperling
Hello Vadim Yanitskiy, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/6287 to look at the new patch set (#2). Cosmetic fixes for power ramping code. Fix typos in 2 comments. Change-Id: I214bcc8b78446bfea450fe445fa9391898638905 --- M

osmo-msc[master]: mcgp: let the MGW allocate the MGCP endpoint

2018-02-12 Thread dexter
Patch Set 1: > do we have a TTCN-3 test case for this in OsmoMSC yet, so we can > make sure the feature works as expected? If not, please provide > one (or indicate what is missing in terms of infrastructure to > write one). There is no test for this yet. If we apply the patch we possibly

[PATCH] osmo-bsc[master]: Add support for Access Control Class ramping.

2018-02-12 Thread Stefan Sperling
Hello Harald Welte, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/6324 to look at the new patch set (#5). Add support for Access Control Class ramping. Access Control Class (ACC) ramping is used to slowly make the cell available to an

[PATCH] osmo-msc[master]: VLR: fix potential NULL dereference

2018-02-12 Thread Max
Review at https://gerrit.osmocom.org/6388 VLR: fix potential NULL dereference The vlr_subscr_get() can return NULL if its argument is NULL (which isn't checked for) so before dereferencing it's result we should check for it. Change-Id: I13632908d0b67323202effa9dd6f29732a12cc91 --- M

[PATCH] osmo-bsc[master]: Make RSL connection attempts time out.

2018-02-12 Thread Stefan Sperling
Review at https://gerrit.osmocom.org/6386 Make RSL connection attempts time out. If a BTS/TRX does not respond to the "IPA RSL Connect" command, pretend that the BTS has sent a NACk for the connection. This is a proof-of-concept which still has (at least) two problems: 1) It assumes that

osmo-bts[master]: Cosmetic fixes for power ramping code.

2018-02-12 Thread Stefan Sperling
Patch Set 1: (1 comment) https://gerrit.osmocom.org/#/c/6287/1/src/common/tx_power.c File src/common/tx_power.c: Line 153: return (tpp->p_total_tgt_mdBm > tpp->p_total_cur_mdBm); > sorry, I really prefer the more verbose version, I think it is what we do i Sure, if you prefer that, I

[PATCH] osmo-bsc[master]: Generate the S_L_INP_TEI_UP signal earlier.

2018-02-12 Thread Stefan Sperling
Review at https://gerrit.osmocom.org/6387 Generate the S_L_INP_TEI_UP signal earlier. The S_L_INP_TEI_UP signal was generated when the first message from a BTS arrives on the OML/RSL link, rather than when the OML/RSL link comes up. Instead, generate this signal when the link is brought up, so

gapk[master]: Add --enable-sanitize configure option

2018-02-12 Thread tnt
Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/6382 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibb26e5fc73843f3951dbc534653ee7d88e4c80e7 Gerrit-PatchSet: 1 Gerrit-Project: gapk Gerrit-Branch: master

osmo-pcu[master]: Move include guard to the top

2018-02-12 Thread Stefan Sperling
Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/6195 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5114a63ce00b03c8eed23565d52969250bd505cc Gerrit-PatchSet: 1 Gerrit-Project: osmo-pcu Gerrit-Branch: master

libosmocore[master]: gsmtap.h: define TETRA DMO mode channels

2018-02-12 Thread Vadim Yanitskiy
Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/6376 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I98976c0ff16a69b2508a79259ed1aeaec51e7549 Gerrit-PatchSet: 3 Gerrit-Project: libosmocore Gerrit-Branch: master

[PATCH] osmo-sgsn[master]: .gitignore: Add m4 files

2018-02-12 Thread Pau Espin Pedrol
Review at https://gerrit.osmocom.org/6389 .gitignore: Add m4 files Change-Id: I7ad810e720ee8a02a28c601aa966ddde04023819 --- M .gitignore 1 file changed, 5 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-sgsn refs/changes/89/6389/1 diff --git a/.gitignore

[PATCH] osmo-sgsn[master]: sgsn_libgtp.c: Fix typos and whitespace

2018-02-12 Thread Pau Espin Pedrol
Review at https://gerrit.osmocom.org/6390 sgsn_libgtp.c: Fix typos and whitespace Change-Id: Ic223cf378a83051603f58dacf087cc59d9f03890 --- M src/gprs/sgsn_libgtp.c 1 file changed, 4 insertions(+), 4 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-sgsn refs/changes/90/6390/1 diff

[PATCH] libosmocore[master]: gsmtap.h: define TETRA DMO mode channels

2018-02-12 Thread allesklar2
gsmtap.h: define TETRA DMO mode channels Change-Id: I98976c0ff16a69b2508a79259ed1aeaec51e7549 --- M include/osmocom/core/gsmtap.h 1 file changed, 5 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/76/6376/3 diff --git

osmo-ggsn[master]: sgsnemu: fix: no outgoing GTP-U in "createif" mode

2018-02-12 Thread Pau Espin Pedrol
Patch Set 1: I reviewed it and indeed it fixes (yet) an(other) error I introduced myself during development of IPv4v6. I doesn't fix the full issue though. I submitted another patch on top of yours to also correctly deallocate the contexts. Thanks for your contributions! -- To view, visit

libosmocore[master]: gsmtap.h: define TETRA DMO mode channels

2018-02-12 Thread allesklar2
Patch Set 3: > Usually we use the imperative style for commit messages, > for example: > > "gsmtap.h: define TETRA DMO mode channels" Thanks for this suggestion. I changed the commit message. -- To view, visit https://gerrit.osmocom.org/6376 To unsubscribe, visit

osmo-ggsn[master]: sgsnemu: fix: no outgoing GTP-U in "createif" mode

2018-02-12 Thread Pau Espin Pedrol
Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/6385 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icd58450548b3a47cb933d70a2e3166c067552b2c Gerrit-PatchSet: 1 Gerrit-Project: osmo-ggsn Gerrit-Branch: master

[PATCH] osmo-ggsn[master]: sgsnemu: Fix bad ptr during context deallocation

2018-02-12 Thread Pau Espin Pedrol
Review at https://gerrit.osmocom.org/6392 sgsnemu: Fix bad ptr during context deallocation Older commit switched pdp_t to have an array of 2 peers instead of only one in order to accomodate for ipv4v6 contexts, which can have 2 addresses assigned. The usage of peer field was not updated in

[PATCH] osmo-ggsn[master]: sgsnemu: listen param is a host, not an interface

2018-02-12 Thread Pau Espin Pedrol
Review at https://gerrit.osmocom.org/6391 sgsnemu: listen param is a host, not an interface This param is parsed by gethostbyname() and it's confusing to document it as an interface, because users will then attempt to pass "lo" to it, which fails. Change-Id:

osmo-sgsn[master]: .gitignore: Add m4 files

2018-02-12 Thread Vadim Yanitskiy
Patch Set 1: (1 comment) https://gerrit.osmocom.org/#/c/6389/1/.gitignore File .gitignore: Line 24: m4/lt~obsolete.m4 I think, you can use a wildcard here ;) m4/*.m4 -- To view, visit https://gerrit.osmocom.org/6389 To unsubscribe, visit https://gerrit.osmocom.org/settings

osmo-sgsn[master]: sgsn_libgtp.c: Fix typos and whitespace

2018-02-12 Thread Vadim Yanitskiy
Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/6390 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic223cf378a83051603f58dacf087cc59d9f03890 Gerrit-PatchSet: 1 Gerrit-Project: osmo-sgsn Gerrit-Branch: master

[PATCH] osmo-ttcn3-hacks[master]: RSL_Emulation: Add second RSL/RSL_PROC port for hand-over cases

2018-02-12 Thread Harald Welte
Review at https://gerrit.osmocom.org/6395 RSL_Emulation: Add second RSL/RSL_PROC port for hand-over cases Also, extend RSLEM_{register,unregister}() with an optional third argiment, so the RSL_DchanHdlr can register 'expect' also for that secondary BTS/port during hand-over Change-Id:

[PATCH] osmo-ttcn3-hacks[master]: bsc: Add VTY module to BSC_Tests

2018-02-12 Thread Harald Welte
Review at https://gerrit.osmocom.org/6394 bsc: Add VTY module to BSC_Tests Change-Id: Ia78f1231f56fc5f3b003bccc850ea109ed4ed2d8 --- M bsc/BSC_Tests.cfg M bsc/BSC_Tests.ttcn M bsc/gen_links.sh M bsc/regen_makefile.sh 4 files changed, 26 insertions(+), 2 deletions(-) git pull

[PATCH] osmo-ttcn3-hacks[master]: MSC_ConnectionHdlr: Add telnet to VTY to each ConnHdlr

2018-02-12 Thread Harald Welte
Review at https://gerrit.osmocom.org/6397 MSC_ConnectionHdlr: Add telnet to VTY to each ConnHdlr This allows each ConnHandler to issue telnet commands to the VTY As a side-effect, it puts some more stress on the VTY interface, as each [parallel] DchanHdlr now has its own telnet connection.

osmo-sgsn[master]: sgsn_libgtp.c: Fix typos and whitespace

2018-02-12 Thread Harald Welte
Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/6390 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic223cf378a83051603f58dacf087cc59d9f03890 Gerrit-PatchSet: 1 Gerrit-Project: osmo-sgsn Gerrit-Branch: master

[PATCH] osmo-ttcn3-hacks[master]: RSL_Emulation: Add procedure calls to suspend/resume dchan h...

2018-02-12 Thread Harald Welte
Review at https://gerrit.osmocom.org/6396 RSL_Emulation: Add procedure calls to suspend/resume dchan handling We introduce a procedure by which any DchanHandler can globally disable all receiving/processing of DChan related messages. This is required in upcoming handover code, as we need to

[PATCH] osmo-ttcn3-hacks[master]: WIP: Prepare MSC_Tests for ability to emulate two BSCs

2018-02-12 Thread Harald Welte
Review at https://gerrit.osmocom.org/6393 WIP: Prepare MSC_Tests for ability to emulate two BSCs Change-Id: Ibe3ae6ed4181c6ba7501f5443b4f22e3c8abeb3e --- M bsc/BSC_Tests.cfg M bsc/BSC_Tests.ttcn M library/BSSAP_Adapter.ttcn M library/BSSMAP_Emulation.ttcn M library/RTP_Emulation.ttcn M

[PATCH] osmo-ttcn3-hacks[master]: WIP: Intra-BSC handover testing

2018-02-12 Thread Harald Welte
Review at https://gerrit.osmocom.org/6398 WIP: Intra-BSC handover testing Change-Id: Ic47e639a7c8640c736c84a44780fc8e111a64b52 --- M bsc/BSC_Tests.ttcn M bsc/MSC_ConnectionHandler.ttcn M library/L3_Templates.ttcn 3 files changed, 203 insertions(+), 3 deletions(-) git pull

osmo-ttcn3-hacks[master]: bsc: Add VTY module to BSC_Tests

2018-02-12 Thread Harald Welte
Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/6394 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia78f1231f56fc5f3b003bccc850ea109ed4ed2d8 Gerrit-PatchSet: 1 Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch:

[PATCH] osmo-ttcn3-hacks[master]: gprs: Move BSSGP related code to library

2018-02-12 Thread Harald Welte
Review at https://gerrit.osmocom.org/6400 gprs: Move BSSGP related code to library Change-Id: I9e13c63cc12c88be82124a8e3ce3c315b7b3a1fa --- M gprs_gb/gen_links.sh R library/BSSGP_Emulation.ttcn R library/BSSGP_Helper.cc R library/BSSGP_Helper_Functions.ttcn R library/BSSGP_Types.ttcn 5 files

osmo-ttcn3-hacks[master]: General_Types: Add INT18b_BO_LAST type

2018-02-12 Thread Harald Welte
Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/6403 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9611cad26bf9a447e63462caa608da1f5888a9d8 Gerrit-PatchSet: 1 Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch:

[PATCH] osmo-ttcn3-hacks[master]: Migrate Gb (NS/BSSGP) code over to Ericsson NS/BSSGP modules

2018-02-12 Thread Harald Welte
Review at https://gerrit.osmocom.org/6401 Migrate Gb (NS/BSSGP) code over to Ericsson NS/BSSGP modules When we started out, Ericsson hadn't released yet their NS and BSSGP modules. Let's port our logic over to their encoder/decoders, as they are more complete (but less regular / more

[PATCH] osmo-ttcn3-hacks[master]: sgsn: Skeleton of a SGSN test fremwork

2018-02-12 Thread Harald Welte
Review at https://gerrit.osmocom.org/6404 sgsn: Skeleton of a SGSN test fremwork Based on the exsting NS/BSSGP emulation as well as the VTY, GSUP and CTRL implementations, we are now building a test framework skeleton for osmo-sgsn. Change-Id: Icce90f9d8a680c7a523163e2c0bc03d12ff857e2 --- M

[PATCH] osmo-ttcn3-hacks[master]: General_Types: Add INT18b_BO_LAST type

2018-02-12 Thread Harald Welte
Review at https://gerrit.osmocom.org/6403 General_Types: Add INT18b_BO_LAST type Change-Id: I9611cad26bf9a447e63462caa608da1f5888a9d8 --- M library/General_Types.ttcn 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks

[PATCH] osmo-ttcn3-hacks[master]: gprs: Move NS Types/CodecPort/Emulation to library directory

2018-02-12 Thread Harald Welte
Review at https://gerrit.osmocom.org/6399 gprs: Move NS Types/CodecPort/Emulation to library directory Change-Id: I876ce0e981d70ff0e737175983002268fd690989 --- M gprs_gb/gen_links.sh R library/NS_CodecPort.ttcn R library/NS_CodecPort_CtrlFunct.ttcn R library/NS_CodecPort_CtrlFunctDef.cc R

[PATCH] osmo-ttcn3-hacks[master]: Move f_hex_is_odd_length from BSSMAP_Templates to GSM_Types

2018-02-12 Thread Harald Welte
Review at https://gerrit.osmocom.org/6402 Move f_hex_is_odd_length from BSSMAP_Templates to GSM_Types It's a quite frequent requirement in encoding IMSI/BCD numbers, so let's move it to the more generic GSM_Types module. Change-Id: I6fb8d9a6f37c990f6901fb48b15312a157954fda --- M

osmo-ttcn3-hacks[master]: RSL_Emulation: Add procedure calls to suspend/resume dchan h...

2018-02-12 Thread Harald Welte
Patch Set 1: Code-Review-1 we should use a counter in case multiple components want to suspend, we want to resume processing only after the last resume has been issued. -- To view, visit https://gerrit.osmocom.org/6396 To unsubscribe, visit https://gerrit.osmocom.org/settings

osmo-ttcn3-hacks[master]: RSL_Emulation: Add second RSL/RSL_PROC port for hand-over cases

2018-02-12 Thread Harald Welte
Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/6395 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic22778f17dc4b93ef54837cf400ddd7d1732ae7e Gerrit-PatchSet: 1 Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch:

osmo-ttcn3-hacks[master]: gprs: Move BSSGP related code to library

2018-02-12 Thread Harald Welte
Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/6400 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9e13c63cc12c88be82124a8e3ce3c315b7b3a1fa Gerrit-PatchSet: 1 Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch:

osmo-ttcn3-hacks[master]: Move f_hex_is_odd_length from BSSMAP_Templates to GSM_Types

2018-02-12 Thread Harald Welte
Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/6402 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6fb8d9a6f37c990f6901fb48b15312a157954fda Gerrit-PatchSet: 1 Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch:

osmo-ttcn3-hacks[master]: gprs: Move NS Types/CodecPort/Emulation to library directory

2018-02-12 Thread Harald Welte
Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/6399 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I876ce0e981d70ff0e737175983002268fd690989 Gerrit-PatchSet: 1 Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch:

osmo-ttcn3-hacks[master]: Migrate Gb (NS/BSSGP) code over to Ericsson NS/BSSGP modules

2018-02-12 Thread Harald Welte
Patch Set 1: this needs testing. -- To view, visit https://gerrit.osmocom.org/6401 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icbc4f5d24f3419f99c9a4805f836bddd2849f492 Gerrit-PatchSet: 1 Gerrit-Project: osmo-ttcn3-hacks

osmo-ttcn3-hacks[master]: MSC_ConnectionHdlr: Add telnet to VTY to each ConnHdlr

2018-02-12 Thread Harald Welte
Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/6397 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibd726af53219d829286da80b44ea4d9fb2ffdf3d Gerrit-PatchSet: 1 Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch:

osmo-sgsn[master]: .gitignore: Add m4 files

2018-02-12 Thread Harald Welte
Patch Set 1: (1 comment) https://gerrit.osmocom.org/#/c/6389/1/.gitignore File .gitignore: Line 24: m4/lt~obsolete.m4 > I think, you can use a wildcard here ;) Agreed. -- To view, visit https://gerrit.osmocom.org/6389 To unsubscribe, visit https://gerrit.osmocom.org/settings