osmo-bts[master]: scheduler.c: Print message when burst substitution happens

2018-02-23 Thread Harald Welte
Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/6870 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If79eab37c80647c9ab64f399fa4676d97af3e9ad Gerrit-PatchSet: 1 Gerrit-Project: osmo-bts Gerrit-Branch: master

[PATCH] osmo-ttcn3-hacks[master]: Add initial OsmoBTS test suite

2018-02-23 Thread Harald Welte
Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/6629 to look at the new patch set (#2). Add initial OsmoBTS test suite This Test suite implements the BSC-side of Abis RSL and is used to test OsmoBTS. It contains provisions for using

[PATCH] osmo-bts[master]: scheduler.c: Print message when burst substitution happens

2018-02-23 Thread Harald Welte
Review at https://gerrit.osmocom.org/6870 scheduler.c: Print message when burst substitution happens Whenever we receive discontinuous frame numbers from the TRX socket, osmo-bts-trx is substituting zero-filled bursts for those frame numbers which we missed. Don't just do this silently, but

[PATCH] osmo-bts[master]: measurement.c: Fix sdcch4_meas_rep_fn102 / sdcch8_meas_rep_f...

2018-02-23 Thread Harald Welte
Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/6871 to look at the new patch set (#2). measurement.c: Fix sdcch4_meas_rep_fn102 / sdcch8_meas_rep_fn102 Since Change-Id: I23fba50f48415314da40cf5bf86fce2ed3e66af6 we were not reporting

[MERGED] osmo-ttcn3-hacks[master]: Add TRXC (OsmoTRX Control) protocol types + codec port

2018-02-23 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: Add TRXC (OsmoTRX Control) protocol types + codec port .. Add TRXC (OsmoTRX Control) protocol types + codec port Change-Id:

[MERGED] osmo-ttcn3-hacks[master]: GSM_Types: add rxqual2ber and rxlev2dbm + ivnerse functions

2018-02-23 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: GSM_Types: add rxqual2ber and rxlev2dbm + ivnerse functions .. GSM_Types: add rxqual2ber and rxlev2dbm + ivnerse functions Change-Id:

osmo-ttcn3-hacks[master]: GSM_Types: add rxqual2ber and rxlev2dbm + ivnerse functions

2018-02-23 Thread Harald Welte
Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/6873 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6293f6a9b73d5614cbb61c64617af4dd8afc1e73 Gerrit-PatchSet: 1 Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch:

osmo-ttcn3-hacks[master]: Add initial OsmoBTS test suite

2018-02-23 Thread Harald Welte
Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/6629 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8ced0d29777aad3ec842d54eabea87dfcc943c79 Gerrit-PatchSet: 2 Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch:

osmo-ttcn3-hacks[master]: Add TRXC (OsmoTRX Control) protocol types + codec port

2018-02-23 Thread Harald Welte
Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/6872 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3b5e81693e5cf8ee8a2c360bde8b16c5276d2297 Gerrit-PatchSet: 1 Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch:

[MERGED] osmo-bts[master]: scheduler.c: Print message when burst substitution happens

2018-02-23 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: scheduler.c: Print message when burst substitution happens .. scheduler.c: Print message when burst substitution happens Whenever we receive

[PATCH] osmo-bts[master]: measurement.c: Fix sdcch4_meas_rep_fn102

2018-02-23 Thread Harald Welte
Review at https://gerrit.osmocom.org/6871 measurement.c: Fix sdcch4_meas_rep_fn102 Since Change-Id: I23fba50f48415314da40cf5bf86fce2ed3e66af6 we were not reporting measurements for SDCCH/4 channel types due to the wrong encoding of the sdcch4_meas_rep_fn102 table. Let's fix the table by

[PATCH] osmo-ttcn3-hacks[master]: Add TRXC (OsmoTRX Control) protocol types + codec port

2018-02-23 Thread Harald Welte
Review at https://gerrit.osmocom.org/6872 Add TRXC (OsmoTRX Control) protocol types + codec port Change-Id: I3b5e81693e5cf8ee8a2c360bde8b16c5276d2297 --- A library/TRXC_CodecPort.ttcn A library/TRXC_CodecPort_CtrlFunct.ttcn A library/TRXC_CodecPort_CtrlFunctDef.cc A library/TRXC_Types.ttcn 4

[PATCH] osmo-ttcn3-hacks[master]: GSM_Types: add rxqual2ber and rxlev2dbm + ivnerse functions

2018-02-23 Thread Harald Welte
Review at https://gerrit.osmocom.org/6873 GSM_Types: add rxqual2ber and rxlev2dbm + ivnerse functions Change-Id: I6293f6a9b73d5614cbb61c64617af4dd8afc1e73 --- M library/GSM_Types.ttcn 1 file changed, 52 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks

[PATCH] osmo-bts[master]: load_indication: Fix start of load indication timer

2018-02-23 Thread Harald Welte
Review at https://gerrit.osmocom.org/6874 load_indication: Fix start of load indication timer Starting the timer in bts_init() may result in it expiring already before the load indication period is set via OML. Let's make load_timer_start() safe to call several times and call it from OML

[MERGED] osmo-bts[master]: load_indication: Fix start of load indication timer

2018-02-23 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: load_indication: Fix start of load indication timer .. load_indication: Fix start of load indication timer Starting the timer in bts_init() may result

osmo-bts[master]: RSL: Implement DELETE INDICATION on AGCH overflow

2018-02-23 Thread Harald Welte
Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/6875 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ied3306e85cbdc6f3476b10dc4bb0463cd728b274 Gerrit-PatchSet: 1 Gerrit-Project: osmo-bts Gerrit-Branch: master

osmo-bts[master]: load_indication: Fix start of load indication timer

2018-02-23 Thread Harald Welte
Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/6874 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I295d91413542014aa2507d5f09e01243fc3916fa Gerrit-PatchSet: 1 Gerrit-Project: osmo-bts Gerrit-Branch: master

[MERGED] osmo-ttcn3-hacks[master]: Add initial OsmoBTS test suite

2018-02-23 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: Add initial OsmoBTS test suite .. Add initial OsmoBTS test suite This Test suite implements the BSC-side of Abis RSL and is used to test OsmoBTS. It

[PATCH] osmo-bts[master]: rsl: Improve ERROR REPORTing

2018-02-23 Thread Harald Welte
Review at https://gerrit.osmocom.org/6877 rsl: Improve ERROR REPORTing Let's make sure all useful optional IEs of the RSL ERROR REPort aare present Change-Id: I5ecb98f8c72f472ac23c1e4e0f606b75e2cf032c --- M src/common/rsl.c 1 file changed, 81 insertions(+), 44 deletions(-) git pull

[PATCH] osmo-bts[master]: RSL: Send ERROR REPORT on too short/truncated messages + wro...

2018-02-23 Thread Harald Welte
Review at https://gerrit.osmocom.org/6876 RSL: Send ERROR REPORT on too short/truncated messages + wrong discriminator Change-Id: I6a0e63999f39592474064e2f05df450aec8e37fe --- M src/common/rsl.c 1 file changed, 6 insertions(+), 0 deletions(-) git pull

[PATCH] osmo-bts[master]: RSL: Implement DELETE INDICATION on AGCH overflow

2018-02-23 Thread Harald Welte
Review at https://gerrit.osmocom.org/6875 RSL: Implement DELETE INDICATION on AGCH overflow This patch adds generation of a DELETE INDICATION when the BTS AGCH queue overflows due to too many IMMEDIATE ASSIGN CMDs, as required by the specs. The AGCH queue length in OsmoBTS so far is at 1000

[PATCH] osmo-bsc[master]: paging: fix paging attemt rate counter

2018-02-23 Thread dexter
Review at https://gerrit.osmocom.org/6860 paging: fix paging attemt rate counter The rate counter BSC_CTR_PAGING_ATTEMPTED does not increment when a paging request is sent to the BSC. The reson for this is that the function call to rate_ctr_inc() is located in a dead code section. - Move the

osmo-gsm-tester[master]: pcap_recorder: log printing pcap file name as dbg

2018-02-23 Thread Pau Espin Pedrol
Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/6859 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I593c0ce02bf7a3a9d26cf1fcc7d523a313cb72eb Gerrit-PatchSet: 1 Gerrit-Project: osmo-gsm-tester Gerrit-Branch:

[MERGED] osmo-gsm-tester[master]: pcap_recorder: log printing pcap file name as dbg

2018-02-23 Thread Pau Espin Pedrol
Pau Espin Pedrol has submitted this change and it was merged. Change subject: pcap_recorder: log printing pcap file name as dbg .. pcap_recorder: log printing pcap file name as dbg The log message is quite long and makes it

[PATCH] osmo-ttcn3-hacks[master]: RSL_Types: Add tr_RSL_MEAS_RES_OSMO()

2018-02-23 Thread Harald Welte
Review at https://gerrit.osmocom.org/6867 RSL_Types: Add tr_RSL_MEAS_RES_OSMO() This is a template that goes beyond the 3GPP specs, as it expects presence of certain optional IEs which we know are always present in the OsmoBTS case. Change-Id: Ibf37565ab4fe70515b598a2757953628aa780241 --- M

[PATCH] osmo-ttcn3-hacks[master]: L1CTL: Increase FBSB timeout to ~1s

2018-02-23 Thread Harald Welte
Review at https://gerrit.osmocom.org/6865 L1CTL: Increase FBSB timeout to ~1s Change-Id: Id2bb23ae966bd9aa5fc36bfa8ba41d7f136ac88f --- M library/L1CTL_Types.ttcn 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/65/6865/1

osmo-ttcn3-hacks[master]: GSM_RR_Types: Fix inverted "valid" logic in measurement report

2018-02-23 Thread Harald Welte
Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/6864 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3ebdd30639b45ba1a9c0fbda7bf2775035833300 Gerrit-PatchSet: 1 Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch:

[PATCH] osmo-ttcn3-hacks[master]: L1CTL: Quickly fail in case of non-successful FBSB.resp

2018-02-23 Thread Harald Welte
Review at https://gerrit.osmocom.org/6866 L1CTL: Quickly fail in case of non-successful FBSB.resp Change-Id: I9d1fdb196eee7b3b06f2d3622e59d58f402dcd0d --- M library/L1CTL_PortType.ttcn 1 file changed, 3 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks

osmo-ttcn3-hacks[master]: RSL: Add definitions for RSL MEAS REP parsing/encoding

2018-02-23 Thread Harald Welte
Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/6863 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib04b81891def2c15a62767a29b53c0fb605d45be Gerrit-PatchSet: 1 Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch:

[PATCH] osmo-bsc[master]: bsc_api: drop unknown RR messages.

2018-02-23 Thread dexter
Review at https://gerrit.osmocom.org/6861 bsc_api: drop unknown RR messages. Radio Resource (RR) handling is entirely done inside the BSC. However, the current implementation forwards unknown RR messages to the MSC. This is not compliant to the specification. - Remove the forwarding and drop

[PATCH] osmo-ttcn3-hacks[master]: RSL: Add definitions for RSL MEAS REP parsing/encoding

2018-02-23 Thread Harald Welte
Review at https://gerrit.osmocom.org/6863 RSL: Add definitions for RSL MEAS REP parsing/encoding Change-Id: Ib04b81891def2c15a62767a29b53c0fb605d45be --- M library/RSL_Types.ttcn 1 file changed, 32 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks

[PATCH] osmo-ttcn3-hacks[master]: GSM_RR_Types: Fix inverted "valid" logic in measurement report

2018-02-23 Thread Harald Welte
Review at https://gerrit.osmocom.org/6864 GSM_RR_Types: Fix inverted "valid" logic in measurement report Change-Id: I3ebdd30639b45ba1a9c0fbda7bf2775035833300 --- M library/GSM_RR_Types.ttcn 1 file changed, 1 insertion(+), 1 deletion(-) git pull

[PATCH] osmo-ttcn3-hacks[master]: BSC: Add CCHAN_PT recently introduced in RSL_Emulation

2018-02-23 Thread Harald Welte
Review at https://gerrit.osmocom.org/6862 BSC: Add CCHAN_PT recently introduced in RSL_Emulation RSL_Emulation has recently gained a port for the common channel management messages, but BSC_Tests was not updated with this port, resulting in RSL_Emulation enqueuing messages to the port which

osmo-ttcn3-hacks[master]: L1CTL: Increase FBSB timeout to ~1s

2018-02-23 Thread Harald Welte
Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/6865 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id2bb23ae966bd9aa5fc36bfa8ba41d7f136ac88f Gerrit-PatchSet: 1 Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch:

osmo-ttcn3-hacks[master]: L1CTL: Quickly fail in case of non-successful FBSB.resp

2018-02-23 Thread Harald Welte
Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/6866 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9d1fdb196eee7b3b06f2d3622e59d58f402dcd0d Gerrit-PatchSet: 1 Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch:

osmo-ttcn3-hacks[master]: RSL_Types: Add tr_RSL_MEAS_RES_OSMO()

2018-02-23 Thread Harald Welte
Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/6867 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibf37565ab4fe70515b598a2757953628aa780241 Gerrit-PatchSet: 1 Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch:

osmo-bsc[master]: bsc_api: drop unknown RR messages.

2018-02-23 Thread Harald Welte
Patch Set 1: (1 comment) https://gerrit.osmocom.org/#/c/6861/1/src/libbsc/bsc_api.c File src/libbsc/bsc_api.c: Line 778:"BSC: Dropping %s 04.08 RR message\n", I think yo want the lchan->name or some other identity/context of the subscr-conn on *where* that message

osmocom-bb[master]: Fix memory leak when not using a lua script

2018-02-23 Thread Vadim Yanitskiy
Patch Set 1: Code-Review+1 Verified+1 Works for me, thanks! -- To view, visit https://gerrit.osmocom.org/6845 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I510af13bcbb46f73a0a289f26a4921cc90bd986a Gerrit-PatchSet: 1 Gerrit-Project:

[PATCH] osmocom-bb[master]: mobile: Fix memory leak when not using a LUA script

2018-02-23 Thread Vadim Yanitskiy
Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/6845 to look at the new patch set (#2). mobile: Fix memory leak when not using a LUA script The primitives are still allocated and dispatched but there was no script handler to delete them.

osmocom-bb[master]: mobile: Fix memory leak when not using a LUA script

2018-02-23 Thread Vadim Yanitskiy
Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/6845 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I510af13bcbb46f73a0a289f26a4921cc90bd986a Gerrit-PatchSet: 2 Gerrit-Project: osmocom-bb Gerrit-Branch: master

osmo-iuh[master]: ensure unique CellIDs in HNB-GW

2018-02-23 Thread Harald Welte
Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/6602 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iffd441eb2b6b75dfbe001b49b01bea015ca6e11c Gerrit-PatchSet: 3 Gerrit-Project: osmo-iuh Gerrit-Branch: master

[MERGED] osmo-iuh[master]: ensure unique CellIDs in HNB-GW

2018-02-23 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: ensure unique CellIDs in HNB-GW .. ensure unique CellIDs in HNB-GW If we receive a HNB-REGISTER-REQ with a cell ID which is already used by another

osmocom-bb[master]: mobile: Fix memory leak when not using a LUA script

2018-02-23 Thread Harald Welte
Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/6845 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I510af13bcbb46f73a0a289f26a4921cc90bd986a Gerrit-PatchSet: 2 Gerrit-Project: osmocom-bb Gerrit-Branch: master

[MERGED] osmocom-bb[master]: mobile: Fix memory leak when not using a LUA script

2018-02-23 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: mobile: Fix memory leak when not using a LUA script .. mobile: Fix memory leak when not using a LUA script The primitives are still allocated and

[MERGED] osmo-mgw[master]: enable osmo_fsm vty commands in libosmo-mgcp-client vty

2018-02-23 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: enable osmo_fsm vty commands in libosmo-mgcp-client vty .. enable osmo_fsm vty commands in libosmo-mgcp-client vty Call osmo_fsm_vty_add_cmds() to make

osmocom-bb[fixeria/trx]: trxcon: change default port number to 5703 to avoid clashes ...

2018-02-23 Thread Harald Welte
Patch Set 1: actually, 5703 is used by OsmoTRX for the second trx. I think it's a bad idea to re-use the same port numbers / port number range on the MS side which are used on the network side. Is there any requirement to do so? why not simply shift the entire base port (5700) on the client

osmo-msc[master]: enable osmo_fsm vty commands in osmo-msc vty

2018-02-23 Thread Harald Welte
Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/6841 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iaf970f6039c3f668f275dd8c21fb9071774a5d9e Gerrit-PatchSet: 1 Gerrit-Project: osmo-msc Gerrit-Branch: master

libosmocore[master]: ensure that osmo_fsm vty commands are only installed once

2018-02-23 Thread Harald Welte
Patch Set 1: (1 comment) https://gerrit.osmocom.org/#/c/6843/1/src/vty/fsm_vty.c File src/vty/fsm_vty.c: Line 192: if (!osmo_fsm_vty_cmds_installed) { what we normally do is if (osmo_fsm_vty_cmds_installed) return; to avoid having to indent all of the other statements in the

[MERGED] osmo-msc[master]: enable osmo_fsm vty commands in osmo-msc vty

2018-02-23 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: enable osmo_fsm vty commands in osmo-msc vty .. enable osmo_fsm vty commands in osmo-msc vty Call osmo_fsm_vty_add_cmds() to make osmo_fsm VTY commands

osmo-mgw[master]: enable osmo_fsm vty commands in libosmo-mgcp-client vty

2018-02-23 Thread Harald Welte
Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/6842 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If772edc304a9f342a57fb548f26908256cc9e6e5 Gerrit-PatchSet: 1 Gerrit-Project: osmo-mgw Gerrit-Branch: master

[PATCH] osmo-gsm-tester[master]: modem: Identify modems by sysfs path instead of ofono dbus path

2018-02-23 Thread Pau Espin Pedrol
Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/6858 to look at the new patch set (#3). modem: Identify modems by sysfs path instead of ofono dbus path ofono dbus paths are non-deterministic and can change over time for a given modem.

osmo-gsm-tester[master]: modem: Identify modems by sysfs path instead of ofono dbus path

2018-02-23 Thread Pau Espin Pedrol
Patch Set 4: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/6858 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibc45a196abadded2706dc9d57b6a3a796b43a201 Gerrit-PatchSet: 4 Gerrit-Project: osmo-gsm-tester Gerrit-Branch:

[PATCH] osmo-gsm-tester[master]: modem: Identify modems by sysfs path instead of ofono dbus path

2018-02-23 Thread Pau Espin Pedrol
Review at https://gerrit.osmocom.org/6858 modem: Identify modems by sysfs path instead of ofono dbus path ofono dbus paths are non-deterministic and can change over time for a given modem. For instance when ofono is restartd or if a modem crashes and the object is destroyed and re-announced by

[PATCH] osmo-gsm-tester[master]: modem: Identify modems by sysfs path instead of ofono dbus path

2018-02-23 Thread Pau Espin Pedrol
Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/6858 to look at the new patch set (#2). modem: Identify modems by sysfs path instead of ofono dbus path ofono dbus paths are non-deterministic and can change over time for a given modem.

[PATCH] osmo-gsm-tester[master]: modem: Identify modems by sysfs path instead of ofono dbus path

2018-02-23 Thread Pau Espin Pedrol
Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/6858 to look at the new patch set (#4). modem: Identify modems by sysfs path instead of ofono dbus path ofono dbus paths are non-deterministic and can change over time for a given modem.

[PATCH] osmo-gsm-tester[master]: pcap_recorder: log printing pcap file name as dbg

2018-02-23 Thread Pau Espin Pedrol
Review at https://gerrit.osmocom.org/6859 pcap_recorder: log printing pcap file name as dbg The log message is quite long and makes it difficult to read the log even with debug disabled. Change-Id: I593c0ce02bf7a3a9d26cf1fcc7d523a313cb72eb --- M src/osmo_gsm_tester/pcap_recorder.py 1 file

[MERGED] osmo-gsm-tester[master]: modem: Identify modems by sysfs path instead of ofono dbus path

2018-02-23 Thread Pau Espin Pedrol
Pau Espin Pedrol has submitted this change and it was merged. Change subject: modem: Identify modems by sysfs path instead of ofono dbus path .. modem: Identify modems by sysfs path instead of ofono dbus path ofono dbus paths

[MERGED] osmo-ttcn3-hacks[master]: L1CTL: Quickly fail in case of non-successful FBSB.resp

2018-02-23 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: L1CTL: Quickly fail in case of non-successful FBSB.resp .. L1CTL: Quickly fail in case of non-successful FBSB.resp Change-Id:

osmo-ttcn3-hacks[master]: BSC: Add CCHAN_PT recently introduced in RSL_Emulation

2018-02-23 Thread Harald Welte
Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/6862 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id8a3c4409599783ca4cd0b49f2570bcb3bb34952 Gerrit-PatchSet: 2 Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch:

[MERGED] osmo-ttcn3-hacks[master]: L1CTL: Increase FBSB timeout to ~1s

2018-02-23 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: L1CTL: Increase FBSB timeout to ~1s .. L1CTL: Increase FBSB timeout to ~1s Change-Id: Id2bb23ae966bd9aa5fc36bfa8ba41d7f136ac88f --- M

[MERGED] osmo-ttcn3-hacks[master]: RSL: Add definitions for RSL MEAS REP parsing/encoding

2018-02-23 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: RSL: Add definitions for RSL MEAS REP parsing/encoding .. RSL: Add definitions for RSL MEAS REP parsing/encoding Change-Id:

[MERGED] osmo-ttcn3-hacks[master]: bsc: fix TC_paging_imsi_a_reset

2018-02-23 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: bsc: fix TC_paging_imsi_a_reset .. bsc: fix TC_paging_imsi_a_reset The testcase TC_paging_imsi_a_reset sends a paging request that causes pagings on all

osmo-ttcn3-hacks[master]: bsc: fix TC_paging_imsi_a_reset

2018-02-23 Thread Harald Welte
Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/6855 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If0cdc0325fd0e1dcf3e4ce52e4de27adb4d9cf48 Gerrit-PatchSet: 2 Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch:

[MERGED] osmo-ttcn3-hacks[master]: GSM_RR_Types: Fix inverted "valid" logic in measurement report

2018-02-23 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: GSM_RR_Types: Fix inverted "valid" logic in measurement report .. GSM_RR_Types: Fix inverted "valid" logic in measurement report Change-Id:

[MERGED] osmo-ttcn3-hacks[master]: BSC: Add CCHAN_PT recently introduced in RSL_Emulation

2018-02-23 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: BSC: Add CCHAN_PT recently introduced in RSL_Emulation .. BSC: Add CCHAN_PT recently introduced in RSL_Emulation RSL_Emulation has recently gained a

[MERGED] osmo-ttcn3-hacks[master]: RSL_Types: Add tr_RSL_MEAS_RES_OSMO()

2018-02-23 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: RSL_Types: Add tr_RSL_MEAS_RES_OSMO() .. RSL_Types: Add tr_RSL_MEAS_RES_OSMO() This is a template that goes beyond the 3GPP specs, as it expects

osmo-bsc[master]: paging: fix paging attemt rate counter

2018-02-23 Thread Harald Welte
Patch Set 1: (1 comment) https://gerrit.osmocom.org/#/c/6860/1/src/osmo-bsc/osmo_bsc_bssap.c File src/osmo-bsc/osmo_bsc_bssap.c: Line 463: rate_ctr_inc(>network->bsc_ctrs->ctr[BSC_CTR_PAGING_ATTEMPTED]); it's called PAGING_ATTEMPTED and we should only increment it if we actually have

[PATCH] osmo-bts[master]: Revert "measurement: fix measurement computation"

2018-02-23 Thread Harald Welte
Review at https://gerrit.osmocom.org/6868 Revert "measurement: fix measurement computation" This reverts commit d5fdcfe6d95f52fb76c4f4201969347a062fc9fd, which introduces a new function lchan_meas_update_ordered_TA whose functionality I still haven't yet managed to fully understand. It appears

[PATCH] osmo-bts[master]: osmo-bts-trx: Add missing frame number to l1if_process_meas_...

2018-02-23 Thread Harald Welte
Review at https://gerrit.osmocom.org/6869 osmo-bts-trx: Add missing frame number to l1if_process_meas_res() Change-Id: I7f1322b025ce733f78ae2b958c7a2bb38b6aa6f5 --- M src/osmo-bts-trx/l1_if.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bts

osmo-bsc[master]: paging: page all bts when no cell is associated

2018-02-23 Thread Harald Welte
Patch Set 1: would be great to include a spec reference in the commit log and possibly even in the code/comment. thanks! -- To view, visit https://gerrit.osmocom.org/6848 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id:

osmo-bts[master]: split scheduler_mframe.c from scheduler.c

2018-02-23 Thread Vadim Yanitskiy
Patch Set 3: Seems, the libl1sched should be linked against libbts this way. This would solve the problem. But in general, I am wondering about moving the multiframe structures to libosmogsm... -- To view, visit https://gerrit.osmocom.org/6852 To unsubscribe, visit

Build failure of network:osmocom:nightly/osmo-trx in Debian_8.0/i586

2018-02-23 Thread OBS Notification
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-trx/Debian_8.0/i586 Package network:osmocom:nightly/osmo-trx failed to build in Debian_8.0/i586 Check out the package for editing: osc checkout network:osmocom:nightly osmo-trx Last lines of build log: [

Build failure of network:osmocom:nightly/osmo-trx in xUbuntu_17.04/i586

2018-02-23 Thread OBS Notification
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-trx/xUbuntu_17.04/i586 Package network:osmocom:nightly/osmo-trx failed to build in xUbuntu_17.04/i586 Check out the package for editing: osc checkout network:osmocom:nightly osmo-trx Last lines of build log:

Build failure of network:osmocom:nightly/osmo-trx in xUbuntu_16.04/i586

2018-02-23 Thread OBS Notification
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-trx/xUbuntu_16.04/i586 Package network:osmocom:nightly/osmo-trx failed to build in xUbuntu_16.04/i586 Check out the package for editing: osc checkout network:osmocom:nightly osmo-trx Last lines of build log:

Build failure of network:osmocom:nightly/osmo-trx in xUbuntu_16.10/i586

2018-02-23 Thread OBS Notification
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-trx/xUbuntu_16.10/i586 Package network:osmocom:nightly/osmo-trx failed to build in xUbuntu_16.10/i586 Check out the package for editing: osc checkout network:osmocom:nightly osmo-trx Last lines of build log:

Build failure of network:osmocom:nightly/osmo-trx in Debian_9.0/i586

2018-02-23 Thread OBS Notification
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-trx/Debian_9.0/i586 Package network:osmocom:nightly/osmo-trx failed to build in Debian_9.0/i586 Check out the package for editing: osc checkout network:osmocom:nightly osmo-trx Last lines of build log: [

osmo-bts[master]: osmo-bts-trx: Add missing frame number to l1if_process_meas_...

2018-02-23 Thread Harald Welte
Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/6869 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7f1322b025ce733f78ae2b958c7a2bb38b6aa6f5 Gerrit-PatchSet: 1 Gerrit-Project: osmo-bts Gerrit-Branch: master

osmo-bts[master]: Revert "measurement: fix measurement computation"

2018-02-23 Thread Harald Welte
Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/6868 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5a5adac6f18f94a5b51758a5ace8ef6ddfd23e80 Gerrit-PatchSet: 1 Gerrit-Project: osmo-bts Gerrit-Branch: master

Build failure of network:osmocom:nightly/osmo-trx in Debian_9.0/aarch64

2018-02-23 Thread OBS Notification
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-trx/Debian_9.0/aarch64 Package network:osmocom:nightly/osmo-trx failed to build in Debian_9.0/aarch64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-trx Last lines of build log:

[MERGED] osmo-bts[master]: Revert "measurement: fix measurement computation"

2018-02-23 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: Revert "measurement: fix measurement computation" .. Revert "measurement: fix measurement computation" This reverts commit

Build failure of network:osmocom:nightly/osmo-trx in xUbuntu_17.10/x86_64

2018-02-23 Thread OBS Notification
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-trx/xUbuntu_17.10/x86_64 Package network:osmocom:nightly/osmo-trx failed to build in xUbuntu_17.10/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-trx Last lines of build

[MERGED] osmo-bts[master]: osmo-bts-trx: Add missing frame number to l1if_process_meas_...

2018-02-23 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: osmo-bts-trx: Add missing frame number to l1if_process_meas_res() .. osmo-bts-trx: Add missing frame number to l1if_process_meas_res() Change-Id:

[MERGED] osmo-bts[master]: l1sap: Pass is_sub from L1 primitive into the Uplink Measure...

2018-02-23 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: l1sap: Pass is_sub from L1 primitive into the Uplink Measurement .. l1sap: Pass is_sub from L1 primitive into the Uplink Measurement info_meas_ind on

[MERGED] osmo-bts[master]: measurement.c: Hand Frame Number into measurement computation

2018-02-23 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: measurement.c: Hand Frame Number into measurement computation .. measurement.c: Hand Frame Number into measurement computation This is currently only

Build failure of network:osmocom:nightly/osmo-trx in xUbuntu_17.04/x86_64

2018-02-23 Thread OBS Notification
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-trx/xUbuntu_17.04/x86_64 Package network:osmocom:nightly/osmo-trx failed to build in xUbuntu_17.04/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-trx Last lines of build

Build failure of network:osmocom:nightly/osmo-trx in xUbuntu_16.10/x86_64

2018-02-23 Thread OBS Notification
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-trx/xUbuntu_16.10/x86_64 Package network:osmocom:nightly/osmo-trx failed to build in xUbuntu_16.10/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-trx Last lines of build

Build failure of network:osmocom:nightly/osmo-trx in Debian_8.0/x86_64

2018-02-23 Thread OBS Notification
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-trx/Debian_8.0/x86_64 Package network:osmocom:nightly/osmo-trx failed to build in Debian_8.0/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-trx Last lines of build log: [

Build failure of network:osmocom:nightly/osmo-trx in Debian_9.0/x86_64

2018-02-23 Thread OBS Notification
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-trx/Debian_9.0/x86_64 Package network:osmocom:nightly/osmo-trx failed to build in Debian_9.0/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-trx Last lines of build log: [

Build failure of network:osmocom:nightly/osmo-trx in xUbuntu_16.04/x86_64

2018-02-23 Thread OBS Notification
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-trx/xUbuntu_16.04/x86_64 Package network:osmocom:nightly/osmo-trx failed to build in xUbuntu_16.04/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-trx Last lines of build

Build failure of network:osmocom:nightly/osmo-trx in Debian_9.0/armv7l

2018-02-23 Thread OBS Notification
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-trx/Debian_9.0/armv7l Package network:osmocom:nightly/osmo-trx failed to build in Debian_9.0/armv7l Check out the package for editing: osc checkout network:osmocom:nightly osmo-trx Last lines of build log: [

[MERGED] osmocom-bb[fixeria/trx]: trxcon|fake_trx: change default TRX port number to 6700

2018-02-23 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: trxcon|fake_trx: change default TRX port number to 6700 .. trxcon|fake_trx: change default TRX port number to 6700 In order to avoid clashes with

osmocom-bb[fixeria/trx]: trxcon|fake_trx: change default TRX port number to 6700

2018-02-23 Thread Harald Welte
Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/6839 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I66b5f25aaba3b836448ed29839c39869b5622bed Gerrit-PatchSet: 2 Gerrit-Project: osmocom-bb Gerrit-Branch:

osmo-trx[master]: osmo-trx.cpp: Move trx start and stop to helper functions

2018-02-23 Thread Harald Welte
Patch Set 5: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/6648 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I10eaaafe38ace2b7bb095a0ad1db70d6c06ee03b Gerrit-PatchSet: 5 Gerrit-Project: osmo-trx Gerrit-Branch: master

osmo-trx[master]: Move enums required by VTY to a separate header

2018-02-23 Thread Harald Welte
Patch Set 5: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/6649 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3d5b0576aa96869756f1629a40306c0043b6304b Gerrit-PatchSet: 5 Gerrit-Project: osmo-trx Gerrit-Branch: master

osmo-trx[master]: osmo-trx: Drop cmd lines and use VTY cfg

2018-02-23 Thread Harald Welte
Patch Set 5: I'm not sure we want to remove them. We might leave them for some time to keep backwards compatibility to existing startup scripts etc? -- To view, visit https://gerrit.osmocom.org/6651 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment

osmo-msc[master]: mcgp: let the MGW allocate the MGCP endpoint

2018-02-23 Thread Stefan Sperling
Patch Set 2: (1 comment) https://gerrit.osmocom.org/#/c/6319/2/src/libmsc/msc_mgcp.c File src/libmsc/msc_mgcp.c: Line 252: MGCP_ENDPOINT_MAXLEN) { While this code is correct because sizeof(mgcp_msg.endpoint) and MGCP_ENDPOINT_MAXLEN have the same value, I would stick to the idiom:

osmo-trx[master]: Logger: Use libosmocore logging system

2018-02-23 Thread Harald Welte
Patch Set 9: We might not want to break existing command line users by removing the debug option completely. Is there a reasonable mapping from old levels to new? -- To view, visit https://gerrit.osmocom.org/6620 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType:

osmo-trx[master]: osmo-trx: Drop cmd lines and use VTY cfg

2018-02-23 Thread Pau Espin Pedrol
Patch Set 5: > I'm not sure we want to remove them. We might leave them for some > time to keep backwards compatibility to existing startup scripts > etc? We are already breaking backwards compatibility in 6619 anyway since we require the config file to parse it to init the VTY/logging

osmo-msc[master]: mcgp: let the MGW allocate the MGCP endpoint

2018-02-23 Thread Harald Welte
Patch Set 2: Code-Review-1 I would love to merge this, but without an updsate to the tests its not possible to merge. -- To view, visit https://gerrit.osmocom.org/6319 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id:

[PATCH] osmo-gsm-tester[master]: contrib: build-osmo-trx: build new dep libosmocore

2018-02-23 Thread Pau Espin Pedrol
Review at https://gerrit.osmocom.org/6847 contrib: build-osmo-trx: build new dep libosmocore Since 8b843e5bed6e3dab1068b86805e557a196f9aa4c, osmo-trx depends on libosmocore. Change-Id: I63d09339da5be7af638efe9e07f0c0ed31738ed1 --- M contrib/jenkins-build-osmo-trx.sh 1 file changed, 1

  1   2   >