Patch Set 7:
> An example run of this can be found at
> http://jenkins.osmocom.org/jenkins/view/osmo-gsm-tester/job/osmo-gsm-tester_run/458/consoleFull
that wasn't a good one, there was still a bug in the following commit #2584.
This is better:
Hello Pau Espin Pedrol, Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/2854
to look at the new patch set (#7).
junit result: also write for aborted runs
Even if aborted due to signal, write a JUnit report XML, and make sure to
indicate the
Patch Set 7:
An example run of this can be found at
http://jenkins.osmocom.org/jenkins/view/osmo-gsm-tester/job/osmo-gsm-tester_run/458/consoleFull
--
To view, visit https://gerrit.osmocom.org/2853
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Hello Pau Espin Pedrol, Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/2853
to look at the new patch set (#7).
refactor: fix error handling; fix log.Origin; only one trial
A bit of refactoring to fix logging and error reporting, and simplify
Hello Pau Espin Pedrol, Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/2854
to look at the new patch set (#6).
junit result: also write for aborted runs
Even if aborted due to signal, write a JUnit report XML, and make sure to
indicate the
Patch Set 5:
(1 comment)
https://gerrit.osmocom.org/#/c/2853/5/src/osmo_gsm_tester/suite.py
File src/osmo_gsm_tester/suite.py:
Line 222: except Exception as e:
> As I said on the other patch, moving this here seems ugly, but if there's n
either we have the 'with self' in
Hello Pau Espin Pedrol, Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/2853
to look at the new patch set (#6).
refactor: fix error handling; fix log.Origin; only one trial
A bit of refactoring to fix logging and error reporting, and simplify
Patch Set 1:
(1 comment)
https://gerrit.osmocom.org/#/c/2852/1/src/osmo_gsm_tester/resource.py
File src/osmo_gsm_tester/resource.py:
Line 483: msg = 'suite.conf reserved only %d x %r.' %
(len(kind_reserved), kind)
> Are you perhaps checking the wrong way or I am missing
Patch Set 2: Code-Review+2
fast track because builds are failing. Verified to work in manual run
http://jenkins.osmocom.org/jenkins/view/osmo-gsm-tester/job/osmo-gsm-tester_run/454/
--
To view, visit https://gerrit.osmocom.org/2860
To unsubscribe, visit https://gerrit.osmocom.org/settings
Neels Hofmeyr has submitted this change and it was merged.
Change subject: osmo-msc: configure HLR address
..
osmo-msc: configure HLR address
In db59bcf9fcdc5f05fdb9047b905ab497472440bc we added a configured GSUP server
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/2860
to look at the new patch set (#2).
osmo-msc: configure HLR address
In db59bcf9fcdc5f05fdb9047b905ab497472440bc we added a configured GSUP server
address for the osmo-hlr, but the
Review at https://gerrit.osmocom.org/2860
osmo-msc: configure HLR address
In db59bcf9fcdc5f05fdb9047b905ab497472440bc we added a configured GSUP server
address for the osmo-hlr, but the osmo-msc is still trying to connect to
127.0.0.1.
In the same way as for mgcpgw, add conf_for_msc() to
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/2685
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I4ce65443c8a33ae9add8f6da9d911c3178472ab2
Gerrit-PatchSet: 1
Gerrit-Project: osmo-trx
Gerrit-Branch: master
Tom Tsou has submitted this change and it was merged.
Change subject: buildenv: cosmetic changes
..
buildenv: cosmetic changes
Change-Id: I9c52f2981513fa6322bdf992215e3e099ac3ddee
---
M config/ax_sse.m4
1 file changed, 8
Tom Tsou has submitted this change and it was merged.
Change subject: buildenv: correct the ax_sse macro description
..
buildenv: correct the ax_sse macro description
Change-Id: I4ce65443c8a33ae9add8f6da9d911c3178472ab2
---
M
Tom Tsou has submitted this change and it was merged.
Change subject: buildenv: actually strip unused cpuid functionality
..
buildenv: actually strip unused cpuid functionality
Despite the macro message says, that cpuid
Tom Tsou has submitted this change and it was merged.
Change subject: buildenv: fix build on systems without SIMD support
..
buildenv: fix build on systems without SIMD support
HAVE_SSE3 and HAVE_SSE4_1 were never defined if
Tom Tsou has submitted this change and it was merged.
Change subject: buildenv: check for __builtin_cpu_supports call support
..
buildenv: check for __builtin_cpu_supports call support
The '__builtin_cpu_supports' is a GCC's
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/2686
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I380bc9c13d29319685781ef27973afe6744fcf3d
Gerrit-PatchSet: 1
Gerrit-Project: osmo-trx
Gerrit-Branch: master
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/2687
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I3350b14dbc91e9b388d0b04a0ed22ba27d436313
Gerrit-PatchSet: 1
Gerrit-Project: osmo-trx
Gerrit-Branch: master
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/2688
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I9c52f2981513fa6322bdf992215e3e099ac3ddee
Gerrit-PatchSet: 1
Gerrit-Project: osmo-trx
Gerrit-Branch: master
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/2690
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I0c90402d8e4c9f196c54b066ff30891c8de3ad2b
Gerrit-PatchSet: 1
Gerrit-Project: osmo-trx
Gerrit-Branch: master
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/2689
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I797f638573e8c3aae39c28abb157ce2ac419f3f7
Gerrit-PatchSet: 1
Gerrit-Project: osmo-trx
Gerrit-Branch: master
Patch Set 1: Code-Review-1
We can't reduce the detection window unless the timing concerns in e90c24c8 are
considered and/or the underlying issue is addressed. One possibility is
disabling 4/1 SPS support and/or defaulting to 4/4 SPS (which has more stable
timing), but those are much more
Patch Set 1: Code-Review+2
I also agree in that it makes sense for PRBS sequences to be in libosmocore,
but the current patch is not mergeable into libosmocore. If someone decides to
rewrite the patch in C and appropriate coding style for libosmocore, then we
can remove it from osmo-trx at
Review at https://gerrit.osmocom.org/2859
Simplify polling troubleshooting
* introduce enum describing poll kind and use it in set_polling()
* move state change and logging into set_polling()
Change-Id: I14074207f8bbc18b3ebd60875bb99a0a3a4b399d
Related: OS#1524
---
M src/tbf.cpp
M src/tbf.h
M
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/2747
to look at the new patch set (#3).
OsmoBTS: Update osmotrx ip to diff between local and remote
Change Id of the code implementation: Ia4c70b3b8436e2647fc35d579a302dfbf32a83f0
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/2857
to look at the new patch set (#2).
Add macros to set/get/clear/toggle bit flags
We extensively use bit masks and flags but do not have any convenience
wrappers for it which decrease
Patch Set 1:
(1 comment)
https://gerrit.osmocom.org/#/c/2857/1/include/osmocom/core/utils.h
File include/osmocom/core/utils.h:
Line 24: #define OSMO_SET(x, flag) ((x) |= 1 << (flag))
I'd add _BIT_ to all of them, otherwise seems a bit too generic and you don't
know what's doing at first
Review at https://gerrit.osmocom.org/2857
Add macros to set/get/clear/toggle bit flags
We extensively use bit masks and flags but do not have any convenience
wrappers for it which decrease code readability. Add macros which can
set/get, clear and toggle bits with corresponding doxygen
Hello Neels Hofmeyr, Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/2779
to look at the new patch set (#9).
ofono_client: Implement network registration during connect()
A new mcc_mnc parameter is now optionally passed to connect() in order
Patch Set 1:
(1 comment)
https://gerrit.osmocom.org/#/c/2852/1/src/osmo_gsm_tester/resource.py
File src/osmo_gsm_tester/resource.py:
Line 483: msg = 'suite.conf reserved only %d x %r.' %
(len(kind_reserved), kind)
> yes. If we reserved 4 modems in suite.conf, we can call
32 matches
Mail list logo
