[PATCH] openbsc[master]: rename osmo-bsc to osmo-bsc-sccplite

Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/4421 to look at the new patch set (#3). rename osmo-bsc to osmo-bsc-sccplite This is to avoid naming conflicts with the new osmo-bsc, which resides in its own git repository (osmo-bsc.git)

openbsc[master]: rename osmo-bsc to osmo-bsc-sccplite

Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/4421 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If10d1599b62d010726336134091a4e855c380d93 Gerrit-PatchSet: 2 Gerrit-Project: openbsc Gerrit-Branch: master

[PATCH] openbsc[master]: rename osmo-bsc to osmo-bsc-sccplite

Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/4421 to look at the new patch set (#2). rename osmo-bsc to osmo-bsc-sccplite This is to avoid naming conflicts with the new osmo-bsc, which resides in its own git repository (osmo-bsc.git)

[PATCH] openbsc[master]: rename osmo-bsc to osmo-bsc-sccplite

Review at https://gerrit.osmocom.org/4421 rename osmo-bsc to osmo-bsc-sccplite This is to avoid naming conflicts with the new osmo-bsc, which resides in its own git repository (osmo-bsc.git) and which uses libosmo-sigtran and implements (primarily) 3GPP AoIP. Change-Id:

openbsc[master]: remove sgsn, gbproxy and gtphub from openbsc.git

Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/4417 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If60e28b23f5cfb2c4eb354951363a2bb63f3e0de Gerrit-PatchSet: 3 Gerrit-Project: openbsc Gerrit-Branch: master

[MERGED] openbsc[master]: Fix nanobts_omlattr unit test

Harald Welte has submitted this change and it was merged. Change subject: Fix nanobts_omlattr unit test .. Fix nanobts_omlattr unit test The test clearly fails unless bts->network is set correctly. Not sure why this hasn't

[MERGED] openbsc[master]: osmo-bsc: Initialize logging before initializing rate_ctr

Harald Welte has submitted this change and it was merged. Change subject: osmo-bsc: Initialize logging before initializing rate_ctr .. osmo-bsc: Initialize logging before initializing rate_ctr The library code for rate counter

openbsc[master]: osmo-bsc: Initialize logging before initializing rate_ctr

Patch Set 1: Verified+1 -- To view, visit https://gerrit.osmocom.org/4420 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1e893c97e023e63489fe8c46539b5e507d3cec8f Gerrit-PatchSet: 1 Gerrit-Project: openbsc Gerrit-Branch: master

[MERGED] openbsc[master]: nanobts_omlattra_test: Initialize logging before executing t...

Harald Welte has submitted this change and it was merged. Change subject: nanobts_omlattra_test: Initialize logging before executing tests .. nanobts_omlattra_test: Initialize logging before executing tests ... the library

openbsc[master]: nanobts_omlattra_test: Initialize logging before executing t...

Patch Set 1: Verified+1 -- To view, visit https://gerrit.osmocom.org/4419 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib4be9541771e95ca4e051b778fc3958202aab9ab Gerrit-PatchSet: 1 Gerrit-Project: openbsc Gerrit-Branch: master

openbsc[master]: Fix nanobts_omlattr unit test

Patch Set 1: Verified+1 -- To view, visit https://gerrit.osmocom.org/4418 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id1cd4ce8f1e03b9715e1223414918bc69499e13d Gerrit-PatchSet: 1 Gerrit-Project: openbsc Gerrit-Branch: master

openbsc[master]: Fix nanobts_omlattr unit test

Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/4418 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id1cd4ce8f1e03b9715e1223414918bc69499e13d Gerrit-PatchSet: 1 Gerrit-Project: openbsc Gerrit-Branch: master

openbsc[master]: osmo-bsc: Initialize logging before initializing rate_ctr

Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/4420 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1e893c97e023e63489fe8c46539b5e507d3cec8f Gerrit-PatchSet: 1 Gerrit-Project: openbsc Gerrit-Branch: master

[PATCH] openbsc[master]: nanobts_omlattra_test: Initialize logging before executing t...

Review at https://gerrit.osmocom.org/4419 nanobts_omlattra_test: Initialize logging before executing tests ... the library code we call could want to log something, after all. Port of osmo-bsc Change-Id Ic01e9bfb63d7b6def9432103e744c23c90f0f6b9 Change-Id:

openbsc[master]: nanobts_omlattra_test: Initialize logging before executing t...

Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/4419 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib4be9541771e95ca4e051b778fc3958202aab9ab Gerrit-PatchSet: 1 Gerrit-Project: openbsc Gerrit-Branch: master

[PATCH] openbsc[master]: osmo-bsc: Initialize logging before initializing rate_ctr

Review at https://gerrit.osmocom.org/4420 osmo-bsc: Initialize logging before initializing rate_ctr The library code for rate counter initialization, which is called from the descendants of bsc_network_alloc() might already want to log something (particularly after Change-Id

[PATCH] openbsc[master]: Fix nanobts_omlattr unit test

Review at https://gerrit.osmocom.org/4418 Fix nanobts_omlattr unit test The test clearly fails unless bts->network is set correctly. Not sure why this hasn't shown up before? Port of osmo-bsc Change-Id I47786ed06ff610213d7a0b56d0ebf1c537cd7568 Change-Id:

[PATCH] openbsc[master]: remove sgsn, gbproxy and gtphub from openbsc.git

Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/4417 to look at the new patch set (#2). remove sgsn, gbproxy and gtphub from openbsc.git The GPRS related programs osmo-sgsn, osmo-gtphub and osmo-gbproxy have been split off into the

[PATCH] openbsc[master]: remove sgsn, gbproxy and gtphub from openbsc.git

Review at https://gerrit.osmocom.org/4417 remove sgsn, gbproxy and gtphub from openbsc.git The GPRS related programs osmo-sgsn, osmo-gtphub and osmo-gbproxy have been split off into the separate osmo-sgsn repository, which can be found at git://git.osmocom.org/osmo-sgsn.git

Build failure of network:osmocom:nightly/openbsc in Debian_9.0/i586

Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/openbsc/Debian_9.0/i586 Package network:osmocom:nightly/openbsc failed to build in Debian_9.0/i586 Check out the package for editing: osc checkout network:osmocom:nightly openbsc Last lines of build log: [ 189s]

Build failure of network:osmocom:nightly/openbsc in Debian_8.0/x86_64

Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/openbsc/Debian_8.0/x86_64 Package network:osmocom:nightly/openbsc failed to build in Debian_8.0/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly openbsc Last lines of build log: [

Build failure of network:osmocom:nightly/openbsc in xUbuntu_17.04/i586

Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/openbsc/xUbuntu_17.04/i586 Package network:osmocom:nightly/openbsc failed to build in xUbuntu_17.04/i586 Check out the package for editing: osc checkout network:osmocom:nightly openbsc Last lines of build log: [

Build failure of network:osmocom:nightly/openbsc in Debian_9.0/x86_64

Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/openbsc/Debian_9.0/x86_64 Package network:osmocom:nightly/openbsc failed to build in Debian_9.0/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly openbsc Last lines of build log: [

Build failure of network:osmocom:nightly/openbsc in xUbuntu_16.04/x86_64

Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/openbsc/xUbuntu_16.04/x86_64 Package network:osmocom:nightly/openbsc failed to build in xUbuntu_16.04/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly openbsc Last lines of build

Build failure of network:osmocom:nightly/openbsc in xUbuntu_17.04/x86_64

Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/openbsc/xUbuntu_17.04/x86_64 Package network:osmocom:nightly/openbsc failed to build in xUbuntu_17.04/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly openbsc Last lines of build

Build failure of network:osmocom:nightly/osmo-pcu in Debian_8.0/i586

Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-pcu/Debian_8.0/i586 Package network:osmocom:nightly/osmo-pcu failed to build in Debian_8.0/i586 Check out the package for editing: osc checkout network:osmocom:nightly osmo-pcu Last lines of build log: [

Build failure of network:osmocom:nightly/osmo-pcu in Debian_8.0/x86_64

Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-pcu/Debian_8.0/x86_64 Package network:osmocom:nightly/osmo-pcu failed to build in Debian_8.0/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-pcu Last lines of build log: [

Build failure of network:osmocom:nightly/osmo-pcu in Debian_9.0/i586

Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-pcu/Debian_9.0/i586 Package network:osmocom:nightly/osmo-pcu failed to build in Debian_9.0/i586 Check out the package for editing: osc checkout network:osmocom:nightly osmo-pcu Last lines of build log: [

Build failure of network:osmocom:nightly/osmo-pcu in xUbuntu_16.04/i586

Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-pcu/xUbuntu_16.04/i586 Package network:osmocom:nightly/osmo-pcu failed to build in xUbuntu_16.04/i586 Check out the package for editing: osc checkout network:osmocom:nightly osmo-pcu Last lines of build log:

Build failure of network:osmocom:nightly/osmo-pcu in Debian_9.0/x86_64

Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-pcu/Debian_9.0/x86_64 Package network:osmocom:nightly/osmo-pcu failed to build in Debian_9.0/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-pcu Last lines of build log: [

Build failure of network:osmocom:nightly/osmo-pcu in xUbuntu_16.10/i586

Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-pcu/xUbuntu_16.10/i586 Package network:osmocom:nightly/osmo-pcu failed to build in xUbuntu_16.10/i586 Check out the package for editing: osc checkout network:osmocom:nightly osmo-pcu Last lines of build log:

Build failure of network:osmocom:nightly/osmo-pcu in xUbuntu_16.04/x86_64

Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-pcu/xUbuntu_16.04/x86_64 Package network:osmocom:nightly/osmo-pcu failed to build in xUbuntu_16.04/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-pcu Last lines of build

Build failure of network:osmocom:nightly/osmo-pcu in xUbuntu_16.10/x86_64

Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-pcu/xUbuntu_16.10/x86_64 Package network:osmocom:nightly/osmo-pcu failed to build in xUbuntu_16.10/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-pcu Last lines of build

Build failure of network:osmocom:nightly/osmo-pcu in xUbuntu_17.04/x86_64

Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-pcu/xUbuntu_17.04/x86_64 Package network:osmocom:nightly/osmo-pcu failed to build in xUbuntu_17.04/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-pcu Last lines of build

libosmocore[master]: Expand bitvec_write_field()

Patch Set 8: > > I am applying new bitvec_write_field_ext function for encoding LH > bits of IA Rest OCtets of EDGE PKT DL IMM ASS in PCU. > > Could you please share your patch for OsmoPCU? Let's see if we can > use L/H directly as a parameter in separate function instead of > extending

openbsc[master]: libmsc: db_subscriber_alloc_exten() remove infinite loop

Patch Set 5: > deferring to neels on this one. as the patch has been sitting in > the queue for quite some time: Ping? I've created https://osmocom.org/issues/2595 It's not a simple as it looks, so I suggest this patch be abandoned until the solution is decided upon. -- To view, visit

osmo-pcu[master]: Move all rate counter related code together

Patch Set 8: Code-Review-1 (1 comment) https://gerrit.osmocom.org/#/c/4413/8/src/bts.cpp File src/bts.cpp: Line 165: rlc_late_block(bts_data()->ctrs); I'm sorry, I really think it's ugly to pass around a counter array to various functions that don't take any other argument.

osmo-pcu[master]: Initialize logging before initializing rate_ctr

Patch Set 8: (4 comments) https://gerrit.osmocom.org/#/c/4411/8/src/bts.cpp File src/bts.cpp: Line 54 I'm not really sure what this is actually all about, but was the removal of the comment intentional? https://gerrit.osmocom.org/#/c/4411/8/src/pcu_ctr.c File src/pcu_ctr.c: Line 22:

osmo-hlr[master]: ctrl: completely replace all CTRL commands

Patch Set 6: see https://gerrit.osmocom.org/#/c/4415/ -- To view, visit https://gerrit.osmocom.org/4311 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I98ee6a06b3aa6a67adb868e0b63b0e04eb42eb50 Gerrit-PatchSet: 6 Gerrit-Project: osmo-hlr

[MERGED] osmo-hlr[master]: db api: fix/add API docs

Neels Hofmeyr has submitted this change and it was merged. Change subject: db api: fix/add API docs .. db api: fix/add API docs Change-Id: I854fafd8e56bd0b8394f8ed79d023c11c2fdbdca --- M src/db_hlr.c 1 file changed, 76

osmo-hlr[master]: db api: fix/add API docs

Patch Set 2: Code-Review+2 let me just apply this without causing review cycles. -- To view, visit https://gerrit.osmocom.org/4415 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I854fafd8e56bd0b8394f8ed79d023c11c2fdbdca Gerrit-PatchSet:

[PATCH] osmo-hlr[master]: db api: fix/add API docs

Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/4415 to look at the new patch set (#2). db api: fix/add API docs Change-Id: I854fafd8e56bd0b8394f8ed79d023c11c2fdbdca --- M src/db_hlr.c 1 file changed, 76 insertions(+), 13 deletions(-)

[PATCH] osmo-hlr[master]: db api: fix/add API docs

Review at https://gerrit.osmocom.org/4415 db api: fix/add API docs Change-Id: I854fafd8e56bd0b8394f8ed79d023c11c2fdbdca --- M src/db_hlr.c 1 file changed, 76 insertions(+), 13 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-hlr refs/changes/15/4415/1 diff --git a/src/db_hlr.c

[MERGED] osmo-gsm-manuals[master]: refactor Makefile build rules, don't use the FORCE

Neels Hofmeyr has submitted this change and it was merged. Change subject: refactor Makefile build rules, don't use the FORCE .. refactor Makefile build rules, don't use the FORCE The initial goal was to make sure we don't

osmo-mgw[master]: client: add unified function to generate MGCP messages

Patch Set 13: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/4146 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I29c5e2fb972896faeb771ba040f015592487fcbe Gerrit-PatchSet: 13 Gerrit-Project: osmo-mgw Gerrit-Branch: master

osmo-mgw[master]: sdp: refactoring sdp parser/generator

Patch Set 14: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/4006 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9f88c93872ff913bc211f560b26901267f577324 Gerrit-PatchSet: 14 Gerrit-Project: osmo-mgw Gerrit-Branch: master

[PATCH] osmo-pcu[master]: Initialize logging before initializing rate_ctr

Hello Harald Welte, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/4411 to look at the new patch set (#8). Initialize logging before initializing rate_ctr The library code for rate counter initialization might already want to log something

[PATCH] osmo-pcu[master]: Initialize logging before initializing rate_ctr

Hello Harald Welte, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/4411 to look at the new patch set (#7). Initialize logging before initializing rate_ctr The library code for rate counter initialization might already want to log something

[PATCH] osmo-pcu[master]: Move all rate counter related code together

Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/4413 to look at the new patch set (#6). Move all rate counter related code together Change-Id: I795631752af3b9077a846c3123217e1deda52e86 Related: OS#1538 --- M src/bts.cpp M src/bts.h M

[PATCH] osmo-pcu[master]: Move all rate counter related code together

Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/4413 to look at the new patch set (#5). Move all rate counter related code together Change-Id: I795631752af3b9077a846c3123217e1deda52e86 Related: OS#1538 --- M src/bts.cpp M src/bts.h M

[PATCH] osmo-pcu[master]: Initialize logging before initializing rate_ctr

Hello Harald Welte, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/4411 to look at the new patch set (#6). Initialize logging before initializing rate_ctr The library code for rate counter initialization might already want to log something

[PATCH] osmo-pcu[master]: Move all rate counter related code together

Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/4413 to look at the new patch set (#4). Move all rate counter related code together Change-Id: I795631752af3b9077a846c3123217e1deda52e86 Related: OS#1538 --- M src/bts.cpp M src/bts.h M

[PATCH] osmo-pcu[master]: Move all rate counter related code together

Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/4413 to look at the new patch set (#3). Move all rate counter related code together Change-Id: I795631752af3b9077a846c3123217e1deda52e86 Related: OS#1538 --- M src/bts.cpp M src/bts.h M

[PATCH] osmo-pcu[master]: Initialize logging before initializing rate_ctr

Hello Harald Welte, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/4411 to look at the new patch set (#5). Initialize logging before initializing rate_ctr The library code for rate counter initialization might already want to log something

osmo-hlr[master]: ctrl: completely replace all CTRL commands

Patch Set 6: (3 comments) all in all I think this patch can stay as it is, but I need to fix the db API docs: https://gerrit.osmocom.org/#/c/4311/6/src/ctrl.c File src/ctrl.c: Line 233: aud3g.algo = OSMO_AUTH_ALG_NONE; > I'm confused by this part. In case of ENOENT error we

openbsc[master]: debian/rules: show testsuite.log when tests are failing

Patch Set 1: Code-Review+2 we already have this in many other repositories and it works well -- To view, visit https://gerrit.osmocom.org/4414 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I30151897d621a1428095006e1f0e8a47059de4cd

[PATCH] openbsc[master]: debian/rules: show testsuite.log when tests are failing

Review at https://gerrit.osmocom.org/4414 debian/rules: show testsuite.log when tests are failing Change-Id: I30151897d621a1428095006e1f0e8a47059de4cd --- M debian/rules 1 file changed, 3 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/openbsc refs/changes/14/4414/1

[PATCH] osmo-pcu[master]: Initialize logging before initializing rate_ctr

Hello Harald Welte, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/4411 to look at the new patch set (#4). Initialize logging before initializing rate_ctr The library code for rate counter initialization might already want to log something

osmo-pcu[master]: Initialize logging before initializing rate_ctr

Patch Set 3: (1 comment) > why the extensive move / separate files are needed There's a ticket about getting rid of BTS singleton so this seems like a good opportunity to move it. Besides, once it does not operate on BTS members it has nothing to do with it so it's better to put this into

osmo-pcu[master]: Initialize logging before initializing rate_ctr

Patch Set 3: (3 comments) There are numerous ways to solve chicken/eggs like this... ideas: Wrap m_ratectrs in a getter function, which allocates the rate counters the first time the getter is called (only if m_ratectrs == NULL), instead of doing so directly in the constructor. or Make the

[PATCH] osmo-pcu[master]: Move all rate counter related code together

Review at https://gerrit.osmocom.org/4413 Move all rate counter related code together Change-Id: I795631752af3b9077a846c3123217e1deda52e86 Related: OS#1541 --- M src/bts.cpp M src/bts.h M src/gprs_rlcmac_sched.cpp M src/gprs_rlcmac_ts_alloc.cpp M src/llc.cpp M src/pcu_ctr.h M src/rlc.cpp M

[MERGED] osmo-sgsn[master]: configure: fix libosmo-sigtran dependency

Harald Welte has submitted this change and it was merged. Change subject: configure: fix libosmo-sigtran dependency .. configure: fix libosmo-sigtran dependency the configure script requires libosmo-sigtran even when IU is not

[PATCH] osmo-pcu[master]: Initialize logging before initializing rate_ctr

Hello Harald Welte, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/4411 to look at the new patch set (#3). Initialize logging before initializing rate_ctr The library code for rate counter initialization might already want to log something

[MERGED] osmo-sgsn[master]: non-iu-build: guard vty libosmo-sigtran function calls.

Harald Welte has submitted this change and it was merged. Change subject: non-iu-build: guard vty libosmo-sigtran function calls. .. non-iu-build: guard vty libosmo-sigtran function calls. The function calls

[MERGED] osmo-sgsn[master]: log: fix default loglevels

Harald Welte has submitted this change and it was merged. Change subject: log: fix default loglevels .. log: fix default loglevels for some log categories the default loglevel is far to verbose. downgrade all loglevels to

[PATCH] osmo-pcu[master]: Initialize logging before initializing rate_ctr

Hello Harald Welte, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/4411 to look at the new patch set (#2). Initialize logging before initializing rate_ctr The library code for rate counter initialization might already want to log something

osmo-bsc[master]: reset: fix illegal FSM name

Patch Set 3: > Mh, I did write the exact same change in Change-Id > I1b44d26cebc4a47094d7b8b3983e5737b88bf003 > Mh, I did write the exact same change in Change-Id > I1b44d26cebc4a47094d7b8b3983e5737b88bf003 > Mh, I did write the exact same change in Change-Id >

libosmocore[master]: utils: avoid segfault when calling osmo_strlcpy(src=NULL)

Patch Set 1: (1 comment) https://gerrit.osmocom.org/#/c/4407/1/src/utils.c File src/utils.c: Line 375: size_t ret = src ? strlen(src) : 0; > Why not simply return here right away? I thought this is the preferred styl I guess it's a good idea to still zero-terminate 'dst' even if 'src' is

libosmocore[master]: utils: avoid segfault when calling osmo_strlcpy(src=NULL)

Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/4407 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ieba7ba262ace2e370a4b9a550b3131fb13f07413 Gerrit-PatchSet: 1 Gerrit-Project: libosmocore Gerrit-Branch: master

osmo-mgw[master]: client: fix stderror logging in unit-test

Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/4412 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7f1bd9454188f0ca869dada1fcc2877b789cc0ac Gerrit-PatchSet: 1 Gerrit-Project: osmo-mgw Gerrit-Branch: master

[PATCH] osmo-mgw[master]: client: fix stderror logging in unit-test

Review at https://gerrit.osmocom.org/4412 client: fix stderror logging in unit-test When testing the file name and the line numbers are output to stderr, this causes the test to fail when change moves the lines. Disable line numbers in the stderror log when testing, also disable timestamps

[PATCH] osmo-mgw[master]: client: add unified function to generate MGCP messages

Hello Neels Hofmeyr, Harald Welte, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/4146 to look at the new patch set (#13). client: add unified function to generate MGCP messages currently the only way to generate MGCP messages is to use

osmo-pcu[master]: Initialize logging before initializing rate_ctr

Patch Set 1: > *why* the output was expanded We init logging first in BTS singleton with some default log levels. Later on init is called again in individual tests but this setting is not taken into account for some reason. Not sure yet why. -- To view, visit https://gerrit.osmocom.org/4411

[ABANDON] libosmo-netif[master]: osmux: Re-write osmux_snprintf

Pau Espin Pedrol has abandoned this change. Change subject: osmux: Re-write osmux_snprintf .. Abandoned 3 patches were merged fixing a few bits remaining to be improved after Pablos' patches. This patch can as a result be

osmo-bsc[master]: Rename osmo_fsm to avoid illegal space in name + more meanin...

Patch Set 2: Please, if it applies, remember to send the same patch against openbsc.git -- To view, visit https://gerrit.osmocom.org/4403 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1b44d26cebc4a47094d7b8b3983e5737b88bf003

[MERGED] osmo-msc[master]: Rename osmo_fsm to avoid illegal space in name + more meanin...

Harald Welte has submitted this change and it was merged. Change subject: Rename osmo_fsm to avoid illegal space in name + more meaningful name .. Rename osmo_fsm to avoid illegal space in name + more meaningful name A FSM

osmo-sgsn[master]: Fix build after recent rate_ctr patches

Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/4410 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icc9a53d35be2b0793d7ed25e6fec5bf6c8f84d92 Gerrit-PatchSet: 1 Gerrit-Project: osmo-sgsn Gerrit-Branch: master

[MERGED] osmo-sgsn[master]: Fix build after recent rate_ctr patches

Harald Welte has submitted this change and it was merged. Change subject: Fix build after recent rate_ctr patches .. Fix build after recent rate_ctr patches It seems like recent changes expanded output of

osmo-msc[master]: Rename osmo_fsm to avoid illegal space in name + more meanin...

Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/4406 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I858a81b8a4e01b2e802e3159f2835e5ca515953d Gerrit-PatchSet: 1 Gerrit-Project: osmo-msc Gerrit-Branch: master

osmo-pcu[master]: Initialize logging before initializing rate_ctr

Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/4411 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibf557d21552d9ff1d6b595b0594f2c7b18db4692 Gerrit-PatchSet: 1 Gerrit-Project: osmo-pcu Gerrit-Branch: master

osmo-bsc[master]: reset: fix illegal FSM name

Patch Set 3: Mh, I did write the exact same change in Change-Id I1b44d26cebc4a47094d7b8b3983e5737b88bf003 -- To view, visit https://gerrit.osmocom.org/4409 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id:

osmo-pcu[master]: Initialize logging before initializing rate_ctr

Patch Set 1: Code-Review+1 I'm happy with those changes, but I would appreciate if you could figure out *why* the output was expanded. This was not the intention of the patches, it was all just about renaming counter groups and counters. -- To view, visit https://gerrit.osmocom.org/4411 To

osmo-sgsn[master]: Fix build after recent rate_ctr patches

Patch Set 1: Code-Review+1 I'm happy with those changes, but I would appreciate if you could figure out *why* the output was expanded. This was not the intention of the patches, it was all just about renaming counter groups and counters. -- To view, visit https://gerrit.osmocom.org/4410 To

[PATCH] osmo-pcu[master]: Initialize logging before initializing rate_ctr

Review at https://gerrit.osmocom.org/4411 Initialize logging before initializing rate_ctr The library code for rate counter initialization, which is called from the descendants of bsc_network_alloc() might already want to log something (particularly after

[PATCH] osmo-bsc[master]: reset: fix illegal FSM name

Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/4409 to look at the new patch set (#3). reset: fix illegal FSM name The name of the state machine that controls the reset contains a whitespace. This is not allowed. Replace whitespace

[PATCH] osmo-bsc[master]: reset: fix illegal FSM name

Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/4409 to look at the new patch set (#2). reset: fix illegal FSM name The name of the state machine that controls the reset contains a whitespace. This is not allowed. Replace whitespace

[ABANDON] osmo-msc[master]: reset: fix illegal FSM name

dexter has abandoned this change. Change subject: reset: fix illegal FSM name .. Abandoned There is already a patch for that. -- To view, visit https://gerrit.osmocom.org/4408 To unsubscribe, visit

[PATCH] osmo-sgsn[master]: Fix build after recent rate_ctr patches

Review at https://gerrit.osmocom.org/4410 Fix build after recent rate_ctr patches It seems like recent changes expanded output of dump_rate_ctr_group(). Adjust output accordingly to fix the build. Change-Id: Icc9a53d35be2b0793d7ed25e6fec5bf6c8f84d92 --- M tests/gbproxy/gbproxy_test.ok 1 file

osmo-msc[master]: Rename osmo_fsm to avoid illegal space in name + more meanin...

Patch Set 1: Code-Review+1 > Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/4406 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I858a81b8a4e01b2e802e3159f2835e5ca515953d Gerrit-PatchSet: 1 Gerrit-Project:

[PATCH] osmo-bsc[master]: reset: fix illegal FSM name

Review at https://gerrit.osmocom.org/4409 reset: fix illegal FSM name The name of the state machine that controls the reset contains a whitespace. This is not allowed. Replace whitespace with an underscore. Change-Id: I44b8e0935f9d249903a30852ca1cdcf335219ba6 --- M src/libcommon-cs/a_reset.c

[PATCH] osmo-msc[master]: reset: fix illegal FSM name

Review at https://gerrit.osmocom.org/4408 reset: fix illegal FSM name The name of the state machine that controls the reset contains a whitespace. This is not allowed. Replace whitespace with an underscore. Change-Id: I1f19cef832308a6078c2c23a3a9b08fa3f0be0b9 --- M src/libcommon-cs/a_reset.c

osmo-msc[master]: Rename osmo_fsm to avoid illegal space in name + more meanin...

Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/4406 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I858a81b8a4e01b2e802e3159f2835e5ca515953d Gerrit-PatchSet: 1 Gerrit-Project: osmo-msc Gerrit-Branch: master

libosmocore[master]: utils: avoid segfault when calling osmo_strlcpy(src=NULL)

Patch Set 1: Code-Review-1 (1 comment) I think test case is required which tried osmo_strlcpy(src=NULL), osmo_strlcpy(siz=0) etc. to ensure that fix actually works as expected. https://gerrit.osmocom.org/#/c/4407/1/src/utils.c File src/utils.c: Line 375: size_t ret = src ? strlen(src)