Change in ...osmo-bsc[master]: doc/manuals: review and tweak handover docs

2019-06-20 Thread neels
neels has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmo-bsc/+/14515 ) Change subject: doc/manuals: review and tweak handover docs .. doc/manuals: review and tweak handover docs Change-Id

Change in ...osmo-bsc[master]: doc/manuals: review and tweak handover docs

2019-06-20 Thread neels
neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/14515 ) Change subject: doc/manuals: review and tweak handover docs .. Patch Set 1: Code-Review+2 let me just apply this now (only doc

Change in ...osmo-bsc[master]: doc/manuals, vty doc: more handover doc clarifications

2019-06-24 Thread neels
neels has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bsc/+/14582 Change subject: doc/manuals, vty doc: more handover doc clarifications .. doc/manuals, vty doc: more handover doc clarifications

Change in ...osmo-bsc[master]: add vty 'no neighbors' to remove all HO targets

2019-07-12 Thread neels
neels has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bsc/+/14768 Change subject: add vty 'no neighbors' to remove all HO targets .. add vty 'no neighbors' to remove all HO targets This is required

Change in ...osmo-bsc[master]: comment and VTY doc tweaks

2019-07-12 Thread neels
neels has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bsc/+/14766 Change subject: comment and VTY doc tweaks .. comment and VTY doc tweaks Clarify some in-code comments. Fix descriptions of some

Change in ...osmo-bsc[master]: silence error for "invalid enum handover_scope value: none"

2019-07-12 Thread neels
neels has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bsc/+/14767 Change subject: silence error for "invalid enum handover_scope value: none" .. silence error for "invalid enum hando

Change in ...osmo-bsc[master]: neighbor config: allow re-using ARFCN+BSIC pairs

2019-07-12 Thread neels
neels has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bsc/+/14769 Change subject: neighbor config: allow re-using ARFCN+BSIC pairs .. neighbor config: allow re-using ARFCN+BSIC pairs Fix neighbor

Change in ...osmo-ttcn3-hacks[master]: bsc: add TC_ho_neighbor_config_1 thru _7

2019-07-12 Thread neels
neels has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/14765 Change subject: bsc: add TC_ho_neighbor_config_1 thru _7 .. bsc: add TC_ho_neighbor_config_1 thru _7 Add tests to play through

Change in ...docker-playground[master]: adjust osmo-bsc.cfg for TC_ho_neighbor_config_1 thru _7

2019-07-12 Thread neels
neels has uploaded this change for review. ( https://gerrit.osmocom.org/c/docker-playground/+/14764 Change subject: adjust osmo-bsc.cfg for TC_ho_neighbor_config_1 thru _7 .. adjust osmo-bsc.cfg for TC_ho_neighbor_config_1

Change in ...osmo-ttcn3-hacks[master]: bsc: add TC_ho_neighbor_config_1 thru _7

2019-07-12 Thread neels
://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ia4ba0e75abd3d45a3422b2525e5f938cdc5a04cc Gerrit-Change-Number: 14765 Gerrit-PatchSet: 2 Gerrit-Owner: neels Gerrit-Reviewer: Jenkins Builder Gerrit-MessageType: newpatchset

Change in ...osmo-bsc[master]: doc/manuals, vty doc: more handover doc clarifications

2019-07-09 Thread neels
neels has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmo-bsc/+/14582 ) Change subject: doc/manuals, vty doc: more handover doc clarifications .. doc/manuals, vty doc: more handover doc

Change in ...osmo-python-tests[master]: tweak README

2019-07-09 Thread neels
neels has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/python/osmo-python-tests/+/14698 ) Change subject: tweak README .. tweak README Most importantly, mention 'python3 setup.py'. Tweak indenting

Change in ...osmo-bsc[master]: remove double BSSMAP Clear on HO failure

2019-07-09 Thread neels
neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/14700 ) Change subject: remove double BSSMAP Clear on HO failure .. Patch Set 1: Code-Review+2 combining 2 +1s from others -- To view

Change in ...osmo-bsc[master]: remove double BSSMAP Clear on HO failure

2019-07-09 Thread neels
neels has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmo-bsc/+/14700 ) Change subject: remove double BSSMAP Clear on HO failure .. remove double BSSMAP Clear on HO failure If a handover fails when

Change in ...osmo-python-tests[master]: tweak README

2019-07-08 Thread neels
neels has uploaded this change for review. ( https://gerrit.osmocom.org/c/python/osmo-python-tests/+/14698 Change subject: tweak README .. tweak README Most importantly, mention 'python3 setup.py'. Tweak indenting and some

Change in ...osmo-bsc[master]: remove double BSSMAP Clear on HO failure

2019-07-08 Thread neels
neels has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bsc/+/14700 Change subject: remove double BSSMAP Clear on HO failure .. remove double BSSMAP Clear on HO failure If a handover fails when the new

Change in ...osmo-bsc[master]: make bsc_clear_request() static

2019-07-08 Thread neels
neels has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bsc/+/14699 Change subject: make bsc_clear_request() static .. make bsc_clear_request() static bsc_clear_request() is in fact used only within

Change in ...osmo-bsc[master]: doc/manuals, vty doc: more handover doc clarifications

2019-07-08 Thread neels
: master Gerrit-Change-Id: I1639efb2dbcca4f0e9c33a74f3067606ce5f4209 Gerrit-Change-Number: 14582 Gerrit-PatchSet: 2 Gerrit-Owner: neels Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-MessageType: newpatchset

Change in ...osmo-msc[master]: add separate vty cfg for Iu encryption / fix ttcn3 iu tests

2019-08-13 Thread neels
neels has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-msc/+/15175 Change subject: add separate vty cfg for Iu encryption / fix ttcn3 iu tests .. add separate vty cfg for Iu encryption / fix ttcn3 iu

Change in ...osmo-msc[master]: add 'encryption uea 1 2' cfg / fix ttcn3 iu tests

2019-08-13 Thread neels
be, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: Ie138f2fcb105533f7bc06a6d2e6deccf6faccc5b Gerrit-Change-Number: 15175 Gerrit-PatchSet: 3 Gerrit-Owner: neels Gerrit-Reviewer: Jenkins Builder Gerrit

Change in ...osmo-bsc[master]: add vty 'no neighbors' to remove all HO targets

2019-08-13 Thread neels
neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/14768 ) Change subject: add vty 'no neighbors' to remove all HO targets .. Patch Set 3: Code-Review+2 > I did not add any further comme

Change in ...osmo-mgw[master]: test_mgcp_codec_pt_translate(): more tests

2019-08-13 Thread neels
neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/15135 ) Change subject: test_mgcp_codec_pt_translate(): more tests .. Patch Set 3: (1 comment) https://gerrit.osmocom.org/#/c/15135/3/tests

Change in ...osmo-msc[master]: add 'encryption uea 1 2' cfg / fix ttcn3 iu tests

2019-08-13 Thread neels
be, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: Ie138f2fcb105533f7bc06a6d2e6deccf6faccc5b Gerrit-Change-Number: 15175 Gerrit-PatchSet: 4 Gerrit-Owner: neels Gerrit-Reviewer: Jenkins Builder Gerrit

Change in ...docker-playground[master]: adjust osmo-bsc.cfg for TC_ho_neighbor_config_1 thru _7

2019-08-13 Thread neels
neels has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/docker-playground/+/14764 ) Change subject: adjust osmo-bsc.cfg for TC_ho_neighbor_config_1 thru _7 .. adjust osmo-bsc.cfg

Change in ...osmo-msc[master]: add 'encryption uea 1 2' cfg / fix ttcn3 iu tests

2019-08-13 Thread neels
neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/15175 ) Change subject: add 'encryption uea 1 2' cfg / fix ttcn3 iu tests .. Patch Set 2: This change is ready for review. -- To view

Change in ...osmo-bsc[master]: add vty 'no neighbors' to remove all HO targets

2019-08-13 Thread neels
neels has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmo-bsc/+/14768 ) Change subject: add vty 'no neighbors' to remove all HO targets .. add vty 'no neighbors' to remove all HO targets

Change in ...osmo-mgw[master]: mgcp_codec: split codec_free() off of codec_init()

2019-08-13 Thread neels
neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/15132 ) Change subject: mgcp_codec: split codec_free() off of codec_init() .. Patch Set 2: (1 comment) https://gerrit.osmocom.org/#/c/15132

Change in ...osmo-bsc[master]: neighbor config: allow re-using ARFCN+BSIC pairs

2019-08-13 Thread neels
neels has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmo-bsc/+/14769 ) Change subject: neighbor config: allow re-using ARFCN+BSIC pairs .. neighbor config: allow re-using ARFCN+BSIC pairs Fix

Change in ...libosmocore[master]: add vty logp command to echo on all log targets

2019-08-13 Thread neels
neels has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/14986 ) Change subject: add vty logp command to echo on all log targets .. Patch Set 1: -- To view, visit https://gerrit.osmocom.org/c

Change in ...osmo-ttcn3-hacks[master]: bsc: add TC_ho_neighbor_config_1 thru _7

2019-08-13 Thread neels
neels has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/14765 ) Change subject: bsc: add TC_ho_neighbor_config_1 thru _7 .. bsc: add TC_ho_neighbor_config_1 thru _7 Add tests

Change in ...osmo-sip-connector[master]: avoid bogus error logs when no cmd_timer is set

2019-08-13 Thread neels
neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-sip-connector/+/15142 ) Change subject: avoid bogus error logs when no cmd_timer is set .. Patch Set 1: (2 comments) https://gerrit.osmocom.org

Change in ...osmo-mgw[master]: test_mgcp_codec_pt_translate(): more tests

2019-08-13 Thread neels
-Owner: neels Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: neels Gerrit-Reviewer: pespin Gerrit-MessageType: newpatchset

Change in ...osmo-mgw[master]: mgcp_codec: codec_set(): log about all possible errors

2019-08-13 Thread neels
Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: I0b44b574c814882b6f8ae7cd738a6f481cd721fd Gerrit-Change-Number: 15138 Gerrit-PatchSet: 4 Gerrit-Owner: neels Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: neels Gerrit-Reviewer: pespin Gerrit-MessageType: newpatchset

Change in ...osmo-mgw[master]: tweak mgcp_parse_audio_ptime_rtpmap()

2019-08-13 Thread neels
neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/15140 ) Change subject: tweak mgcp_parse_audio_ptime_rtpmap() .. Patch Set 3: (1 comment) https://gerrit.osmocom.org/#/c/15140/1//COMMIT_MSG

Change in ...osmo-mgw[master]: mgcp_codec: codec_set(): log about all possible errors

2019-08-13 Thread neels
neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/15138 ) Change subject: mgcp_codec: codec_set(): log about all possible errors .. Patch Set 3: (1 comment) https://gerrit.osmocom.org/#/c

Change in ...osmo-ttcn3-hacks[master]: fix TC_ho_int; make neighbor config more robust

2019-08-14 Thread neels
sit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: If44dd6b578cdc55076c8180707d1c2d69fe5f2a8 Gerrit-Change-Number: 15216 Gerrit-PatchSet: 2 Gerrit-Owner: neels Gerrit-Reviewer: Jenkins Builder Gerrit-MessageType: newpatchset

Change in ...osmo-sgsn[master]: gprs_gmm: Avoid spaces in fsm events and enum strings

2019-08-14 Thread neels
neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/15212 ) Change subject: gprs_gmm: Avoid spaces in fsm events and enum strings .. Patch Set 1: Code-Review+1 (2 comments) https

Change in ...osmo-ttcn3-hacks[master]: fix TC_ho_int; make neighbor config more robust

2019-08-14 Thread neels
neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15216 ) Change subject: fix TC_ho_int; make neighbor config more robust .. Patch Set 2: Code-Review+2 -- To view, visit https

Change in ...osmo-ttcn3-hacks[master]: fix TC_ho_int; make neighbor config more robust

2019-08-14 Thread neels
neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15216 ) Change subject: fix TC_ho_int; make neighbor config more robust .. Patch Set 2: +2 to self to fix a ttcn3-bsc-test failure

Change in ...osmo-ttcn3-hacks[master]: fix TC_ho_int; make neighbor config more robust

2019-08-14 Thread neels
neels has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15216 ) Change subject: fix TC_ho_int; make neighbor config more robust .. fix TC_ho_int; make neighbor config more robust

Change in ...docker-playground[master]: apply osmo-bsc.cfg changes from osmo-ttcn3-hacks

2019-08-14 Thread neels
neels has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/docker-playground/+/15217 ) Change subject: apply osmo-bsc.cfg changes from osmo-ttcn3-hacks .. apply osmo-bsc.cfg changes from osmo-ttcn3-hacks

Change in ...docker-playground[master]: apply osmo-bsc.cfg changes from osmo-ttcn3-hacks

2019-08-14 Thread neels
neels has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/15217 ) Change subject: apply osmo-bsc.cfg changes from osmo-ttcn3-hacks .. Patch Set 1: Verified+1 Code-Review+2 -- To view, visit

Change in ...osmo-sgsn[master]: Introduce and use log macros when no mm ctx available

2019-08-14 Thread neels
neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/15211 ) Change subject: Introduce and use log macros when no mm ctx available .. Patch Set 1: Code-Review+1 (4 comments) https

Change in ...osmo-bsc[master]: gsm_08_08.c: always pick first msc for unsolicit paging responses

2019-08-14 Thread neels
neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/15209 ) Change subject: gsm_08_08.c: always pick first msc for unsolicit paging responses .. Patch Set 1: (2 comments) agree to fix

Change in ...libosmocore[master]: osmo_tdef_get(): allow passing -1 as default timeout

2019-08-14 Thread neels
neels has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmocore/+/15218 Change subject: osmo_tdef_get(): allow passing -1 as default timeout .. osmo_tdef_get(): allow passing -1 as default timeout

Change in ...libosmocore[master]: osmo_tdef_get(): allow passing -1 as default timeout

2019-08-14 Thread neels
neels has uploaded a new patch set (#2). ( https://gerrit.osmocom.org/c/libosmocore/+/15218 ) Change subject: osmo_tdef_get(): allow passing -1 as default timeout .. osmo_tdef_get(): allow passing -1 as default timeout

Change in ...osmo-sgsn[master]: Replace own timer infra with libosmocore osmo_tdef

2019-08-14 Thread neels
neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/15214 ) Change subject: Replace own timer infra with libosmocore osmo_tdef .. Patch Set 1: Code-Review-1 (2 comments) nice! https

Change in ...osmo-sgsn[master]: tests: Check timers can be set over VTY

2019-08-14 Thread neels
neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/15213 ) Change subject: tests: Check timers can be set over VTY .. Patch Set 1: (1 comment) https://gerrit.osmocom.org/#/c/15213/1/tests

Change in ...osmo-sgsn[master]: tests: Introduce vty-transcript-test tests

2019-08-14 Thread neels
neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/15215 ) Change subject: tests: Introduce vty-transcript-test tests .. Patch Set 4: Code-Review+2 excellent! -- To view, visit https

Change in ...osmo-sgsn[master]: gprs_gmm.c: Call mmctx_set_(p)mm_state only on related ran_type

2019-08-14 Thread neels
neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/15186 ) Change subject: gprs_gmm.c: Call mmctx_set_(p)mm_state only on related ran_type .. Patch Set 2: (7 comments) I'm advocating

Change in ...osmo-sgsn[master]: tests: Check timers can be set over VTY

2019-08-14 Thread neels
neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/15213 ) Change subject: tests: Check timers can be set over VTY .. Patch Set 1: Code-Review+1 (2 comments) https://gerrit.osmocom.org/#/c

Change in ...osmo-ttcn3-hacks[master]: BSC_Tests: Change test-expectation of TC_paging_resp_unsol

2019-08-14 Thread neels
neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15208 ) Change subject: BSC_Tests: Change test-expectation of TC_paging_resp_unsol .. Patch Set 1: Code-Review+1 (1 comment) https

Change in ...osmo-ttcn3-hacks[master]: SGSN: introduce f_send_l3() to allow one function for Gb & Iu

2019-08-14 Thread neels
neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15171 ) Change subject: SGSN: introduce f_send_l3() to allow one function for Gb & Iu .. Patch Set 1: Code-Review+1 what'

Change in ...osmo-ttcn3-hacks[master]: fix TC_ho_int; make neighbor config more robust

2019-08-14 Thread neels
neels has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15216 Change subject: fix TC_ho_int; make neighbor config more robust .. fix TC_ho_int; make neighbor config more robust Since osmo

Change in ...docker-playground[master]: apply osmo-bsc.cfg changes from osmo-ttcn3-hacks

2019-08-14 Thread neels
neels has uploaded this change for review. ( https://gerrit.osmocom.org/c/docker-playground/+/15217 Change subject: apply osmo-bsc.cfg changes from osmo-ttcn3-hacks .. apply osmo-bsc.cfg changes from osmo-ttcn3-hacks

Change in ...osmo-sgsn[master]: gprs_gmm: Introduce assert to guard against unexpected condition

2019-08-14 Thread neels
neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/15167 ) Change subject: gprs_gmm: Introduce assert to guard against unexpected condition .. Patch Set 2: Code-Review-1 (1 comment) https

Change in ...osmo-sgsn[master]: gprs_sgsn.h: Flag MM_CTX_T_GERAN_Iu as not supported

2019-08-14 Thread neels
neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/15184 ) Change subject: gprs_sgsn.h: Flag MM_CTX_T_GERAN_Iu as not supported .. Patch Set 2: Code-Review+2 why is that even

Change in ...osmo-sgsn[master]: gprs_gmm.c: Flag mmctx_set_(p)mm_state() functions static

2019-08-14 Thread neels
neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/15185 ) Change subject: gprs_gmm.c: Flag mmctx_set_(p)mm_state() functions static .. Patch Set 2: Code-Review+1 -- To view, visit https

Change in ...osmo-msc[master]: Implement a global switch on the network to disable call waiting.

2019-08-14 Thread neels
neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/15120 ) Change subject: Implement a global switch on the network to disable call waiting. .. Patch Set 12: Code-Review+1 (2 comments) non

Change in ...osmo-sgsn[master]: libgtp: don't call sgsn_pdp_ctx_free() with NULL pdp

2019-08-14 Thread neels
neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/13929 ) Change subject: libgtp: don't call sgsn_pdp_ctx_free() with NULL pdp .. Patch Set 5: (1 comment) hmm, I can't vote here because

Change in ...osmo-mgw[master]: test_mgcp_codec_pt_translate(): more tests

2019-08-12 Thread neels
: neels Gerrit-Reviewer: Jenkins Builder Gerrit-MessageType: newpatchset

Change in ...osmo-mgw[master]: mgcp_test: extend / rewrite test_mgcp_codec_pt_translate()

2019-08-12 Thread neels
lters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: I888000d77512cfecb0f199b86ef6003e7fc0e6cb Gerrit-Change-Number: 15134 Gerrit-PatchSet: 2 Gerrit-Owner: neels Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin Gerrit-MessageType: newpatchset

Change in ...osmo-mgw[master]: ptmap: implicitly match '/8000' and '/8000/1'

2019-08-12 Thread neels
er Gerrit-Change-Id: Iab00bf9a55b1847f85999077114b37e70fb677c2 Gerrit-Change-Number: 15137 Gerrit-PatchSet: 2 Gerrit-Owner: neels Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-MessageType: newpatchset

Change in ...osmo-mgw[master]: differentiate AMR octet-aligned=0 vs =1

2019-08-12 Thread neels
: Ib8be73a7ca1b95ce794d130e8eb206dcee700124 Gerrit-Change-Number: 15136 Gerrit-PatchSet: 2 Gerrit-Owner: neels Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: keith Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-MessageType: newpatchset

Change in ...osmo-mgw[master]: tweak mgcp_parse_audio_ptime_rtpmap()

2019-08-12 Thread neels
neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/15140 ) Change subject: tweak mgcp_parse_audio_ptime_rtpmap() .. Patch Set 2: (1 comment) https://gerrit.osmocom.org/#/c/15140/1//COMMIT_MSG

Change in ...osmo-mgw[master]: mgcp_codec: constify 'param' arg

2019-08-12 Thread neels
neels has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmo-mgw/+/15131 ) Change subject: mgcp_codec: constify 'param' arg .. mgcp_codec: constify 'param' arg Change-Id

Change in ...osmo-mgw[master]: rename codecs_cmp() to codecs_same()

2019-08-12 Thread neels
neels has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmo-mgw/+/15130 ) Change subject: rename codecs_cmp() to codecs_same() .. rename codecs_cmp() to codecs_same() The name 'cmp' implies a return

Change in ...osmo-mgw[master]: differentiate AMR octet-aligned=0 vs =1

2019-08-12 Thread neels
neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/15136 ) Change subject: differentiate AMR octet-aligned=0 vs =1 .. Patch Set 2: (1 comment) https://gerrit.osmocom.org/#/c/15136/1/src

Change in ...osmo-mgw[master]: mgcp_codec: split codec_free() off of codec_init()

2019-08-12 Thread neels
neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/15132 ) Change subject: mgcp_codec: split codec_free() off of codec_init() .. Patch Set 1: (2 comments) https://gerrit.osmocom.org/#/c/15132

Change in ...osmo-mgw[master]: ptmap: implicitly match '/8000' and '/8000/1'

2019-08-12 Thread neels
h: master Gerrit-Change-Id: Iab00bf9a55b1847f85999077114b37e70fb677c2 Gerrit-Change-Number: 15137 Gerrit-PatchSet: 3 Gerrit-Owner: neels Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-MessageType: newpatchset

Change in ...osmo-mgw[master]: mgcp_codec: split codec_free() off of codec_init()

2019-08-12 Thread neels
://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: I120cab0a352a1e7b31c8f9c720c47b2c291311d7 Gerrit-Change-Number: 15132 Gerrit-PatchSet: 2 Gerrit-Owner: neels Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: neels Gerrit-Reviewer

Change in ...osmo-mgw[master]: differentiate AMR octet-aligned=0 vs =1

2019-08-12 Thread neels
: Ib8be73a7ca1b95ce794d130e8eb206dcee700124 Gerrit-Change-Number: 15136 Gerrit-PatchSet: 3 Gerrit-Owner: neels Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: keith Gerrit-Reviewer: laforge Gerrit-Reviewer: neels Gerrit-Reviewer: pespin Gerrit-MessageType: newpatchset

Change in ...libosmocore[master]: osmo_tdef_get(): allow passing -1 as default timeout

2019-08-19 Thread neels
neels has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/15218 ) Change subject: osmo_tdef_get(): allow passing -1 as default timeout .. Patch Set 2: (1 comment) https://gerrit.osmocom.org/#/c

Change in ...libosmocore[master]: osmo_tdef_get(): allow passing -1 as default timeout

2019-08-19 Thread neels
neels has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/libosmocore/+/15218 ) Change subject: osmo_tdef_get(): allow passing -1 as default timeout .. osmo_tdef_get(): allow passing -1 as default

Change in ...libosmocore[master]: add vty logp command to echo on all log targets

2019-08-19 Thread neels
neels has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/14986 ) Change subject: add vty logp command to echo on all log targets .. Patch Set 2: Code-Review+2 -- To view, visit https

Change in ...libosmocore[master]: add vty logp command to echo on all log targets

2019-08-19 Thread neels
neels has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/libosmocore/+/14986 ) Change subject: add vty logp command to echo on all log targets .. add vty logp command to echo on all log targets When

Change in ...osmo-mgw[master]: fix crashes: don't assert on incoming RTP packet size

2019-08-19 Thread neels
neels has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-mgw/+/15242 Change subject: fix crashes: don't assert on incoming RTP packet size .. fix crashes: don't assert on incoming RTP packet size Remove

Change in ...osmo-mgw[master]: mgcp_send(): stop looping on conversion error

2019-08-19 Thread neels
neels has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-mgw/+/15243 Change subject: mgcp_send(): stop looping on conversion error .. mgcp_send(): stop looping on conversion error If mgcp_send() runs

Change in ...osmo-mgw[master]: mgcp_send(): stop looping on conversion error

2019-08-19 Thread neels
https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: Iba115a0b1d74e7cefba5dcdd777e98ddea9eba8c Gerrit-Change-Number: 15243 Gerrit-PatchSet: 2 Gerrit-Owner: neels Gerrit-Reviewer: Jenkins Builder Gerrit-MessageType: newpatchset

Change in ...osmo-mgw[master]: fix crashes: don't assert on incoming RTP packet size

2019-08-19 Thread neels
/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: I6bc6ee950ce07bcc2c585c30fad02b81153bdde2 Gerrit-Change-Number: 15242 Gerrit-PatchSet: 2 Gerrit-Owner: neels Gerrit-Reviewer: Jenkins Builder Gerrit-MessageType: newpatchset

Change in ...osmo-msc[master]: add 'encryption uea 1 2' cfg / fix ttcn3 iu tests

2019-08-14 Thread neels
neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/15175 ) Change subject: add 'encryption uea 1 2' cfg / fix ttcn3 iu tests .. Patch Set 4: (1 comment) https://gerrit.osmocom.org/#/c/15175/4

Change in ...osmo-msc[master]: add 'encryption uea 1 2' cfg / fix ttcn3 iu tests

2019-08-14 Thread neels
neels has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmo-msc/+/15175 ) Change subject: add 'encryption uea 1 2' cfg / fix ttcn3 iu tests .. add 'encryption uea 1 2' cfg / fix ttcn3 iu tests

Change in ...osmo-mgw[master]: fix crashes: don't assert on incoming RTP packet size

2019-08-21 Thread neels
://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: I6bc6ee950ce07bcc2c585c30fad02b81153bdde2 Gerrit-Change-Number: 15242 Gerrit-PatchSet: 3 Gerrit-Owner: neels Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: neels Gerrit-Reviewer: pespin Gerrit-MessageType

Change in ...osmo-mgw[master]: fix crashes: don't assert on incoming RTP packet size

2019-08-21 Thread neels
neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/15242 ) Change subject: fix crashes: don't assert on incoming RTP packet size .. Patch Set 2: (2 comments) https://gerrit.osmocom.org/#/c

Change in ...libosmocore[master]: fix: vty crash by logging to killed telnet session

2019-08-27 Thread neels
mocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Idca3f54dc986abf6784790c12e69e02bdf77cb41 Gerrit-Change-Number: 15265 Gerrit-PatchSet: 2 Gerrit-Owner: neels Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: neels Gerrit-CC: pespin Gerrit-MessageType: newpatchset

Change in ...osmo-msc[master]: ran_dec logging: log message sizes on errors

2019-08-30 Thread neels
neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/15342 ) Change subject: ran_dec logging: log message sizes on errors .. Patch Set 1: The --enable-iu build only warns: "ran_msg_a.c:

Change in ...osmo-msc[master]: ran_dec logging: log message sizes on errors

2019-08-30 Thread neels
neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/15342 ) Change subject: ran_dec logging: log message sizes on errors .. Patch Set 1: (1 comment) https://gerrit.osmocom.org/#/c/15342/1/src

Change in ...libosmocore[master]: OSMO_SOCKADDR_STR_FMT_ARGS: remove useless condition

2019-08-30 Thread neels
: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I13ed06776a784cfa99bbdfca2bb4dfe12913a1ec Gerrit-Change-Number: 15340 Gerrit-PatchSet: 3 Gerrit-Owner: neels Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-MessageType: newpatchset

Change in ...osmo-msc[master]: ran_dec logging: log message sizes on errors

2019-08-30 Thread neels
neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/15342 ) Change subject: ran_dec logging: log message sizes on errors .. Patch Set 1: > Patch Set 1: > > Compilation warnings, jenk

Change in ...osmo-mgw[master]: mgcp_codec: split codec_free() off of codec_init()

2019-08-27 Thread neels
neels has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmo-mgw/+/15132 ) Change subject: mgcp_codec: split codec_free() off of codec_init() .. mgcp_codec: split codec_free() off of codec_init() Both

Change in ...osmo-mgw[master]: fix memleak: actually free strings in mgcp_codec_reset_all()

2019-08-27 Thread neels
neels has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmo-mgw/+/15133 ) Change subject: fix memleak: actually free strings in mgcp_codec_reset_all() .. fix memleak: actually free strings

Change in ...osmo-mgw[master]: mgcp_codec: split codec_free() off of codec_init()

2019-08-27 Thread neels
neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/15132 ) Change subject: mgcp_codec: split codec_free() off of codec_init() .. Patch Set 2: Code-Review+2 now I notice there are actually two

Change in ...osmo-mgw[master]: mgcp_codec: codec_set(): log about all possible errors

2019-08-27 Thread neels
neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/15138 ) Change subject: mgcp_codec: codec_set(): log about all possible errors .. Patch Set 4: (1 comment) https://gerrit.osmocom.org/#/c

Change in ...osmo-mgw[master]: SDP: store all ptmap entries

2019-08-27 Thread neels
neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/15141 ) Change subject: SDP: store all ptmap entries .. Patch Set 5: Code-Review+2 combining votes -- To view, visit https

Change in ...osmo-mgw[master]: mgcp_codec_add: fix audio_name size check

2019-08-27 Thread neels
neels has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-mgw/+/15301 Change subject: mgcp_codec_add: fix audio_name size check .. mgcp_codec_add: fix audio_name size check Needs to account

Change in ...osmo-mgw[master]: ptmap: implicitly match '/8000' and '/8000/1'

2019-08-27 Thread neels
neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/15137 ) Change subject: ptmap: implicitly match '/8000' and '/8000/1' .. Patch Set 4: Code-Review+2 combining votes -- To view, visit

Change in ...osmo-msc[master]: ran_dec logging: log message sizes on errors

2019-08-30 Thread neels
neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/15342 ) Change subject: ran_dec logging: log message sizes on errors .. Patch Set 1: interesting to note that my gcc seems to not warn about

Change in ...osmo-msc[master]: ran_dec logging: log message sizes on errors

2019-08-30 Thread neels
-msc/+/15342 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: Id08e4ee5a4dbf552dbb107d8f0519110664f6acb Gerrit-Change-Number: 15342 Gerrit-PatchSet: 2 Gerrit-Owner: neels Gerrit-Reviewer

Change in ...osmo-msc[master]: msc_a fsm: ignore state chg to same state

2019-09-03 Thread neels
neels has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmo-msc/+/15389 ) Change subject: msc_a fsm: ignore state chg to same state .. msc_a fsm: ignore state chg to same state We sometimes see

Change in ...osmo-msc[master]: ran_dec logging: log message sizes on errors

2019-09-03 Thread neels
neels has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmo-msc/+/15342 ) Change subject: ran_dec logging: log message sizes on errors .. ran_dec logging: log message sizes on errors Change-Id

  1   2   3   4   5   6   7   8   9   10   >