Gerrit-Branch: master
Gerrit-Change-Id: I0033faf9da393418930252233ce74d62cd1cef8a
Gerrit-Change-Number: 29084
Gerrit-PatchSet: 16
Gerrit-Owner: Max
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria
Gerrit-Reviewer: laforge
Gerrit-Reviewer: neels
Gerrit-CC: pespin
Gerrit-Attention: neels
Attention is currently required from: neels, laforge, pespin, fixeria.
Max has posted comments on this change. (
https://gerrit.osmocom.org/c/libosmo-sccp/+/29084 )
Change subject: SIGTRAN: cache Optional Data for SCCP CR/CC/RLSD
Max has submitted this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/29242 )
Change subject: Set working directory in systemd service file
..
Set working directory in systemd service file
By default systemd will execute
Attention is currently required from: roh.
Max has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-msc/+/29242 )
Change subject: Set working directory in systemd service file
..
Patch Set 2: Code-Review+2
Max has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-gbproxy/+/29252 )
Change subject: Set working directory in systemd service file
..
Set Ready For Review
--
To view, visit https://gerrit.osmocom.org
Max has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-cbc/+/29251 )
Change subject: Set working directory in systemd service file
..
Set Ready For Review
--
To view, visit https://gerrit.osmocom.org/c
Max has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-upf/+/29250 )
Change subject: Set working directory in systemd service file
..
Set Ready For Review
--
To view, visit https://gerrit.osmocom.org/c
Max has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-hnodeb/+/29249 )
Change subject: Set working directory in systemd service file
..
Set Ready For Review
--
To view, visit https://gerrit.osmocom.org
Max has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-hnbgw/+/29246 )
Change subject: Set working directory in systemd service file
..
Set Ready For Review
--
To view, visit https://gerrit.osmocom.org/c
Max has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-sgsn/+/29244 )
Change subject: Set working directory in systemd service file
..
Set Ready For Review
--
To view, visit https://gerrit.osmocom.org/c
Max has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-mgw/+/29245 )
Change subject: Set working directory in systemd service file
..
Set Ready For Review
--
To view, visit https://gerrit.osmocom.org/c
Max has posted comments on this change. ( https://gerrit.osmocom.org/13609 )
Change subject: ggsn: More logging from PCO handling (e.g. in case of
malconfiguration)
..
Patch Set 4:
Some comment/reference to what PCO is would
Max has posted comments on this change. ( https://gerrit.osmocom.org/13608 )
Change subject: ggsn: Add minimalistic PAP support
..
Patch Set 4:
(1 comment)
https://gerrit.osmocom.org/#/c/13608/4/ggsn/ggsn.c
File ggsn/ggsn.c
Max has posted comments on this change. ( https://gerrit.osmocom.org/13630 )
Change subject: libmsc/db.c: fix storing SMS with empty TP-User-Data
..
Patch Set 1:
(1 comment)
https://gerrit.osmocom.org/#/c/13630/1//COMMIT_MSG
Max has posted comments on this change. ( https://gerrit.osmocom.org/13629 )
Change subject: Introduce initial unit test for db_sms_* API
..
Patch Set 1:
(1 comment)
https://gerrit.osmocom.org/#/c/13629/1/src/libmsc/db.c
File
Max has posted comments on this change. ( https://gerrit.osmocom.org/13655 )
Change subject: libmsc/gsm_04_11.c: properly handle TP-User-Data-Length
..
Patch Set 1:
(2 comments)
https://gerrit.osmocom.org/#/c/13655/1
Max has posted comments on this change. ( https://gerrit.osmocom.org/13436 )
Change subject: make all library-internal static buffers thread-local
..
Patch Set 6:
(1 comment)
https://gerrit.osmocom.org/#/c/13436/6//COMMIT_MSG
Max has posted comments on this change. ( https://gerrit.osmocom.org/13723 )
Change subject: osmo-bts-trx: distinguish 11-bit Access Bursts by synch.
sequence
..
Patch Set 4:
(2 comments)
https://gerrit.osmocom.org/#/c/13723
Max has posted comments on this change. ( https://gerrit.osmocom.org/13782 )
Change subject: lms: flush_recv: alloc buf on stack instead of heap
..
Patch Set 1:
> Using the stack is quicker.
What makes you think that? Do
Max has posted comments on this change. ( https://gerrit.osmocom.org/13787 )
Change subject: lms: Remove references to ALERT loglevel
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/13787
Max has posted comments on this change. ( https://gerrit.osmocom.org/13788 )
Change subject: lms: Remove unused var m_last_tx_overruns
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/13788
Max has posted comments on this change. ( https://gerrit.osmocom.org/13784 )
Change subject: cosmetic: Threads.h: Remove trailing whitespace
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/13784
Max has posted comments on this change. ( https://gerrit.osmocom.org/13402 )
Change subject: Update MCS selection for retransmission
..
Patch Set 4:
(1 comment)
https://gerrit.osmocom.org/#/c/13402/1/src/coding_scheme.c
File
Gerrit-PatchSet: 4
Gerrit-Owner: Max
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Max
Gerrit-CC: Pau Espin Pedrol
Max has posted comments on this change. ( https://gerrit.osmocom.org/13402 )
Change subject: Update MCS selection for retransmission
..
Patch Set 3:
(1 comment)
https://gerrit.osmocom.org/#/c/13402/1/src/coding_scheme.c
File
Max has posted comments on this change. ( https://gerrit.osmocom.org/13057 )
Change subject: Use boolean for DL resegmentation parameter
..
Patch Set 9:
(1 comment)
https://gerrit.osmocom.org/#/c/13057/8/src/pcu_main.cpp
File
-Number: 13406
Gerrit-PatchSet: 4
Gerrit-Owner: Max
Gerrit-Reviewer: Daniel Willmann
Gerrit-Reviewer: Harald Welte
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Max
Gerrit-Reviewer: osmith
-Change-Id: I4d4fe5fe12068a4532cb3b61d4eeb229a77c1476
Gerrit-Change-Number: 13057
Gerrit-PatchSet: 9
Gerrit-Owner: Max
Gerrit-Reviewer: Daniel Willmann
Gerrit-Reviewer: Harald Welte
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Max
Gerrit-Reviewer: Pau Espin Pedrol
Gerrit-Reviewer
Max has posted comments on this change. ( https://gerrit.osmocom.org/13406 )
Change subject: Add ARQ type helpers
..
Patch Set 3:
(2 comments)
https://gerrit.osmocom.org/#/c/13406/3/src/coding_scheme.c
File src
Max has submitted this change and it was merged. (
https://gerrit.osmocom.org/12961 )
Change subject: Rewrite Packet Uplink IA Rest Octets for MBA
..
Rewrite Packet Uplink IA Rest Octets for MBA
Use bitvec_set_*() directly
Max has submitted this change and it was merged. (
https://gerrit.osmocom.org/13244 )
Change subject: TBF-DL: cosmetic update for helper routines
..
TBF-DL: cosmetic update for helper routines
* use enum values where
Max has submitted this change and it was merged. (
https://gerrit.osmocom.org/13216 )
Change subject: Fix Channel Coding Command for MCS
..
Fix Channel Coding Command for MCS
Previously result of ".to_num() - 1"
Max has submitted this change and it was merged. (
https://gerrit.osmocom.org/13245 )
Change subject: Update IA Rest Octets encoding
..
Update IA Rest Octets encoding
Write initial bits of 3GPP TS 44.018 §10.5.2.16 IA Rest
Max has submitted this change and it was merged. (
https://gerrit.osmocom.org/13243 )
Change subject: TBF: update MCS counters
..
TBF: update MCS counters
* use enum CodingScheme directly instead of converting it to class
Max has submitted this change and it was merged. (
https://gerrit.osmocom.org/12955 )
Change subject: Rewrite Packet Uplink IA Rest Octets for SBA
..
Rewrite Packet Uplink IA Rest Octets for SBA
Use bitvec_set_*() directly
Max has submitted this change and it was merged. (
https://gerrit.osmocom.org/12956 )
Change subject: Use Timing Advance Index in UL assignments
..
Use Timing Advance Index in UL assignments
Write TAI (if available) when
Max has posted comments on this change. ( https://gerrit.osmocom.org/13215 )
Change subject: MCS: add Channel Coding Command encoder
..
Patch Set 6:
(1 comment)
Let's do it in a separate patch though to avoid going through
Max has submitted this change and it was merged. (
https://gerrit.osmocom.org/13215 )
Change subject: MCS: add Channel Coding Command encoder
..
MCS: add Channel Coding Command encoder
Add function to encode MCS value
Max has posted comments on this change. ( https://gerrit.osmocom.org/13418 )
Change subject: nanobts: use libosmocore's osmo_store*() for OML attr. patching
..
Patch Set 1:
(1 comment)
Not sure this will have a chance
Max has submitted this change and it was merged. (
https://gerrit.osmocom.org/13418 )
Change subject: nanobts: use libosmocore's osmo_store*() for OML attr. patching
..
nanobts: use libosmocore's osmo_store*() for OML attr
Max has posted comments on this change. ( https://gerrit.osmocom.org/13415 )
Change subject: Add osmocom-build-old-tags-against-master.sh
..
Patch Set 7: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/13415
Max has posted comments on this change. ( https://gerrit.osmocom.org/13421 )
Change subject: Add vty option to globally enable LCLS
..
Patch Set 5:
This change is ready for review.
--
To view, visit https
Max has posted comments on this change. ( https://gerrit.osmocom.org/13415 )
Change subject: Add osmocom-build-old-tags-against-master.sh
..
Patch Set 6:
(1 comment)
Btw, is there stable URL which could use instead of
https
Max has posted comments on this change. ( https://gerrit.osmocom.org/13415 )
Change subject: Add osmocom-build-old-tags-against-master.sh
..
Patch Set 6: Code-Review+1
Neat. Now it's rather obvious that we should make OsmoSGSN
Max has uploaded this change for review. ( https://gerrit.osmocom.org/13422
Change subject: Autofill LCLS parameters for A-interface transactions
..
Autofill LCLS parameters for A-interface transactions
That's experimental
Max has posted comments on this change. ( https://gerrit.osmocom.org/13421 )
Change subject: Add vty option to globally enable LCLS
..
Patch Set 2:
This change is ready for review.
--
To view, visit https
Max has posted comments on this change. ( https://gerrit.osmocom.org/13419 )
Change subject: Use osmo_lcls instead of anonymous struct
..
Patch Set 1:
This change is ready for review.
--
To view, visit https
Max has posted comments on this change. ( https://gerrit.osmocom.org/13420 )
Change subject: Log protocol for which transaction is allocated
..
Patch Set 2:
This change is ready for review.
--
To view, visit https
Max has uploaded this change for review. ( https://gerrit.osmocom.org/13421
Change subject: Add vty option to globally enable LCLS
..
Add vty option to globally enable LCLS
It's disabled by default and will be used in follow
Max has uploaded this change for review. ( https://gerrit.osmocom.org/13420
Change subject: Log protocol for which transaction is allocated
..
Log protocol for which transaction is allocated
Change-Id
Max has posted comments on this change. ( https://gerrit.osmocom.org/12246 )
Change subject: cosmetic: use const pointer for bts_data
..
Patch Set 3:
This change is ready for review.
--
To view, visit https
Max has uploaded this change for review. ( https://gerrit.osmocom.org/13419
Change subject: Use osmo_lcls instead of anonymous struct
..
Use osmo_lcls instead of anonymous struct
This allows us to (re)use code from libosmocore
Max has posted comments on this change. ( https://gerrit.osmocom.org/6239 )
Change subject: vty: add commands to show TBF of a certain kind
..
Patch Set 6:
(1 comment)
Doh! Somehow lost it during patch rebase before
Max has posted comments on this change. ( https://gerrit.osmocom.org/3895 )
Change subject: TS alloc: expand tests log
..
Patch Set 28:
(1 comment)
Should have replied year ago but thanks to underwhelming pace of OsmoPCU
Max has posted comments on this change. ( https://gerrit.osmocom.org/13164 )
Change subject: Add test for MS mode and (M)CS settings
..
Patch Set 3:
This change is ready for review.
--
To view, visit https
Max has posted comments on this change. ( https://gerrit.osmocom.org/13415 )
Change subject: Add osmocom-build-old-tags-against-master.sh
..
Patch Set 5:
(1 comment)
Looking at other FOSS projects, it seems likely
Max has posted comments on this change. ( https://gerrit.osmocom.org/13415 )
Change subject: Add osmocom-build-old-tags-against-master.sh
..
Patch Set 5:
(1 comment)
I think the entire test should not stop/fail if one
Max has posted comments on this change. ( https://gerrit.osmocom.org/13415 )
Change subject: Add osmocom-build-old-tags-against-master.sh
..
Patch Set 5:
> osmo-sgsn (no tags configured)
So it was manually disab
Max has posted comments on this change. ( https://gerrit.osmocom.org/13057 )
Change subject: Use boolean for DL resegmentation parameter
..
Patch Set 8:
This change is ready for review.
--
To view, visit https
Max has posted comments on this change. ( https://gerrit.osmocom.org/13362 )
Change subject: oc2g: Change log type (Litecell15->Oc2g)
..
Patch Set 2:
> I want to keep the commit from others unchanged as much as a can
Max has posted comments on this change. ( https://gerrit.osmocom.org/13406 )
Change subject: Add ARQ type helpers
..
Patch Set 3:
This change is ready for review.
--
To view, visit https://gerrit.osmocom.org/13406
Max has posted comments on this change. ( https://gerrit.osmocom.org/13319 )
Change subject: a_iface_bssap: add context information to log output
..
Patch Set 5: Code-Review+1
--
To view, visit https://gerrit.osmocom.org
Max has posted comments on this change. ( https://gerrit.osmocom.org/13204 )
Change subject: BSSGP: use variable for NSEI
..
Patch Set 3:
(1 comment)
This change is ready for review.
https://gerrit.osmocom.org/#/c/13204/1
Max has posted comments on this change. ( https://gerrit.osmocom.org/12487 )
Change subject: deb: fix wrong changelog date
..
Patch Set 3:
This change is ready for review.
--
To view, visit https://gerrit.osmocom.org/12487
Max has posted comments on this change. ( https://gerrit.osmocom.org/13416 )
Change subject: jobs: add osmocom-build-tags-against-master.yml
..
Patch Set 4: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/13416
Max has uploaded this change for review. ( https://gerrit.osmocom.org/13418
Change subject: nanobts: use libosmocore's osmo_store*() for OML attr. patching
..
nanobts: use libosmocore's osmo_store*() for OML attr. patching
Max has posted comments on this change. ( https://gerrit.osmocom.org/13416 )
Change subject: jobs: add osmocom-build-tags-against-master.yml
..
Patch Set 2:
(1 comment)
https://gerrit.osmocom.org/#/c/13416/2/jobs/osmocom
Max has posted comments on this change. ( https://gerrit.osmocom.org/13413 )
Change subject: osmo-build-dep.sh: cd into subdir before building
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/13413
Max has posted comments on this change. ( https://gerrit.osmocom.org/13414 )
Change subject: osmo-build-dep.sh: run 'make check' when CHECK=1
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/13414
Max has posted comments on this change. ( https://gerrit.osmocom.org/13412 )
Change subject: osmocom-list-commits.sh: move functions to common.sh
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.osmocom.org
Max has uploaded this change for review. ( https://gerrit.osmocom.org/13417
Change subject: Drop Iu*S support and related dependencies
..
Drop Iu*S support and related dependencies
There's optional libiu for Iu*S support
Max has submitted this change and it was merged. (
https://gerrit.osmocom.org/13345 )
Change subject: Drop openggsn from build dependencies
..
Drop openggsn from build dependencies
We don't have SGSN-related code here anymore
Max has posted comments on this change. ( https://gerrit.osmocom.org/13345 )
Change subject: Drop openggsn from build dependencies
..
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/13345
Max has posted comments on this change. ( https://gerrit.osmocom.org/13403 )
Change subject: bts.h: always include C-headers
..
Patch Set 1:
(1 comment)
https://gerrit.osmocom.org/#/c/13403/1/src/bts.h
File src/bts.h:
https
Max has posted comments on this change. ( https://gerrit.osmocom.org/13243 )
Change subject: TBF: update MCS counters
..
Patch Set 3:
This change is ready for review.
--
To view, visit https://gerrit.osmocom.org/13243
Max has posted comments on this change. ( https://gerrit.osmocom.org/12955 )
Change subject: Rewrite Packet Uplink IA Rest Octets for SBA
..
Patch Set 15:
This change is ready for review.
--
To view, visit https
Max has posted comments on this change. ( https://gerrit.osmocom.org/13244 )
Change subject: TBF-DL: cosmetic update for helper routines
..
Patch Set 3:
This change is ready for review.
--
To view, visit https
Max has posted comments on this change. ( https://gerrit.osmocom.org/13245 )
Change subject: Update IA Rest Octets encoding
..
Patch Set 3:
This change is ready for review.
--
To view, visit https://gerrit.osmocom.org/13245
Max has posted comments on this change. ( https://gerrit.osmocom.org/12956 )
Change subject: Use Timing Advance Index in UL assignments
..
Patch Set 12:
This change is ready for review.
--
To view, visit https
Max has posted comments on this change. ( https://gerrit.osmocom.org/13216 )
Change subject: Fix Channel Coding Command for MCS
..
Patch Set 6:
This change is ready for review.
--
To view, visit https://gerrit.osmocom.org
Max has posted comments on this change. ( https://gerrit.osmocom.org/12961 )
Change subject: Rewrite Packet Uplink IA Rest Octets for MBA
..
Patch Set 9:
This change is ready for review.
--
To view, visit https
Max has posted comments on this change. ( https://gerrit.osmocom.org/13215 )
Change subject: MCS: add Channel Coding Command encoder
..
Patch Set 5:
This change is ready for review.
--
To view, visit https
Max has posted comments on this change. ( https://gerrit.osmocom.org/13214 )
Change subject: MCS: add mcs_is_*() helpers
..
Patch Set 5:
This change is ready for review.
--
To view, visit https://gerrit.osmocom.org/13214
Max has uploaded this change for review. ( https://gerrit.osmocom.org/13406
Change subject: Add ARQ type helpers
..
Add ARQ type helpers
Add functions to check/log EGPRS ARQ type (as described in 3GPP TS
44.060 §8.1.1). Note
Max has posted comments on this change. ( https://gerrit.osmocom.org/13403 )
Change subject: bts.h: always include C-headers
..
Patch Set 1:
(1 comment)
https://gerrit.osmocom.org/#/c/13403/1/src/bts.h
File src/bts.h:
https
Max has posted comments on this change. ( https://gerrit.osmocom.org/13401 )
Change subject: src/logging.c: fix syntax errors in Doxygen documentation
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.osmocom.org
Max has uploaded this change for review. ( https://gerrit.osmocom.org/13403
Change subject: bts.h: always include C-headers
..
bts.h: always include C-headers
Previously C-headers were only included if bts.h was used by C
Max has posted comments on this change. ( https://gerrit.osmocom.org/13361 )
Change subject: Include pdch.h in bts.h even if we're not compiling C++
..
Patch Set 2: Code-Review+1
That's generic fix unrelated to oc2g in any way
Max has uploaded this change for review. ( https://gerrit.osmocom.org/13402
Change subject: Update MCS selection for retransmission
..
Update MCS selection for retransmission
In 3GPP TS 44.060 the selection of MCS
Max has submitted this change and it was merged. (
https://gerrit.osmocom.org/13163 )
Change subject: MCS: move Mode enum outside of class definition
..
MCS: move Mode enum outside of class definition
Move Mode (EDGE/GPRS
Max has posted comments on this change. ( https://gerrit.osmocom.org/13394 )
Change subject: add osmo_str_startswith()
..
Patch Set 1: Code-Review-1
(1 comment)
https://gerrit.osmocom.org/#/c/13394/1//COMMIT_MSG
Commit
Max has posted comments on this change. ( https://gerrit.osmocom.org/13390 )
Change subject: gsm_utils.h: remove unused include of gsm_08_08.h
..
Patch Set 2:
Does this really depends on all the preceding patches or it can
: I3baaac7f1ca3f5b88917a23c1679d63847455f47
Gerrit-Change-Number: 13163
Gerrit-PatchSet: 7
Gerrit-Owner: Max
Gerrit-Reviewer: Daniel Willmann
Gerrit-Reviewer: Harald Welte
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Max
Gerrit-Reviewer: Pau Espin Pedrol
Gerrit-Reviewer: osmith
Max has posted comments on this change. ( https://gerrit.osmocom.org/13387 )
Change subject: talloc_ctx_init: Use public API osmo_signal_talloc_ctx_init
..
Patch Set 1: Code-Review+1
--
To view, visit https
Max has posted comments on this change. ( https://gerrit.osmocom.org/13368 )
Change subject: Also build oc2g support for osmo-pcu
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/13368
To unsubscribe
Max has uploaded this change for review. ( https://gerrit.osmocom.org/13395
Change subject: Use libosmocore for IMSI parsing
..
Use libosmocore for IMSI parsing
Change-Id: Iec5c65776fc54b2f9e5dd55c711ace2471662db1
---
M src
Max has posted comments on this change. ( https://gerrit.osmocom.org/13384 )
Change subject: gprs_debug: Use named initializers and explicit array indicies
..
Patch Set 1: Code-Review+1
--
To view, visit https
Max has submitted this change and it was merged. (
https://gerrit.osmocom.org/13355 )
Change subject: trxcon: use static helper to prepare FBSB
..
trxcon: use static helper to prepare FBSB
Use static helper to prepare
Max has submitted this change and it was merged. (
https://gerrit.osmocom.org/13364 )
Change subject: trxcon: log FBSB timer events
..
trxcon: log FBSB timer events
Change-Id: I0168d43951494f4010df891f391ddad4b57493d7
---
M
Max has posted comments on this change. ( https://gerrit.osmocom.org/13163 )
Change subject: MCS: move Mode enum outside of class definition
..
Patch Set 6:
This change is ready for review.
--
To view, visit https
1 - 100 of 3542 matches
Mail list logo
